Skip to content

Latest commit

 

History

History
30 lines (24 loc) · 1.13 KB

Not using OpenZeppelin contracts.md

File metadata and controls

30 lines (24 loc) · 1.13 KB

OpenZeppelin maintains a library of standard, audited, community-reviewed, and battle-tested smart contracts.

Instead of always importing these contracts, the Holdefi project reimplements them in some cases, while in other cases it just copies them.

This increases the amount of code that the Holdefi team will have to maintain and misses all the improvements and bug fixes that the OpenZeppelin team is constantly implementing with the help of the community.

Recommendation:

Consider importing the OpenZeppelin contracts instead of reimplementing or copying them.

These contracts can be extended to add the extra functionalities required by Holdefi.


Slide Screenshot

179.jpg


Slide Text

  • OpenZeppelin Audit HoldeFi Finding M09
  • Patching
  • Copy/Reimplement
  • Maintain & Bug Fixes
  • Import OZ Libraries
  • Reuse & Extend

References


Tags