Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Management API does not return JSON #4

Closed
lmigula opened this issue Jun 26, 2022 · 4 comments
Closed

Management API does not return JSON #4

lmigula opened this issue Jun 26, 2022 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@lmigula
Copy link
Contributor

lmigula commented Jun 26, 2022

I'm already trying to create a Web-Frontend.
When getting the Data through the API the stations are interpreted as string and need to be converted to JSON.

And the attribute stationUrl isn't consistent. When using a GET Request the stationUrl is returned stream but is expected as streamUrl when creating a new station with a POST request.

@x789
Copy link
Owner

x789 commented Jun 26, 2022

Hey @lmigula,
thanks for your work on a web-frontend. I am curious to see what you create.

You are right, the API is not consistent and returns stringified JSON objects. 😒
I will fix that with the new release.
In the meantime, you can implement against the API I've sketched here.

To test your UI, Stoplight also gives you the option to directly address a mock server.

@x789 x789 self-assigned this Jun 26, 2022
@lmigula
Copy link
Contributor Author

lmigula commented Jun 26, 2022

Great, I've prepared the App as far as possible and will update the repository later: https://github.com/lmigula/xonox-frontend

If you need a compiled version for testing let me know.

image

x789 added a commit that referenced this issue Jun 28, 2022
@x789 x789 changed the title REST-API doesn't return JSON Management API doesn't return JSON Jun 28, 2022
@x789 x789 changed the title Management API doesn't return JSON Management API does not return JSON Jun 28, 2022
@x789
Copy link
Owner

x789 commented Jun 28, 2022

@lmigula: I pushed a fix to branch /issue/4. Would you mind to check if this code fixes your issue? If it does, I will publish a new release on PyPI.

@lmigula
Copy link
Contributor Author

lmigula commented Jun 28, 2022

looks good :)

@lmigula lmigula closed this as completed Jun 28, 2022
x789 added a commit that referenced this issue Jun 29, 2022
@x789 x789 added the bug Something isn't working label Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants