Updatet propertysets definitions to IFC4 ADD 2 TC1

[danielaase1337]

I had a look at the latest release of IFC4 Add2 TC1 - this is implemented as i can se in the XBIM enviroment,
but when checking if the new PSet's was presenent I found them missing.

Is there any plans of implementing these before the release of 4.3 ?

I have started to do something about it, but might need som sparring around two minor issues.
These two issues is
Handeling of IFCValue in DataType - _type setter.

In Pset_ReinforcingBarCommon - BendingParameters => IfcValue is defined as valuetype for the list.
This is as I can understand it a base type for other valuetypes.
Should it just be added to the Enum ? or is there better ways of solving it ?

If I just add it to Enum, it is correct in definitinons, and I can use it inside Revit.

Tags in the xml headers
The new Xml definisjons found in the IFC4 ADD2 TC1 download has a tag as shown under.
xsi:noNamespaceSchemaLocation="http://buildingSMART-tech.org/xml/psd/PSD_IFC4.xsd"
To get it to work, i changed the xsi:noNamespaceSchemaLocation to just "xmlns:"

The link it self is obvious wrong, but i can't locate the where it has been moved.

Is this a valid solution ?
All the other xml files has only refs to xmlns, not the other one.

[martin1cerny]

Hi @danielaase1337, there were issues with invalid XML files from buildingSMART in past. That is why we included them in the actual code after we fixed them. Feel free to do the same and contribute to this project with a significant PR. All contributions are most welcome.

[danielaase1337]

Ok, then I'll add the new PSets from the latest fix.

I shall try to understand the best way of imlementing IfcValue type.