Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove center_times kwarg from temporal averaging methods #254

Merged
merged 5 commits into from
Jun 9, 2022

Conversation

tomvothecoder
Copy link
Collaborator

@tomvothecoder tomvothecoder commented Jun 9, 2022

Description

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

If applicable:

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass with my changes (locally and CI/CD build)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have noted that this is a breaking change for a major release (fix or feature that would cause existing functionality to not work as expected)

- Update references to `center_times()`
- Add function `_get_coord_var()`
- Refactor tests in `test_axis.py`
@tomvothecoder tomvothecoder added Priority: High breaking-change A breaking change, intended for a major release. labels Jun 9, 2022
@tomvothecoder tomvothecoder added this to In progress in v0.3.0 via automation Jun 9, 2022
@tomvothecoder tomvothecoder self-assigned this Jun 9, 2022
xcdat/axis.py Outdated Show resolved Hide resolved
@tomvothecoder tomvothecoder merged commit 68d8ae1 into main Jun 9, 2022
v0.3.0 automation moved this from In progress to Done Jun 9, 2022
@tomvothecoder tomvothecoder deleted the feature/253-remove-center-times-kwarg branch June 9, 2022 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change A breaking change, intended for a major release.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

[Feature]: Remove center_times from temporal averaging methods
1 participant