Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin numba=0.55.2 in dev env and constrain numba>=0.55.2 in ci env #280

Merged
merged 6 commits into from
Jul 28, 2022

Conversation

tomvothecoder
Copy link
Collaborator

@tomvothecoder tomvothecoder commented Jul 26, 2022

Description

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

If applicable:

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass with my changes (locally and CI/CD build)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have noted that this is a breaking change for a major release (fix or feature that would cause existing functionality to not work as expected)

@tomvothecoder tomvothecoder added type: bug Inconsistencies or issues which will cause an issue or problem for users or implementors. type: devops Testing, CI/CD, systems configuration Priority: High labels Jul 26, 2022
@tomvothecoder tomvothecoder self-assigned this Jul 26, 2022
@tomvothecoder tomvothecoder changed the title Pin numba=0.55.2 and numpy=1.22.4 in dev env Pin numba=0.55.2 in dev env and constrain numba>=0.55.2 in ci env Jul 28, 2022
@tomvothecoder tomvothecoder merged commit 16b3b06 into main Jul 28, 2022
@tomvothecoder
Copy link
Collaborator Author

Hey @xCDAT/core-developers, I recommend updating your xcdat_dev env with the latest changes here.

You can run conda env update -f conda-env/dev.yml (or mamba env update -f conda-env/dev.yml)
You must specify -n <NAME_OF_ENV> if you used a custom env name.

@tomvothecoder tomvothecoder deleted the bugfix/270-constrain-numba branch July 28, 2022 17:13
@tomvothecoder
Copy link
Collaborator Author

@xCDAT/core-developers actually, you can hold off updating your env. I will probably update the envs in a new PR with the latest version of xarray (2022.6.0), which has a ton of new things like vectorized group by.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Inconsistencies or issues which will cause an issue or problem for users or implementors. type: devops Testing, CI/CD, systems configuration
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug]: “ImportError: Numba needs NumPy 1.21 or less”
1 participant