-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simple proposed fix for #289 #291
Conversation
Codecov Report
@@ Coverage Diff @@
## main #291 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 14 14
Lines 1143 1146 +3
=========================================
+ Hits 1143 1146 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment then it is good to go, thanks!
@tomvothecoder - I think the code is fine, but I somehow re-based this in a way that makes it look like Paul's changes are on this PR (I was getting |
author Stephen Po-Chedley <pochedley@gmail.com> 1659104117 -0700 committer Tom Vo <tomvothecoder@gmail.com> 1659457104 -0700 simple proposed fix for #289 add suggested conditional for .load() Co-authored-by: Tom Vo <tomvothecoder@gmail.com> incorporate review suggestions incorporate review suggestions remove potentially unneeeded test
a164325
to
d5642f6
Compare
It could have been a merge pull that placed Paul's changes on top of your's, although I'm not exactly sure why a diff still shows. I squashed your branch and rebased on the latest You can merge this PR now. |
Description
This PR represents a simple proposed fix for #289. We just need to use
.load()
when handlingtime_lengths
(used to make temporal weights. We had to do this for spatial averaging, too (e.g., here).Checklist
If applicable: