Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify conda environments and move configs to pyproject.toml #512

Merged
merged 20 commits into from Jun 22, 2023

Conversation

tomvothecoder
Copy link
Collaborator

@tomvothecoder tomvothecoder commented Jun 22, 2023

Description

  • Closes [DevOps]: Loosen up conda environment constraints and consolidate yml files #511
  • Loosening constraints improves upgradeability of the environments with a tradeoff in determinism
  • Make Python 3.9 the minimum version
  • Replace Python 3.8 with Python 3.11 in build workflow
  • Remove readthedocs.yml and use dev.yml for Read the Docs builds
  • Bump QA tool versions
  • Move configs from setup.cfg to pyproject.toml (except flake8 which does not support pyproject.toml)
  • Fix build workflow overwriting the Python version in the mamba env during matrix testing to only the Python version in ci.yml

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

If applicable:

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass with my changes (locally and CI/CD build)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have noted that this is a breaking change for a major release (fix or feature that would cause existing functionality to not work as expected)

- Loosening constraints improves upgradeability of the environments with a tradeoff in determinism
@tomvothecoder tomvothecoder added the type: devops Testing, CI/CD, systems configuration label Jun 22, 2023
@tomvothecoder tomvothecoder added this to In progress in Next Release (v0.6.0) via automation Jun 22, 2023
@tomvothecoder tomvothecoder self-assigned this Jun 22, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (792cdbd) 100.00% compared to head (96d4fe7) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #512   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines         1517      1517           
=========================================
  Hits          1517      1517           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

- Bump QA tool versions
- Loosen mypy additional dependencies constraints with pre-commit
@github-actions github-actions bot added the type: docs Updates to documentation label Jun 22, 2023
@tomvothecoder tomvothecoder changed the title Simplify conda environments and loosen constraints Simplify conda environments, replace conda refs with mamba, update QA configs Jun 22, 2023
CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
@tomvothecoder tomvothecoder changed the title Simplify conda environments, replace conda refs with mamba, update QA configs Simplify conda environments and prioritize pyproject.toml usage Jun 22, 2023
@tomvothecoder tomvothecoder changed the title Simplify conda environments and prioritize pyproject.toml usage Simplify conda environments and move configs to pyproject.toml Jun 22, 2023
@tomvothecoder tomvothecoder merged commit 8f46b30 into main Jun 22, 2023
7 checks passed
Next Release (v0.6.0) automation moved this from In progress to Done Jun 22, 2023
@tomvothecoder tomvothecoder deleted the devops/511-loose-conda-envs branch June 22, 2023 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: devops Testing, CI/CD, systems configuration type: docs Updates to documentation
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

[DevOps]: Loosen up conda environment constraints and consolidate yml files
2 participants