Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes duplicate parameter entry #532

Merged
merged 1 commit into from Aug 17, 2023
Merged

Conversation

jasonb5
Copy link
Collaborator

@jasonb5 jasonb5 commented Aug 16, 2023

Description

Removes duplicate parameter from create_grid.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

If applicable:

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass with my changes (locally and CI/CD build)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have noted that this is a breaking change for a major release (fix or feature that would cause existing functionality to not work as expected)

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f8d33c0) 100.00% compared to head (9c58c72) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #532   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines         1590      1590           
=========================================
  Hits          1590      1590           
Files Changed Coverage Δ
xcdat/regridder/grid.py 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tomvothecoder tomvothecoder added this to In progress in Next Release (v0.6.0) via automation Aug 16, 2023
@tomvothecoder tomvothecoder added the type: docs Updates to documentation label Aug 16, 2023
@tomvothecoder tomvothecoder self-requested a review August 16, 2023 16:50
@jasonb5 jasonb5 merged commit 08cfea3 into xCDAT:main Aug 17, 2023
9 checks passed
Next Release (v0.6.0) automation moved this from In progress to Done Aug 17, 2023
@jasonb5 jasonb5 deleted the fix_create_grid_docs branch August 17, 2023 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: docs Updates to documentation
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

[Doc]: Remove extra attrs docstring for create_axis
2 participants