Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ESMFMKFILE env variable not set in RTD build #577

Merged
merged 3 commits into from Dec 5, 2023
Merged

Fix ESMFMKFILE env variable not set in RTD build #577

merged 3 commits into from Dec 5, 2023

Conversation

tomvothecoder
Copy link
Collaborator

@tomvothecoder tomvothecoder commented Dec 5, 2023 •
edited

Description

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

If applicable:

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass with my changes (locally and CI/CD build)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have noted that this is a breaking change for a major release (fix or feature that would cause existing functionality to not work as expected)

@github-actions github-actions bot added type: bug Inconsistencies or issues which will cause an issue or problem for users or implementors. type: docs Updates to documentation labels Dec 5, 2023
@tomvothecoder tomvothecoder marked this pull request as ready for review December 5, 2023 17:58
@tomvothecoder tomvothecoder self-assigned this Dec 5, 2023
tomvothecoder
tomvothecoder commented Dec 5, 2023
View reviewed changes
docs/conf.py Outdated Show resolved Hide resolved
@tomvothecoder tomvothecoder merged commit 6238148 into main Dec 5, 2023
5 checks passed
@tomvothecoder tomvothecoder deleted the docs/574-esmfmkfile-bug branch December 5, 2023 18:04
@tomvothecoder tomvothecoder mentioned this pull request Apr 16, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tomvothecoder tomvothecoder

Labels
type: bug Inconsistencies or issues which will cause an issue or problem for users or implementors. type: docs Updates to documentation
Projects
xCDAT FY24 Development
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Fix Read the Docs build with ESMF env variable not being set in v0.6.1
1 participant
@tomvothecoder