Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Duplicate credentials are possible #81

Closed
Bouhfid-Mohamed opened this issue Aug 17, 2022 · 2 comments
Closed

bug: Duplicate credentials are possible #81

Bouhfid-Mohamed opened this issue Aug 17, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@Bouhfid-Mohamed
Copy link

Bouhfid-Mohamed commented Aug 17, 2022

Actual behaviour

When I add a new credential (Description, Login and Password) with the same informations as an other that already exist. The new one is inserted even if it already exist.

Expected behaviour

A verification before adding new credentials should be done in order to prevent new credentials if (Login and Password) already exist

Reproduce Steps

Steps to reproduce the behavior:

  1. Add credentials
  2. Add a new credentials with same informations as the first one
  3. The new credentials are created even if they already exist

Screenshots

image

Environment

  • OS: Windows 10
  • App Version: 3.1.0
@Bouhfid-Mohamed Bouhfid-Mohamed added the bug Something isn't working label Aug 17, 2022
@Bouhfid-Mohamed
Copy link
Author

Hello @xEdziu if you find it's realy a bug , you can assign it to me so I work on the fix

@xEdziu
Copy link
Owner

xEdziu commented Aug 17, 2022

Hi @Bouhfid-Mohamed, thanks for reaching out, it means the world to me.

Although I see, how it may be concerning for users, I don't believe it is a bug, more an enhancement I would say.

If you would like to contribute to this project and resolve this problem, feel free to fork this project and propose your solution, otherwise, I will maybe try to resolve this, but I don't know when.

Thank you a lot and have a great day!

@xEdziu xEdziu added the enhancement New feature or request label Aug 17, 2022
@xEdziu xEdziu removed the bug Something isn't working label Aug 22, 2022
@xEdziu xEdziu closed this as not planned Won't fix, can't repro, duplicate, stale Sep 29, 2022
KeepMyPassword-Desktop Project automation moved this from To do to Done Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

No branches or pull requests

2 participants