Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Provider with bound object #9

Merged
merged 3 commits into from May 3, 2018
Merged

Refactor Provider with bound object #9

merged 3 commits into from May 3, 2018

Conversation

xJkit
Copy link
Owner

@xJkit xJkit commented May 3, 2018

  1. Refactor Provider value to pass by bound object literal
  2. API CHANGE: rename pass to handlePass function

@xJkit
Copy link
Owner Author

xJkit commented May 3, 2018

By doing so, I think it fixes #8

@xJkit xJkit merged commit 1ac12d1 into master May 3, 2018
@xJkit xJkit deleted the enhance/provider-rerender branch May 3, 2018 03:05
@coveralls
Copy link

Pull Request Test Coverage Report for Build 32

  • 2 of 4 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.6%) to 72.917%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/GoodByeProvider.js 2 4 50.0%
Totals Coverage Status
Change from base Build 30: -2.6%
Covered Lines: 32
Relevant Lines: 39
💛 - Coveralls

@xJkit xJkit mentioned this pull request May 3, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xJkit @coveralls