Skip to content

Commit

Permalink
always disable dont keep start channels for ESPixelStick discover
Browse files Browse the repository at this point in the history
  • Loading branch information
@computergeek1507
computergeek1507 committed Jan 22, 2024
1 parent 6e0cf17 commit e0ec659
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion xLights/controllers/FPP.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2944,8 +2944,8 @@ static void CreateController(Discovery &discovery, DiscoveredData *inst) {
} else if (inst->typeId == 0xC2 || inst->typeId == 0xC3) {
if (inst->controller->GetProtocol() != OUTPUT_DDP) {
inst->controller->SetProtocol(OUTPUT_DDP);
dynamic_cast<DDPOutput*>(inst->controller->GetOutputs().front())->SetKeepChannelNumber(false);
}
dynamic_cast<DDPOutput*>(inst->controller->GetOutputs().front())->SetKeepChannelNumber(false);
if (inst->majorVersion <= 3) {
inst->pixelControllerType = inst->platformModel;
} else if (inst->typeId == 0xC2) {
Expand Down

3 comments on commit e0ec659

@cybercop23
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I'm missing something here.. but did a Discovery and found my ESPixelStick but kept the Keep Channel Numbers. If I Upload Outputs or FPP Connect and check the hat... with the Keep Channel numbers I get the error
This is using the new Test Flight Mac nightlys.

image

@computergeek1507
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a Mac or specific network config issue, it works for me with my test FPP instance on the same subnet.

espixel

@cybercop23
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh... yes. My Mac is connected wired on a diff subnet than the ESPixleStick. If I connect wifi to the same subnet.. it does find it and populates the same info you have.

#1 wired diff subnet:
2024-01-24 08:41:43,133 6107623424 log_curl [INFO] URL: http://192.168.3.124/
2024-01-24 08:41:48,846 8027135040 log_base [INFO] Processing ip: 192.168.3.124 host: dqaeplus1 uuid:
2024-01-24 08:41:48,846 8027135040 log_curl [INFO] Discovery Adding CURL - URL: http://192.168.3.124/ Method: GET
2024-01-24 08:41:48,864 8027135040 log_base [INFO] Processing ip: 192.168.3.124 host: dqaeplus1 uuid:
2024-01-24 08:41:48,864 8027135040 log_base [INFO] Processing ip: 192.168.3.124 host: dqaeplus1 uuid:
2024-01-24 08:41:49,053 8027135040 log_curl [INFO] Discovery CURL Callback - URL: http://192.168.3.124/ RC: 200 Size: 26505
2024-01-24 08:42:00,740 6105903104 log_curl [INFO] URL: http://192.168.3.124/

#2 wireless same ssid
2024-01-24 08:43:49,840 8027135040 log_base [DEBUG] IP 192.168.3.124
2024-01-24 08:43:49,840 8027135040 log_curl [INFO] Discovery Adding CURL - URL: http://192.168.3.124/ Method: GET
2024-01-24 08:43:49,857 8027135040 log_base [DEBUG] {"config":{"hostname":"dqaeplus1","id":"dqaeplus1","ip":"192.168.3.124","version":"4.0-ci7146255144","hardwareType":"ESPixelStick-ESP32","type":195,"num_chan":3540,"NumPixelPort":8,"NumSerialPort":0}}
2024-01-24 08:43:49,915 8027135040 log_base [INFO] FPP Discovery - Received Ping response from 192.168.3.124
2024-01-24 08:43:49,969 8027135040 log_base [INFO] FPP Discovery - Received Ping response from 192.168.3.124
2024-01-24 08:43:50,016 8027135040 log_base [INFO] Processing ip: 192.168.3.124 host: dqaeplus1 uuid:
2024-01-24 08:43:50,020 8027135040 log_base [DEBUG] {"config":{"hostname":"dqaeplus1","id":"dqaeplus1","ip":"192.168.3.124","version":"4.0-ci7146255144","hardwareType":"ESPixelStick-ESP32","type":195,"num_chan":3540,"NumPixelPort":8,"NumSerialPort":0}}
2024-01-24 08:43:50,023 8027135040 log_base [INFO] FPP Discovery - Received Ping response from 192.168.3.124
2024-01-24 08:43:50,167 8027135040 log_curl [INFO] Discovery CURL Callback - URL: http://192.168.3.124/ RC: 200 Size: 26505
2024-01-24 08:43:50,876 8027135040 log_base [INFO] Processing ip: 192.168.3.124 host: dqaeplus1 uuid:
2024-01-24 08:43:50,876 8027135040 log_base [INFO] Processing ip: 192.168.3.124 host: dqaeplus1 uuid:
2024-01-24 08:43:57,130 6109917184 log_curl [INFO] URL: http://192.168.3.124/

Please sign in to comment.