Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy/Paste Sub Model Node Ranges #2954

Closed
jimswinder opened this issue Nov 22, 2021 · 4 comments
Closed

Copy/Paste Sub Model Node Ranges #2954

jimswinder opened this issue Nov 22, 2021 · 4 comments
Labels

Comments

@jimswinder
Copy link

jimswinder commented Nov 22, 2021

NOTE: IF YOU DO NOT ATTACH A SEQUENCE THAT DEMONSTRATES YOUR PROBLEM THEN THERE IS A HIGH PROBABILITY YOUR ISSUE WILL JUST BE CLOSED AND NOT INVESTIGATED.

Describe the bug
When trying to Copy/Paste the Node Ranges from Sub Model #1 to Sub Model #3 it also copies it to Sub Model #2.

Could also use a "SAVE" button within the Sub Models instead of having to hit "OK" and closing the window down when making a change and having to reopen the window to make other changes.

To Reproduce
Steps to reproduce the behavior:
(and/or link to a short video showing the problem with audio track describing what you are doing)

  1. Go to Sub Models of a Model
  2. Click on Sub Model Number 1 and copy Node Range
  3. Paste to Sub Model Number 3
  4. Node Range Also appears in Sub Model Number 2

Expected behavior
Would expect Node Range to only appear in Sub Model I pasted it to
Screenshots
Video Attached (Also..tried to attach a .mov file and got the error "We Don't Support That Type Of File"

Versions (please complete the following information):

  • OS: Windows 10
  • xLights version 2021.35 64bit

Additional context
None

Attachments

Sub Models.zip
Sub Models-Those Blinking Lights RGB.zip

@cybercop23
Copy link
Collaborator

Can this be closed?

@derwin12
Copy link
Collaborator

Need some help on this one..
This grabs the submodel that you just clicked on "Two"
SubModelInfo* sm = GetSubModelInfo(GetSelectedName());
But the assignment is STILL looking at the Third line .. where you just pasted in new info
sm->strands[str] = NodesGrid->GetCellValue(r, 0); // dwe this might still be pointing at the last one???
So that means that line TWO data is overwritten by the entry of line THREE.
The "workaround" is to be sure and hit enter after making the change on line THREE.. but it is easily reproducible without hitting the enter key.

image

@derwin12
Copy link
Collaborator

Seems like a feature of wxWidgets :-) May have to code some trickery here.
https://forums.wxwidgets.org/viewtopic.php?t=39587

@cybercop23
Copy link
Collaborator

Will be available in the nightly and next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants