Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In 2-person tab, prevent un-joining participants #123

Closed
jancborchardt opened this issue Mar 27, 2017 · 5 comments
Closed

In 2-person tab, prevent un-joining participants #123

jancborchardt opened this issue Mar 27, 2017 · 5 comments

Comments

@jancborchardt
Copy link
Collaborator

If there are just two people in a tab, especially permanently, it sometimes happens that the »joined« button is misclicked and thus the person deselected. This could be disabled to catch misclicks.

Yes there is the case where you want to go through the list and unjoin people before you add the others which took part. A different proposal could be that if you have just two people in a tab and save a transaction with one person not having joined, automatically both should be set to joined cause a transaction with just one person is not possible.

What do you think @xMartin?

@xMartin
Copy link
Owner

xMartin commented Oct 21, 2018

How would the toggle button look like for this state "selected and deselection disabled"? It would be confusing if it looked the same but wouldn't react in tap/click, no?

@jancborchardt
Copy link
Collaborator Author

I'm now leaning towards the second proposal from above:

A different proposal could be that if you have just two people in a tab and save a transaction with one person not having joined, automatically both should be set to joined cause a transaction with just one person is not possible.

@xMartin
Copy link
Owner

xMartin commented Nov 11, 2018

If you only have two people in a tab, they are both set to "joined" initially for a new transaction.

I don't feel fixing "misclicks" in a certain situation is worth introducing automagic behavior. Is it really that big of an issue?

@jancborchardt
Copy link
Collaborator Author

I probably have that once a month or less. So yeah it’s not really that often, but it’s not something that should happen either?

@jancborchardt
Copy link
Collaborator Author

I didn’t have this issue since then, so let’s close it. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants