Skip to content

Commit

Permalink
fix: introduce feature flag to control jupyter integration
Browse files Browse the repository at this point in the history
JIRA: TRIVIAL
  • Loading branch information
xMort committed Nov 23, 2023
1 parent 7371f3b commit ec0808b
Show file tree
Hide file tree
Showing 7 changed files with 18 additions and 0 deletions.
Binary file modified libs/sdk-backend-tiger/gooddata-sdk-backend-tiger-0.0.0-dev.0.tgz
Binary file not shown.
7 changes: 7 additions & 0 deletions libs/sdk-backend-tiger/src/backend/features/feature.ts
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,13 @@ export function mapFeatures(features: FeaturesMap): Partial<ITigerFeatureFlags>
"BOOLEAN",
FeatureFlagsValues.enableKDDependentFilters,
),
...loadFeature(
features,
TigerFeaturesNames.EnableAdvancedMachineLearningIntegration,
"enableAdvancedMachineLearningIntegration",
"BOOLEAN",
FeatureFlagsValues.enableAdvancedMachineLearningIntegration,
),
};
}

Expand Down
5 changes: 5 additions & 0 deletions libs/sdk-backend-tiger/src/backend/uiFeatures.ts
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@ export enum TigerFeaturesNames {
EnableUserManagement = "enableUserManagement",
//boolean + possible values: enabled, disabled
EnableKDDependentFilters = "enableKDDependentFilters",
//boolean + possible values: enabled, disabled
EnableAdvancedMachineLearningIntegration = "enableAdvancedMachineLearningIntegration",
}

export type ITigerFeatureFlags = {
Expand Down Expand Up @@ -85,6 +87,7 @@ export type ITigerFeatureFlags = {
enablePivotTableIncreaseBucketSize: typeof FeatureFlagsValues["enablePivotTableIncreaseBucketSize"][number];
enableUserManagement: typeof FeatureFlagsValues["enableUserManagement"][number];
enableKDDependentFilters: typeof FeatureFlagsValues["enableKDDependentFilters"][number];
enableAdvancedMachineLearningIntegration: typeof FeatureFlagsValues["enableAdvancedMachineLearningIntegration"][number]
};

export const DefaultFeatureFlags: ITigerFeatureFlags = {
Expand Down Expand Up @@ -113,6 +116,7 @@ export const DefaultFeatureFlags: ITigerFeatureFlags = {
enablePivotTableIncreaseBucketSize: true,
enableUserManagement: false,
enableKDDependentFilters: false,
enableAdvancedMachineLearningIntegration: false,
};

export const FeatureFlagsValues = {
Expand Down Expand Up @@ -145,4 +149,5 @@ export const FeatureFlagsValues = {
enablePivotTableIncreaseBucketSize: [true, false] as const,
enableUserManagement: [true, false] as const,
enableKDDependentFilters: [true, false] as const,
enableAdvancedMachineLearningIntegration: [true, false] as const,
};
1 change: 1 addition & 0 deletions libs/sdk-model/api/sdk-model.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -2414,6 +2414,7 @@ export interface ISettings {
ADMeasureValueFilterNullAsZeroOption?: string;
disableKpiDashboardHeadlineUnderline?: boolean;
enableAdDescriptionEdit?: boolean;
enableAdvancedMachineLearningIntegration?: boolean;
enableAlternativeDisplayFormSelection?: boolean;
enableAnalyticalDashboardPermissions?: boolean;
enableApproxCount?: boolean;
Expand Down
Binary file modified libs/sdk-model/gooddata-sdk-model-0.0.0-dev.0.tgz
Binary file not shown.
5 changes: 5 additions & 0 deletions libs/sdk-model/src/settings/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -319,6 +319,11 @@ export interface ISettings {
*/
enableKDDependentFilters?: boolean;

/**
* Enable advanced machine learning integration in KD.
*/
enableAdvancedMachineLearningIntegration?: boolean;

[key: string]: number | boolean | string | object | undefined;
}

Expand Down
Binary file modified tools/plugin-toolkit/gooddata-plugin-toolkit-0.0.0-dev.0.tgz
Binary file not shown.

0 comments on commit ec0808b

Please sign in to comment.