Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE: LX-23 Render values validation items in attribute filter configuration #1

Closed
wants to merge 2 commits into from
Closed

FEATURE: LX-23 Render values validation items in attribute filter configuration #1

wants to merge 2 commits into from

Conversation

xMort
Copy link
Owner

@xMort xMort commented Jan 17, 2024

JIRA: LX-23

Supported PR commands:

Command Description
ok to test Re-run standard checks
extended test BackstopJS tests

PR Checklist

xMort
xMort commented Jan 17, 2024
View reviewed changes
...i-dashboard/src/presentation/filterBar/attributeFilter/dashboardDropdownBody/useItemsHook.ts
@@ -1,21 +0,0 @@
// (C) 2021-2022 GoodData Corporation
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file was not used.

xMort
xMort commented Jan 17, 2024
View reviewed changes
.../attributeFilter/dashboardDropdownBody/configuration/parentFilters/ParentFiltersListItem.tsx
@@ -14,12 +14,6 @@ import {
} from "../../../../../../model/index.js";
import { ConnectingAttributeDropdown } from "../connectingAttribute/ConnectingAttributeDropdown.js";

export interface IConfigurationParentItem {
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This interface was not used.

@xMort xMort marked this pull request as ready for review January 17, 2024 19:10
@xMort xMort changed the title feat: render values validation items in attribute filter configuration FEATURE: LX-23 Render values validation items in attribute filter configuration Jan 17, 2024
@xMort xMort force-pushed the pdo-lx-23-available-filter-values-spi branch from 5ed94e2 to f2f1edb Compare January 18, 2024 10:47
@xMort xMort closed this Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@xMort