Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add icon #23

Merged
merged 5 commits into from Jun 3, 2018
Merged

Add icon #23

merged 5 commits into from Jun 3, 2018

Conversation

hafizahmmed
Copy link
Contributor

No description provided.

@hafizahmmed hafizahmmed mentioned this pull request Jun 2, 2018
Closed
xRahul
xRahul reviewed Jun 2, 2018
View reviewed changes
README.md Outdated
@@ -1,3 +1,5 @@
![asset 1-8](https://user-images.githubusercontent.com/38810169/40872729-06168d0e-6675-11e8-9537-af0a0f133d11.png)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add NotifyAvailability instead of asset 1-8 and remove the header below. This by itself looks good enough

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i removed this

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was actually a good header image. Can you add this image in the path images/readmeHeader.png?

xRahul
xRahul requested changes Jun 2, 2018
View reviewed changes
Copy link
Owner

@xRahul xRahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just update the readme. I would also prefer the icon folder to be moved to a images folder.

@hafizahmmed hafizahmmed closed this Jun 2, 2018
@hafizahmmed hafizahmmed reopened this Jun 2, 2018
@hafizahmmed
Copy link
Contributor Author

now check

xRahul
xRahul requested changes Jun 3, 2018
View reviewed changes
images/icon
@@ -0,0 +1 @@

Copy link
Owner

@xRahul xRahul Jun 3, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is unnecessary. I was asking to move the entire icon folder that you have created in the folder images.

@xRahul
Copy link
Owner

xRahul commented Jun 3, 2018 •
edited

Also, can you add this image in the path images/readmeHeader.png along with its license?
I could use this as the header image for this app.

Also, if you have the svg file you've used to create the icon, can you add that? In the future if I need to create some other resolution image for this, that would make it easier.

@xRahul xRahul added enhancement New feature or request good first issue Good for newcomers and removed good first issue Good for newcomers labels Jun 3, 2018
@xRahul xRahul merged commit be8fa5d into xRahul:master Jun 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xRahul xRahul xRahul requested changes

Assignees

@hafizahmmed hafizahmmed

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hafizahmmed @xRahul