Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] or bug? Missing dp input (humidifier_current_humidity_dp) in config flow for (de)humidifier #159

Closed
kvikindi opened this issue Mar 5, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@kvikindi
Copy link

kvikindi commented Mar 5, 2024

Device: Inventor EVA Ion Pro II wifi.
localtuya version: master and 3.2.4.2

When setting up through configure - add new - discover entities automatically, the configuration includes the line humidifier_current_humidity_dp: '6', but as soon as you manually edit the device through "configure", that line is removed entirely (as evident by exporting templates before and after change).

Looking through .storage/core.config_entries I can see the same happen in real-time when submitting the change through the config flow.

Possible solution might be an additional input box in the DP 1* config flow for adding "Current Humidity DP", similar to how you set modes and humidity target DPs?
*In my case, that's the main switch DP for the dehumidifier

What sent me down this rabbit hole is that after adding missing features through "configure" (ION mode switch, fan speed etc.), I noticed that the humidifier card wasn't showing current humidity anymore.
After manually editing .storage/core.config_entries, I can see this feature again.

I'm not sure if you need any logs from me, as it seems to be inherent to the config flow itself. Please let me know if otherwise.

Thank you for keeping this integration alive btw!
Stay fabulous,
Ragnar

*edit - example of template before and after editing an auto-discovered setup.

Before
- humidifier:
    device_class: dehumidifier
    entity_category: None
    friendly_name: ''
    humidifier_available_modes:
      continuous: Continuous
      dehumidify: Dehumidify
      drying: Drying
    humidifier_current_humidity_dp: '6'
    humidifier_mode_dp: '5'
    humidifier_set_humidity_dp: '2'
    icon: ''
    id: '1'
    platform: humidifier
- sensor:
    device_class: humidity
    entity_category: None
    friendly_name: Humidity
    icon: ''
    id: '6'
    platform: sensor
    state_class: measurement
- sensor:
    device_class: temperature
    entity_category: None
    friendly_name: Temperature
    icon: ''
    id: '7'
    platform: sensor
    state_class: measurement
- binary_sensor:
    device_class: problem
    entity_category: diagnostic
    friendly_name: Fault
    icon: ''
    id: '19'
    platform: binary_sensor
    state_on: '1'
After
- humidifier:
    device_class: dehumidifier
    entity_category: None
    friendly_name: Eva Ion Pro II
    humidifier_available_modes:
      continuous: Continuous
      drying: Drying
      manual: Manual
      smart: Smart
    humidifier_mode_dp: '5'
    humidifier_set_humidity_dp: '2'
    icon: ''
    id: '1'
    max_humidity: 85
    min_humidity: 35
    platform: humidifier
- sensor:
    device_class: humidity
    entity_category: None
    friendly_name: Humidity
    icon: ''
    id: '6'
    platform: sensor
    state_class: measurement
- sensor:
    device_class: temperature
    entity_category: None
    friendly_name: Temperature
    icon: ''
    id: '7'
    platform: sensor
    state_class: measurement
- binary_sensor:
    device_class: problem
    entity_category: diagnostic
    friendly_name: Fault
    icon: ''
    id: '19'
    platform: binary_sensor
    state_on: '1'
@kvikindi kvikindi added the bug Something isn't working label Mar 5, 2024
@xZetsubou
Copy link
Owner

I think I forgot to add a the current humidity DP into the config flow 😅 , so after editing the device it probably overwritten the old config with new one which it doesn't includes current DP option

@xZetsubou xZetsubou added the master/next-release Fixed in master branch, Will be ready in the next release label Mar 5, 2024
Copy link

github-actions bot commented Mar 8, 2024

This issue was closed because it was resolved on the release: 3.2.5

@github-actions github-actions bot added stale and removed master/next-release Fixed in master branch, Will be ready in the next release stale labels Mar 8, 2024
@github-actions github-actions bot closed this as completed Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants