Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

[Launcher][iOS] Fixing save to files bug #1609

Merged
merged 21 commits into from
Jan 15, 2021
Merged

Conversation

dimonovdd
Copy link
Contributor

@dimonovdd dimonovdd commented Dec 27, 2020

Bugs Fixed

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard
  • Updated documentation (see walkthrough)

@dimonovdd dimonovdd changed the title [Launcher][iOS] fixing save to files bug [Launcher][iOS] Fixing save to files bug Dec 27, 2020
Copy link
Contributor

@mattleibow mattleibow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Just a few Q's and then a quick revert of one file.

After I do some testing in release on a device, we can approve.

Samples/Samples/View/LauncherPage.xaml Outdated Show resolved Hide resolved
Xamarin.Essentials/Launcher/Launcher.ios.tvos.cs Outdated Show resolved Hide resolved
Xamarin.Essentials/Launcher/Launcher.ios.tvos.cs Outdated Show resolved Hide resolved
@mattleibow mattleibow added this to the 1.6.1 milestone Jan 14, 2021
@mattleibow mattleibow merged commit c541cbe into xamarin:main Jan 15, 2021
@dimonovdd dimonovdd mentioned this pull request Mar 6, 2021
@dimonovdd dimonovdd deleted the fix1592 branch July 12, 2021 20:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants