This repository has been archived by the owner on May 15, 2024. It is now read-only.
Use NSSpeechSynthesizer.AttributesForVoice to correctly populate the X.E Locale on Mac. #1623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@mattleibow, @jamesmontemagno Let me know if there is anything else I should do to this PR, to get this merged?? |
mattleibow
reviewed
Jan 14, 2021
|
I did some testing on Android and they had a bunch of en for all the variants. I think we need to at some point parse the languages and create a better locale object. |
|
@mattleibow When will this hit X.E preview nugets? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Use NSSynthesiser Attributes to correctly populate the X.E Locale properties on Mac.
Fix Locale Name on iOS as it was incorrectly populating it with Language
Tweaked TTS demo, to list Languages, so that voices are changed correctly on all platforms.
Bugs Fixed
API Changes
None
Added:
None
Changed:
[Mac] Pass each voice to the NSSpeechSynthesizer.AttributesForVoice(), so we can then popolate the Locale object correctly.
https://github.com/CartBlanche/Essentials/blob/dominique-FixTTSLocaleOnMac/Xamarin.Essentials/TextToSpeech/TextToSpeech.macos.cs#L15-L18
[iOS] Populate Name property correctly.
https://github.com/CartBlanche/Essentials/blob/dominique-FixTTSLocaleOnMac/Xamarin.Essentials/TextToSpeech/TextToSpeech.ios.tvos.watchos.cs#L15-L16
[Sample] Use language to populate Action sheet, so languages can be changes across platforms.
https://github.com/CartBlanche/Essentials/blob/dominique-FixTTSLocaleOnMac/Samples/Samples/ViewModel/TextToSpeechViewModel.cs#L91-L95
Behavioural Changes
Tweaked how the Locale on Mac is populated as per changes above.
PR Checklist
mainat time of PR