Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle version downgrades (e.g. via TestFlight) #1969

Merged

Conversation

cpraehaus
Copy link
Contributor

Description of Change

Version downgrades (e.g. from "1.1.0" to "1.0.1") are possible on certain platforms (e.g. on iOS with TestFlight) and thus should be handled correctly by VersionTracking module - especially if the version was already installed previously.

Since this is a bugfix (not a feature) covered by unit tests no samples are provided (see PR checklist).

Bugs Fixed

API Changes

None

Behavioral Changes

Observable behavior/semantics of the following API elements can change but only in downgrade scenarios described above:

  • VersionTracking.IsFirstLaunchForCurrentVersion
  • VersionTracking.IsFirstLaunchForCurrentBuild
  • VersionTracking.PreviousVersion
  • VersionTracking.PreviousBuild
  • VersionTracking.FirstInstalledVersion
  • VersionTracking.FirstInstalledBuild
  • VersionTracking.VersionHistory
  • VersionTracking.BuildHistory
  • VersionTracking.IsFirstLaunchForVersion()
  • VersionTracking.IsFirstLaunchForBuild()

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard
  • Updated documentation (see walkthrough)

@ghost
Copy link

ghost commented Feb 20, 2022

CLA assistant check
All CLA requirements met.

@jamesmontemagno
Copy link
Collaborator

@mattleibow since you wrote this if you can take a look at it.

@jamesmontemagno jamesmontemagno added this to the 1.7.2 milestone Feb 22, 2022
@jfversluis
Copy link
Member

jfversluis commented Apr 5, 2022

Edit: nope, I am totally mistaken with what I wrote earlier. This seems good to me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants