Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surface exception for not supported phone number on iOS PhoneDialer #1986

Merged
merged 1 commit into from Apr 5, 2022

Conversation

jfversluis
Copy link
Member

Description of Change

Doesn't swallow the exception because of the async void that was going on

Bugs Fixed

API Changes

N/A

Behavioral Changes

Doesn't swallow the exception because of the async void that was going on

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard
  • Updated documentation (see walkthrough)

@jfversluis jfversluis added bug Something isn't working ios This issue impacts iOS labels Apr 4, 2022
@jfversluis jfversluis added this to the 1.7.2 milestone Apr 4, 2022
@jfversluis
Copy link
Member Author

@jamesmontemagno this seems like a small one we can also pull into 1.7.2?

@jfversluis
Copy link
Member Author

Reviewed through .NET MAUI change. If it's good enough for .NET MAUI, it's good enough for Xamarin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ios This issue impacts iOS
Projects
None yet
1 participant