Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove wrong Connectivity dispose calls on Android #2091

Merged
merged 1 commit into from Jul 2, 2023
Merged

Conversation

jfversluis
Copy link
Member

Fixes #1996

Closes #1997

@jfversluis jfversluis added the android This issue impacts Android label Jun 15, 2023
@jfversluis
Copy link
Member Author

@borrrden @cpraehaus if this is still relevant, would you be able to get the NuGet from this PR and try if that resolves your issues?

@borrrden
Copy link

Let me reach out to our user who was having the problem.

@cpraehaus
Copy link
Contributor

@jfversluis Thanks for the fix. Yes, I will try to re-produce the issue again and then test the fix in this PR.

@cpraehaus
Copy link
Contributor

@jfversluis I tested v1.8.0-pr.2091.1 and can confirm that for our case the problem is fixed: no exception is thrown anymore.

Android ConnectivityManager still complains about the missing callback but I think this is OK in this case since the callback was scheduled by the system but in the meantime deregistered/removed by the application:

[ConnectivityManager.CallbackHandler] callback not found for CALLBACK_AVAILABLE message

@jfversluis
Copy link
Member Author

Thanks @cpraehaus

@jfversluis jfversluis merged commit 8ee188f into main Jul 2, 2023
11 of 12 checks passed
@jfversluis jfversluis deleted the fix-1996 branch July 2, 2023 11:54
jfversluis added a commit that referenced this pull request Jul 3, 2023
Remove wrong Connectivity dispose calls on Android
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android This issue impacts Android
Projects
None yet
3 participants