Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

Change CMAttitudeReferenceFrame to XMagneticNorthZVertical to remove … #2123

Closed
wants to merge 2 commits into from

Conversation

robheffo79
Copy link

…the dependency on the compass calibration, thus removing the dependency on location services.

Description of Change

Changed the CMAttitudeReferenceFrame value from XTrueNorthZVertical to XMagneticNorthZVertical in OrientationSensor.ios.watchos.cs line #19.

This change is trivial and requires no tests, samples or documentation.

Bugs Fixed

- Related to issue #2122

API Changes

None

Behavioral Changes

Orientation Sensor takes calibration from Magnetic North instead of True North. True north requires Location Services to be enabled for the app, introducing a sensitive permission that is not strictly necessary. This change pulls the functionality into line with the behavior of Android, which uses Magnetic North for its calibration.

PR Checklist

  • [ ❌ ] Has tests (if omitted, state reason in description)
  • [ ❌ ] Has samples (if omitted, state reason in description)
  • [ ✔️ ] Rebased on top of main at time of PR
  • [ ✔️ ] Changes adhere to coding standard
  • [ ❌ ] Updated documentation (see walkthrough)

Robert Heffernan and others added 2 commits February 1, 2024 16:54
…the dependency on the compass calibration, thus removing the dependency on location services.
@jfversluis
Copy link
Member

This would be a breaking change and I don't think we want to do that in this phase of the Xamarin.Essentials lifecycle as we're only months away from sunsetting it.

Thanks for your time and effort here, you might want to consider proposing this still for .NET MAUI as that likely has the same behavior.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants