Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-649: Return distinct connectivity profiles. #650

Merged
merged 2 commits into from Dec 19, 2018
Merged

GH-649: Return distinct connectivity profiles. #650

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9fc01f
Return distnct profiles. Added test as well.
jamesmontemagno Dec 12, 2018
88d02b2
Merge branch 'master' into bug/issue-649
jamesmontemagno Dec 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 8 additions & 1 deletion DeviceTests/DeviceTests.Shared/Connectivity_Tests.cs
View file
Open in desktop
Expand Up @@ -11,7 +11,14 @@ public class Connectivity_Tests
Assert.Equal(NetworkAccess.Internet, Connectivity.NetworkAccess);

[Fact]
public void ConnectionProfiles() =>
public void Connection_Profiles() =>
Assert.True(Connectivity.ConnectionProfiles.Count() > 0);

[Fact]
public void Distict_Connection_Profiles()
{
var profiles = Connectivity.ConnectionProfiles;
Assert.Equal(profiles.Count(), profiles.Distinct().Count());
}
}
}
2 changes: 1 addition & 1 deletion Xamarin.Essentials/Connectivity/Connectivity.shared.cs
View file
Open in desktop
Expand Up @@ -15,7 +15,7 @@ public static partial class Connectivity

public static NetworkAccess NetworkAccess => PlatformNetworkAccess;

public static IEnumerable<ConnectionProfile> ConnectionProfiles => PlatformConnectionProfiles;
public static IEnumerable<ConnectionProfile> ConnectionProfiles => PlatformConnectionProfiles.Distinct();

public static event EventHandler<ConnectivityChangedEventArgs> ConnectivityChanged
{
Expand Down