Converters between meters and feet (US Survey and International) added #935

qmark · 2019-10-15T16:22:51Z

Description of Change

Converters between meters and feet (US Survey and International) added

API Changes

    public static double MetersToUSSurveyFeet(double meters);
    public static double USSurveyFeetToMeters(double usfeet);

    public static double MetersToInternationalFeet(double meters);
    public static double InternationalFeetToMeters(double intfeet);

VSC-Service-Account · 2019-10-15T16:24:06Z

Docs Build status updates of commit bf4e1ac:

⚠️ Validation status: warnings

File	Status	Details
	⚠️Warning	Details
Xamarin.Essentials/Types/UnitConverters.shared.cs	✅Succeeded
docs/en/Xamarin.Essentials/SizeExtensions.xml	✅Succeeded
docs/en/Xamarin.Essentials/RectangleExtensions.xml	✅Succeeded
docs/en/Xamarin.Essentials/PointExtensions.xml	✅Succeeded
docs/en/Xamarin.Essentials/ColorExtensions.xml	✅Succeeded

[Warning] Uid(Xamarin.Essentials.ColorExtensions.ToPlatformColor(System.Drawing.Color)_m) has already been defined in api/Xamarin.Essentials.ColorExtensions.ToPlatformColor.yml#Xamarin_Essentials_ColorExtensions_ToPlatformColor_System_Drawing_Color__m.
[Warning] Uid(Xamarin.Essentials.PointExtensions.ToPlatformPoint(System.Drawing.Point)_m) has already been defined in api/Xamarin.Essentials.PointExtensions.ToPlatformPoint.yml#Xamarin_Essentials_PointExtensions_ToPlatformPoint_System_Drawing_Point__m.
[Warning] Uid(Xamarin.Essentials.SizeExtensions.ToPlatformSize(System.Drawing.Size)_m) has already been defined in api/Xamarin.Essentials.SizeExtensions.ToPlatformSize.yml#Xamarin_Essentials_SizeExtensions_ToPlatformSize_System_Drawing_Size__m.
[Warning] Uid(Xamarin.Essentials.RectangleExtensions.ToPlatformRectangle(System.Drawing.Rectangle)_m) has already been defined in api/Xamarin.Essentials.RectangleExtensions.ToPlatformRectangle.yml#Xamarin_Essentials_RectangleExtensions_ToPlatformRectangle_System_Drawing_Rectangle__m.

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

mattleibow

LGTM

jamesmontemagno · 2019-10-16T03:38:22Z

Is naming alright @Redth thoughts @mattleibow does everything align?

Looks like there is some spacing issues:

Xamarin.Essentials\Types\UnitConverters.shared.cs(105,1): Error SA1516: Elements should be separated by blank line

jamesmontemagno · 2019-10-16T03:40:18Z

Also needs documentation:

1 Foot:
International survey foot defined as exactly 0.3048 meters by convention in 1959. This is the most common modern foot measure. US Survey may also be used but are nearly identical for short distances. 1 ft = 0.3048 m.

1 Foot (U.S. Survey):
Exactly 1200/3937 meters by definition. In decimal terms approximately 0.304 800 609 601 219 meters. Variation from the common international foot of exactly 0.3048 meters may only be considerable over large survey distances. 1 ft (US survey) = 1200/3937 m

Should there also be.... USSurveyFeetToInternationalFeet and InternationalFeetToUSSurveyFeet ?

jamesmontemagno · 2019-10-16T03:41:45Z

Also needs tests as to make sure they are being converted correctly

VSC-Service-Account · 2019-10-16T12:05:09Z

Docs Build status updates of commit b1e5cf5:

🕙 Pending: waiting for processors (6 builds ahead of you)

⚠️ Docs Build is busy, currently there are 6 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

msftclas · 2019-10-16T12:05:12Z

All CLA requirements met.

VSC-Service-Account · 2019-10-16T12:06:31Z

Docs Build status updates of commit b1e5cf5:

⚠️ Validation status: warnings

File	Status	Details
	⚠️Warning	Details
Xamarin.Essentials/Types/UnitConverters.shared.cs	✅Succeeded
docs/en/Xamarin.Essentials/SizeExtensions.xml	✅Succeeded
docs/en/Xamarin.Essentials/RectangleExtensions.xml	✅Succeeded
docs/en/Xamarin.Essentials/PointExtensions.xml	✅Succeeded
docs/en/Xamarin.Essentials/ColorExtensions.xml	✅Succeeded

[Warning] Uid(Xamarin.Essentials.SizeExtensions.ToPlatformSize(System.Drawing.Size)_m) has already been defined in api/Xamarin.Essentials.SizeExtensions.ToPlatformSize.yml#Xamarin_Essentials_SizeExtensions_ToPlatformSize_System_Drawing_Size__m.
[Warning] Uid(Xamarin.Essentials.ColorExtensions.ToPlatformColor(System.Drawing.Color)_m) has already been defined in api/Xamarin.Essentials.ColorExtensions.ToPlatformColor.yml#Xamarin_Essentials_ColorExtensions_ToPlatformColor_System_Drawing_Color__m.
[Warning] Uid(Xamarin.Essentials.PointExtensions.ToPlatformPoint(System.Drawing.Point)_m) has already been defined in api/Xamarin.Essentials.PointExtensions.ToPlatformPoint.yml#Xamarin_Essentials_PointExtensions_ToPlatformPoint_System_Drawing_Point__m.
[Warning] Uid(Xamarin.Essentials.RectangleExtensions.ToPlatformRectangle(System.Drawing.Rectangle)_m) has already been defined in api/Xamarin.Essentials.RectangleExtensions.ToPlatformRectangle.yml#Xamarin_Essentials_RectangleExtensions_ToPlatformRectangle_System_Drawing_Rectangle__m.

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

qmark · 2019-10-16T12:09:49Z

@jamesmontemagno have added documentation and refactored for a nicer look (with constants and indents). Unfortunately I cannot launch Tests of Essentials projects, but I can provide NUnit tests I use for the code in my project (and they run successively)

    [Test]
    public void MetersToInternationalFeet()
    {
        Assert.AreEqual(10000, DistanceUtility.MetersToInternationalFeet(3048));
    }

    [Test]
    public void InternationalFeetToMeters()
    {
        Assert.AreEqual(6096, DistanceUtility.InternationalFeetToMeters(20000));
    }

    [Test]
    public void MetersToUSSurveyFeet()
    {
        Assert.AreEqual(3937, DistanceUtility.MetersToUSSurveyFeet(1200));
    }

    [Test]
    public void USSurveyFeetToMeters()
    {
        Assert.AreEqual(2400, DistanceUtility.USSurveyFeetToMeters(7874));
    }

Redth · 2019-10-16T13:24:28Z

@qmark can you please change these to use xUnit ?

[Fact]
public void USSurveyFeetToMeters()
{
    Assert.AreEqual(2400, DistanceUtility.USSurveyFeetToMeters(7874));
}

Thanks

qmark · 2019-10-16T13:33:54Z

@Redth I will, however I cannot launch them in the project, so not sure if they will run successfully. Does autocheck run unit tests?

VSC-Service-Account · 2019-10-16T13:42:32Z

Docs Build status updates of commit 258b7f6:

⚠️ Validation status: warnings

File	Status	Details
	⚠️Warning	Details
Tests/UnitConverters_Tests.cs	✅Succeeded
Xamarin.Essentials/Types/UnitConverters.shared.cs	✅Succeeded
docs/en/Xamarin.Essentials/SizeExtensions.xml	✅Succeeded
docs/en/Xamarin.Essentials/RectangleExtensions.xml	✅Succeeded
docs/en/Xamarin.Essentials/PointExtensions.xml	✅Succeeded
docs/en/Xamarin.Essentials/ColorExtensions.xml	✅Succeeded

[Warning] Uid(Xamarin.Essentials.PointExtensions.ToPlatformPoint(System.Drawing.Point)_m) has already been defined in api/Xamarin.Essentials.PointExtensions.ToPlatformPoint.yml#Xamarin_Essentials_PointExtensions_ToPlatformPoint_System_Drawing_Point__m.
[Warning] Uid(Xamarin.Essentials.ColorExtensions.ToPlatformColor(System.Drawing.Color)_m) has already been defined in api/Xamarin.Essentials.ColorExtensions.ToPlatformColor.yml#Xamarin_Essentials_ColorExtensions_ToPlatformColor_System_Drawing_Color__m.
[Warning] Uid(Xamarin.Essentials.SizeExtensions.ToPlatformSize(System.Drawing.Size)_m) has already been defined in api/Xamarin.Essentials.SizeExtensions.ToPlatformSize.yml#Xamarin_Essentials_SizeExtensions_ToPlatformSize_System_Drawing_Size__m.
[Warning] Uid(Xamarin.Essentials.RectangleExtensions.ToPlatformRectangle(System.Drawing.Rectangle)_m) has already been defined in api/Xamarin.Essentials.RectangleExtensions.ToPlatformRectangle.yml#Xamarin_Essentials_RectangleExtensions_ToPlatformRectangle_System_Drawing_Rectangle__m.

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

qmark · 2019-10-16T13:59:53Z

Managed to run the tests, they all pass

Redth · 2019-10-28T19:10:03Z

@qmark the only other question I'd say is, do we really need to call them International feet? Is this not the commonly understood implementation of feet already? I may be ignorant here but to me it seems more confusion to call them International Feet. I totally get calling the US Survey feet specifically out though.

Thoughts?

VSC-Service-Account · 2019-10-29T10:39:52Z

Docs Build status updates of commit a27f831:

✅ Validation status: passed

File	Status	Preview URL	Details
Tests/UnitConverters_Tests.cs	✅Succeeded
Xamarin.Essentials/Types/UnitConverters.shared.cs	✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

qmark · 2019-10-29T10:58:13Z

@Redth Yes, it is the commonly understood implementation of feet, and I also added summary with "This is the most common modern foot measure" for International foot. For me it's hard to say if it is confusing, as I have some knowledge in the field, and say there is also Indian survey foot, which may be just "Foot" for someone in India, or metric foot, which is exactly 30 cm and may be "Foot" for someone in Europe.

I'd say it's better for someone in the U.S. to have it as just "Foot", but not sure about other people. For instance, English wiki page https://en.wikipedia.org/wiki/Foot_(unit) says "one foot is defined as 0.3048 meter exactly" in the second sentence, but Russian wiki https://ru.wikipedia.org/wiki/Фут says "The exact linear value varies from country to country." in the second sentence, and "“International” foot began to equal exactly 0.3048 m" later on.

Redth · 2019-10-29T16:13:36Z

Thanks!

VSC-Service-Account · 2019-10-29T16:14:30Z

Docs Build status updates of commit e19ed72:

✅ Validation status: passed

File	Status	Preview URL	Details
Tests/UnitConverters_Tests.cs	✅Succeeded
Xamarin.Essentials/Types/UnitConverters.shared.cs	✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

xamarin#935) * Converters between meters and feet (US Survey and International) added * Refactoring and documentation * xUnit tests

Converters between meters and feet (US Survey and International) added

bf4e1ac

mattleibow previously approved these changes Oct 16, 2019

View reviewed changes

Refactoring and documentation

b1e5cf5

qmark dismissed mattleibow’s stale review via b1e5cf5 October 16, 2019 12:05

xUnit tests

258b7f6

qmark requested a review from mattleibow October 18, 2019 11:49

Redth changed the base branch from master to dev/1.4.0 October 28, 2019 19:10

Redth added this to the 1.4.0 milestone Oct 28, 2019

Redth added the hacktoberfest 🎃 label Oct 28, 2019

Merge branch 'dev/1.4.0' into add-feet-convertors

a27f831

Redth approved these changes Oct 29, 2019

View reviewed changes

Merge branch 'dev/1.4.0' into add-feet-convertors

e19ed72

Redth merged commit 4b12a72 into xamarin:dev/1.4.0 Oct 29, 2019

qmark deleted the add-feet-convertors branch October 29, 2019 16:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Converters between meters and feet (US Survey and International) added #935

Converters between meters and feet (US Survey and International) added #935

qmark commented Oct 15, 2019

VSC-Service-Account commented Oct 15, 2019

mattleibow left a comment

jamesmontemagno commented Oct 16, 2019

jamesmontemagno commented Oct 16, 2019

jamesmontemagno commented Oct 16, 2019

VSC-Service-Account commented Oct 16, 2019

msftclas commented Oct 16, 2019 •

edited

VSC-Service-Account commented Oct 16, 2019

qmark commented Oct 16, 2019 •

edited

Redth commented Oct 16, 2019

qmark commented Oct 16, 2019

VSC-Service-Account commented Oct 16, 2019

qmark commented Oct 16, 2019

Redth commented Oct 28, 2019

VSC-Service-Account commented Oct 29, 2019

qmark commented Oct 29, 2019

Redth commented Oct 29, 2019

VSC-Service-Account commented Oct 29, 2019

Converters between meters and feet (US Survey and International) added #935

Converters between meters and feet (US Survey and International) added #935

Conversation

qmark commented Oct 15, 2019

Description of Change

API Changes

VSC-Service-Account commented Oct 15, 2019

⚠️ Validation status: warnings

mattleibow left a comment

Choose a reason for hiding this comment

jamesmontemagno commented Oct 16, 2019

jamesmontemagno commented Oct 16, 2019

jamesmontemagno commented Oct 16, 2019

VSC-Service-Account commented Oct 16, 2019

msftclas commented Oct 16, 2019 • edited

VSC-Service-Account commented Oct 16, 2019

⚠️ Validation status: warnings

qmark commented Oct 16, 2019 • edited

Redth commented Oct 16, 2019

qmark commented Oct 16, 2019

VSC-Service-Account commented Oct 16, 2019

⚠️ Validation status: warnings

qmark commented Oct 16, 2019

Redth commented Oct 28, 2019

VSC-Service-Account commented Oct 29, 2019

✅ Validation status: passed

qmark commented Oct 29, 2019

Redth commented Oct 29, 2019

VSC-Service-Account commented Oct 29, 2019

✅ Validation status: passed

msftclas commented Oct 16, 2019 •

edited

qmark commented Oct 16, 2019 •

edited