[Firebase][Auth] Fixed SignInWithCredential parameter type

* This fixes #326
xamarin · Nov 12, 2019 · d2e55de · d2e55de
1 parent b809bf1
commit d2e55de
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/Readme.md b/Readme.md
@@ -9,7 +9,7 @@ Xamarin creates and maintains Xamarin.iOS bindings for the Google APIs for iOS L
 | [Xamarin.Firebase.iOS.ABTesting][F.ABTesting.Name]                           | [3.0.0.0][F.ABTesting.Package]               |
 | [Xamarin.Firebase.iOS.AdMob][F.AdMob.Name]                                   | [7.47.0.0][F.AdMob.Package]                  |
 | [Xamarin.Firebase.iOS.Analytics][F.Analytics.Name]                           | [6.0.4.0][F.Analytics.Package]               |
-| [Xamarin.Firebase.iOS.Auth][F.Auth.Name]                                     | [6.2.1.0][F.Auth.Package]                    |
+| [Xamarin.Firebase.iOS.Auth][F.Auth.Name]                                     | [6.2.1.1][F.Auth.Package]                    |
 | [Xamarin.Firebase.iOS.CloudFirestore][F.CloudFirestore.Name]                 | [1.4.2.0][F.CloudFirestore.Package]          |
 | [Xamarin.Firebase.iOS.CloudMessaging][F.CloudMessaging.Name]                 | [4.1.1.1][F.CloudMessaging.Package]          |
 | [Xamarin.Firebase.iOS.Core][F.Core.Name]                                     | [6.1.0.0][F.Core.Package]                    |
@@ -53,7 +53,7 @@ Here's a table that shows in which global version is located each component of F
 | Firebase A/B Testing             | **3.0.0.0**       | **6.5.0**      |
 | Firebase AdMob                   | **7.47.0.0**      | **6.5.0**      |
 | Firebase Analytics               | **6.0.4.0**       | **6.5.0**      |
-| Firebase Auth                    | **6.2.1.0**       | **6.5.0**      |
+| Firebase Auth                    | **6.2.1.1**       | **6.5.0**      |
 | Firebase Cloud Firestore         | **1.4.2.0**       | **6.5.0**      |
 | Firebase Cloud Messaging         | **4.1.1.0**       | **6.5.0**      |
 | Firebase Core                    | **6.1.0.0**       | **6.5.0**      |

diff --git a/components.cake b/components.cake
@@ -2,7 +2,7 @@
 Artifact FIREBASE_AB_TESTING_ARTIFACT              = new Artifact ("Firebase.ABTesting",              "3.0.0.0",  "8.0", ComponentGroup.Firebase, csprojName: "ABTesting");
 Artifact FIREBASE_AD_MOB_ARTIFACT                  = new Artifact ("Firebase.AdMob",                  "7.47.0",   "8.0", ComponentGroup.Firebase, csprojName: "AdMob");
 Artifact FIREBASE_ANALYTICS_ARTIFACT               = new Artifact ("Firebase.Analytics",              "6.0.4",    "8.0", ComponentGroup.Firebase, csprojName: "Analytics");
-Artifact FIREBASE_AUTH_ARTIFACT                    = new Artifact ("Firebase.Auth",                   "6.2.1",    "8.0", ComponentGroup.Firebase, csprojName: "Auth");
+Artifact FIREBASE_AUTH_ARTIFACT                    = new Artifact ("Firebase.Auth",                   "6.2.1.1",  "8.0", ComponentGroup.Firebase, csprojName: "Auth");
 Artifact FIREBASE_CLOUD_FIRESTORE_ARTIFACT         = new Artifact ("Firebase.CloudFirestore",         "1.4.2",    "8.0", ComponentGroup.Firebase, csprojName: "CloudFirestore");
 Artifact FIREBASE_CLOUD_MESSAGING_ARTIFACT         = new Artifact ("Firebase.CloudMessaging",         "4.1.1.1",  "8.0", ComponentGroup.Firebase, csprojName: "CloudMessaging");
 Artifact FIREBASE_CORE_ARTIFACT                    = new Artifact ("Firebase.Core",                   "6.1.0",    "8.0", ComponentGroup.Firebase, csprojName: "Core");

diff --git a/source/Firebase/Auth/ApiDefinition.cs b/source/Firebase/Auth/ApiDefinition.cs
@@ -240,10 +240,10 @@ interface Auth
 		[Export ("signInAndRetrieveDataWithCredential:completion:")]
 		void SignInAndRetrieveDataWithCredential (AuthCredential credential, [NullAllowed] AuthDataResultHandler completion);
 
-		// -(void)signInWithCredential:(FIRAuthCredential * _Nonnull)credential completion:(FIRAuthResultCallback _Nullable)completion;
+		// - (void) signInWithCredential:(FIRAuthCredential*) credential completion:(nullable FIRAuthDataResultCallback) completion;
 		[Async]
 		[Export ("signInWithCredential:completion:")]
-		void SignInWithCredential (AuthCredential credential, [NullAllowed] AuthResultHandler completion);
+		void SignInWithCredential (AuthCredential credential, [NullAllowed] AuthDataResultHandler completion);
 
 		// -(void)signInAnonymouslyWithCompletion:(FIRAuthResultCallback _Nullable)completion;
 		[Async]

diff --git a/source/Firebase/Auth/Auth.csproj b/source/Firebase/Auth/Auth.csproj
@@ -6,7 +6,7 @@
     <RootNamespace>Firebase.Auth</RootNamespace>
     <AssemblyName>Firebase.Auth</AssemblyName>
     <AssemblyVersion>1.0.0.0</AssemblyVersion>
-    <FileVersion>6.2.1</FileVersion>
+    <FileVersion>6.2.1.1</FileVersion>
     <IPhoneResourcePrefix>Resources</IPhoneResourcePrefix>
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
   </PropertyGroup>
@@ -23,7 +23,7 @@
     <PackageProjectUrl>https://go.microsoft.com/fwlink/?linkid=865530</PackageProjectUrl>
     <PackageLicenseUrl>https://go.microsoft.com/fwlink/?linkid=865534</PackageLicenseUrl>
     <PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>
-    <PackageVersion>6.2.1</PackageVersion>
+    <PackageVersion>6.2.1.1</PackageVersion>
   </PropertyGroup>
 
   <ItemGroup>