fix memory leak (and some crashes) in ItemsViewController (iOS)

xamarin · Jul 6, 2021 · 0d34dee · 0d34dee
1 parent 49a12b3
commit 0d34dee
Showing 1 changed file with 14 additions and 1 deletion.
diff --git a/Xamarin.Forms.Platform.iOS/CollectionView/ItemsViewController.cs b/Xamarin.Forms.Platform.iOS/CollectionView/ItemsViewController.cs
@@ -12,7 +12,20 @@ public abstract class ItemsViewController<TItemsView> : UICollectionViewControll
 	{
 		public const int EmptyTag = 333;
 
-		public IItemsViewSource ItemsSource { get; protected set; }
+
+		private IItemsViewSource _itemsSource;
+		public IItemsViewSource ItemsSource
+		{
+			get => _itemsSource;
+			protected set
+			{
+				if (_itemsSource != null && value != _itemsSource)
+				{
+					_itemsSource.Dispose();
+				}
+				_itemsSource = value;
+			}
+		}
 		public TItemsView ItemsView { get; }
 		protected ItemsViewLayout ItemsViewLayout { get; set; }
 		bool _initialized;