Throw exception when ViewCell View is null (#752)

xamarin · Mar 3, 2017 · 97b28b1 · 97b28b1
1 parent 81058db
commit 97b28b1
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/Xamarin.Forms.Platform.Android/Cells/ViewCellRenderer.cs b/Xamarin.Forms.Platform.Android/Cells/ViewCellRenderer.cs
@@ -2,6 +2,7 @@
 using Android.Views;
 using AView = Android.Views.View;
 using Xamarin.Forms.Internals;
+using System;
 
 namespace Xamarin.Forms.Platform.Android
 {
@@ -32,6 +33,9 @@ protected override AView GetCellCore(Cell item, AView convertView, ViewGroup par
 				rowHeight = ListView.RowHeightProperty;
 			}
 
+			if (cell.View == null)
+				throw new InvalidOperationException($"ViewCell must have a {nameof(cell.View)}");
+
 			IVisualElementRenderer view = Platform.CreateRenderer(cell.View);
 			Platform.SetRenderer(cell.View, view);
 			cell.View.IsPlatformEnabled = true;

diff --git a/Xamarin.Forms.Platform.iOS/Cells/ViewCellRenderer.cs b/Xamarin.Forms.Platform.iOS/Cells/ViewCellRenderer.cs
@@ -139,6 +139,9 @@ protected override void Dispose(bool disposing)
 
 			IVisualElementRenderer GetNewRenderer()
 			{
+				if (_viewCell.View == null)
+					throw new InvalidOperationException($"ViewCell must have a {nameof(_viewCell.View)}");
+
 				var newRenderer = Platform.CreateRenderer(_viewCell.View);
 				_rendererRef = new WeakReference<IVisualElementRenderer>(newRenderer);
 				ContentView.AddSubview(newRenderer.NativeView);