Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Bug] RefreshView not showing ActivityIndicator on page appearing with XF Shell #10377

Closed
scottrsimms73 opened this issue Apr 19, 2020 · 3 comments
Closed

[Bug] RefreshView not showing ActivityIndicator on page appearing with XF Shell #10377

scottrsimms73 opened this issue Apr 19, 2020 · 3 comments
Labels
a/refreshview 🔄 a/shell 🐚 e/2 🕑 2 p/iOS 🍎 t/bug 🐛
Projects
vNext+1 (5.0.0)
Milestone
5.0.0

Comments

@scottrsimms73
Copy link

scottrsimms73 commented Apr 19, 2020 •
edited
Loading

Description

RefreshView not showing ActivityIndicator on page appearing with Shell on iOS

Steps to Reproduce:

  1. Create a new XF Shell project in VS 2019
  2. Run in iOS Simulator
  3. Observe the Activity Indicator not showing on first appearance of "ItemsPage"

NB1: Add a Task Delay to "ExecuteLoadItemsCommand" to further highlight the issue
NB2: Appears to work if not using Shell

Expected Behavior
Activity Indicator should show during first page appearance refresh (see Android)

Actual Behavior
Activity Indicator not shown

Version
Xamarin Forms 4.5.0.617
iOS SDK 13.4
@scottrsimms73 scottrsimms73 added s/unverified New report that has yet to be verified t/bug 🐛 labels Apr 19, 2020
@pauldipietro pauldipietro added this to New in Triage Apr 19, 2020
@jsuarezruiz
Copy link
Contributor

@scottrsimms73 I have done some tests and can reproduce the issue using 4.5.617. However, the issue seems to be fixed in 4.6-pre4. Could you test this updated sample and verify it?
Issue10377.zip

@jsuarezruiz jsuarezruiz moved this from New to Needs Info in Triage Apr 20, 2020
@jsuarezruiz jsuarezruiz added the s/needs-info ❓ A question has been asked that requires an answer before work can continue on this issue. label Apr 20, 2020
@scottrsimms73
Copy link
Author

@jsuarezruiz The Activity Indicator is now showing using XF 4.6-pre4 but it does not 'spin'. Add some more delay to 'ExecuteLoadItemsCommand' to see this more clearly.

@samhouts samhouts removed the s/needs-info ❓ A question has been asked that requires an answer before work can continue on this issue. label Apr 21, 2020
@samhouts samhouts moved this from Needs Info to New in Triage Apr 21, 2020
@jsuarezruiz
Copy link
Contributor

Tested and you are right. Seems that only happens the first time on iOS.

@jsuarezruiz jsuarezruiz added e/2 🕑 2 and removed s/unverified New report that has yet to be verified labels Apr 22, 2020
@jsuarezruiz jsuarezruiz moved this from New to Ready For Work in Triage Apr 22, 2020
@samhouts samhouts added this to To do in iOS Ready For Work Apr 26, 2020
@samhouts samhouts removed this from Ready For Work in Triage Apr 26, 2020
@samhouts samhouts added this to Backlog in Shell May 5, 2020
@adamped adamped mentioned this issue Jul 7, 2020
Merged
2 tasks
@samhouts samhouts added this to the 5.0.0 milestone Aug 13, 2020
@samhouts samhouts added this to To do in vNext+1 (5.0.0) Aug 13, 2020
@samhouts samhouts moved this from To do to Done in vNext+1 (5.0.0) Aug 17, 2020
myroot pushed a commit to myroot/Xamarin.Forms that referenced this issue Aug 19, 2020
@adamped @myroot
[iOS] ActivityIndicator starting animation only when attached to supe…
fb0f13f 
…rview (xamarin#11339)

* Update ActivityIndicatorRenderer.cs

You can't start animating the ActivityIndicator if it's not attached to the Superview

* Update ActivityIndicatorRenderer.cs

Added CoreGraphics namespace

fixes xamarin#10377
fixes xamarin#1989
sung-su pushed a commit to sung-su/Xamarin.Forms that referenced this issue Aug 20, 2020
@adamped @sung-su
[iOS] ActivityIndicator starting animation only when attached to supe…
5fc07e0 
…rview (xamarin#11339)

* Update ActivityIndicatorRenderer.cs

You can't start animating the ActivityIndicator if it's not attached to the Superview

* Update ActivityIndicatorRenderer.cs

Added CoreGraphics namespace

fixes xamarin#10377
fixes xamarin#1989
sung-su pushed a commit to sung-su/Xamarin.Forms that referenced this issue Aug 20, 2020
@adamped @sung-su
[iOS] ActivityIndicator starting animation only when attached to supe…
7e978f9 
…rview (xamarin#11339)

* Update ActivityIndicatorRenderer.cs

You can't start animating the ActivityIndicator if it's not attached to the Superview

* Update ActivityIndicatorRenderer.cs

Added CoreGraphics namespace

fixes xamarin#10377
fixes xamarin#1989
iOS Ready For Work automation moved this from To do to Done Aug 21, 2020
Shell automation moved this from Backlog to Done Aug 21, 2020
@samhouts samhouts removed this from Done in iOS Ready For Work Nov 3, 2020
@samhouts samhouts removed this from Done in Shell Nov 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
a/refreshview 🔄 a/shell 🐚 e/2 🕑 2 p/iOS 🍎 t/bug 🐛
Projects
No open projects
vNext+1 (5.0.0)
Done
Milestone
5.0.0
Development

No branches or pull requests
3 participants
@jsuarezruiz @samhouts @scottrsimms73