Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Bug] SwipeView Open methods does not work for RightItems #10563

Closed
mtopolewski opened this issue May 4, 2020 · 7 comments · Fixed by #10575
Closed

[Bug] SwipeView Open methods does not work for RightItems #10563

mtopolewski opened this issue May 4, 2020 · 7 comments · Fixed by #10575
Assignees
@jsuarezruiz
Labels
a/swipeview blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. e/2 🕑 2 in-progress This issue has an associated pull request that may resolve it! t/bug 🐛
Projects
SwipeView vNext+1 (5.0.0)
Milestone
5.0.0

Comments

@mtopolewski
Copy link

Open method for SwipeView doesn't work for RightItems, it works for left items but not for right. Tested on Android and iOS.

Steps to Reproduce

  1. Add SwipeView to ViewPage
  2. Add RightItems to that SwipeView
  3. Invoke Open(OpenSwipeItem.RightItems) method on that SwipeView

Expected Behavior

Open method should open view and reveal right items.

Actual Behavior

Open method does nothing

Basic Information

  • Xamarin Forms: 4.6.0.726
  • IDE: Visual Studio for Mac, ver 8.5.4 (build 12)
  • Xcode ver 11.4.1

Reproduction Link

https://github.com/mariaszek9003/SwipeViewTest
or you can either test it on your own SwipeView demo repository, just use right items instead of left on SwipeViewProgrammaticPage: https://github.com/xamarin/xamarin-forms-samples/tree/master/UserInterface/SwipeViewDemos
@mtopolewski mtopolewski added s/unverified New report that has yet to be verified t/bug 🐛 labels May 4, 2020
@pauldipietro pauldipietro added this to New in Triage May 4, 2020
@jsuarezruiz jsuarezruiz self-assigned this May 4, 2020
@jsuarezruiz jsuarezruiz added this to Backlog in SwipeView via automation May 4, 2020
@jsuarezruiz jsuarezruiz added a/swipeview e/2 🕑 2 and removed s/unverified New report that has yet to be verified labels May 4, 2020
@jsuarezruiz jsuarezruiz mentioned this issue May 5, 2020
Merged
2 tasks
@jsuarezruiz
Copy link
Contributor

Thanks for the reproduction sample @mariaszek9003.

@samhouts samhouts moved this from New to Ready For Work in Triage May 5, 2020
@samhouts samhouts removed this from Ready For Work in Triage May 11, 2020
@jsuarezruiz jsuarezruiz moved this from Backlog to In Progress in SwipeView May 11, 2020
@samhouts samhouts added the in-progress This issue has an associated pull request that may resolve it! label May 28, 2020
@haavamoa
Copy link

I tested the same but with TopItems and that did not work either. :(

@samhouts samhouts added this to In Progress in 4.7.0 Jun 20, 2020
@samhouts samhouts removed this from In Progress in 4.7.0 Jul 8, 2020
@samhouts samhouts added this to In Progress in vCurrent (4.8.0) Jul 30, 2020
@samhouts samhouts added this to In Progress in .NET MAUI Backlog Jul 30, 2020
@samhouts samhouts removed this from In Progress in vCurrent (4.8.0) Jul 30, 2020
@samhouts samhouts added this to the 5.0.0 milestone Aug 4, 2020
@samhouts samhouts removed this from In Progress in .NET MAUI Backlog Aug 4, 2020
@samhouts samhouts added this to In Progress in vNext+1 (5.0.0) Aug 11, 2020
@WilliamWatterson86
Copy link

WilliamWatterson86 commented Sep 4, 2020 •
edited
Loading

Have the same issue here - as a work around I rotated my swipeview by 180. And then rotated the contents of it by another 180. Seems to work OK for now but not ideal.

@elielson-anjos
Copy link

SwipeView.Open() is not working at all.

@jsuarezruiz
Copy link
Contributor

@WilliamWatterson86 and @Rothanan Could you try using the NuGet from #10575?

@elielson-anjos
Copy link

elielson-anjos commented Oct 28, 2020 •
edited
Loading

Im Sorry, I tought this was an UWP Topic, I'm having trouble with this in UWP.

The solution you mentioned doesnt fix It for UWP.

@Only-Xam
Copy link

Only-Xam commented Nov 1, 2020

[UWP] SwipeView.Open() is still not working with latest available version Xamarin.Forms.5.0.0.1558-pre3

@PureWeen PureWeen added the blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. label Nov 2, 2020
SwipeView automation moved this from In Progress to Done Dec 18, 2020
vNext+1 (5.0.0) automation moved this from In Progress to Done Dec 18, 2020
rmarinho added a commit that referenced this issue Dec 18, 2020
@jsuarezruiz @rmarinho
[Android/iOS] Fix programmatically open right SwipeItems (#10575) fixes
50e6fbb 
#10563

* Fixed programmatically open SwipeView issue
Added animated parameter to open and close the SwipeView

* Renamed request open and close SwipeView EventArgs

* Added UITest

* Fixed build issue on iOS

* Removed SwipeView Experimental flag

* Renamed open and close SwipeView EventArgs to CloseRequestedEventArgs and OpenRequestedEventArgs

* No block the open behavior if it's already open in a different direction

* Avoid try to open an opened SwipeItem

* Updated test

* More changes to the test

* Changed UITest

* Fixed UITest

Co-authored-by: Rui Marinho <me@ruimarinho.net>
@Only-Xam Only-Xam mentioned this issue Jan 9, 2021
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jsuarezruiz jsuarezruiz

Labels
a/swipeview blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. e/2 🕑 2 in-progress This issue has an associated pull request that may resolve it! t/bug 🐛
Projects
SwipeView
  
Done
vNext+1 (5.0.0)
Done
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

[Android/iOS] Fix programmatically open right SwipeItems xamarin/Xamarin.Forms
8 participants
@haavamoa @PureWeen @jsuarezruiz @samhouts @mtopolewski @WilliamWatterson86 @elielson-anjos @Only-Xam