Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Bug] [iOS] CollectionView with MeasureAllItems broken Animations & Scroll #10625

Closed
dmariogatto opened this issue May 9, 2020 · 1 comment · Fixed by #12919
Closed

[Bug] [iOS] CollectionView with MeasureAllItems broken Animations & Scroll #10625

dmariogatto opened this issue May 9, 2020 · 1 comment · Fixed by #12919
Labels
a/animation 🎬 Animation stuff a/collectionview e/5 🕔 5 p/iOS 🍎 t/bug 🐛
Projects
CollectionView vNext+1 (5.0.0)
Milestone
5.0.0

Comments

@dmariogatto
Copy link
Contributor

Description

Adding items to a CollectionView with MeasureAllItems results in corrupted animations. NB: This also breaks Collection.ScrollTo() and ItemsUpdatingScrollMode="KeepLastItemInView".

Possibly Related:
#5455
#7788

Steps to Reproduce

  1. Set the CollectionView's ItemSizingStrategy to MeasureAllItems
  2. Dyamically add items in the CollectionView's ItemsSource

Expected Behavior

Adding items shouldn't cause the items to jump around.

Actual Behavior

Corrupted animations.

Basic Information

  • Version with issue: 4.6.0.726 & 4.7.0.760-nightly
  • Last known good version: N/A
  • IDE: Visual Studio 16.5.4
  • Platform Target Frameworks:
    • iOS: 13.4

Doesn't occur on Android.

Screenshots

ezgif-3-79a6a6c25c36

Reproduction Link

https://github.com/dmariogatto/xf4-collecview-measureall
@dmariogatto dmariogatto added s/unverified New report that has yet to be verified t/bug 🐛 labels May 9, 2020
@pauldipietro pauldipietro added this to New in Triage May 9, 2020
@jsuarezruiz jsuarezruiz added this to Backlog in CollectionView via automation May 11, 2020
@rmarinho rmarinho removed the s/unverified New report that has yet to be verified label May 19, 2020
@rmarinho rmarinho moved this from New to Needs Estimate in Triage May 19, 2020
@BrayanKhosravian BrayanKhosravian mentioned this issue May 25, 2020
Closed
@samhouts samhouts added a/animation 🎬 Animation stuff e/5 🕔 5 labels May 26, 2020
@samhouts samhouts moved this from Needs Estimate to Ready For Work in Triage May 26, 2020
@samhouts samhouts removed this from Ready For Work in Triage May 28, 2020
@yurii-harkusha yurii-harkusha mentioned this issue Jun 11, 2020
Open
@samhouts samhouts added this to the 5.0.0 milestone Aug 13, 2020
@samhouts samhouts added this to To do in vNext+1 (5.0.0) Aug 13, 2020
@samhouts samhouts removed this from the 5.0.0 milestone Nov 2, 2020
@dmariogatto
Copy link
Contributor Author

Update, still an issue in the latest Xamarin Forms version (4.8.0.1687).

@hartez hartez mentioned this issue Nov 19, 2020
Merged
2 tasks
@rmarinho rmarinho added this to To do in v5.0.1 via automation Nov 24, 2020
@rmarinho rmarinho added this to the 5.0.1 milestone Nov 24, 2020
@rmarinho rmarinho added this to To do in vNext+1 (5.0.0) via automation Nov 24, 2020
@rmarinho rmarinho removed this from To do in v5.0.1 Nov 24, 2020
@rmarinho rmarinho modified the milestones: 5.0.1, 5.0.0 Nov 24, 2020
@rmarinho rmarinho moved this from To do to In Progress in vNext+1 (5.0.0) Nov 24, 2020
@rmarinho rmarinho moved this from Backlog to In Progress in CollectionView Nov 24, 2020
CollectionView automation moved this from In Progress to Done Dec 29, 2020
vNext+1 (5.0.0) automation moved this from In Progress to Done Dec 29, 2020
rmarinho pushed a commit that referenced this issue Dec 29, 2020
@hartez
Cache cell sizes after resize from estimates (#12919) fixes #10842 fixes
5db7f40 
 #10625

* Cache template sizes for use as estimated item sizes; fixes #10842

* Restore test items

* Add clarifying comments

* Cache cell measurements

* Correct caching index for Carousel

* Fix caching exception during item removal;
Fix empty view switching overlap;

* Update size when reusing Forms element on dequeued cell
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
a/animation 🎬 Animation stuff a/collectionview e/5 🕔 5 p/iOS 🍎 t/bug 🐛
Projects
CollectionView
  
Done
vNext+1 (5.0.0)
Done
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Cache cell sizes after resize from estimates xamarin/Xamarin.Forms
4 participants
@rmarinho @jsuarezruiz @samhouts @dmariogatto