This repository has been archived by the owner on May 1, 2024. It is now read-only.
[Android] Update CurrentItem when swiping #10850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmarinho
changed the title
samhouts
added
the
blocker
|
Tested on Android and iOS:
Is working as expected. |
|
Failing tests not related |
jsuarezruiz
approved these changes
May 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
A couple of fixes, getting the real centered item. If we were using the PeakAreaInsets there were some times that center item wasn't found since it was using just 1 centered coordiante, it should use both, x and y for CarouselView.
Fix state that was blocking update CurrentItem when swiping. Fix introduced in 4.6.0 to fix scrolling to the item when added was blocking the current item to be update when swiping.
Contains also fix #10838
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
Go to test case 9827, swipe to next item, check the SearchBar text is updated to "Item1 with some additional text"
PR Checklist