Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Bug] CarouselView should not animate an initial Position on Android #11081

Closed
BioTurboNick opened this issue Jun 17, 2020 · 1 comment · Fixed by #11173
Closed

[Bug] CarouselView should not animate an initial Position on Android #11081

BioTurboNick opened this issue Jun 17, 2020 · 1 comment · Fixed by #11173
Assignees
@jsuarezruiz
Labels
a/carouselview e/2 🕑 2 in-progress This issue has an associated pull request that may resolve it! t/bug 🐛
Projects
vNext+1 (5.0.0)
Milestone
5.0.0

Comments

@BioTurboNick
Copy link

Description

On Android, setting Position of a CarouselView in XAML, or in a page constructor in C#, causes it to be animated to that position. This does not occur on iOS.

If I'm reading the code correctly, line 305 in UpdateInitialPosition() in the Android CarouselViewRenderer.cs [Android] should change from

Carousel.ScrollTo(_oldPosition, position: Xamarin.Forms.ScrollToPosition.Center, animate: Carousel.AnimatePositionChanges)

Carousel.ScrollTo(_oldPosition, position: Xamarin.Forms.ScrollToPosition.Center, animate: false)

Expected Behavior

CarouselView should be initialized to show the assigned position without animation.

Actual Behavior

CarouselView cycles through all prior positions before reaching the initial position.

Basic Information

  • Version with issue: 4.6.0.967
  • Last known good version: n/a
  • IDE: VS 2019 16.6.2
  • Platform Target Frameworks:
    • iOS: 13.0
    • Android: 9.0, 10.0
  • Affected Devices: Android

Reproduction Link

CarouselBug.zip

Workaround

None
@BioTurboNick BioTurboNick added s/unverified New report that has yet to be verified t/bug 🐛 labels Jun 17, 2020
@pauldipietro pauldipietro added this to New in Triage Jun 17, 2020
@jsuarezruiz jsuarezruiz mentioned this issue Jun 23, 2020
Merged
2 tasks
@samhouts samhouts added the in-progress This issue has an associated pull request that may resolve it! label Jun 23, 2020
@samhouts samhouts added this to In Progress in 4.7.0 Jun 23, 2020
@jsuarezruiz jsuarezruiz self-assigned this Jun 26, 2020
@jsuarezruiz jsuarezruiz added e/2 🕑 2 and removed s/unverified New report that has yet to be verified labels Jun 26, 2020
@jsuarezruiz jsuarezruiz moved this from New to Ready For Work in Triage Jun 26, 2020
@samhouts samhouts added this to To do in Other Ready For Work Jun 26, 2020
@samhouts samhouts removed this from Ready For Work in Triage Jun 26, 2020
@samhouts samhouts moved this from To do to In progress in Other Ready For Work Jun 26, 2020
@smalgin
Copy link

smalgin commented Jul 4, 2020

Confirmed - still exists with latest stable. Will await resolution :)

@samhouts samhouts removed this from In Progress in 4.7.0 Jul 8, 2020
@samhouts samhouts added this to Backlog in CarouselView Jul 13, 2020
@samhouts samhouts moved this from Backlog to In Progress in CarouselView Jul 13, 2020
@samhouts samhouts added this to In Progress in vCurrent (4.8.0) Jul 30, 2020
@samhouts samhouts added this to In Progress in .NET MAUI Backlog Jul 30, 2020
@samhouts samhouts removed this from In Progress in vCurrent (4.8.0) Jul 30, 2020
@samhouts samhouts removed this from In Progress in .NET MAUI Backlog Aug 4, 2020
@samhouts samhouts added this to In Progress in vNext+1 (5.0.0) Aug 11, 2020
@samhouts samhouts added this to the 5.0.0 milestone Aug 13, 2020
Other Ready For Work automation moved this from In progress to Done Sep 17, 2020
CarouselView automation moved this from In Progress to Done Sep 17, 2020
rmarinho pushed a commit that referenced this issue Sep 17, 2020
@jsuarezruiz
Disable animation scrolling to initial position in CarouselView (#11173…
8a13756 
…) fixes #11081
vNext+1 (5.0.0) automation moved this from In Progress to Done Sep 17, 2020
@samhouts samhouts removed this from Done in Other Ready For Work Nov 3, 2020
@samhouts samhouts removed this from Done in CarouselView Nov 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jsuarezruiz jsuarezruiz

Labels
a/carouselview e/2 🕑 2 in-progress This issue has an associated pull request that may resolve it! t/bug 🐛
Projects
No open projects
vNext+1 (5.0.0)
Done
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Disable animation scrolling to initial position in CarouselView xamarin/Xamarin.Forms
4 participants
@BioTurboNick @jsuarezruiz @samhouts @smalgin