Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Bug] [iOS][SwipeView] If Swipe view is disabled, tap gesture events are not firing #11968

Closed
janithacw opened this issue Aug 31, 2020 · 1 comment · Fixed by #12942
Closed

[Bug] [iOS][SwipeView] If Swipe view is disabled, tap gesture events are not firing #11968

janithacw opened this issue Aug 31, 2020 · 1 comment · Fixed by #12942
Labels
a/gestures 🖖 a/swipeview e/5 🕔 5 in-progress This issue has an associated pull request that may resolve it! p/iOS 🍎 t/bug 🐛
Projects
SwipeView iOS Ready For Work

Comments

@janithacw
Copy link

Description

On iOS, we are using the Swipe view for a Data Template in a Collection view. But If we disabled the swipe view for a line item, tap gesture also will not get fired for the line item. This is working fine on Android.

Steps to Reproduce

  1. Place a Swipe view in a collection view
  2. Add a swipe item
  3. Add a view to the content of the Swipe view
  4. Add a Tap Gesture recognizer to the Content
  5. Tap on line item

Expected Behavior

The Tap gesture Tapped event or command should fire

Actual Behavior

The tapped gesture event or command doesn't fire if you disabled the swipe view.

Basic Information

  • Version with issue:
  • Last known good version:
  • IDE: VS for Mac
  • Platform Target Frameworks:
    • iOS: iOS: 13.4
    • Android:
    • UWP:
  • Android Support Library Version:
  • Nuget Packages: Xamarin.Forms 4.7.0.968
  • Affected Devices: iPhones

Screenshots

swipeviewdemo

Reproduction Link

Sample Project

Workaround

No
@janithacw janithacw added s/unverified New report that has yet to be verified t/bug 🐛 labels Aug 31, 2020
@samhouts samhouts added this to New in Triage Aug 31, 2020
@jsuarezruiz jsuarezruiz added this to Backlog in SwipeView via automation Aug 31, 2020
@jsuarezruiz jsuarezruiz mentioned this issue Sep 4, 2020
Closed
@hartez hartez added e/5 🕔 5 and removed s/unverified New report that has yet to be verified labels Sep 5, 2020
@hartez hartez removed this from New in Triage Sep 5, 2020
@hartez hartez added this to To do in iOS Ready For Work via automation Sep 5, 2020
@samhouts samhouts added this to the 5.0.0 milestone Sep 8, 2020
@samhouts samhouts added this to To do in vNext+1 (5.0.0) Sep 8, 2020
@cblanchard519
Copy link

Hey guys just wanted to let everyone know I found a workaround for this issue, you can add an event on SwipeStarted on the SwipeView and close the SwipeView if you don't want the user to have access to swipe functionality, this still leaves the tap event working.

@samhouts samhouts removed this from the 5.0.0 milestone Nov 2, 2020
@jsuarezruiz jsuarezruiz mentioned this issue Nov 23, 2020
Merged
2 tasks
@jsuarezruiz jsuarezruiz added the in-progress This issue has an associated pull request that may resolve it! label Nov 23, 2020
@jsuarezruiz jsuarezruiz moved this from To do to In progress in iOS Ready For Work Nov 23, 2020
iOS Ready For Work automation moved this from In progress to Done Dec 18, 2020
SwipeView automation moved this from Backlog to Done Dec 18, 2020
rmarinho added a commit that referenced this issue Dec 18, 2020
@jsuarezruiz @rmarinho
[iOS] If SwipeView is disabled, tap gesture events are not firing (#1…
2774990 
…2942) fixes #11969 fixes #11968

* Added repro sample

* Fix the issue

* Added UITest

Co-authored-by: Rui Marinho <me@ruimarinho.net>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
a/gestures 🖖 a/swipeview e/5 🕔 5 in-progress This issue has an associated pull request that may resolve it! p/iOS 🍎 t/bug 🐛
Projects
SwipeView
  
Done
iOS Ready For Work
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[iOS] If SwipeView is disabled, tap gesture events are not firing xamarin/Xamarin.Forms
5 participants
@hartez @jsuarezruiz @samhouts @cblanchard519 @janithacw