-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[Bug] TabBarIsVisible = True/False doesn't work on Back navigation #12126
Comments
Can confirm this issue persists in 4.8.0.1451 |
🤔It seems SharedTransitionShell was the mistake. I replace it by Shell , and TabBar show and hide correctly . @josephlbailey did you use SharedTransition too ? |
@jm-parent I believe mine is related to #8969 or #12144 as it is an issue only on iOS. |
Hmm so this is an odd one :-/ Similar issue here For some reason these exports are no longer executing....
It's annoying because they execute fine when I'm building against source but not from the nuget package... Haven't traced back to why those have stopped executing yet |
I've only seen one repro so far so that's what I've been able to fix :-) I'm hoping that's everyones issue. There's a nuget here If you can all test that nuget and let me know if that resolves the issue for you that would be great!!! If it doesn't can you try to include a repro? |
@PureWeen So I tested the new nuget with no luck. So here's a repro using the standard boilerplate project that is created when doing a new Shell app: I used the LoginPage as my third level of navigation to illustrate that when using |
Thank you @josephlbailey !! That helped me locate what looks to be the most problematic part of code. New set of nugets here brewing Let me know if that works for you |
@PureWeen Worked like a charm! Well done! |
Description
I have an App with Shell Navigation.
Page A is the "Tab".
I navigate to Page B with await Shell.Current.GoToAsync(RouteNames.WorkOrderDetailPage);
This page have Shell.TabBarIsVisible="False"
TabBar is hiding. 💪
When a tap "back" , Page A doesn't show Bottom Tabs 😦 Even if i foce Shell.TabBarIsVisible="True" on this ContentPage.
Steps to Reproduce
Page A ( a Tab ) with TabbarVisible = true // Tab is => Visible ✅
Nav to Page B with TabbarVisible = false // Tab is => Hide ✅
And now 2 things , if you :
Nav Back to Page A TabbarVisible = true // Tab is => Still hide 🚫
or
Nav to Page C : TabbarVisible = true // Tab is => Visible ✅ but 🤔
Expected Behavior
TabBar is visible when TabBarIsVisible = True 👍
Actual Behavior
TabBar is not visible even if TabBarIsVisible = True 🙅
Basic Information
I'm currently using XF 4.8.0.1364.
Screenshots
Page A : Tab with TabbarVisible = true
Page C : Common ContentPage with TabbarVisible = false
Page A : Common ContentPage Tab with TabbarVisible = true
https://streamable.com/0nkdb5
In this video you can see :
Page A => Page B => Page C => Page B => Page A
Tab : visible => not visible => visible ✅ => visible 🙅 => visible ✅
Page A => Page B => Page A
Tab : visible => not visible => not visible 🙅
The text was updated successfully, but these errors were encountered: