Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Bug] XF 4.8 breaks custom renderer (Button) background color on iOS #12372

Closed
jimiatnymbl opened this issue Oct 6, 2020 · 0 comments · Fixed by #12395
Closed

[Bug] XF 4.8 breaks custom renderer (Button) background color on iOS #12372

jimiatnymbl opened this issue Oct 6, 2020 · 0 comments · Fixed by #12395
Assignees
@jsuarezruiz
Labels
a/customrenderer blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. e/2 🕑 2 i/regression in-progress This issue has an associated pull request that may resolve it! p/iOS 🍎 t/bug 🐛
Projects
vNext+1 (5.0.0) iOS Ready For Work
Milestone
5.0.0

Comments

@jimiatnymbl
Copy link

Description

After upgrading to XF 4.8 our custom button renderer does not have a background / color until the user presses the button and then the background is shown. This custom renderer has worked until XF 4.8. Downgrading to XF 4.7 and the button color works again.

Steps to Reproduce

  1. Download repo.
  2. Run on iOS and notice the "Testing" button has no background.
  3. Press the "Testing" button and see the blue background appear (and work from there on out).
  4. Downgrade to XF 4.7 and notice the "Testing" button has a blue background on startup (no press needed).

Expected Behavior

Control.BackgroundColor should work after it is set.

Actual Behavior

Control.BackgroundColor is not set on the UI until the button is interacted with.

Basic Information

  • Version with issue: XF 4.8
  • Last known good version: XF 4.7
  • IDE: Visual Studio 2019
  • Platform Target Frameworks:
    • iOS: Fails on iOS 12 and iOS 14
    • Android: Works on Android
    • UWP: N/A

Screenshots

image

Reproduction Link

https://github.com/jimiatnymbl/CustomButtonIOS
@jimiatnymbl jimiatnymbl added s/unverified New report that has yet to be verified t/bug 🐛 labels Oct 6, 2020
@samhouts samhouts added this to New in Triage Oct 6, 2020
@jsuarezruiz jsuarezruiz added a/customrenderer p/iOS 🍎 e/2 🕑 2 and removed s/unverified New report that has yet to be verified labels Oct 6, 2020
@jsuarezruiz jsuarezruiz moved this from New to Resource Blocked in Triage Oct 7, 2020
@jsuarezruiz jsuarezruiz moved this from Resource Blocked to Ready For Work in Triage Oct 7, 2020
@jsuarezruiz jsuarezruiz self-assigned this Oct 7, 2020
@jsuarezruiz jsuarezruiz mentioned this issue Oct 7, 2020
Merged
2 tasks
@samhouts samhouts added the in-progress This issue has an associated pull request that may resolve it! label Nov 2, 2020
@samhouts samhouts added this to In Progress in vNext+1 (5.0.0) Nov 2, 2020
@samhouts samhouts added this to To do in iOS Ready For Work Nov 3, 2020
@samhouts samhouts removed this from Ready For Work in Triage Nov 3, 2020
@samhouts samhouts moved this from To do to In progress in iOS Ready For Work Nov 3, 2020
@PureWeen PureWeen added this to the 5.0.0 milestone Nov 5, 2020
@PureWeen PureWeen added the blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. label Nov 5, 2020
iOS Ready For Work automation moved this from In progress to Done Dec 15, 2020
vNext+1 (5.0.0) automation moved this from In Progress to Done Dec 15, 2020
rmarinho pushed a commit that referenced this issue Dec 15, 2020
@jsuarezruiz @PureWeen
[iOS] Fix Background issue in Button CustomRenderer (#12395) fixes #1…
8b10f11 
…2372

* Added repro sample

* Updated the sample

* Fix the issue

* Improved the fix with another approach

Co-authored-by: Shane Neuville <shneuvil@microsoft.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jsuarezruiz jsuarezruiz

Labels
a/customrenderer blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. e/2 🕑 2 i/regression in-progress This issue has an associated pull request that may resolve it! p/iOS 🍎 t/bug 🐛
Projects
iOS Ready For Work
  
Done
vNext+1 (5.0.0)
Done
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

[iOS] Fix Background issue in Button CustomRenderer xamarin/Xamarin.Forms
4 participants
@PureWeen @jsuarezruiz @samhouts @jimiatnymbl