Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Bug] Android: Entry Clear button becomes invisible when changing Entry.BackgroundColor to dark color #12380

Closed
InquisitorJax opened this issue Oct 6, 2020 · 0 comments · Fixed by #12391
Assignees
Labels
a/entry e/2 🕑 2 in-progress This issue has an associated pull request that may resolve it! p/Android t/bug 🐛

Comments

@InquisitorJax
Copy link

InquisitorJax commented Oct 6, 2020

Description

If the background property of an entry is updated to be a dark color, then the clear button isn't visible.
Clear button color should always match the TextColor property (or at least offer dark/light setting). This is needed for theme support.

Steps to Reproduce

  1. Add an entry, and set the BackgroundColor to Black, and TextColor to white, and ClearButtonVisibility to WhileEditing
  2. Start typing in the entry
  3. The clear button isn't visible, because the color of the clear icon is also black.

Expected Behavior

Clear button icon color should match the TextColor property

Actual Behavior

Clear button icon is always black - which makes it invisible when making entry BackgroundColor = Black

Screenshots

image

@InquisitorJax InquisitorJax added s/unverified New report that has yet to be verified t/bug 🐛 labels Oct 6, 2020
@samhouts samhouts added this to New in Triage Oct 6, 2020
@jsuarezruiz jsuarezruiz added a/entry p/Android e/2 🕑 2 and removed s/unverified New report that has yet to be verified labels Oct 6, 2020
@jsuarezruiz jsuarezruiz moved this from New to Ready For Work in Triage Oct 7, 2020
@jsuarezruiz jsuarezruiz self-assigned this Oct 7, 2020
@samhouts samhouts added the in-progress This issue has an associated pull request that may resolve it! label Nov 2, 2020
@samhouts samhouts added this to In Progress in vNext+1 (5.0.0) Nov 2, 2020
@samhouts samhouts removed this from Ready For Work in Triage Nov 3, 2020
@samhouts samhouts moved this from To do to In progress in Android Ready For Work Nov 3, 2020
@PureWeen PureWeen added this to To do in v5.0.1 via automation Nov 5, 2020
@PureWeen PureWeen removed this from In Progress in vNext+1 (5.0.0) Nov 5, 2020
@samhouts samhouts added this to In Progress in vNext+1 (5.0.0) Nov 5, 2020
@samhouts samhouts removed this from To do in v5.0.1 Nov 5, 2020
@PureWeen PureWeen added this to To do in v5.0.1 via automation Nov 5, 2020
@PureWeen PureWeen removed this from In Progress in vNext+1 (5.0.0) Nov 5, 2020
Android Ready For Work automation moved this from In progress to Done Jul 6, 2021
v5.0.1 automation moved this from To do to Done Jul 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a/entry e/2 🕑 2 in-progress This issue has an associated pull request that may resolve it! p/Android t/bug 🐛
Projects
Development

Successfully merging a pull request may close this issue.

3 participants