This repository has been archived by the owner on May 1, 2024. It is now read-only.
[Android] Entry Clear button invisible if BackgroundColor is a dark color #12391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have the same problem on iOS, added changes to tint the clear image icon. |
|
@jsuarezruiz what do you think about change the underline entry color too? |
Transis-Felipe
approved these changes
Dec 22, 2020
|
We have been suffering from this bug for a while. Greatly looking forward to it in the next Xamarin.Forms release! |
|
@jsuarezruiz is there something blocking this guy from getting merged? |
2 tasks
mattleibow
approved these changes
Jul 6, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
If the background property of an entry is updated to be a dark color, then the clear button isn't visible.
This PR include changes to set the ClearButton color using the TextColor property.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Testing Procedure
Launch Core Gallery and navigate to the issue 12380. If the ClearButton is visible in all cases, the test has passed.
PR Checklist