Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Grid layout broken when updating to latest xamarin forms #13127

Closed
gabsterdev1 opened this issue Dec 13, 2020 · 1 comment · Fixed by #13146
Closed

Grid layout broken when updating to latest xamarin forms #13127

gabsterdev1 opened this issue Dec 13, 2020 · 1 comment · Fixed by #13146
Assignees
@hartez
Labels
4.8.0 regression on 4.8.0 a/grid a/layout blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. i/high Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often in-progress This issue has an associated pull request that may resolve it! t/bug 🐛
Projects
Other Ready For Work

Comments

@gabsterdev1
Copy link

gabsterdev1 commented Dec 13, 2020 •
edited

Description

We have quite a few forms where we do some overlapping to achieve the look as in the pic below. We noticed that any version of Xamarin forms above 4.8.0.1560 will break the layout , this includes the latest xamarin forms 5.0.0.1791-pre5

Steps to Reproduce

  1. I have attached a sample repo
  2. Is set to xamarin forms 4.8.0.1560
  3. Build and run and you will see

image

  1. Update to 5.0.0.1791-pre5 and the layout is now broken.

This prevents us to upgrade to the latest xamarin forms and we are keen to move to 5 when released.

Many thanks for your prompt feedback

SampleRepo.zip
@gabsterdev1 gabsterdev1 added s/unverified New report that has yet to be verified t/bug 🐛 labels Dec 13, 2020
@samhouts samhouts added this to New in Triage Dec 13, 2020
@jsuarezruiz jsuarezruiz added a/grid a/layout i/high Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often labels Dec 14, 2020
@rmarinho rmarinho moved this from New to Ready For Work in Triage Dec 14, 2020
@rmarinho rmarinho added 4.8.0 regression on 4.8.0 blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. and removed s/unverified New report that has yet to be verified labels Dec 14, 2020
hartez added a commit that referenced this issue Dec 15, 2020
@hartez
Scale potential star row/column values by the appropriate star value
7d43b2c 
Along with 13085, this fixes #13127
@hartez hartez mentioned this issue Dec 15, 2020
Merged
2 tasks
@hartez hartez added this to To do in Other Ready For Work via automation Dec 15, 2020
@hartez hartez removed this from Ready For Work in Triage Dec 15, 2020
@hartez hartez moved this from To do to In progress in Other Ready For Work Dec 15, 2020
@hartez hartez added the in-progress This issue has an associated pull request that may resolve it! label Dec 15, 2020
@hartez hartez linked a pull request Dec 15, 2020 that will close this issue
Scale potential star row/column values by the appropriate star value #13146
Merged
2 tasks
@hartez hartez closed this as completed in 43d5751 Dec 17, 2020
Other Ready For Work automation moved this from In progress to Done Dec 17, 2020
@bPoller2810
Copy link

Sadly this problem seems in a few cases still persists up to 5.0.0.2244. I cant repo this in a empty project right now, but got it in 2 Production apps happening.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hartez hartez

Labels
4.8.0 regression on 4.8.0 a/grid a/layout blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. i/high Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often in-progress This issue has an associated pull request that may resolve it! t/bug 🐛
Projects
Other Ready For Work
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Scale potential star row/column values by the appropriate star value xamarin/Xamarin.Forms
5 participants
@hartez @rmarinho @jsuarezruiz @bPoller2810 @gabsterdev1