Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Bug] DatePicker style in Xamarin.Forms 5.0 #13331

Closed
ColeXm opened this issue Jan 8, 2021 · 2 comments · Fixed by #13344
Closed

[Bug] DatePicker style in Xamarin.Forms 5.0 #13331

ColeXm opened this issue Jan 8, 2021 · 2 comments · Fixed by #13344
Labels
a/datepicker i/high Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often p/iOS 🍎 t/bug 🐛
Projects
iOS Ready For Work vNext+1 (5.0.0)
Milestone
5.0.0

Comments

@ColeXm
Copy link

ColeXm commented Jan 8, 2021

Description

The style of DatePicker looks strange after upgrading XF to 5.x , I have to click the inner text to show the datepicker panel , is this a bug or by design ?
I tried to use custom renderer(DatePickerRenderer) to revert the style as wheel like before , but it seems hard to implement it .

Steps to Reproduce

111221
@ColeXm ColeXm added s/unverified New report that has yet to be verified t/bug 🐛 labels Jan 8, 2021
@samhouts samhouts added this to New in Triage Jan 8, 2021
@hartez
Copy link
Contributor

hartez commented Jan 8, 2021

Nope, that's a bug. It should be displaying the wheels version.

@hartez hartez added a/datepicker p/iOS 🍎 i/high Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often and removed s/unverified New report that has yet to be verified labels Jan 8, 2021
@hartez hartez added this to To do in iOS Ready For Work via automation Jan 8, 2021
@hartez hartez removed this from New in Triage Jan 8, 2021
@hartez
Copy link
Contributor

hartez commented Jan 8, 2021

TimePicker will also have this problem.

@hartez hartez added this to the 5.0.0 milestone Jan 8, 2021
@hartez hartez added this to To do in vNext+1 (5.0.0) via automation Jan 8, 2021
hartez added a commit that referenced this issue Jan 8, 2021
@hartez
Restore wheels date/time picker styles in 5.0; fixes #13331
442fdcc
@hartez hartez mentioned this issue Jan 8, 2021
Merged
2 tasks
iOS Ready For Work automation moved this from To do to Done Jan 10, 2021
vNext+1 (5.0.0) automation moved this from To do to Done Jan 10, 2021
rmarinho pushed a commit that referenced this issue Jan 10, 2021
@hartez
[iOS] Restore wheels date/time picker styles in 5.0 (#13344) fixes #1…
788bf84 
…3331

* Restore wheels date/time picker styles in 5.0; fixes #13331

* Ignore date/time picker wheel tests below iOS 14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
a/datepicker i/high Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often p/iOS 🍎 t/bug 🐛
Projects
iOS Ready For Work
  
Done
vNext+1 (5.0.0)
Done
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

[iOS] Restore wheels date/time picker styles in 5.0 xamarin/Xamarin.Forms
2 participants
@hartez @ColeXm