Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SetHasNavigationBar screen height wrong #1426

Closed
davidortinau opened this issue Dec 20, 2017 · 0 comments
Closed

SetHasNavigationBar screen height wrong #1426

davidortinau opened this issue Dec 20, 2017 · 0 comments
Assignees
@rmarinho
Labels
in-progress This issue has an associated pull request that may resolve it! p/Android p/iOS 🍎 p/UWP t/bug 🐛

Comments

@davidortinau
Copy link
Contributor

Migrated from https://bugzilla.xamarin.com/show_bug.cgi?id=36598

Description

When you push to a different page, and go back, you can see that the height is calculated wrong, because the last image on that page is now under the tabbar.

If you add the workaround, when you pop the page, the first page's content animates when it corrects it self, and doesn't look professional.

Broken on 2.3.246, 2.3.5.256-pre6, and latest nightly 2.3.6.120

The issue isn't apparent at the NavigationBar, but the TabBar.

Expected Behavior

Actual Behavior

Basic Information

  • Version with issue: 2.3.246, 2.3.5.256-pre6, and latest nightly 2.3.6.120

Reproduction Link

sethasnavigationbarbug.zip
@pauldipietro pauldipietro added this to New in Triage Dec 20, 2017
@davidortinau davidortinau added this to Ready in v3.0.0 Dec 20, 2017
@pauldipietro pauldipietro removed this from New in Triage Dec 20, 2017
@rmarinho rmarinho self-assigned this Jan 3, 2018
@rmarinho rmarinho moved this from Ready to In Progress in v3.0.0 Jan 3, 2018
rmarinho added a commit that referenced this issue Jan 3, 2018
@rmarinho
[Controls] Add test case for github #1426
91e03a2
@rmarinho rmarinho mentioned this issue Jan 8, 2018
Closed
4 tasks
@rmarinho rmarinho moved this from In Progress to In Review in v3.0.0 Jan 8, 2018
@rmarinho rmarinho mentioned this issue Jan 8, 2018
Merged
4 tasks
rmarinho added a commit that referenced this issue Jan 22, 2018
@rmarinho
[Controls] Repo for issue #1426
40aaf47
rmarinho added a commit that referenced this issue Feb 2, 2018
@rmarinho
[Controls] Repo for issue #1426
1ef140b
v3.0.0 automation moved this from In Review to Done Feb 20, 2018
jsuarezruiz added a commit to XamarinFormsCommunity/Xamarin.Forms that referenced this issue Feb 28, 2018
@jsuarezruiz
Merge branch 'master' of https://github.com/xamarin/Xamarin.Forms
d908bfb 
* 'master' of https://github.com/xamarin/Xamarin.Forms: (23 commits)
  [C] use direct cast
  [Core, iOS, Android, UWP, WPF] Hide scroll view scroll bars (xamarin#1910)
  Allow users to specify resolution method for handlers, effects, and services (xamarin#1870) fixes xamarin#1739
  [Build] Update submodule
  Capitalization keyboard flag additions for Entry/Editor (xamarin#1683) (xamarin#1833)
  [Build] Don't specify .net sdk version
  Simplify event raising invocation pattern (xamarin#1971)
  [iOS Maps] Pin rendering customization (xamarin#1065)
  set csharp_space_after_keywords_in_control_flow_statements to true to fit our design guide lines (xamarin#1964)
  [iOS] Add shadow effect (xamarin#1896)
  Added support for ListView full width separators on iOS (xamarin#1854) fixes xamarin#1665
  Support CascadeInputTransparent to Tizen (xamarin#1916)
  [Android]?Remove UserVisibleHint (xamarin#1550) fixes xamarin#1438
  [iOS] ViewDidLayoutSubviews after removing page (xamarin#1532) fixes xamarin#1426
  Use relative URL to support recursive checkout in VSTS (xamarin#1926)
  [UITest] Fix test for UITest package update (xamarin#1923)
  Implemented MaxLength property on Entry and Editor (xamarin#1880)
  [Build]Fix master and build (xamarin#1920)
  [Build] Fix windows cert
  Fix to absolute URL
  ...

# Conflicts:
#	Xamarin.Forms.Controls/CoreGalleryPages/EditorCoreGalleryPage.cs
#	Xamarin.Forms.Controls/CoreGalleryPages/EntryCoreGalleryPage.cs
#	Xamarin.Forms.Core/InputView.cs
#	Xamarin.Forms.CustomAttributes/TestAttributes.cs
#	Xamarin.Forms.Platform.Android/Renderers/EditorRenderer.cs
#	Xamarin.Forms.Platform.Android/Renderers/EntryRenderer.cs
#	Xamarin.Forms.Platform.MacOS/Renderers/EditorRenderer.cs
#	Xamarin.Forms.Platform.MacOS/Renderers/EntryRenderer.cs
#	Xamarin.Forms.Platform.Tizen/Renderers/EditorRenderer.cs
#	Xamarin.Forms.Platform.Tizen/Renderers/EntryRenderer.cs
#	Xamarin.Forms.Platform.WPF/Renderers/EditorRenderer.cs
#	Xamarin.Forms.Platform.WPF/Renderers/EntryRenderer.cs
#	Xamarin.Forms.Platform.iOS/Renderers/EditorRenderer.cs
#	Xamarin.Forms.Platform.iOS/Renderers/EntryRenderer.cs
@shnaz shnaz mentioned this issue Mar 29, 2018
Closed
@samhouts samhouts removed this from Done in v3.0.0 May 7, 2018
@samhouts samhouts added the in-progress This issue has an associated pull request that may resolve it! label Jun 20, 2020
@samhouts samhouts added this to In Progress in vCurrent (4.8.0) Jun 20, 2020
@samhouts samhouts removed this from In Progress in vCurrent (4.8.0) Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmarinho rmarinho

Labels
in-progress This issue has an associated pull request that may resolve it! p/Android p/iOS 🍎 p/UWP t/bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[iOS] ViewDidLayoutSubviews after removing page fixes #1426 xamarin/Xamarin.Forms
3 participants
@davidortinau @rmarinho @samhouts