Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] TapGestureRecognizer do not fire the tapped event on "normal" tap/click. #1628

Open
mathias3d opened this Issue Jan 21, 2018 · 5 comments

Comments

Projects
6 participants
@mathias3d
Copy link

commented Jan 21, 2018

Bug report best practices: https://github.com/xamarin/Xamarin.Forms/wiki/Submitting-Issues

Description

On Android the TapGestureRecognizer do not fire the tapped event on "normal" tap/click.
The finger is always sliding a little over the screen when you are tapping it, the TapGestureRecognizer have a very small "sliding"-tolerance. This makes the TapGestureRecognizer to only fire a tapped event if you click much more carefully than on a normal button.

Steps to Reproduce

  1. Device: Samsung SM-T580 (Galaxy Tab A)
  2. OS: Android 7.0
  3. Enable developer options: Show Touches and Show Pointer location.

Create any basic Xamarin.Forms project and apply a TapGestureRecognizer to any basic element (Text, StackLayout etc.)

Expected Behavior

The tapped event should be fired even if a little sliding occurs, just like normal buttons do.

Actual Behavior

No event is fired when a little sliding occurs, like it does on buttons.

Basic Information

  • Version with issue: Xamarin.Forms 2.5.0.122203
  • Platform Target Frameworks:
    • Android: 7.0
  • Android Support Library Version: Xamarin.Android.Support.v4 (26.1.0.1), Xamarin.Android.Support.v7.AppCompat (26.1.0.1)
  • Affected Devices: Samsung SM-T580 (Galaxy Tab A)

Screenshots

Reproduction Link

@pauldipietro pauldipietro added this to New in Triage Jan 21, 2018

@StephaneDelcroix StephaneDelcroix moved this from New to Ready For Work in Triage Jan 22, 2018

@mathias3d

This comment has been minimized.

Copy link
Author

commented Jan 22, 2018

Related to this maybe?
#1374

@timahrentlov

This comment has been minimized.

Copy link

commented Mar 13, 2018

When will Xamarin Forms support the tap event on Android ? It's a pretty basic feature for a mobile development framework.

@samhouts samhouts added this to To do in Sprint 138 Jul 2, 2018

@kingces95 kingces95 self-assigned this Jul 6, 2018

@kingces95

This comment has been minimized.

Copy link
Member

commented Jul 6, 2018

App14.zip

Reproduction of the behavior which is as described.

A button will recognize any gesture as a click regardless of how much sliding occurs so long as the sliding starts and stops within the button.

A label with a tap gesture recognizer will register a tap with only a few pixels of sliding tolerance.

@kingces95

This comment has been minimized.

Copy link
Member

commented Jul 6, 2018

@jassmith says we should add a knob to allow users to control sliding tolerance for the tap gesture recognizer. I doubt we'll go as far as making the tap gesture recognizer logic match that of a button.

@kingces95 kingces95 removed this from To do in Sprint 138 Jul 6, 2018

@mathias3d

This comment has been minimized.

Copy link
Author

commented Jul 6, 2018

I am glad to hear that this is being dealt with. A setting for the sliding tolerance would be appreciated, right now i am getting allot of complaints about people not being able to use our app because the users think they cant click on the items.

@PureWeen PureWeen assigned PureWeen and unassigned kingces95 Aug 9, 2018

@samhouts samhouts removed this from Ready For Work in Triage Oct 4, 2018

@samhouts samhouts added this to To do in Sprint 143 Oct 15, 2018

@PureWeen PureWeen removed their assignment Oct 23, 2018

@samhouts samhouts added the inactive label Jan 2, 2019

@samhouts samhouts added this to Under consideration in Enhancements Feb 5, 2019

@samhouts samhouts moved this from Under consideration to Needs Specification in Enhancements Feb 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.