-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[Enhancement] Entry: Read-only entry #1678
Comments
Hi, Can I be assigned to this issue :) |
How does this work for iOS and UWP ? |
Same as Android. |
@PureWeen Any reason this wouldn't make sense on Editor as well? |
@hartez I changed the spec to apply to the InputView and to verify implementation with the Entry and Editor controls |
Hey @almirvuk, you still working on this? If not we can move it back to the ready for work column |
Had some problems :( , I am planning to finish it by the end of tommorow, is that ok? |
More than OK :) I am just checking in to make sure we're not losing track of things. Thank you for your efforts! |
On iOS you can use: https://developer.xamarin.com/api/property/MonoTouch.UIKit.UIView.UserInteractionEnabled/ On Android you can use: These will prevent text from being edited without changing the respective controls' appearances. |
On Tizen you can use |
Nice, thanks @rookiejava! I am very happy with my progress (as first time XF contributor), I will need day or two more to complete this :) |
@jassmith I made pull request to community repository, I am working on docs and some small improvements. I will make PR on official one in day or two 🙂 |
Awesome |
- fixes #1678 - fixes #4834 * InputView BindableProperty IsReadOnly * Android Editor and Entry setup * MacOS Editor and Entry setup * Tizen Editor and Entry setup * UAP Editor and Entry setup * WPF Editor and Entry setup * iOS Editor and Entry setup * Issue1678 - TestContentPage added * Tests added * Tizen Editor and Entry fix * UI Test fix * Android fix for Entry and Editor. * Unit Tests fix. * Android Renderer first try. * MacOS Entry renderer small fix. * UpdateEditable fix. * Android Entry and Editor reduced number of calls to BP. * fix TestAttributes conflicts * Remove keyboard * [macOS] relinquish first responder * [Android] remove call to UpdateCursorSelection * [UWP] fix tabs
- fixes #1678 - fixes #4834 * InputView BindableProperty IsReadOnly * Android Editor and Entry setup * MacOS Editor and Entry setup * Tizen Editor and Entry setup * UAP Editor and Entry setup * WPF Editor and Entry setup * iOS Editor and Entry setup * Issue1678 - TestContentPage added * Tests added * Tizen Editor and Entry fix * UI Test fix * Android fix for Entry and Editor. * Unit Tests fix. * Android Renderer first try. * MacOS Entry renderer small fix. * UpdateEditable fix. * Android Entry and Editor reduced number of calls to BP. * fix TestAttributes conflicts * Remove keyboard * [macOS] relinquish first responder * [Android] remove call to UpdateCursorSelection * [UWP] fix tabs
- fixes xamarin#1678 - fixes xamarin#4834 * InputView BindableProperty IsReadOnly * Android Editor and Entry setup * MacOS Editor and Entry setup * Tizen Editor and Entry setup * UAP Editor and Entry setup * WPF Editor and Entry setup * iOS Editor and Entry setup * Issue1678 - TestContentPage added * Tests added * Tizen Editor and Entry fix * UI Test fix * Android fix for Entry and Editor. * Unit Tests fix. * Android Renderer first try. * MacOS Entry renderer small fix. * UpdateEditable fix. * Android Entry and Editor reduced number of calls to BP. * fix TestAttributes conflicts * Remove keyboard * [macOS] relinquish first responder * [Android] remove call to UpdateCursorSelection * [UWP] fix tabs
Hey Guys, It would be great to have it also for Picker, DatePicker, TimePicker, Regards, |
Hi guys I know this is too late but . With this read only property why Long click on entry text which opens copy selectAll option is not opening.Some might want allow user to copy and select specific text which can be easily achieved using this ReadOnly property of Entry if default entry long clicks functionality works. Regards |
I believe that this is a basic requirement/feature/enhancement that should be enabled ASAP ! I cannot imagine a framework without this feature ! |
Rationale
Currently you can set an Entry and Editor to IsEnabled false which technically makes it Read Only but it's greyed out. Is Read Only would present the field so it looks the same when it's editable but now it's not editable.
Implementation
Add IsReadonly property to InputView (base class of Entry and Editor)
Renderers will make the platform native entry field uneditable but how it looks will not change
Currently the Entry and Editor controls inherit form InputView so need to verify that this enhancement works for both an Entry and Editor
Expected Result
Android
Entry.IsReadonly = true
: should make the input control uneditableEditor.IsReadonly = true
: should make the input control uneditableiOS
See Android
UWP
See Android
Implications for CSS
Backward Compatibility
This is adding a new property so should be backwards compatible. Need to ensure that the property defaults to false.
Difficulty : Easy
This is an easy change and great for a first time contributor.
The text was updated successfully, but these errors were encountered: