Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Race condition between the main thread and a thread used by CADisplayLinkTicker #1755

Closed
PradoVargasN opened this issue Jan 31, 2018 · 8 comments · Fixed by #3774
Closed
Assignees
Labels
e/1 🕐 1 i/high Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often m/low impact ◾ p/iOS 🍎 t/bug 🐛

Comments

@PradoVargasN
Copy link

PradoVargasN commented Jan 31, 2018

Description

Race condition between the main thread and a thread used by CADisplayLinkTicker
CADisplayLinkTicker invokes Quartz.CATransaction.commi()t which is deciding to do an auto layout while not on the main thread, in the main thread we are adding/removing ContentViews (Note class in our code) to an AbsoluteLayout

This makes the iOS version of our app to crash.

Hardware Model:      iPhone10,4
Code Type:           ARM-64 (Native)
Role:                Foreground
Parent Process:      launchd [1]

Date/Time:           2018-01-15 09:22:43.8605 -0700
Launch Time:         2018-01-15 09:19:50.1545 -0700
OS Version:          iPhone OS 11.2.1 (15C153)
Baseband Version:    1.03.06
Report Version:      104

Exception Type:  EXC_CRASH (SIGABRT)
Exception Codes: 0x0000000000000000, 0x0000000000000000
Exception Note:  EXC_CORPSE_NOTIFY
Triggered by Thread:  18

Application Specific Information:
abort() called

Filtered syslog:
None found

Last Exception Backtrace:
0   CoreFoundation                	0x183eb2364 __exceptionPreprocess + 124
1   libobjc.A.dylib               	0x1830f8528 objc_exception_throw + 55
2   CoreFoundation                	0x183eb19f0 __NSFastEnumerationMutationHandler + 127
3   UIKit                         	0x18d38ac04 -[UIView+ 27652 (Hierarchy) subviews] + 343
4   UIKit                         	0x18d67e200 -[UIView+ 3121664 (CALayerDelegate) _wantsReapplicationOfAutoLayoutWithLayoutDirtyOnEntry:] + 71
5   UIKit                         	0x18d390f48 -[UIView+ 53064 (CALayerDelegate) layoutSublayersOfLayer:] + 1347
6   QuartzCore                    	0x187ef5998 -[CALayer layoutSublayers] + 183
7   QuartzCore                    	0x187ef9b20 CA::Layer::layout_if_needed+ 1207072 (CA::Transaction*) + 331
8   QuartzCore                    	0x187e6636c CA::Context::commit_transaction+ 602988 (CA::Transaction*) + 335
9   QuartzCore                    	0x187e8db90 CA::Transaction::commit+ 764816 () + 539
10  MyAPP                      	0x1046bbcd8 wrapper_managed_to_native_ObjCRuntime_Messaging_void_objc_msgSend_intptr_intptr + 25263320 (/<unknown>:1)
11  MyAPP                      	0x104663ca8 CoreAnimation_CATransaction_Commit + 24902824 (CATransaction.g.cs:89)
12  MyAPP                      	0x10453db7c Xamarin_Forms_Platform_iOS_CADisplayLinkTicker_StartThread + 23698300 (/C:\BuildAgent3\work\ca3766cfc22354a1\Xamarin.Forms.Platform.iOS\CADisplayLinkTicker.cs:61)
13  MyAPP                      	0x103a3b33c System_Threading_ThreadHelper_ThreadStart_Context_object + 187
14  MyAPP                      	0x103a38ef4 System_Threading_ExecutionContext_RunInternal_System_Threading_ExecutionContext_System_Threading_ContextCallback_object_bool + 403
15  MyAPP                      	0x103a38d4c System_Threading_ExecutionContext_Run_System_Threading_ExecutionContext_System_Threading_ContextCallback_object_bool + 43
16  MyAPP                      	0x103a38ccc System_Threading_ExecutionContext_Run_System_Threading_ExecutionContext_System_Threading_ContextCallback_object + 75
17  MyAPP                      	0x103a3b4a4 System_Threading_ThreadHelper_ThreadStart + 51
18  MyAPP                      	0x103b981b4 wrapper_runtime_invoke_object_runtime_invoke_dynamic_intptr_intptr_intptr_intptr + 243
19  MyAPP                      	0x1055a4b84 mono_jit_runtime_invoke + 40897412 (mini-runtime.c:2525)
20  MyAPP                      	0x10561e238 do_runtime_invoke + 41394744 (object.c:2829)
21  MyAPP                      	0x10564b934 start_wrapper + 41580852 (threads.c:837)
22  libsystem_pthread.dylib       	0x183ad82b4 _pthread_body + 307
23  libsystem_pthread.dylib       	0x183ad8180 _pthread_start + 311
24  libsystem_pthread.dylib       	0x183ad6b74 thread_start + 3


Thread 0 name:  tid_303  Dispatch queue: com.apple.main-thread
Thread 0:
0   MyAPP                      	0x0000000105628de4 mono_type_get_object_handle + 41438692 (reflection.c:564)
1   MyAPP                      	0x00000001055e1130 ves_icall_System_Type_internal_from_name + 41144624 (handle.h:413)
2   MyAPP                      	0x00000001039582c8 wrapper_managed_to_native_System_Type_internal_from_name_string_bool_bool + 168
3   MyAPP                      	0x0000000103958354 System_Type_GetType_string + 36
4   MyAPP                      	0x0000000104e5e9cc Xamarin_Forms_Xaml_TypeConversionExtensions__c__DisplayClass1_0__ConvertTob__0 + 33270220 (/C:\BuildAgent3\work\ca3766cfc22354a1\Xamarin.Forms.Xaml\TypeConversionExtensions.cs:70)
5   MyAPP                      	0x0000000104e5c658 Xamarin_Forms_Xaml_TypeConversionExtensions_ConvertTo_object_System_Type_System_Func_1_object_System_IServiceProvider + 33261144 (/C:\BuildAgent3\work\ca3766cfc22354a1\Xamarin.Forms.Xaml\TypeConversionExtensions.cs:110)
6   MyAPP                      	0x0000000104e5bbdc Xamarin_Forms_Xaml_TypeConversionExtensions_ConvertTo_object_System_Type_System_Func_1_System_Reflection_MemberInfo_System_IServiceProvider + 33258460 (/C:\BuildAgent3\work\ca3766cfc22354a1\Xamarin.Forms.Xaml\TypeConversionExtensions.cs:74)
7   MyAPP                      	0x0000000104e71e88 Xamarin_Forms_Xaml_ApplyPropertiesVisitor_TrySetValue_object_Xamarin_Forms_BindableProperty_bool_object_System_Xml_IXmlLineInfo_Xamarin_Forms_Xaml_Internals_XamlServiceProvider_System_Exception_ + 33349256 (/C:\BuildAgent3\work\ca3766cfc22354a1\Xamarin.Forms.Xaml\ApplyPropertiesVisitor.cs:404)
8   MyAPP                      	0x0000000104e706f0 Xamarin_Forms_Xaml_ApplyPropertiesVisitor_SetPropertyValue_object_Xamarin_Forms_Xaml_XmlName_object_object_Xamarin_Forms_Xaml_INode_Xamarin_Forms_Xaml_HydratationContext_System_Xml_IXmlLineInfo + 33343216 (/C:\BuildAgent3\work\ca3766cfc22354a1\Xamarin.Forms.Xaml\ApplyPropertiesVisitor.cs:295)
9   MyAPP                      	0x0000000104e6bf78 Xamarin_Forms_Xaml_ApplyPropertiesVisitor_Visit_Xamarin_Forms_Xaml_ValueNode_Xamarin_Forms_Xaml_INode + 33324920 (/C:\BuildAgent3\work\ca3766cfc22354a1\Xamarin.Forms.Xaml\ApplyPropertiesVisitor.cs:64)
10  MyAPP                      	0x0000000104e5689c Xamarin_Forms_Xaml_ValueNode_Accept_Xamarin_Forms_Xaml_IXamlNodeVisitor_Xamarin_Forms_Xaml_INode + 33237148 (/C:\BuildAgent3\work\ca3766cfc22354a1\Xamarin.Forms.Xaml\XamlNode.cs:102)
11  MyAPP                      	0x0000000104e57858 Xamarin_Forms_Xaml_ElementNode_Accept_Xamarin_Forms_Xaml_IXamlNodeVisitor_Xamarin_Forms_Xaml_INode + 33241176 (/C:\BuildAgent3\work\ca3766cfc22354a1\Xamarin.Forms.Xaml\XamlNode.cs:169)
12  MyAPP                      	0x0000000104e596c4 Xamarin_Forms_Xaml_ListNode_Accept_Xamarin_Forms_Xaml_IXamlNodeVisitor_Xamarin_Forms_Xaml_INode + 33248964 (/C:\BuildAgent3\work\ca3766cfc22354a1\Xamarin.Forms.Xaml\XamlNode.cs:248)
13  MyAPP                      	0x0000000104e57858 Xamarin_Forms_Xaml_ElementNode_Accept_Xamarin_Forms_Xaml_IXamlNodeVisitor_Xamarin_Forms_Xaml_INode + 33241176 (/C:\BuildAgent3\work\ca3766cfc22354a1\Xamarin.Forms.Xaml\XamlNode.cs:169)
14  MyAPP                      	0x0000000104e58d28 Xamarin_Forms_Xaml_RootNode_Accept_Xamarin_Forms_Xaml_IXamlNodeVisitor_Xamarin_Forms_Xaml_INode + 33246504 (/C:\BuildAgent3\work\ca3766cfc22354a1\Xamarin.Forms.Xaml\XamlNode.cs:222)
15  MyAPP                      	0x0000000104e54408 Xamarin_Forms_Xaml_XamlLoader_Visit_Xamarin_Forms_Xaml_RootNode_Xamarin_Forms_Xaml_HydratationContext + 33227784 (/C:\BuildAgent3\work\ca3766cfc22354a1\Xamarin.Forms.Xaml\XamlLoader.cs:136)
16  MyAPP                      	0x0000000104e53748 Xamarin_Forms_Xaml_XamlLoader_Load_object_string + 33224520 (/C:\BuildAgent3\work\ca3766cfc22354a1\Xamarin.Forms.Xaml\XamlLoader.cs:90)
17  MyAPP                      	0x0000000104e53308 Xamarin_Forms_Xaml_XamlLoader_Load_object_System_Type + 33223432 (/C:\BuildAgent3\work\ca3766cfc22354a1\Xamarin.Forms.Xaml\XamlLoader.cs:67)
18  MyAPP                      	0x0000000104e53020 Xamarin_Forms_Xaml_Extensions_LoadFromXaml_TXaml_REF_TXaml_REF_System_Type + 33222688 (/C:\BuildAgent3\work\ca3766cfc22354a1\Xamarin.Forms.Xaml\ViewExtensions.cs:37)
19  MyAPP                      	0x0000000104873a04 MyAPP_PCL_Controls_Note_InitializeComponent + 27064836 (MyAPP.PCL.Controls.Note.xaml.g.cs:20)
20  MyAPP                      	0x0000000104873940 MyAPP_PCL_Controls_Note__ctor + 27064640 (Note.xaml.cs:10)
21  MyAPP                      	0x0000000104874184 MyAPP_PCL_Controls_NotesRenderer_Add_MyAPP_PCL_Controls_NotesRenderer_NoteViewModel + 27066756 (NotesRenderer.xaml.cs:38)
22  MyAPP                      	0x0000000104873cd8 MyAPP_PCL_Controls_NotesRenderer_AddOrUpdate_System_Collections_Generic_IEnumerable_1_MyAPP_PCL_Controls_NotesRenderer_NoteViewModel + 27065560 (NotesRenderer.xaml.cs:23)
23  MyAPP                      	0x0000000103298160 MyAPP_Layouts_RigDetails_RigChartsTab__c__DisplayClass161_1__UpdateTimeHistoryb__5 + 4145504 (RigChartsTab.xaml.cs:3253)
24  MyAPP                      	0x0000000104621444 Foundation_NSAsyncActionDispatcher_Apply + 24630340 (NSAction.cs:163)
25  MyAPP                      	0x0000000103b981b4 wrapper_runtime_invoke_object_runtime_invoke_dynamic_intptr_intptr_intptr_intptr + 244
26  MyAPP                      	0x00000001055a4b84 mono_jit_runtime_invoke + 40897412 (mini-runtime.c:2526)
27  MyAPP                      	0x000000010561e238 do_runtime_invoke + 41394744 (object.c:2829)
28  MyAPP                      	0x000000010561e198 mono_runtime_invoke + 41394584 (object.c:2983)
29  MyAPP                      	0x0000000102ec315c native_to_managed_trampoline_3(objc_object*, objc_selector*, _MonoMethod**, unsigned int) + 127324 (registrar.m:108)
30  MyAPP                      	0x0000000102ec36b4 -[__MonoMac_NSAsyncActionDispatcher xamarinApplySelector] + 128692 (registrar.m:8202)
31  Foundation                    	0x00000001848af2e4 __NSThreadPerformPerform + 340
32  CoreFoundation                	0x0000000183e5a97c __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 24
33  CoreFoundation                	0x0000000183e5a8fc __CFRunLoopDoSource0 + 88
34  CoreFoundation                	0x0000000183e5a184 __CFRunLoopDoSources0 + 204
35  CoreFoundation                	0x0000000183e57d5c __CFRunLoopRun + 1048
36  CoreFoundation                	0x0000000183d77e58 CFRunLoopRunSpecific + 436
37  GraphicsServices              	0x0000000185c24f84 GSEventRunModal + 100
38  UIKit                         	0x000000018d3f767c UIApplicationMain + 236
39  MyAPP                      	0x00000001046b9380 wrapper_managed_to_native_UIKit_UIApplication_UIApplicationMain_int_string___intptr_intptr + 25252736 (/<unknown>:1)
40  MyAPP                      	0x000000010463efdc UIKit_UIApplication_Main_string___intptr_intptr + 24752092 (UIApplication.cs:79)
41  MyAPP                      	0x000000010463ef9c UIKit_UIApplication_Main_string___string_string + 24752028 (UIApplication.cs:63)
42  MyAPP                      	0x00000001034c8120 MyAPP_iOS_Application_Main_string__ + 6439200 (Main.cs:19)
43  MyAPP                      	0x0000000103b981b4 wrapper_runtime_invoke_object_runtime_invoke_dynamic_intptr_intptr_intptr_intptr + 244
44  MyAPP                      	0x00000001055a4b84 mono_jit_runtime_invoke + 40897412 (mini-runtime.c:2526)
45  MyAPP                      	0x000000010561e238 do_runtime_invoke + 41394744 (object.c:2829)
46  MyAPP                      	0x0000000105621398 do_exec_main_checked + 41407384 (object.c:4623)
47  MyAPP                      	0x0000000105588de8 mono_jit_exec + 40783336 (driver.g.c:1040)
48  MyAPP                      	0x00000001056f9dac xamarin_main + 42294700 (monotouch-main.m:483)
49  MyAPP                      	0x0000000102eef1b0 main + 307632 (main.m:161)
50  libdyld.dylib                 	0x000000018389456c start + 4

Thread 1:
0   libsystem_kernel.dylib        	0x00000001839c4d80 __workq_kernreturn + 8
1   libsystem_pthread.dylib       	0x0000000183ad6eec _pthread_wqthread + 884
2   libsystem_pthread.dylib       	0x0000000183ad6b6c start_wqthread + 4

Thread 2:
0   libsystem_kernel.dylib        	0x00000001839c40f0 __psynch_cvwait + 8
1   libsystem_pthread.dylib       	0x0000000183adef74 _pthread_cond_wait$VARIANT$armv81 + 624
2   libc++.1.dylib                	0x000000018307bea4 std::__1::condition_variable::wait+ 32420 (std::__1::unique_lock<std::__1::mutex>&) + 24
3   JavaScriptCore                	0x000000018b1b8b58 void std::__1::condition_variable_any::wait<std::__1::unique_lock<bmalloc::Mutex> >+ 9726808 (std::__1::unique_lock<bmalloc::Mutex>&) + 96
4   JavaScriptCore                	0x000000018b1b8a80 bmalloc::AsyncTask<bmalloc::Heap, void (bmalloc::Heap::*)()>::threadRunLoop+ 9726592 () + 172
5   JavaScriptCore                	0x000000018b1b8de4 void* std::__1::__thread_proxy<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, void (*)(bmalloc::AsyncTask<bmalloc::Heap, void (bmalloc::Heap::*)()>*), bmalloc::AsyncTask<bmalloc::Heap, void (bmalloc::Heap::*)()>*> >+ 9727460 (void*) + 44
6   libsystem_pthread.dylib       	0x0000000183ad82b4 _pthread_body + 308
7   libsystem_pthread.dylib       	0x0000000183ad8180 _pthread_body + 0
8   libsystem_pthread.dylib       	0x0000000183ad6b74 thread_start + 4

Thread 3 name:  WebThread
Thread 3:
0   libsystem_kernel.dylib        	0x00000001839a3568 mach_msg_trap + 8
1   libsystem_kernel.dylib        	0x00000001839a33e0 mach_msg + 72
2   CoreFoundation                	0x0000000183e5a308 __CFRunLoopServiceMachPort + 196
3   CoreFoundation                	0x0000000183e57ed4 __CFRunLoopRun + 1424
4   CoreFoundation                	0x0000000183d77e58 CFRunLoopRunSpecific + 436
5   WebCore                       	0x000000018bc852c8 RunWebThread+ 266952 (void*) + 560
6   libsystem_pthread.dylib       	0x0000000183ad82b4 _pthread_body + 308
7   libsystem_pthread.dylib       	0x0000000183ad8180 _pthread_body + 0
8   libsystem_pthread.dylib       	0x0000000183ad6b74 thread_start + 4

Thread 4 name:  SGen worker
Thread 4:
0   libsystem_kernel.dylib        	0x00000001839c40f0 __psynch_cvwait + 8
1   libsystem_pthread.dylib       	0x0000000183adef74 _pthread_cond_wait$VARIANT$armv81 + 624
2   MyAPP                      	0x000000010569f058 thread_func + 41922648 (sgen-thread-pool.c:130)
3   libsystem_pthread.dylib       	0x0000000183ad82b4 _pthread_body + 308
4   libsystem_pthread.dylib       	0x0000000183ad8180 _pthread_body + 0
5   libsystem_pthread.dylib       	0x0000000183ad6b74 thread_start + 4

Thread 5 name:  Finalizer
Thread 5:
0   libsystem_kernel.dylib        	0x00000001839a35a4 semaphore_wait_trap + 8
1   MyAPP                      	0x00000001055dda3c finalizer_thread + 41130556 (mono-os-semaphore.h:92)
2   MyAPP                      	0x000000010564b910 start_wrapper + 41580816 (threads.c:829)
3   libsystem_pthread.dylib       	0x0000000183ad82b4 _pthread_body + 308
4   libsystem_pthread.dylib       	0x0000000183ad8180 _pthread_body + 0
5   libsystem_pthread.dylib       	0x0000000183ad6b74 thread_start + 4

Thread 6:
0   libsystem_kernel.dylib        	0x00000001839c4d80 __workq_kernreturn + 8
1   libsystem_pthread.dylib       	0x0000000183ad6eec _pthread_wqthread + 884
2   libsystem_pthread.dylib       	0x0000000183ad6b6c start_wqthread + 4

Thread 7 name:  com.apple.uikit.eventfetch-thread
Thread 7:
0   libsystem_kernel.dylib        	0x00000001839a3568 mach_msg_trap + 8
1   libsystem_kernel.dylib        	0x00000001839a33e0 mach_msg + 72
2   CoreFoundation                	0x0000000183e5a308 __CFRunLoopServiceMachPort + 196
3   CoreFoundation                	0x0000000183e57ed4 __CFRunLoopRun + 1424
4   CoreFoundation                	0x0000000183d77e58 CFRunLoopRunSpecific + 436
5   Foundation                    	0x00000001847ad594 -[NSRunLoop+ 50580 (NSRunLoop) runMode:beforeDate:] + 304
6   Foundation                    	0x00000001847cc9ac -[NSRunLoop+ 178604 (NSRunLoop) runUntilDate:] + 96
7   UIKit                         	0x000000018df617b8 -[UIEventFetcher threadMain] + 136
8   Foundation                    	0x00000001848af0f4 __NSThread__start__ + 996
9   libsystem_pthread.dylib       	0x0000000183ad82b4 _pthread_body + 308
10  libsystem_pthread.dylib       	0x0000000183ad8180 _pthread_body + 0
11  libsystem_pthread.dylib       	0x0000000183ad6b74 thread_start + 4

Thread 8:
0   libsystem_pthread.dylib       	0x0000000183ad6b68 start_wqthread + 0

Thread 9 name:  Timer-Scheduler
Thread 9:
0   libsystem_kernel.dylib        	0x00000001839c40f0 __psynch_cvwait + 8
1   libsystem_pthread.dylib       	0x0000000183adef74 _pthread_cond_wait$VARIANT$armv81 + 624
2   MyAPP                      	0x0000000105658450 mono_os_cond_timedwait + 41632848 (mono-os-mutex.h:216)
3   MyAPP                      	0x000000010565712c mono_w32handle_timedwait_signal_handle + 41627948 (w32handle.c:976)
4   MyAPP                      	0x0000000105656fdc mono_w32handle_wait_one + 41627612 (w32handle.c:1213)
5   MyAPP                      	0x00000001056572ac mono_w32handle_wait_multiple + 41628332 (w32handle.c:1244)
6   MyAPP                      	0x000000010564707c mono_wait_uninterrupted + 41562236 (threads.c:1892)
7   MyAPP                      	0x000000010564738c ves_icall_System_Threading_WaitHandle_WaitOne_internal + 41563020 (threads.c:2017)
8   MyAPP                      	0x0000000103a467d8 wrapper_managed_to_native_System_Threading_WaitHandle_WaitOne_internal_intptr_int + 104
9   MyAPP                      	0x0000000103a46720 System_Threading_WaitHandle_WaitOneNative_System_Runtime_InteropServices_SafeHandle_uint_bool_bool + 80
10  MyAPP                      	0x0000000103a45eec System_Threading_WaitHandle_InternalWaitOne_System_Runtime_InteropServices_SafeHandle_long_bool_bool + 60
11  MyAPP                      	0x0000000103a45e9c System_Threading_WaitHandle_WaitOne_long_bool + 44
12  MyAPP                      	0x0000000103a45dac System_Threading_WaitHandle_WaitOne_int_bool + 60
13  MyAPP                      	0x0000000103a45e5c System_Threading_WaitHandle_WaitOne_int + 44
14  MyAPP                      	0x0000000103a4a308 System_Threading_Timer_Scheduler_SchedulerThread + 1400
15  MyAPP                      	0x0000000103a3b33c System_Threading_ThreadHelper_ThreadStart_Context_object + 188
16  MyAPP                      	0x0000000103a38ef4 System_Threading_ExecutionContext_RunInternal_System_Threading_ExecutionContext_System_Threading_ContextCallback_object_bool + 404
17  MyAPP                      	0x0000000103a38d4c System_Threading_ExecutionContext_Run_System_Threading_ExecutionContext_System_Threading_ContextCallback_object_bool + 44
18  MyAPP                      	0x0000000103a38ccc System_Threading_ExecutionContext_Run_System_Threading_ExecutionContext_System_Threading_ContextCallback_object + 76
19  MyAPP                      	0x0000000103a3b4a4 System_Threading_ThreadHelper_ThreadStart + 52
20  MyAPP                      	0x0000000103b981b4 wrapper_runtime_invoke_object_runtime_invoke_dynamic_intptr_intptr_intptr_intptr + 244
21  MyAPP                      	0x00000001055a4b84 mono_jit_runtime_invoke + 40897412 (mini-runtime.c:2526)
22  MyAPP                      	0x000000010561e238 do_runtime_invoke + 41394744 (object.c:2829)
23  MyAPP                      	0x000000010564b934 start_wrapper + 41580852 (threads.c:839)
24  libsystem_pthread.dylib       	0x0000000183ad82b4 _pthread_body + 308
25  libsystem_pthread.dylib       	0x0000000183ad8180 _pthread_body + 0
26  libsystem_pthread.dylib       	0x0000000183ad6b74 thread_start + 4

Thread 10 name:  Threadpool worker
Thread 10:
0   libsystem_kernel.dylib        	0x00000001839c40f0 __psynch_cvwait + 8
1   libsystem_pthread.dylib       	0x0000000183adef74 _pthread_cond_wait$VARIANT$armv81 + 624
2   MyAPP                      	0x00000001056418b4 worker_thread + 41539764 (mono-os-mutex.h:216)
3   MyAPP                      	0x000000010564b910 start_wrapper + 41580816 (threads.c:829)
4   libsystem_pthread.dylib       	0x0000000183ad82b4 _pthread_body + 308
5   libsystem_pthread.dylib       	0x0000000183ad8180 _pthread_body + 0
6   libsystem_pthread.dylib       	0x0000000183ad6b74 thread_start + 4

Thread 11 name:  Threadpool worker
Thread 11:
0   libsystem_kernel.dylib        	0x00000001839c40f0 __psynch_cvwait + 8
1   libsystem_pthread.dylib       	0x0000000183adef74 _pthread_cond_wait$VARIANT$armv81 + 624
2   MyAPP                      	0x00000001056418b4 worker_thread + 41539764 (mono-os-mutex.h:216)
3   MyAPP                      	0x000000010564b910 start_wrapper + 41580816 (threads.c:829)
4   libsystem_pthread.dylib       	0x0000000183ad82b4 _pthread_body + 308
5   libsystem_pthread.dylib       	0x0000000183ad8180 _pthread_body + 0
6   libsystem_pthread.dylib       	0x0000000183ad6b74 thread_start + 4

Thread 12 name:  Threadpool worker
Thread 12:
0   libsystem_kernel.dylib        	0x00000001839c40f0 __psynch_cvwait + 8
1   libsystem_pthread.dylib       	0x0000000183adef74 _pthread_cond_wait$VARIANT$armv81 + 624
2   MyAPP                      	0x00000001056418b4 worker_thread + 41539764 (mono-os-mutex.h:216)
3   MyAPP                      	0x000000010564b910 start_wrapper + 41580816 (threads.c:829)
4   libsystem_pthread.dylib       	0x0000000183ad82b4 _pthread_body + 308
5   libsystem_pthread.dylib       	0x0000000183ad8180 _pthread_body + 0
6   libsystem_pthread.dylib       	0x0000000183ad6b74 thread_start + 4

Thread 13 name:  Threadpool worker
Thread 13:
0   libsystem_kernel.dylib        	0x00000001839c40f0 __psynch_cvwait + 8
1   libsystem_pthread.dylib       	0x0000000183adef74 _pthread_cond_wait$VARIANT$armv81 + 624
2   MyAPP                      	0x00000001056418b4 worker_thread + 41539764 (mono-os-mutex.h:216)
3   MyAPP                      	0x000000010564b910 start_wrapper + 41580816 (threads.c:829)
4   libsystem_pthread.dylib       	0x0000000183ad82b4 _pthread_body + 308
5   libsystem_pthread.dylib       	0x0000000183ad8180 _pthread_body + 0
6   libsystem_pthread.dylib       	0x0000000183ad6b74 thread_start + 4

Thread 14 name:  Threadpool worker
Thread 14:
0   libSkiaSharp                  	0x000000010606b6fc 0x105cc4000 + 3831548
1   libSkiaSharp                  	0x00000001061124f0 0x105cc4000 + 4515056
2   libSkiaSharp                  	0x00000001061130a4 0x105cc4000 + 4518052
3   libSkiaSharp                  	0x0000000106066a78 0x105cc4000 + 3811960
4   libSkiaSharp                  	0x0000000106066dd8 0x105cc4000 + 3812824
5   libSkiaSharp                  	0x0000000105fa6d78 0x105cc4000 + 3026296
6   MyAPP                      	0x0000000104f1ce08 wrapper_managed_to_native_SkiaSharp_SkiaApi_sk_canvas_draw_path_intptr_intptr_intptr + 34049544 (/<unknown>:1)
7   MyAPP                      	0x0000000104ef8490 SkiaSharp_SKCanvas_DrawPath_SkiaSharp_SKPath_SkiaSharp_SKPaint + 33899664 (/<unknown>:1)
8   MyAPP                      	0x0000000104ec1658 NovMobilityGDI_Drawing_Graphics_DrawPath_NovMobilityGDI_Drawing_Pen_NovMobilityGDI_Drawing_GraphicsPath + 33674840 (Graphics.cs:211)
9   MyAPP                      	0x00000001049d2600 EDRControls_StripChart_1_EDRControls_TimeTag_DrawTraceData_NovMobilityGDI_Drawing_Graphics_int_int + 28501504 (StripChart.cs:2455)
10  MyAPP                      	0x00000001049d1e98 EDRControls_StripChart_1_EDRControls_TimeTag_DrawChart_NovMobilityGDI_Drawing_Graphics_int_int + 28499608 (StripChart.cs:2429)
11  MyAPP                      	0x00000001049ce824 EDRControls_StripChart_1_EDRControls_TimeTag_DrawChart_NovMobilityGDI_Drawing_Graphics + 28485668 (StripChart.cs:2241)
12  MyAPP                      	0x00000001049c4994 EDRControls_StripChart_1_EDRControls_TimeTag_ResumeLayout + 28445076 (StripChart.cs:1502)
13  MyAPP                      	0x00000001049c45e0 EDRControls_StripChart_1_EDRControls_TimeTag_SetHistoricalData_System_Collections_Generic_List_1_EDRControls_StripChart_1_TraceData_EDRControls_TimeTag___EDRControls_TimeTag___long + 28444128 (StripChart.cs:1481)
14  MyAPP                      	0x00000001032765d0 MyAPP_Layouts_RigDetails_RigChartsTab_UpdateTimeHistory_MyAPP_Infrastructure_ChartStripContainer_MyAPP_Infrastructure_TimeHistoricalDataRequest_MyAPP_PCL_HistoricalDataWrapper + 4007376 (RigChartsTab.xaml.cs:3259)
15  MyAPP                      	0x0000000103270a98 MyAPP_Layouts_RigDetails_RigChartsTab_OnHistoricalDataCompleted_object_MyAPP_Infrastructure_HistoricalDataCompletionEventArgs + 3984024 (RigChartsTab.xaml.cs:2839)
16  MyAPP                      	0x000000010355a840 MyAPP_Infrastructure_HistoricalRequestManager__c__DisplayClass41_0__InitializeHistoricalDataAsyncb__7_System_Threading_Tasks_Task_1_MyAPP_Infrastructure_HistoricalCacheRequest + 7039040 (HistoricalRequestManager.cs:649)
17  MyAPP                      	0x0000000103bcd32c gsharedvt_out_trampoline + 220
18  MyAPP                      	0x0000000103b1b9f4 System_Threading_Tasks_ContinuationResultTaskFromResultTask_2_TAntecedentResult_GSHAREDVT_TResult_GSHAREDVT_InnerInvoke + 244
19  MyAPP                      	0x0000000103a5b904 System_Threading_Tasks_Task_Execute + 68
20  MyAPP                      	0x0000000103a5c168 System_Threading_Tasks_Task_ExecutionContextCallback_object + 88
21  MyAPP                      	0x0000000103a38ef4 System_Threading_ExecutionContext_RunInternal_System_Threading_ExecutionContext_System_Threading_ContextCallback_object_bool + 404
22  MyAPP                      	0x0000000103a38d4c System_Threading_ExecutionContext_Run_System_Threading_ExecutionContext_System_Threading_ContextCallback_object_bool + 44
23  MyAPP                      	0x0000000103a5c094 System_Threading_Tasks_Task_ExecuteWithThreadLocal_System_Threading_Tasks_Task_ + 340
24  MyAPP                      	0x0000000103a5beb8 System_Threading_Tasks_Task_ExecuteEntry_bool + 280
25  MyAPP                      	0x0000000103a5bd28 System_Threading_Tasks_Task_System_Threading_IThreadPoolWorkItem_ExecuteWorkItem + 24
26  MyAPP                      	0x0000000103a4195c System_Threading_ThreadPoolWorkQueue_Dispatch + 460
27  MyAPP                      	0x0000000104602ce0 ObjCRuntime_Runtime_ThreadPoolDispatcher_System_Func_1_bool + 24505568 (Runtime.cs:244)
28  MyAPP                      	0x0000000103a43508 System_Threading__ThreadPoolWaitCallback_PerformWaitCallback + 136
29  MyAPP                      	0x0000000103b981b4 wrapper_runtime_invoke_object_runtime_invoke_dynamic_intptr_intptr_intptr_intptr + 244
30  MyAPP                      	0x00000001055a4b84 mono_jit_runtime_invoke + 40897412 (mini-runtime.c:2526)
31  MyAPP                      	0x000000010561e238 do_runtime_invoke + 41394744 (object.c:2829)
32  MyAPP                      	0x0000000105643ef0 worker_callback + 41549552 (threadpool.c:360)
33  MyAPP                      	0x00000001056416d8 worker_thread + 41539288 (threadpool-worker-default.c:477)
34  MyAPP                      	0x000000010564b910 start_wrapper + 41580816 (threads.c:829)
35  libsystem_pthread.dylib       	0x0000000183ad82b4 _pthread_body + 308
36  libsystem_pthread.dylib       	0x0000000183ad8180 _pthread_body + 0
37  libsystem_pthread.dylib       	0x0000000183ad6b74 thread_start + 4

Thread 15 name:  AVAudioSession Notify Thread
Thread 15:
0   libsystem_kernel.dylib        	0x00000001839a3568 mach_msg_trap + 8
1   libsystem_kernel.dylib        	0x00000001839a33e0 mach_msg + 72
2   CoreFoundation                	0x0000000183e5a308 __CFRunLoopServiceMachPort + 196
3   CoreFoundation                	0x0000000183e57ed4 __CFRunLoopRun + 1424
4   CoreFoundation                	0x0000000183d77e58 CFRunLoopRunSpecific + 436
5   AVFAudio                      	0x00000001896dddc4 GenericRunLoopThread::Entry+ 564676 (void*) + 164
6   AVFAudio                      	0x0000000189708830 CAPThread::Entry+ 739376 (CAPThread*) + 84
7   libsystem_pthread.dylib       	0x0000000183ad82b4 _pthread_body + 308
8   libsystem_pthread.dylib       	0x0000000183ad8180 _pthread_body + 0
9   libsystem_pthread.dylib       	0x0000000183ad6b74 thread_start + 4

Thread 16 name:  Threadpool worker
Thread 16:
0   libsystem_kernel.dylib        	0x00000001839c40f0 __psynch_cvwait + 8
1   libsystem_pthread.dylib       	0x0000000183adef74 _pthread_cond_wait$VARIANT$armv81 + 624
2   MyAPP                      	0x00000001056418b4 worker_thread + 41539764 (mono-os-mutex.h:216)
3   MyAPP                      	0x000000010564b910 start_wrapper + 41580816 (threads.c:829)
4   libsystem_pthread.dylib       	0x0000000183ad82b4 _pthread_body + 308
5   libsystem_pthread.dylib       	0x0000000183ad8180 _pthread_body + 0
6   libsystem_pthread.dylib       	0x0000000183ad6b74 thread_start + 4

Thread 17 name:  Threadpool worker
Thread 17:
0   libsystem_kernel.dylib        	0x00000001839c40f0 __psynch_cvwait + 8
1   libsystem_pthread.dylib       	0x0000000183adef74 _pthread_cond_wait$VARIANT$armv81 + 624
2   MyAPP                      	0x00000001056418b4 worker_thread + 41539764 (mono-os-mutex.h:216)
3   MyAPP                      	0x000000010564b910 start_wrapper + 41580816 (threads.c:829)
4   libsystem_pthread.dylib       	0x0000000183ad82b4 _pthread_body + 308
5   libsystem_pthread.dylib       	0x0000000183ad8180 _pthread_body + 0
6   libsystem_pthread.dylib       	0x0000000183ad6b74 thread_start + 4

Thread 18 name:  tid_7d5f
Thread 18 Crashed:
0   libsystem_kernel.dylib        	0x00000001839c42e8 __pthread_kill + 8
1   libsystem_pthread.dylib       	0x0000000183add748 pthread_kill$VARIANT$armv81 + 360
2   libsystem_c.dylib             	0x0000000183932fbc abort + 140
3   MyAPP                      	0x0000000102eaba7c -[PLCrashReporter generateLiveReportWithThread:] + 0
4   CoreFoundation                	0x0000000183eb26d8 __handleUncaughtException + 628
5   libobjc.A.dylib               	0x00000001830f8804 _objc_terminate+ 34820 () + 112
6   libc++abi.dylib               	0x00000001830e854c std::__terminate(void (*)+ 107852 ()) + 16
7   libc++abi.dylib               	0x00000001830e7ea8 __cxxabiv1::exception_cleanup_func+ 106152 (_Unwind_Reason_Code, _Unwind_Exception*) + 0
8   libobjc.A.dylib               	0x00000001830f865c _objc_exception_destructor+ 34396 (void*) + 0
9   CoreFoundation                	0x0000000183eb19f0 -[__NSSingleObjectEnumerator initWithObject:] + 0
10  UIKit                         	0x000000018d38ac04 -[UIView+ 27652 (Hierarchy) subviews] + 344
11  UIKit                         	0x000000018d67e200 -[UIView+ 3121664 (CALayerDelegate) _wantsReapplicationOfAutoLayoutWithLayoutDirtyOnEntry:] + 72
12  UIKit                         	0x000000018d390f48 -[UIView+ 53064 (CALayerDelegate) layoutSublayersOfLayer:] + 1348
13  QuartzCore                    	0x0000000187ef5998 -[CALayer layoutSublayers] + 184
14  QuartzCore                    	0x0000000187ef9b20 CA::Layer::layout_if_needed+ 1207072 (CA::Transaction*) + 332
15  QuartzCore                    	0x0000000187e6636c CA::Context::commit_transaction+ 602988 (CA::Transaction*) + 336
16  QuartzCore                    	0x0000000187e8db90 CA::Transaction::commit+ 764816 () + 540
17  MyAPP                      	0x00000001046bbcd8 wrapper_managed_to_native_ObjCRuntime_Messaging_void_objc_msgSend_intptr_intptr + 25263320 (/<unknown>:1)
18  MyAPP                      	0x0000000104663ca8 CoreAnimation_CATransaction_Commit + 24902824 (CATransaction.g.cs:89)
19  MyAPP                      	0x000000010453db7c Xamarin_Forms_Platform_iOS_CADisplayLinkTicker_StartThread + 23698300 (/C:\BuildAgent3\work\ca3766cfc22354a1\Xamarin.Forms.Platform.iOS\CADisplayLinkTicker.cs:63)
20  MyAPP                      	0x0000000103a3b33c System_Threading_ThreadHelper_ThreadStart_Context_object + 188
21  MyAPP                      	0x0000000103a38ef4 System_Threading_ExecutionContext_RunInternal_System_Threading_ExecutionContext_System_Threading_ContextCallback_object_bool + 404
22  MyAPP                      	0x0000000103a38d4c System_Threading_ExecutionContext_Run_System_Threading_ExecutionContext_System_Threading_ContextCallback_object_bool + 44
23  MyAPP                      	0x0000000103a38ccc System_Threading_ExecutionContext_Run_System_Threading_ExecutionContext_System_Threading_ContextCallback_object + 76
24  MyAPP                      	0x0000000103a3b4a4 System_Threading_ThreadHelper_ThreadStart + 52
25  MyAPP                      	0x0000000103b981b4 wrapper_runtime_invoke_object_runtime_invoke_dynamic_intptr_intptr_intptr_intptr + 244
26  MyAPP                      	0x00000001055a4b84 mono_jit_runtime_invoke + 40897412 (mini-runtime.c:2526)
27  MyAPP                      	0x000000010561e238 do_runtime_invoke + 41394744 (object.c:2829)
28  MyAPP                      	0x000000010564b934 start_wrapper + 41580852 (threads.c:839)
29  libsystem_pthread.dylib       	0x0000000183ad82b4 _pthread_body + 308
30  libsystem_pthread.dylib       	0x0000000183ad8180 _pthread_body + 0
31  libsystem_pthread.dylib       	0x0000000183ad6b74 thread_start + 4

Thread 19 name:  realTimeStreamf856af9b-04c3-47d9-82ca-898aa5ef80e7
Thread 19:
0   libsystem_kernel.dylib        	0x00000001839c40f0 __psynch_cvwait + 8
1   libsystem_pthread.dylib       	0x0000000183adef74 _pthread_cond_wait$VARIANT$armv81 + 624
2   MyAPP                      	0x0000000105658478 mono_os_cond_timedwait + 41632888 (mono-os-mutex.h:173)
3   MyAPP                      	0x000000010565712c mono_w32handle_timedwait_signal_handle + 41627948 (w32handle.c:976)
4   MyAPP                      	0x0000000105656fdc mono_w32handle_wait_one + 41627612 (w32handle.c:1213)
5   MyAPP                      	0x0000000105610700 ves_icall_System_Threading_Monitor_Monitor_wait + 41338624 (monitor.c:1392)
6   MyAPP                      	0x0000000103a3a908 wrapper_managed_to_native_System_Threading_Monitor_Monitor_wait_object_int + 104
7   MyAPP                      	0x0000000103a3a9b0 System_Threading_Monitor_ObjWait_bool_int_object + 80
8   MyAPP                      	0x0000000103a3a4ac System_Threading_Monitor_Wait_object_int_bool + 44
9   MyAPP                      	0x0000000103a3a530 System_Threading_Monitor_Wait_object + 32
10  MyAPP                      	0x00000001052e83b8 WRQCommon_WRQResponseStream_Read_byte___int_int + 38028216 (WRQResponseStream.cs:261)
11  MyAPP                      	0x00000001039c9b70 System_IO_BinaryReader_FillBuffer_int + 256
12  MyAPP                      	0x00000001039c8964 System_IO_BinaryReader_ReadInt64 + 36
13  MyAPP                      	0x0000000104b002c8 WellDataCommon_Portable_RtDataService_ProtocolDriver + 29737672 (/<unknown>:1)
14  MyAPP                      	0x0000000103a3b33c System_Threading_ThreadHelper_ThreadStart_Context_object + 188
15  MyAPP                      	0x0000000103a38ef4 System_Threading_ExecutionContext_RunInternal_System_Threading_ExecutionContext_System_Threading_ContextCallback_object_bool + 404
16  MyAPP                      	0x0000000103a38d4c System_Threading_ExecutionContext_Run_System_Threading_ExecutionContext_System_Threading_ContextCallback_object_bool + 44
17  MyAPP                      	0x0000000103a38ccc System_Threading_ExecutionContext_Run_System_Threading_ExecutionContext_System_Threading_ContextCallback_object + 76
18  MyAPP                      	0x0000000103a3b4a4 System_Threading_ThreadHelper_ThreadStart + 52
19  MyAPP                      	0x0000000103b981b4 wrapper_runtime_invoke_object_runtime_invoke_dynamic_intptr_intptr_intptr_intptr + 244
20  MyAPP                      	0x00000001055a4b84 mono_jit_runtime_invoke + 40897412 (mini-runtime.c:2526)
21  MyAPP                      	0x000000010561e238 do_runtime_invoke + 41394744 (object.c:2829)
22  MyAPP                      	0x000000010564b934 start_wrapper + 41580852 (threads.c:839)
23  libsystem_pthread.dylib       	0x0000000183ad82b4 _pthread_body + 308
24  libsystem_pthread.dylib       	0x0000000183ad8180 _pthread_body + 0
25  libsystem_pthread.dylib       	0x0000000183ad6b74 thread_start + 4

Thread 20 name:  tid_1222b
Thread 20:
0   libsystem_kernel.dylib        	0x00000001839c4414 __recvfrom + 8
1   MyAPP                      	0x000000010566076c mono_w32socket_recvfrom + 41666412 (w32socket-unix.c:321)
2   MyAPP                      	0x0000000105663900 ves_icall_System_Net_Sockets_Socket_Receive_internal + 41679104 (w32socket.c:1391)
3   MyAPP                      	0x00000001041b0700 wrapper_managed_to_native_System_Net_Sockets_Socket_Receive_internal_intptr_byte___int_int_System_Net_Sockets_SocketFlags_int__bool + 144
4   MyAPP                      	0x00000001041b0624 System_Net_Sockets_Socket_Receive_internal_System_Net_Sockets_SafeSocketHandle_byte___int_int_System_Net_Sockets_SocketFlags_int__bool + 19973668 (Socket.cs:1527)
5   MyAPP                      	0x00000001041af980 System_Net_Sockets_Socket_Receive_byte___int_int_System_Net_Sockets_SocketFlags_System_Net_Sockets_SocketError_ + 19970432 (Socket.cs:1312)
6   MyAPP                      	0x00000001041a9d30 System_Net_Sockets_Socket_Receive_byte___int_int_System_Net_Sockets_SocketFlags + 19946800 (Socket.cs:1769)
7   MyAPP                      	0x00000001041a5b14 System_Net_Sockets_NetworkStream_Read_byte___int_int + 19929876 (NetworkStream.cs:513)
8   MyAPP                      	0x00000001040bfa18 Mono_Net_Security_MobileAuthenticatedStream_InnerRead_int + 18987544 (MobileAuthenticatedStream.cs:530)
9   MyAPP                      	0x00000001040bc590 Mono_Net_Security_AsyncProtocolRequest_ProcessOperation_Mono_Net_Security_AsyncOperationStatus + 18974096 (AsyncProtocolRequest.cs:253)
10  MyAPP                      	0x00000001040bc438 Mono_Net_Security_AsyncProtocolRequest_ProcessOperation + 18973752 (AsyncProtocolRequest.cs:218)
11  MyAPP                      	0x00000001040bc2c8 Mono_Net_Security_AsyncProtocolRequest_StartOperation + 18973384 (AsyncProtocolRequest.cs:200)
12  MyAPP                      	0x00000001040bc1e0 Mono_Net_Security_AsyncProtocolRequest_StartOperation_Mono_Net_Security_AsyncOperation + 18973152 (AsyncProtocolRequest.cs:190)
13  MyAPP                      	0x00000001040bf498 Mono_Net_Security_MobileAuthenticatedStream_StartOperation_Mono_Net_Security_AsyncProtocolRequest__Mono_Net_Security_BufferOffsetSize2__Mono_Net_Security_AsyncOperation_Mono_Net_Security_AsyncProtocolRequest_string + 18986136 (MobileAuthenticatedStream.cs:365)
14  MyAPP                      	0x00000001040bf344 Mono_Net_Security_MobileAuthenticatedStream_ProcessReadOrWrite_Mono_Net_Security_AsyncProtocolRequest__Mono_Net_Security_BufferOffsetSize2__Mono_Net_Security_AsyncOperation_Mono_Net_Security_BufferOffsetSize_System_Net_LazyAsyncResult + 18985796 (MobileAuthenticatedStream.cs:353)
15  MyAPP                      	0x00000001040bee2c Mono_Net_Security_MobileAuthenticatedStream_Read_byte___int_int + 18984492 (MobileAuthenticatedStream.cs:293)
16  MyAPP                      	0x00000001041bff24 System_Net_Security_SslStream_Read_byte___int_int + 20037412 (SslStream.cs:353)
17  MyAPP                      	0x00000001039c9b70 System_IO_BinaryReader_FillBuffer_int + 256
18  MyAPP                      	0x00000001039c87c4 System_IO_BinaryReader_ReadInt32 + 164
19  MyAPP                      	0x00000001054b31f0 WRQClient_WRQStreamClient_ProcessStreamContent_object + 39907824 (WRQClient.cs:301)
20  MyAPP                      	0x0000000103a3b380 System_Threading_ThreadHelper_ThreadStart_Context_object + 256
21  MyAPP                      	0x0000000103a38ef4 System_Threading_ExecutionContext_RunInternal_System_Threading_ExecutionContext_System_Threading_ContextCallback_object_bool + 404
22  MyAPP                      	0x0000000103a38d4c System_Threading_ExecutionContext_Run_System_Threading_ExecutionContext_System_Threading_ContextCallback_object_bool + 44
23  MyAPP                      	0x0000000103a38ccc System_Threading_ExecutionContext_Run_System_Threading_ExecutionContext_System_Threading_ContextCallback_object + 76
24  MyAPP                      	0x0000000103a3b40c System_Threading_ThreadHelper_ThreadStart_object + 108
25  MyAPP                      	0x0000000103b981b4 wrapper_runtime_invoke_object_runtime_invoke_dynamic_intptr_intptr_intptr_intptr + 244
26  MyAPP                      	0x00000001055a4b84 mono_jit_runtime_invoke + 40897412 (mini-runtime.c:2526)
27  MyAPP                      	0x000000010561e238 do_runtime_invoke + 41394744 (object.c:2829)
28  MyAPP                      	0x000000010564b934 start_wrapper + 41580852 (threads.c:839)
29  libsystem_pthread.dylib       	0x0000000183ad82b4 _pthread_body + 308
30  libsystem_pthread.dylib       	0x0000000183ad8180 _pthread_body + 0
31  libsystem_pthread.dylib       	0x0000000183ad6b74 thread_start + 4

Thread 21 name:  Threadpool worker
Thread 21:
0   libsystem_kernel.dylib        	0x00000001839c40f0 __psynch_cvwait + 8
1   libsystem_pthread.dylib       	0x0000000183adef74 _pthread_cond_wait$VARIANT$armv81 + 624
2   MyAPP                      	0x00000001056418b4 worker_thread + 41539764 (mono-os-mutex.h:216)
3   MyAPP                      	0x000000010564b910 start_wrapper + 41580816 (threads.c:829)
4   libsystem_pthread.dylib       	0x0000000183ad82b4 _pthread_body + 308
5   libsystem_pthread.dylib       	0x0000000183ad8180 _pthread_body + 0
6   libsystem_pthread.dylib       	0x0000000183ad6b74 thread_start + 4

Thread 22 name:  Threadpool worker
Thread 22:
0   libsystem_kernel.dylib        	0x00000001839c40f0 __psynch_cvwait + 8
1   libsystem_pthread.dylib       	0x0000000183adef74 _pthread_cond_wait$VARIANT$armv81 + 624
2   MyAPP                      	0x00000001056418b4 worker_thread + 41539764 (mono-os-mutex.h:216)
3   MyAPP                      	0x000000010564b910 start_wrapper + 41580816 (threads.c:829)
4   libsystem_pthread.dylib       	0x0000000183ad82b4 _pthread_body + 308
5   libsystem_pthread.dylib       	0x0000000183ad8180 _pthread_body + 0
6   libsystem_pthread.dylib       	0x0000000183ad6b74 thread_start + 4

Thread 23 name:  tid_d03b
Thread 23:
0   libsystem_kernel.dylib        	0x00000001839c40f0 __psynch_cvwait + 8
1   libsystem_pthread.dylib       	0x0000000183adef74 _pthread_cond_wait$VARIANT$armv81 + 624
2   MyAPP                      	0x00000001056b444c mono_thread_info_sleep + 42009676 (mono-os-mutex.h:216)
3   MyAPP                      	0x00000001056412b8 monitor_thread + 41538232 (threadpool-worker-default.c:693)
4   MyAPP                      	0x000000010564b910 start_wrapper + 41580816 (threads.c:829)
5   libsystem_pthread.dylib       	0x0000000183ad82b4 _pthread_body + 308
6   libsystem_pthread.dylib       	0x0000000183ad8180 _pthread_body + 0
7   libsystem_pthread.dylib       	0x0000000183ad6b74 thread_start + 4

Thread 18 crashed with ARM Thread State (64-bit):
    x0: 0x0000000000000000   x1: 0x0000000000000000   x2: 0x0000000000000000   x3: 0xffffffffffffffff
    x4: 0x0000000000000010   x5: 0x0000000000002b87   x6: 0x00000001d0382be0   x7: 0x0000000000002b88
    x8: 0x0000000008000000   x9: 0x0000000004000000  x10: 0x0000000183add5e0  x11: 0x00000001b743a004
   x12: 0x00000001b743a004  x13: 0x0000000000000018  x14: 0x0000000000000001  x15: 0x0000000000000881
   x16: 0x0000000000000148  x17: 0x0000000000000000  x18: 0xfffffff0146dd260  x19: 0x0000000000000006
   x20: 0x000000016ec27000  x21: 0x00000001c42a0fc0  x22: 0x0000000000007d5f  x23: 0x000000016ec270e0
   x24: 0x00000001b5118000  x25: 0x000000018e1275fe  x26: 0x000000018e1313b5  x27: 0x0000000183f4a23f
   x28: 0x00000001b384ea18   fp: 0x000000016ec22d80   lr: 0x0000000183add748
    sp: 0x000000016ec22d50   pc: 0x00000001839c42e8 cpsr: 0x00000000

Binary Images:
0x102ea4000 - 0x1057e7fff MyAPP arm64  <2e9158b4942a3684976ad9088358b3f4> /var/containers/Bundle/Application/CF6854E5-6845-4FFE-A853-AF998E517D4E/MyAPP.app/MyAPP
0x105c28000 - 0x105c67fff dyld arm64  <477a8a1f098b3a80860d656a3f4918ea> /usr/lib/dyld
0x105cc4000 - 0x1061bbfff libSkiaSharp arm64  <fbe96e043c7f3abeb2382c3152221eec> /var/containers/Bundle/Application/CF6854E5-6845-4FFE-A853-AF998E517D4E/MyAPP.app/Frameworks/libSkiaSharp.framework/libSkiaSharp
0x183072000 - 0x183073fff libSystem.B.dylib arm64  <f1a8dae6cdac3bdeb67f9a56e4acb0d0> /usr/lib/libSystem.B.dylib
0x183074000 - 0x1830cdfff libc++.1.dylib arm64  <aee157a049663aa88c4e928768cfd553> /usr/lib/libc++.1.dylib
0x1830ce000 - 0x1830eefff libc++abi.dylib arm64  <b4f54419327f3bfea747549b84dad328> /usr/lib/libc++abi.dylib
0x1830f0000 - 0x1837abfff libobjc.A.dylib arm64  <3a9d464322eb3285bc88fabf7cec20ed> /usr/lib/libobjc.A.dylib
0x1837ac000 - 0x1837b0fff libcache.dylib arm64  <5d31b020cbde3110981e6a8213297535> /usr/lib/system/libcache.dylib
0x1837b1000 - 0x1837bcfff libcommonCrypto.dylib arm64  <5fcc43ca8cd9305091129711db270b8c> /usr/lib/system/libcommonCrypto.dylib
0x1837bd000 - 0x1837c0fff libcompiler_rt.dylib arm64  <49e30d90aab53f8a99c9109db350ae39> /usr/lib/system/libcompiler_rt.dylib
0x1837c1000 - 0x1837c8fff libcopyfile.dylib arm64  <bc50a65225833e458ae22db52300bf10> /usr/lib/system/libcopyfile.dylib
0x1837c9000 - 0x18382cfff libcorecrypto.dylib arm64  <1647a3e06adc30b3b8f8298f897d6e87> /usr/lib/system/libcorecrypto.dylib
0x18382d000 - 0x183892fff libdispatch.dylib arm64  <25e5e6ee10093937b122c4b509716294> /usr/lib/system/libdispatch.dylib
0x183893000 - 0x1838adfff libdyld.dylib arm64  <aa89b903caf232bebaea4294ee62a6d2> /usr/lib/system/libdyld.dylib
0x1838ae000 - 0x1838aefff liblaunch.dylib arm64  <ca90373a022d3c38ac7ecd736c13bf9b> /usr/lib/system/liblaunch.dylib
0x1838af000 - 0x1838b4fff libmacho.dylib arm64  <5cf371e4795437008e8ba71f7c18c3e0> /usr/lib/system/libmacho.dylib
0x1838b5000 - 0x1838b6fff libremovefile.dylib arm64  <1f6279ea185b39ebab0412f03836952f> /usr/lib/system/libremovefile.dylib
0x1838b7000 - 0x1838cefff libsystem_asl.dylib arm64  <dd425157f17d3c428245da87b0d36205> /usr/lib/system/libsystem_asl.dylib
0x1838cf000 - 0x1838cffff libsystem_blocks.dylib arm64  <93403bb53b293e748a97895ea5d99def> /usr/lib/system/libsystem_blocks.dylib
0x1838d0000 - 0x18394dfff libsystem_c.dylib arm64  <400d9d205a453ab49971ab4bebbff01c> /usr/lib/system/libsystem_c.dylib
0x18394e000 - 0x183952fff libsystem_configuration.dylib arm64  <1d864850ea2a32d6bb44b37cff02883c> /usr/lib/system/libsystem_configuration.dylib
0x183953000 - 0x183958fff libsystem_containermanager.dylib arm64  <fc551cabe5a334c1b09a49278900e46a> /usr/lib/system/libsystem_containermanager.dylib
0x183959000 - 0x18395afff libsystem_coreservices.dylib arm64  <367354d549a434efb82345e4010ae363> /usr/lib/system/libsystem_coreservices.dylib
0x18395b000 - 0x18395cfff libsystem_darwin.dylib arm64  <74d54bc023a2320a9d93943806b0c19e> /usr/lib/system/libsystem_darwin.dylib
0x18395d000 - 0x183963fff libsystem_dnssd.dylib arm64  <5c8c5aaa95393d4e8492379ff9efb960> /usr/lib/system/libsystem_dnssd.dylib
0x183964000 - 0x1839a1fff libsystem_info.dylib arm64  <a844d2a933a93a0ea78b2aa73be718ea> /usr/lib/system/libsystem_info.dylib
0x1839a2000 - 0x1839cafff libsystem_kernel.dylib arm64  <1eb83b93d8e5382fa3692c4db5c8425e> /usr/lib/system/libsystem_kernel.dylib
0x1839cb000 - 0x1839f8fff libsystem_m.dylib arm64  <fec251da685c39678cddf31fc925050a> /usr/lib/system/libsystem_m.dylib
0x1839f9000 - 0x183a13fff libsystem_malloc.dylib arm64  <4867a62768f93413a9e9da35906b4624> /usr/lib/system/libsystem_malloc.dylib
0x183a14000 - 0x183ab4fff libsystem_network.dylib arm64  <27058056b60a3c5b9f7dd945f07ced58> /usr/lib/system/libsystem_network.dylib
0x183ab5000 - 0x183ac0fff libsystem_networkextension.dylib arm64  <26f9a6394d763402add762982498e16d> /usr/lib/system/libsystem_networkextension.dylib
0x183ac1000 - 0x183acbfff libsystem_notify.dylib arm64  <f4a564bb65e13f7fa40a7b3e7b400e16> /usr/lib/system/libsystem_notify.dylib
0x183acc000 - 0x183ad5fff libsystem_platform.dylib arm64  <5bdfc85463ac3da5976bdb230cc9904e> /usr/lib/system/libsystem_platform.dylib
0x183ad6000 - 0x183ae5fff libsystem_pthread.dylib arm64  <ec07a01f70933f629bb77dfa516eac50> /usr/lib/system/libsystem_pthread.dylib
0x183ae6000 - 0x183ae9fff libsystem_sandbox.dylib arm64  <c207a17a12a03d92aaa44fb3d7bb4664> /usr/lib/system/libsystem_sandbox.dylib
0x183aea000 - 0x183af1fff libsystem_symptoms.dylib arm64  <e2f659feb4f33387951c4e76e64be23d> /usr/lib/system/libsystem_symptoms.dylib
0x183af2000 - 0x183b05fff libsystem_trace.dylib arm64  <291c25bcc2ee33259698edefb7e76a1f> /usr/lib/system/libsystem_trace.dylib
0x183b06000 - 0x183b0bfff libunwind.dylib arm64  <db0499e29a383530972aec98f7b20450> /usr/lib/system/libunwind.dylib
0x183b0c000 - 0x183b0cfff libvminterpose.dylib arm64  <d51048b4b2573b18875138004e66b83d> /usr/lib/system/libvminterpose.dylib
0x183b0d000 - 0x183b37fff libxpc.dylib arm64  <ad6af358f21c3fd9a171d66c6fcc1e0d> /usr/lib/system/libxpc.dylib
0x183b38000 - 0x183d59fff libicucore.A.dylib arm64  <32c272e1e9f735aba4c16a17580f13e3> /usr/lib/libicucore.A.dylib
0x183d5a000 - 0x183d6bfff libz.1.dylib arm64  <c402ff63470b34df8634f2078cd151e1> /usr/lib/libz.1.dylib
0x183d6c000 - 0x184104fff CoreFoundation arm64  <733e7542e92b34bd9403762135ad5014> /System/Library/Frameworks/CoreFoundation.framework/CoreFoundation
0x184105000 - 0x184115fff libbsm.0.dylib arm64  <b7a56e43a852351d8a2dab94c7fc04e6> /usr/lib/libbsm.0.dylib
0x184116000 - 0x184116fff libenergytrace.dylib arm64  <6adeca3b70ed33dda70a16353c5ef6ce> /usr/lib/libenergytrace.dylib
0x184117000 - 0x18419cfff IOKit arm64  <9e81333d12bd3d06bfdcaa867f2035da> /System/Library/Frameworks/IOKit.framework/Versions/A/IOKit
0x18419d000 - 0x184286fff libxml2.2.dylib arm64  <33530216f58333d993d4acb846c63aac> /usr/lib/libxml2.2.dylib
0x184287000 - 0x184294fff libbz2.1.0.dylib arm64  <35c6ddde076638589f755656ac0058ce> /usr/lib/libbz2.1.0.dylib
0x184295000 - 0x1842adfff liblzma.5.dylib arm64  <7d5815f117103d15a67fd30b3375b11b> /usr/lib/liblzma.5.dylib
0x1842ae000 - 0x18440bfff libsqlite3.dylib arm64  <eac933b033d43444ae182e2d7de6137f> /usr/lib/libsqlite3.dylib
0x18440c000 - 0x184432fff libMobileGestalt.dylib arm64  <9c73d51ef65330e3b29fa4ec81169863> /usr/lib/libMobileGestalt.dylib
0x184433000 - 0x1847a0fff CFNetwork arm64  <fd66a1913ddd34f89f00756cf3147246> /System/Library/Frameworks/CFNetwork.framework/CFNetwork
0x1847a1000 - 0x184a9cfff Foundation arm64  <b0f8df9777ec36008a9f35035b889efd> /System/Library/Frameworks/Foundation.framework/Foundation
0x184a9d000 - 0x184b8bfff Security arm64  <f8097c91a8623fbda138a402b6151ca2> /System/Library/Frameworks/Security.framework/Security
0x184b8c000 - 0x184bf8fff SystemConfiguration arm64  <13d55604fde63c2e96df89e8d6e84fe6> /System/Library/Frameworks/SystemConfiguration.framework/SystemConfiguration
0x184bf9000 - 0x184c2ffff libCRFSuite.dylib arm64  <12e6cdcbfa43330da4fa268f1662bf39> /usr/lib/libCRFSuite.dylib
0x184c30000 - 0x184c30fff libapple_crypto.dylib arm64  <26fe924005203d45aee4a14f5cb64434> /usr/lib/libapple_crypto.dylib
0x184c31000 - 0x184c47fff libapple_nghttp2.dylib arm64  <ff88135792b639679509b309f0c0cad9> /usr/lib/libapple_nghttp2.dylib
0x184c48000 - 0x184c71fff libarchive.2.dylib arm64  <957aea53942d3afc91420044f6ae5112> /usr/lib/libarchive.2.dylib
0x184c72000 - 0x184d23fff libboringssl.dylib arm64  <3c4640e6332d3b44a79759034630ce2a> /usr/lib/libboringssl.dylib
0x184d24000 - 0x184d3bfff libcoretls.dylib arm64  <c2287d06413f32c2aee0e6c3313d98c7> /usr/lib/libcoretls.dylib
0x184d3c000 - 0x184d3dfff libcoretls_cfhelpers.dylib arm64  <503fb7729cbe382ea1e0a315e7bd87ba> /usr/lib/libcoretls_cfhelpers.dylib
0x184d3e000 - 0x184d3ffff liblangid.dylib arm64  <11d94ede5ab1300a820d96e3374f53fa> /usr/lib/liblangid.dylib
0x184d40000 - 0x184e13fff libnetwork.dylib arm64  <ba7d2d20eb3a32ac802209e5f7008280> /usr/lib/libnetwork.dylib
0x184e14000 - 0x184e46fff libpcap.A.dylib arm64  <419a8dd2325a326c81b4b02d849ce562> /usr/lib/libpcap.A.dylib
0x184e47000 - 0x184e7bfff libusrtcp.dylib arm64  <227ec64866e53676828e76f89c1e4928> /usr/lib/libusrtcp.dylib
0x184e7c000 - 0x184e85fff IOSurface arm64  <121f7f9d94d63afb8974ca4b14aadbbf> /System/Library/Frameworks/IOSurface.framework/IOSurface
0x184e86000 - 0x184f2bfff libBLAS.dylib arm64  <05ecdd31f9573a069c0e8b3d610bbc3f> /System/Library/Frameworks/Accelerate.framework/Frameworks/vecLib.framework/libBLAS.dylib
0x184f2c000 - 0x18525bfff libLAPACK.dylib arm64  <3e55f73c8a4c329d8bb7f5e58ed687c3> /System/Library/Frameworks/Accelerate.framework/Frameworks/vecLib.framework/libLAPACK.dylib
0x18525c000 - 0x1854c8fff vImage arm64  <7fabce5d1fe83c38aa998440146eb09b> /System/Library/Frameworks/Accelerate.framework/Frameworks/vImage.framework/vImage
0x1854c9000 - 0x1854dafff libSparseBLAS.dylib arm64  <88335b280db13b3d812ee89998bc363c> /System/Library/Frameworks/Accelerate.framework/Frameworks/vecLib.framework/libSparseBLAS.dylib
0x1854db000 - 0x1854fffff libvMisc.dylib arm64  <20da313fe2343db189a04c72928eb120> /System/Library/Frameworks/Accelerate.framework/Frameworks/vecLib.framework/libvMisc.dylib
0x185500000 - 0x18552afff libBNNS.dylib arm64  <19481dd658fb3f949cc1874250cfead5> /System/Library/Frameworks/Accelerate.framework/Frameworks/vecLib.framework/libBNNS.dylib
0x18552b000 - 0x185540fff libLinearAlgebra.dylib arm64  <0f6e8d5a7dd8384ebb8a873c2caa7ad7> /System/Library/Frameworks/Accelerate.framework/Frameworks/vecLib.framework/libLinearAlgebra.dylib
0x185541000 - 0x185545fff libQuadrature.dylib arm64  <124a57c41e3e3956b46e10d49ddf8fe1> /System/Library/Frameworks/Accelerate.framework/Frameworks/vecLib.framework/libQuadrature.dylib
0x185546000 - 0x18559cfff libSparse.dylib arm64  <c7def66b4a4c3f29b55fcbdcf881e3f2> /System/Library/Frameworks/Accelerate.framework/Frameworks/vecLib.framework/libSparse.dylib
0x18559d000 - 0x185615fff libvDSP.dylib arm64  <4bf846f47a0e309db93bbbc791720463> /System/Library/Frameworks/Accelerate.framework/Frameworks/vecLib.framework/libvDSP.dylib
0x185616000 - 0x185616fff vecLib arm64  <86cdd48d842334dd831b1fc0e2b0270f> /System/Library/Frameworks/Accelerate.framework/Frameworks/vecLib.framework/vecLib
0x185617000 - 0x185617fff Accelerate arm64  <01d515c3376c332799f14694934ed70b> /System/Library/Frameworks/Accelerate.framework/Accelerate
0x185618000 - 0x18562dfff libcompression.dylib arm64  <b1a3a8c4b3a6301da874dc2af4a50920> /usr/lib/libcompression.dylib
0x18562e000 - 0x185b72fff CoreGraphics arm64  <84200292e2373b96bde75a022c9eeacf> /System/Library/Frameworks/CoreGraphics.framework/CoreGraphics
0x185b73000 - 0x185b78fff IOAccelerator arm64  <e66452fc19ef3af29dac52b16e6cb128> /System/Library/PrivateFrameworks/IOAccelerator.framework/IOAccelerator
0x185b79000 - 0x185b7efff libCoreFSCache.dylib arm64  <ac1882646b0c3cccb69dfc5246995396> /System/Library/Frameworks/OpenGLES.framework/libCoreFSCache.dylib
0x185b7f000 - 0x185c19fff Metal arm64  <ef4fbbbcfa2b38928f3c8ec471c8cde6> /System/Library/Frameworks/Metal.framework/Metal
0x185c1a000 - 0x185c2dfff GraphicsServices arm64  <60c9cc9a0df43872a837f0ddb03140a5> /System/Library/PrivateFrameworks/GraphicsServices.framework/GraphicsServices
0x185c2e000 - 0x185d86fff MobileCoreServices arm64  <dcdc67868d5a370185e0242a11a54054> /System/Library/Frameworks/MobileCoreServices.framework/MobileCoreServices
0x185d87000 - 0x185d89fff IOSurfaceAccelerator arm64  <cf8349e45ac1355386a2d94794f075e4> /System/Library/PrivateFrameworks/IOSurfaceAccelerator.framework/IOSurfaceAccelerator
0x185d8a000 - 0x185dcbfff AppleJPEG arm64  <9ee4b3efde073642af80e42915e2f46c> /System/Library/PrivateFrameworks/AppleJPEG.framework/AppleJPEG
0x185dcc000 - 0x18637cfff ImageIO arm64  <ab5dbbc48a64389487f5572f13867857> /System/Library/Frameworks/ImageIO.framework/ImageIO
0x18637d000 - 0x1863e1fff BaseBoard arm64  <763fe7d346a337e68e1b067d7359b9f6> /System/Library/PrivateFrameworks/BaseBoard.framework/BaseBoard
0x1863e2000 - 0x1863f9fff AssertionServices arm64  <eac3dcdc35103304b3dc72ce0c8a0a07> /System/Library/PrivateFrameworks/AssertionServices.framework/AssertionServices
0x1863fa000 - 0x186402fff CorePhoneNumbers arm64  <d4693a21c4e83fb09a52ddb833dc793c> /System/Library/PrivateFrameworks/CorePhoneNumbers.framework/CorePhoneNumbers
0x186403000 - 0x186447fff AppSupport arm64  <8f2f75f2c4853c7e8e7d9739e12d45cd> /System/Library/PrivateFrameworks/AppSupport.framework/AppSupport
0x186448000 - 0x186460fff CrashReporterSupport arm64  <18930e85456c3eb39fe19a4fe0a7d171> /System/Library/PrivateFrameworks/CrashReporterSupport.framework/CrashReporterSupport
0x186461000 - 0x186466fff AggregateDictionary arm64  <95f98162fc7836268686104aabee8c12> /System/Library/PrivateFrameworks/AggregateDictionary.framework/AggregateDictionary
0x186467000 - 0x1864e8fff libTelephonyUtilDynamic.dylib arm64  <0d366024d6da340a93979ccdec97be29> /usr/lib/libTelephonyUtilDynamic.dylib
0x1864e9000 - 0x186508fff ProtocolBuffer arm64  <9bf97e1248b13b959d7a10a0dc8bcaf7> /System/Library/PrivateFrameworks/ProtocolBuffer.framework/ProtocolBuffer
0x186509000 - 0x186534fff MobileKeyBag arm64  <f7fe398063d1384291d2c0f09c64e9e1> /System/Library/PrivateFrameworks/MobileKeyBag.framework/MobileKeyBag
0x186535000 - 0x186569fff BackBoardServices arm64  <6c304c21d68037e9b0646f0deb25ca58> /System/Library/PrivateFrameworks/BackBoardServices.framework/BackBoardServices
0x18656a000 - 0x1865c5fff FrontBoardServices arm64  <6fb061c48f653be48d29f133e1cda578> /System/Library/PrivateFrameworks/FrontBoardServices.framework/FrontBoardServices
0x1865c6000 - 0x186602fff SpringBoardServices arm64  <21b76097326c3a008eed2a77084a3f1e> /System/Library/PrivateFrameworks/SpringBoardServices.framework/SpringBoardServices
0x186603000 - 0x186611fff PowerLog arm64  <b88d155999433dfb9850b7159809529e> /System/Library/PrivateFrameworks/PowerLog.framework/PowerLog
0x186612000 - 0x18662ffff CommonUtilities arm64  <c93c41c50d3f3f48865808dbc37f3b8a> /System/Library/PrivateFrameworks/CommonUtilities.framework/CommonUtilities
0x186630000 - 0x18663bfff liblockdown.dylib arm64  <3f0340a84dc533789f81ee18818c6564> /usr/lib/liblockdown.dylib
0x18663c000 - 0x18693efff CoreData arm64  <2228ace9ad8e381893664325ab627965> /System/Library/Frameworks/CoreData.framework/CoreData
0x18693f000 - 0x186945fff TCC arm64  <a26916f3c09f332da85ef22df54c9862> /System/Library/PrivateFrameworks/TCC.framework/TCC
0x186946000 - 0x18694dfff libcupolicy.dylib arm64  <3ebba1ecd87a340ba782af975c9ca4bb> /usr/lib/libcupolicy.dylib
0x18694e000 - 0x1869dafff CoreTelephony arm64  <07b9ce765862308bbe70a691fcabb505> /System/Library/Frameworks/CoreTelephony.framework/CoreTelephony
0x1869db000 - 0x186a31fff Accounts arm64  <6847536ea2373c7388fb9081c9dbbadd> /System/Library/Frameworks/Accounts.framework/Accounts
0x186a32000 - 0x186a5bfff AppleSauce arm64  <3bbfd85a193f3a529cd5fa4ce93b6a87> /System/Library/PrivateFrameworks/AppleSauce.framework/AppleSauce
0x186a5c000 - 0x186a64fff DataMigration arm64  <241a0384f6d630b496686b1f454a82e4> /System/Library/PrivateFrameworks/DataMigration.framework/DataMigration
0x186a65000 - 0x186a6bfff Netrb arm64  <eff36ad08b493f15a80e93aa57cb7672> /System/Library/PrivateFrameworks/Netrb.framework/Netrb
0x186a6c000 - 0x186a9ffff PersistentConnection arm64  <e053741bde6f318b93de7c35c2a9db61> /System/Library/PrivateFrameworks/PersistentConnection.framework/PersistentConnection
0x186aa0000 - 0x186ab1fff libmis.dylib arm64  <f864082f4e9b3830a0e050fce4352f14> /usr/lib/libmis.dylib
0x186ab2000 - 0x186bb2fff ManagedConfiguration arm64  <cc35838fdd2939999a226213f56ab5e9> /System/Library/PrivateFrameworks/ManagedConfiguration.framework/ManagedConfiguration
0x186bb3000 - 0x186bb8fff libReverseProxyDevice.dylib arm64  <8578d96ba38c3027ba0d802eba838736> /usr/lib/libReverseProxyDevice.dylib
0x186bb9000 - 0x186bcafff libamsupport.dylib arm64  <aefcd7ec80cf32ffb612b2d508ec4434> /usr/lib/libamsupport.dylib
0x186bcb000 - 0x186bd0fff libCoreVMClient.dylib arm64  <017bacb6b7e83fdda154764e0492358a> /System/Library/Frameworks/OpenGLES.framework/libCoreVMClient.dylib
0x186bd1000 - 0x186bd2fff libCVMSPluginSupport.dylib arm64  <0ea33c2e6344361db9a3c8fa83948ebe> /System/Library/Frameworks/OpenGLES.framework/libCVMSPluginSupport.dylib
0x186bd3000 - 0x186bd6fff libutil.dylib arm64  <b82455fcf10c34ddbe0871d7e6998071> /usr/lib/libutil.dylib
0x186bd7000 - 0x186c18fff libGLImage.dylib arm64  <9ac83085267733acb9bc652dd70dcc2d> /System/Library/Frameworks/OpenGLES.framework/libGLImage.dylib
0x186c19000 - 0x186c89fff APFS arm64  <b37bd4abf8fc37f985190265ad8dca3e> /System/Library/PrivateFrameworks/APFS.framework/APFS
0x186c8a000 - 0x186cbbfff MediaKit arm64  <41ac5f40d9c43b5cad406fd5ec592d31> /System/Library/PrivateFrameworks/MediaKit.framework/MediaKit
0x186cbc000 - 0x186cd4fff libSERestoreInfo.dylib arm64  <73db2cd529163f2591a962e7d2911a53> /usr/lib/updaters/libSERestoreInfo.dylib
0x186cd9000 - 0x186d15fff DiskImages arm64  <4bc2acb597e63ef3a3ac9225ec7ab2f3> /System/Library/PrivateFrameworks/DiskImages.framework/DiskImages
0x186d16000 - 0x186d20fff libGFXShared.dylib arm64  <f53963ffa07f3455a080784a939f3027> /System/Library/Frameworks/OpenGLES.framework/libGFXShared.dylib
0x186d21000 - 0x186d67fff libauthinstall.dylib arm64  <d769efe64c5a3b519087c768cd609565> /usr/lib/libauthinstall.dylib
0x186d68000 - 0x186d70fff IOMobileFramebuffer arm64  <c293967d42ae3c1bae785619369433bd> /System/Library/PrivateFrameworks/IOMobileFramebuffer.framework/IOMobileFramebuffer
0x186d71000 - 0x186d7cfff OpenGLES arm64  <1d31b8472eef34d1a8bbd0cefa8c7927> /System/Library/Frameworks/OpenGLES.framework/OpenGLES
0x186d7d000 - 0x186e04fff ColorSync arm64  <33046de8138635a29227b3a477d00dd7> /System/Library/PrivateFrameworks/ColorSync.framework/ColorSync
0x186e05000 - 0x186e2ffff CoreVideo arm64  <6b2310090f9b37f5baf0378866ec978d> /System/Library/Frameworks/CoreVideo.framework/CoreVideo
0x186e30000 - 0x186e31fff libCTGreenTeaLogger.dylib arm64  <a549a1b35b8236b9bc0962cee0afc366> /usr/lib/libCTGreenTeaLogger.dylib
0x186e32000 - 0x186f94fff CoreAudio arm64  <c5554e700acf38d58cdfe448135184c5> /System/Library/Frameworks/CoreAudio.framework/CoreAudio
0x186f95000 - 0x186fc3fff CoreAnalytics arm64  <8300701d98d7319689110ee40b2120b5> /System/Library/PrivateFrameworks/CoreAnalytics.framework/CoreAnalytics
0x186fc4000 - 0x186fc7fff UserFS arm64  <0470e2fc32c0303c816947cdb954d434> /System/Library/PrivateFrameworks/UserFS.framework/UserFS
0x186fc8000 - 0x18713bfff CoreMedia arm64  <f965487a47cd36b4a0655cbea8768cf2> /System/Library/Frameworks/CoreMedia.framework/CoreMedia
0x18713c000 - 0x18714efff libprotobuf-lite.dylib arm64  <2ed5fd0c82f8337b96e17a7b1846b878> /usr/lib/libprotobuf-lite.dylib
0x18714f000 - 0x1871b3fff libprotobuf.dylib arm64  <0a967243387e32aeb31a8b5ceeac3718> /usr/lib/libprotobuf.dylib
0x1871b4000 - 0x187491fff libAWDSupportFramework.dylib arm64  <db0f4644d45938e39bdace7ecc5c6eeb> /usr/lib/libAWDSupportFramework.dylib
0x187492000 - 0x1874d8fff WirelessDiagnostics arm64  <24442ae5cff4329fad51f2efd6cb9ec9> /System/Library/PrivateFrameworks/WirelessDiagnostics.framework/WirelessDiagnostics
0x1874d9000 - 0x187591fff VideoToolbox arm64  <14ee6431977f31b2a349496d8b2b812d> /System/Library/Frameworks/VideoToolbox.framework/VideoToolbox
0x187592000 - 0x18769dfff libFontParser.dylib arm64  <21220ffc653432808d5d09df7698e61b> /System/Library/PrivateFrameworks/FontServices.framework/libFontParser.dylib
0x18769e000 - 0x18769ffff FontServices arm64  <e17c3dd6d3733750a4a1b82ac527ba53> /System/Library/PrivateFrameworks/FontServices.framework/FontServices
0x1876a0000 - 0x1877effff CoreText arm64  <dbab05410da4301782ad6922d55546a0> /System/Library/Frameworks/CoreText.framework/CoreText
0x1877f0000 - 0x1877fffff IntlPreferences arm64  <7aafcdb73e8e3a7690ea5b2cf667afaa> /System/Library/PrivateFrameworks/IntlPreferences.framework/IntlPreferences
0x187800000 - 0x187808fff RTCReporting arm64  <278400bd508c38768e2972eb594ab959> /System/Library/PrivateFrameworks/RTCReporting.framework/RTCReporting
0x187809000 - 0x187876fff CoreBrightness arm64  <95be0f7b665835619b8a4fca3388ec48> /System/Library/PrivateFrameworks/CoreBrightness.framework/CoreBrightness
0x187877000 - 0x187882fff libAudioStatistics.dylib arm64  <3d794f8dcc493d2195d6929f4d09b38d> /usr/lib/libAudioStatistics.dylib
0x187883000 - 0x187dd2fff AudioToolbox arm64  <5856a9cad5ad3f88ae48a2c580dccc0c> /System/Library/Frameworks/AudioToolbox.framework/AudioToolbox
0x187dd3000 - 0x188003fff QuartzCore arm64  <66977459f63f39ac96813aef68ff0eaf> /System/Library/Frameworks/QuartzCore.framework/QuartzCore
0x188004000 - 0x18800ffff MediaAccessibility arm64  <78f4363eea97331495885cfaddd39d12> /System/Library/Frameworks/MediaAccessibility.framework/MediaAccessibility
0x188010000 - 0x188102fff libiconv.2.dylib arm64  <28fec549f7f6396483fb3b04c800adcb> /usr/lib/libiconv.2.dylib
0x188103000 - 0x18811ffff NetworkStatistics arm64  <73ff6f9af8f43ec5bbb4772b6d7c6671> /System/Library/PrivateFrameworks/NetworkStatistics.framework/NetworkStatistics
0x188120000 - 0x188135fff MPSCore arm64  <f17598623cb432f2a175ce166396bbea> /System/Library/Frameworks/MetalPerformanceShaders.framework/Frameworks/MPSCore.framework/MPSCore
0x188136000 - 0x18819afff MPSImage arm64  <b860f467ef823f7f9c1e54002d4a2d31> /System/Library/Frameworks/MetalPerformanceShaders.framework/Frameworks/MPSImage.framework/MPSImage
0x18819b000 - 0x1881bbfff MPSMatrix arm64  <9d69c1f2cff932ce82dd6fea51bfa313> /System/Library/Frameworks/MetalPerformanceShaders.framework/Frameworks/MPSMatrix.framework/MPSMatrix
0x1881bc000 - 0x1881cafff CoreAUC arm64  <707e9d20bc113658afececb44cd65468> /System/Library/PrivateFrameworks/CoreAUC.framework/CoreAUC
0x1881cb000 - 0x18884efff MediaToolbox arm64  <3212389e443d30649517cf43f8bc521d> /System/Library/Frameworks/MediaToolbox.framework/MediaToolbox
0x18884f000 - 0x188915fff MPSNeuralNetwork arm64  <ad66eabd1b0232539656f3699ece6c1c> /System/Library/Frameworks/MetalPerformanceShaders.framework/Frameworks/MPSNeuralNetwork.framework/MPSNeuralNetwork
0x188916000 - 0x188916fff MetalPerformanceShaders arm64  <968c8d8650a6345e99c11a24d4908a14> /System/Library/Frameworks/MetalPerformanceShaders.framework/MetalPerformanceShaders
0x188917000 - 0x188d4afff FaceCore arm64  <d2dbc5ac047a3a3086d71339f3e4baad> /System/Library/PrivateFrameworks/FaceCore.framework/FaceCore
0x188d4b000 - 0x188d58fff GraphVisualizer arm64  <6babaa2dbd4237638afddfbe7a50eef6> /System/Library/PrivateFrameworks/GraphVisualizer.framework/GraphVisualizer
0x188d59000 - 0x188efefff libFosl_dynamic.dylib arm64  <8dade3ca46eb36ba918cabaae25e7279> /usr/lib/libFosl_dynamic.dylib
0x188eff000 - 0x189164fff CoreImage arm64  <fb0038da9f393be4bf10a072d87f06fa> /System/Library/Frameworks/CoreImage.framework/CoreImage
0x189165000 - 0x189353fff CoreMotion arm64  <d4e50e15fed83c6c8910b3f176fb9d75> /System/Library/Frameworks/CoreMotion.framework/CoreMotion
0x189354000 - 0x189382fff CoreBluetooth arm64  <0a6e2ddd19833f11aef2db9eac09b767> /System/Library/Frameworks/CoreBluetooth.framework/CoreBluetooth
0x189383000 - 0x1893a5fff PlugInKit arm64  <58516352e5423efcae9a5e91b2f0dd01> /System/Library/PrivateFrameworks/PlugInKit.framework/PlugInKit
0x1893a6000 - 0x1895d0fff Celestial arm64  <c1ff1c50f57230d1927b24a9e48ad629> /System/Library/PrivateFrameworks/Celestial.framework/Celestial
0x1895d1000 - 0x189653fff Quagga arm64  <881da54d257d32bab10fe8f51c9267a1> /System/Library/PrivateFrameworks/Quagga.framework/Quagga
0x189654000 - 0x18974dfff AVFAudio arm64  <767d3ec2f13a303cb1892207c94db016> /System/Library/Frameworks/AVFoundation.framework/Frameworks/AVFAudio.framework/AVFAudio
0x18974e000 - 0x18993cfff AVFoundation arm64  <237969258f323f1eb2562d4dd4f95aef> /System/Library/Frameworks/AVFoundation.framework/AVFoundation
0x18993d000 - 0x189960fff CacheDelete arm64  <8510e8ab56db3d5995706cc99293a006> /System/Library/PrivateFrameworks/CacheDelete.framework/CacheDelete
0x189961000 - 0x189986fff StreamingZip arm64  <c16c7b4c281a3649ac6e446cd24faba1> /System/Library/PrivateFrameworks/StreamingZip.framework/StreamingZip
0x189987000 - 0x189998fff CoreEmoji arm64  <0fed33cbda37338b9a43e1ef58c8e0f2> /System/Library/PrivateFrameworks/CoreEmoji.framework/CoreEmoji
0x189999000 - 0x1899e7fff CoreLocationProtobuf arm64  <7c704f35846b3bb3abd87bbeac17725e> /System/Library/PrivateFrameworks/CoreLocationProtobuf.framework/CoreLocationProtobuf
0x1899e8000 - 0x1899effff SymptomDiagnosticReporter arm64  <f2889f7d3709300b9705b2f211eb795f> /System/Library/PrivateFrameworks/SymptomDiagnosticReporter.framework/SymptomDiagnosticReporter
0x1899f0000 - 0x18a2f0fff GeoServices arm64  <b78713b86cac34b19772734e7a101333> /System/Library/PrivateFrameworks/GeoServices.framework/GeoServices
0x18a2f1000 - 0x18a308fff MobileAsset arm64  <135ac14d29573717a5aca07db0a1066e> /System/Library/PrivateFrameworks/MobileAsset.framework/MobileAsset
0x18a309000 - 0x18a34afff Lexicon arm64  <26e262cea357360f896ec150d8e7e0fe> /System/Library/PrivateFrameworks/Lexicon.framework/Lexicon
0x18a34b000 - 0x18a35bfff libcmph.dylib arm64  <8b492aa79dc5318481752d5cba68e84b> /usr/lib/libcmph.dylib
0x18a35c000 - 0x18a478fff LanguageModeling arm64  <c297b33f937532a1bdfb93eaeac4585f> /System/Library/PrivateFrameworks/LanguageModeling.framework/LanguageModeling
0x18a479000 - 0x18a490fff libmarisa.dylib arm64  <948c4447eef032a2bd7fdb0d5860359c> /usr/lib/libmarisa.dylib
0x18a491000 - 0x18a52bfff CoreLocation arm64  <4f98821d01ee39e3b2cda430fb77ff49> /System/Library/Frameworks/CoreLocation.framework/CoreLocation
0x18a52c000 - 0x18a52cfff PhoneNumbers arm64  <3aa5a16bf8123be8b4f1ea9ab4293e80> /System/Library/PrivateFrameworks/PhoneNumbers.framework/PhoneNumbers
0x18a52d000 - 0x18a538fff libChineseTokenizer.dylib arm64  <19ddc4b9d0f13f2183631824651c70c9> /usr/lib/libChineseTokenizer.dylib
0x18a539000 - 0x18a5e6fff libmecab_em.dylib arm64  <0a7c2fd4dd613449a0bdae35e1c05621> /usr/lib/libmecab_em.dylib
0x18a5e7000 - 0x18a5e8fff libThaiTokenizer.dylib arm64  <235c653d8a4f3a778f71258342a49c87> /usr/lib/libThaiTokenizer.dylib
0x18a5e9000 - 0x18a5edfff libgermantok.dylib arm64  <21224ee62107366c8c6c1af241c5b9b5> /usr/lib/libgermantok.dylib
0x18a5ee000 - 0x18a646fff CoreNLP arm64  <631fdf115f0c3047a3ca6dd7b28c073b> /System/Library/PrivateFrameworks/CoreNLP.framework/CoreNLP
0x18a647000 - 0x18a805fff MobileSpotlightIndex arm64  <cd13d8305e4230e6b001ff9d173470c3> /System/Library/PrivateFrameworks/MobileSpotlightIndex.framework/MobileSpotlightIndex
0x18a806000 - 0x18a865fff CoreSpotlight arm64  <1d631a5f5b8834c48d6719d79b772bc8> /System/Library/Frameworks/CoreSpotlight.framework/CoreSpotlight
0x18a872000 - 0x18b244fff JavaScriptCore arm64  <f8ccf929435534c7bafa70746e9b95f9> /System/Library/Frameworks/JavaScriptCore.framework/JavaScriptCore
0x18b245000 - 0x18b24afff libheimdal-asn1.dylib arm64  <1dc1aa4421fe3ddea53a07080c5058c6> /usr/lib/libheimdal-asn1.dylib
0x18b24b000 - 0x18b2c5fff libate.dylib arm64  <bb4173dd632f3d9baf425608ec3ad1a7> /usr/lib/libate.dylib
0x18b2c6000 - 0x18b368fff TextureIO arm64  <57a2d0b6d5fd36de9f35834757dd6e1e> /System/Library/PrivateFrameworks/TextureIO.framework/TextureIO
0x18b369000 - 0x18b433fff CoreUI arm64  <69a9ab41133d3819be7437b4d9fc58c3> /System/Library/PrivateFrameworks/CoreUI.framework/CoreUI
0x18b434000 - 0x18b43dfff MobileIcons arm64  <4a020d6be6443a5cb093a703e301507f> /System/Library/PrivateFrameworks/MobileIcons.framework/MobileIcons
0x18b43e000 - 0x18b44cfff AppleFSCompression arm64  <e91d533eee543737900020f2b6dd1209> /System/Library/PrivateFrameworks/AppleFSCompression.framework/AppleFSCompression
0x18b44d000 - 0x18b4a6fff TextInput arm64  <4eb2ccd7f165345f9253c62faf5de39f> /System/Library/PrivateFrameworks/TextInput.framework/TextInput
0x18b4a7000 - 0x18b4cffff libxslt.1.dylib arm64  <9f41e38d7d1d374eb4c317ffa766d51d> /usr/lib/libxslt.1.dylib
0x18b4d0000 - 0x18b505fff DataDetectorsCore arm64  <918573c60dec3e50b57d0215573d65f0> /System/Library/PrivateFrameworks/DataDetectorsCore.framework/DataDetectorsCore
0x18b506000 - 0x18b59bfff FileProvider arm64  <29753c5b5f3e32b2881f8c44ddcf4cd9> /System/Library/Frameworks/FileProvider.framework/FileProvider
0x18b69c000 - 0x18b774fff ProofReader arm64  <04c4e392021f33489f04b01ce76cbd02> /System/Library/PrivateFrameworks/ProofReader.framework/ProofReader
0x18b775000 - 0x18b789fff libAccessibility.dylib arm64  <f9278e55ebdc34528a01f614a78def92> /usr/lib/libAccessibility.dylib
0x18b78a000 - 0x18bbe2fff libwebrtc.dylib arm64  <cbe7d01cc0113edcb4be72bfb604ce8d> /System/Library/PrivateFrameworks/WebCore.framework/Frameworks/libwebrtc.dylib
0x18bbe3000 - 0x18bc43fff ContactsFoundation arm64  <8e3781f5e5a23366907c2fdc447ab008> /System/Library/PrivateFrameworks/ContactsFoundation.framework/ContactsFoundation
0x18bc44000 - 0x18cff0fff WebCore arm64  <17b029bf848431a4b7613b41708aca64> /System/Library/PrivateFrameworks/WebCore.framework/WebCore
0x18cff1000 - 0x18d163fff WebKitLegacy arm64  <eb2a2de9272a39b3a671d66f07c2fb87> /System/Library/PrivateFrameworks/WebKitLegacy.framework/WebKitLegacy
0x18d164000 - 0x18d18cfff DataAccessExpress arm64  <14e9e1270dca3e0c90bf867c08dbc188> /System/Library/PrivateFrameworks/DataAccessExpress.framework/DataAccessExpress
0x18d18d000 - 0x18d225fff AddressBookLegacy arm64  <6ad817e759b23b499aa3eccfde7d766c> /System/Library/PrivateFrameworks/AddressBookLegacy.framework/AddressBookLegacy
0x18d226000 - 0x18d27dfff ProtectedCloudStorage arm64  <5a4c02583e573b2abfdb24da350b7e98> /System/Library/PrivateFrameworks/ProtectedCloudStorage.framework/ProtectedCloudStorage
0x18d27e000 - 0x18d2aafff UserNotifications arm64  <1acc9bc755ae33708ad7a5eeadf6b8ec> /System/Library/Frameworks/UserNotifications.framework/UserNotifications
0x18d2ab000 - 0x18d2b6fff AppleIDAuthSupport arm64  <e320d30ed9eb361295151481bd624549> /System/Library/PrivateFrameworks/AppleIDAuthSupport.framework/AppleIDAuthSupport
0x18d2b7000 - 0x18d305fff AuthKit arm64  <7ea243ecc77b3aa7b24375b3e1d079d5> /System/Library/PrivateFrameworks/AuthKit.framework/AuthKit
0x18d330000 - 0x18d383fff DocumentManager arm64  <ccce6da1d4c638ea97d53cdf51377e7c> /System/Library/Frameworks/UIKit.framework/Frameworks/DocumentManager.framework/DocumentManager
0x18d384000 - 0x18e409fff UIKit arm64  <63bb42d77c7a3152a4a305f534779a61> /System/Library/Frameworks/UIKit.framework/UIKit
0x18e40a000 - 0x18e41bfff DocumentManagerCore arm64  <591ab729d9e53d3c818125db9a5a252a> /System/Library/PrivateFrameworks/DocumentManagerCore.framework/DocumentManagerCore
0x18e41c000 - 0x18e420fff HangTracer arm64  <f66e4e75e8073b9290d9723d324edb88> /System/Library/PrivateFrameworks/HangTracer.framework/HangTracer
0x18e421000 - 0x18e473fff PhysicsKit arm64  <5506b2a20d883442a4cad88e1b49475b> /System/Library/PrivateFrameworks/PhysicsKit.framework/PhysicsKit
0x18e474000 - 0x18e476fff StudyLog arm64  <cc3048f6ddea3203be8c9078e8334198> /System/Library/PrivateFrameworks/StudyLog.framework/StudyLog
0x18e477000 - 0x18e557fff UIFoundation arm64  <fa727d25bd7432f3afe426784ff9cdd1> /System/Library/PrivateFrameworks/UIFoundation.framework/UIFoundation
0x18e558000 - 0x18e664fff CloudKit arm64  <b6e98437c800397bb600258e4876eff5> /System/Library/Frameworks/CloudKit.framework/CloudKit
0x18e665000 - 0x18e665fff IntentsFoundation arm64  <bddd7668dee33f8894f87e72b5179805> /System/Library/PrivateFrameworks/IntentsFoundation.framework/IntentsFoundation
0x18e666000 - 0x18e72ffff Network arm64  <231cd3af11133afbb61078d2e0a72813> /System/Library/PrivateFrameworks/Network.framework/Network
0x18e730000 - 0x18e93afff Intents arm64  <464982043f213c9a9b6e863c59fe30d2> /System/Library/Frameworks/Intents.framework/Intents
0x18e93b000 - 0x18e956fff libresolv.9.dylib arm64  <1243b6c2a9b93b79898311cb8d37d87a> /usr/lib/libresolv.9.dylib
0x18e957000 - 0x18e959fff CoreDuetDebugLogging arm64  <40fcd2a0492a3138ab50daa0fc539408> /System/Library/PrivateFrameworks/CoreDuetDebugLogging.framework/CoreDuetDebugLogging
0x18e95a000 - 0x18e98efff libtidy.A.dylib arm64  <f8dae748d73237b985dd34f9ef9f953f> /usr/lib/libtidy.A.dylib
0x18e98f000 - 0x18eab9fff CoreDuet arm64  <8391cd7b01893c7bb5567c9566d16c48> /System/Library/PrivateFrameworks/CoreDuet.framework/CoreDuet
0x18eaba000 - 0x18ead8fff CoreDuetContext arm64  <aad357044daa31bab4f12fa570ae8386> /System/Library/PrivateFrameworks/CoreDuetContext.framework/CoreDuetContext
0x18ead9000 - 0x18eaedfff CoreDuetDaemonProtocol arm64  <c414be876f203f2c98812d573be9bafa> /System/Library/PrivateFrameworks/CoreDuetDaemonProtocol.framework/CoreDuetDaemonProtocol
0x18eaee000 - 0x18eb59fff IMFoundation arm64  <6b6422289ce939baafbfe0508edc2b13> /System/Library/PrivateFrameworks/IMFoundation.framework/IMFoundation
0x18eb5a000 - 0x18eb88fff vCard arm64  <b0a50e4baac93faa8dcdeb7d37e521d1> /System/Library/PrivateFrameworks/vCard.framework/vCard
0x18eb89000 - 0x18ec94fff Contacts arm64  <4e8acc9e76de3e49a6264964058223e4> /System/Library/Frameworks/Contacts.framework/Contacts
0x18ec95000 - 0x18ec96fff DiagnosticLogCollection arm64  <aa5b7374194e3a0ebd05d5213e33f94b> /System/Library/PrivateFrameworks/DiagnosticLogCollection.framework/DiagnosticLogCollection
0x18ec97000 - 0x18ec98fff Marco arm64  <db4311c1bca83d24afacd3db6518f2b3> /System/Library/PrivateFrameworks/Marco.framework/Marco
0x18ec99000 - 0x18ec9ffff MessageProtection arm64  <6dc7651d32053fbf96d333c60519bc43> /System/Library/PrivateFrameworks/MessageProtection.framework/MessageProtection
0x18eca0000 - 0x18efa6fff StoreServices arm64  <eed397d3163f358db76c1d5ebaf7e4f6> /System/Library/PrivateFrameworks/StoreServices.framework/StoreServices
0x18efa7000 - 0x18efbffff Engram arm64  <edec7faf180d37b2a646533a7ad7069e> /System/Library/PrivateFrameworks/Engram.framework/Engram
0x18efc0000 - 0x18f0b2fff IDSFoundation arm64  <d527e9a4304d324c9d456c3d903e52d9> /System/Library/PrivateFrameworks/IDSFoundation.framework/IDSFoundation
0x18f0b3000 - 0x18f0befff CaptiveNetwork arm64  <68930edfd9593c61be8952bd70f75bf9> /System/Library/PrivateFrameworks/CaptiveNetwork.framework/CaptiveNetwork
0x18f0bf000 - 0x18f0edfff EAP8021X arm64  <0b795c120aaa38a1a91860a611284c58> /System/Library/PrivateFrameworks/EAP8021X.framework/EAP8021X
0x18f0ee000 - 0x18f128fff MobileWiFi arm64  <29fe25fde1de390ba1fc5e51850a17d3> /System/Library/PrivateFrameworks/MobileWiFi.framework/MobileWiFi
0x18f129000 - 0x18f12bfff OAuth arm64  <1ca9fd6c48a437948124d95ae53825e7> /System/Library/PrivateFrameworks/OAuth.framework/OAuth
0x18f12c000 - 0x18f12efff CommonAuth arm64  <35c1af3f71213eaeb19292fda822e67a> /System/Library/PrivateFrameworks/CommonAuth.framework/CommonAuth
0x18f12f000 - 0x18f19dfff Heimdal arm64  <f744238528d13568a383cd02c2c3c17a> /System/Library/PrivateFrameworks/Heimdal.framework/Heimdal
0x18f19e000 - 0x18f1c7fff GSS arm64  <39131c5b25f33207829d786ea5d2837e> /System/Library/Frameworks/GSS.framework/GSS
0x18f1c8000 - 0x18f1dffff ApplePushService arm64  <d5e2e4944c4d3e1faa66dab4d1f90d6f> /System/Library/PrivateFrameworks/ApplePushService.framework/ApplePushService
0x18f1e0000 - 0x18f278fff AccountsDaemon arm64  <303267dfcfa23f4eba9af44f724879be> /System/Library/PrivateFrameworks/AccountsDaemon.framework/AccountsDaemon
0x18f279000 - 0x18f297fff AppleIDSSOAuthentication arm64  <a2ad71e90a133bbbaeab3ab0d1ff4ff7> /System/Library/PrivateFrameworks/AppleIDSSOAuthentication.framework/AppleIDSSOAuthentication
0x18f298000 - 0x18f30afff AppleAccount arm64  <cd5e7605d3b2364291dd1a1c18369b8d> /System/Library/PrivateFrameworks/AppleAccount.framework/AppleAccount
0x18f30b000 - 0x18f41efff CoreUtils arm64  <572166133ddc3056aa0f87d05fc39b12> /System/Library/PrivateFrameworks/CoreUtils.framework/CoreUtils
0x18f41f000 - 0x18f538fff IDS arm64  <a1857f67312132fd92dea45e766c42a9> /System/Library/PrivateFrameworks/IDS.framework/IDS
0x18f539000 - 0x18f55afff MediaServices arm64  <58cd7ac73c8d3fbea1130cbd4c8d6064> /System/Library/PrivateFrameworks/MediaServices.framework/MediaServices
0x18f55b000 - 0x18f6bffff MediaRemote arm64  <f214ad97f14b3e4fa92d19875f7beedc> /System/Library/PrivateFrameworks/MediaRemote.framework/MediaRemote
0x18f6c0000 - 0x18f6d6fff UserManagement arm64  <37e9f071230432efb4de36fccf3974d6> /System/Library/PrivateFrameworks/UserManagement.framework/UserManagement
0x18f6d7000 - 0x18f6e6fff MobileBluetooth arm64  <2644a4173d5632ac9e6ba2421f3ee4bb> /System/Library/PrivateFrameworks/MobileBluetooth.framework/MobileBluetooth
0x18f6e7000 - 0x18f717fff Bom arm64  <1687a8ce9c5030df8b0b6338bd5f168e> /System/Library/PrivateFrameworks/Bom.framework/Bom
0x18f718000 - 0x18f71cfff CommunicationsFilter arm64  <59084d88ea733e4ab9f6d81ebeea61ac> /System/Library/PrivateFrameworks/CommunicationsFilter.framework/CommunicationsFilter
0x18f71d000 - 0x18f742fff FTAWD arm64  <4e5e93f600b73542bd17d45153d0f4ca> /System/Library/PrivateFrameworks/FTAWD.framework/FTAWD
0x18f743000 - 0x18f796fff FTServices arm64  <2ab1437a5b573cc082e4a54ec9661a48> /System/Library/PrivateFrameworks/FTServices.framework/FTServices
0x18f797000 - 0x18f7e9fff WirelessProximity arm64  <ced3be636c6838769f8f07a7b2ed1685> /System/Library/PrivateFrameworks/WirelessProximity.framework/WirelessProximity
0x18f7ea000 - 0x18f7fefff ProactiveEventTracker arm64  <684b2a827fd03675a51d5f33139b1978> /System/Library/PrivateFrameworks/ProactiveEventTracker.framework/ProactiveEventTracker
0x18f7ff000 - 0x18f850fff ChunkingLibrary arm64  <118a49d396bd312cb2a149a061813c8d> /System/Library/PrivateFrameworks/ChunkingLibrary.framework/ChunkingLibrary
0x18f851000 - 0x18f85dfff libnetworkextension.dylib arm64  <969fc737cd7c3812a8e11b396fd14f1f> /usr/lib/libnetworkextension.dylib
0x18f85e000 - 0x18f882fff AddressBook arm64  <6bf7a3ae474d3d32bc8f7bab92e4e544> /System/Library/Frameworks/AddressBook.framework/AddressBook
0x19065b000 - 0x1907f0fff NetworkExtension arm64  <75cb9b101c8936d0a49ccf229b36bc00> /System/Library/Frameworks/NetworkExtension.framework/NetworkExtension
0x1907f1000 - 0x190bf4fff SiriTTS arm64  <85bc1195f02b350cad0c507fc0e9b859> /System/Library/PrivateFrameworks/SiriTTS.framework/SiriTTS
0x190bf5000 - 0x190c4efff SAObjects arm64  <e499a9dd9ed03f02a0ac397841fa0977> /System/Library/PrivateFrameworks/SAObjects.framework/SAObjects
0x190c4f000 - 0x190c8cfff VoiceServices arm64  <1b46a00eef7d3174a3f3f63568c71e65> /System/Library/PrivateFrameworks/VoiceServices.framework/VoiceServices
0x190c8d000 - 0x190cbdfff GLKit arm64  <0fe06ba442e73cebb622c9935f5ce6d0> /System/Library/Frameworks/GLKit.framework/GLKit
0x190cbe000 - 0x190da1fff AssistantServices arm64  <b311b53535383151a673756484cba7b7> /System/Library/PrivateFrameworks/AssistantServices.framework/AssistantServices
0x190da2000 - 0x190da9fff AssetCacheServices arm64  <065bdc6672843b94985ca785a4889c2c> /System/Library/PrivateFrameworks/AssetCacheServices.framework/AssetCacheServices
0x190daa000 - 0x190e64fff NetworkServiceProxy arm64  <7270a6a9ae8036ab88d882352bb51e47> /System/Library/PrivateFrameworks/NetworkServiceProxy.framework/NetworkServiceProxy
0x190e65000 - 0x190f5afff MMCS arm64  <36d1198f00a63b389e137333dd53251f> /System/Library/PrivateFrameworks/MMCS.framework/MMCS
0x190f5b000 - 0x190f67fff BluetoothManager arm64  <292ce6f9c7e83d14b1410e924fb010eb> /System/Library/PrivateFrameworks/BluetoothManager.framework/BluetoothManager
0x190f68000 - 0x190fd9fff CoreDAV arm64  <2b8c3a76866d37389d07f97118dc177e> /System/Library/PrivateFrameworks/CoreDAV.framework/CoreDAV
0x190fda000 - 0x19100efff iCalendar arm64  <00a6da1e12ad3aa9a40e09d0e98c1a65> /System/Library/PrivateFrameworks/iCalendar.framework/iCalendar
0x19100f000 - 0x19101dfff PersonaKit arm64  <50c8e7f6befb3d6dbc8f4b8560c5536e> /System/Library/PrivateFrameworks/PersonaKit.framework/PersonaKit
0x19101e000 - 0x191078fff CalendarFoundation arm64  <88351d14d0c53df78d7bef9d37732014> /System/Library/PrivateFrameworks/CalendarFoundation.framework/CalendarFoundation
0x191079000 - 0x1910a6fff PhotosFormats arm64  <1ac9d31535f034229cd2e62a85cc70cf> /System/Library/PrivateFrameworks/PhotosFormats.framework/PhotosFormats
0x1910a7000 - 0x191143fff CalendarDatabase arm64  <aea5cc07347a35e7ac7b035bec99bcb8> /System/Library/PrivateFrameworks/CalendarDatabase.framework/CalendarDatabase
0x191144000 - 0x191195fff CalendarDaemon arm64  <5a4f13d8fcac3a888ab10c31789b736f> /System/Library/PrivateFrameworks/CalendarDaemon.framework/CalendarDaemon
0x191196000 - 0x1912b4fff CloudPhotoLibrary arm64  <3090eb778bf83102b9693a3819c8d657> /System/Library/PrivateFrameworks/CloudPhotoLibrary.framework/CloudPhotoLibrary
0x1912b5000 - 0x191399fff EventKit arm64  <0084b9612435327aba71161ba7ba1254> /System/Library/Frameworks/EventKit.framework/EventKit
0x19139a000 - 0x1913c4fff AssetsLibraryServices arm64  <698f27791d7034a689c77fd45f1cef73> /System/Library/PrivateFrameworks/AssetsLibraryServices.framework/AssetsLibraryServices
0x1913c5000 - 0x1913f9fff ACTFramework arm64  <30c48c06532734ffb365afdd8c3b9f14> /System/Library/PrivateFrameworks/ACTFramework.framework/ACTFramework
0x1913fa000 - 0x19141afff DCIMServices arm64  <8c9a59ca94a23c0599e0b5f89f9d8990> /System/Library/PrivateFrameworks/DCIMServices.framework/DCIMServices
0x19141b000 - 0x191555fff CoreMediaStream arm64  <f8cf05ed94a43506a5adc8fffe6d8d34> /System/Library/PrivateFrameworks/CoreMediaStream.framework/CoreMediaStream
0x191556000 - 0x19155dfff XPCKit arm64  <92f06031b48134d9b54bc9ec5b7f1a7a> /System/Library/PrivateFrameworks/XPCKit.framework/XPCKit
0x19155e000 - 0x191644fff CameraKit arm64  <91088223dc9734c7b79b6af1c8ed6ca7> /System/Library/PrivateFrameworks/CameraKit.framework/CameraKit
0x191645000 - 0x19165dfff CloudPhotoServices arm64  <72e95f7d4dc934d3b162de9b862b5999> /System/Library/PrivateFrameworks/CloudPhotoServices.framework/CloudPhotoServices
0x19165e000 - 0x191669fff CoreRecents arm64  <32ef08ca2b40314282ee7ef190a22580> /System/Library/PrivateFrameworks/CoreRecents.framework/CoreRecents
0x19166a000 - 0x191688fff MediaStream arm64  <4be5138a6f033789a3febfc7d1fb0463> /System/Library/PrivateFrameworks/MediaStream.framework/MediaStream
0x191689000 - 0x191aabfff PhotoLibraryServices arm64  <6489f89144ee3db0b91b46b8644370b9> /System/Library/PrivateFrameworks/PhotoLibraryServices.framework/PhotoLibraryServices
0x191aac000 - 0x191ae2fff PrototypeTools arm64  <6ede9fbb2b0c36838cb5c599f8c2a1e7> /System/Library/PrivateFrameworks/PrototypeTools.framework/PrototypeTools
0x191ae3000 - 0x191b6efff CoreSymbolication arm64  <9b8b07fe88613b47b88c47ce005df8dd> /System/Library/PrivateFrameworks/CoreSymbolication.framework/CoreSymbolication
0x191b6f000 - 0x191c9cfff SearchFoundation arm64  <605cb19d691d397d96ea1d4283ee47d3> /System/Library/PrivateFrameworks/SearchFoundation.framework/SearchFoundation
0x191c9d000 - 0x191ca3fff IncomingCallFilter arm64  <3fece80f60593d99a89c0b8e9f11c453> /System/Library/PrivateFrameworks/IncomingCallFilter.framework/IncomingCallFilter
0x191ca4000 - 0x191d4dfff iTunesStore arm64  <e0be60e8ccd63484b6da6dea8dda6bf6> /System/Library/PrivateFrameworks/iTunesStore.framework/iTunesStore
0x191d4e000 - 0x191d54fff libtzupdate.dylib arm64  <fd7111e1412537ac8f5767c7210f92e8> /usr/lib/libtzupdate.dylib
0x191d55000 - 0x191ec0fff Preferences arm64  <9d6abde3c55834d98a531c16d91148c0> /System/Library/PrivateFrameworks/Preferences.framework/Preferences
0x191ec1000 - 0x191ec8fff CoreTime arm64  <ef89af2891023b5ba25f7c5238a65f81> /System/Library/PrivateFrameworks/CoreTime.framework/CoreTime
0x191ec9000 - 0x192032fff CVML arm64  <2fed505762a1347588d8b111d17ab79a> /System/Library/PrivateFrameworks/CVML.framework/CVML
0x192033000 - 0x19207ffff CoreAppleCVA arm64  <f47139766a92326cae961ddc40bdcf52> /System/Library/PrivateFrameworks/CoreAppleCVA.framework/CoreAppleCVA
0x192080000 - 0x1920b6fff DifferentialPrivacy arm64  <e8cd80cc069e3861b5b4801ecbf03175> /System/Library/PrivateFrameworks/DifferentialPrivacy.framework/DifferentialPrivacy
0x1920b7000 - 0x19221efff AppleCVA arm64  <4bd64569da453be087fb4e09f5e4703e> /System/Library/PrivateFrameworks/AppleCVA.framework/AppleCVA
0x19221f000 - 0x1922bafff Montreal arm64  <e5573691e703327e8377f9241dfd5c2e> /System/Library/PrivateFrameworks/Montreal.framework/Montreal
0x1922bb000 - 0x192498fff Espresso arm64  <bdea27aa09cd3ead9ef3d9c7a0003622> /System/Library/PrivateFrameworks/Espresso.framework/Espresso
0x19249d000 - 0x1925effff Photos arm64  <5d1fbb8ee40f39928a8e4bfae7091a53> /System/Library/Frameworks/Photos.framework/Photos
0x1925fc000 - 0x1927c5fff CoreML arm64  <b630bba175ae3c72936918f0fe48ff2b> /System/Library/Frameworks/CoreML.framework/CoreML
0x1927c6000 - 0x1927cafff CoreOptimization arm64  <6e61942f08953dd79fd44cc9d4d744f1> /System/Library/PrivateFrameworks/CoreOptimization.framework/CoreOptimization
0x1927cb000 - 0x192808fff SafariCore arm64  <e48385ff069e3aee9750fa167847ae2a> /System/Library/PrivateFrameworks/SafariCore.framework/SafariCore
0x192809000 - 0x192863fff CorePrediction arm64  <cbba5beaa97f3f4f8d1803b796592eb1> /System/Library/PrivateFrameworks/CorePrediction.framework/CorePrediction
0x192864000 - 0x192961fff Navigation arm64  <6e9d43be24e83bd69946d2c753eac763> /System/Library/PrivateFrameworks/Navigation.framework/Navigation
0x192962000 - 0x19297afff ContactsDonation arm64  <850e4dad3a1e35cbb43225944027046f> /System/Library/PrivateFrameworks/ContactsDonation.framework/ContactsDonation
0x19297b000 - 0x1929a7fff Futhark arm64  <24175dd790eb31e093ed3d242fa14ea8> /System/Library/PrivateFrameworks/Futhark.framework/Futhark
0x1929eb000 - 0x192a3ffff ToneLibrary arm64  <6317905b6f4d3cc49323f024a5e7395c> /System/Library/PrivateFrameworks/ToneLibrary.framework/ToneLibrary
0x192a40000 - 0x192a52fff BaseBoardUI arm64  <091856ff2c98390abfd06867ddfd8c99> /System/Library/PrivateFrameworks/BaseBoardUI.framework/BaseBoardUI
0x192a53000 - 0x192aabfff ContactsUICore arm64  <a2781bb6bc043f6cbc0203433093616b> /System/Library/PrivateFrameworks/ContactsUICore.framework/ContactsUICore
0x192aac000 - 0x192c10fff ContactsUI arm64  <8db1cf7a61153acf8930085673dc45ee> /System/Library/Frameworks/ContactsUI.framework/ContactsUI
0x192c11000 - 0x192cedfff CorePDF arm64  <22a974d195923e16a509bd49b06b1fdc> /System/Library/PrivateFrameworks/CorePDF.framework/CorePDF
0x192cee000 - 0x192f4efff Vision arm64  <049116800f633780b6048e89309ae58a> /System/Library/Frameworks/Vision.framework/Vision
0x192f4f000 - 0x1932fefff WebKit arm64  <78b19dea30573176a37ee0092e22b716> /System/Library/Frameworks/WebKit.framework/WebKit
0x1932ff000 - 0x1933b8fff BulletinBoard arm64  <f0dbceea8a0c3bc0bbeaa2ecee45d11b> /System/Library/PrivateFrameworks/BulletinBoard.framework/BulletinBoard
0x1933b9000 - 0x1933befff ConstantClasses arm64  <54dae35faf09384087e3b0b13b2e119f> /System/Library/PrivateFrameworks/ConstantClasses.framework/ConstantClasses
0x1933bf000 - 0x1933c7fff CertUI arm64  <b699133afdc9395d8d5042b70a656476> /System/Library/PrivateFrameworks/CertUI.framework/CertUI
0x1933c8000 - 0x19340cfff AXRuntime arm64  <6a040aef0bb63bbfb362cf51c1613885> /System/Library/PrivateFrameworks/AXRuntime.framework/AXRuntime
0x19340d000 - 0x193444fff ScreenReaderCore arm64  <91faaa92b7b7329f8ed639d4c95a854d> /System/Library/PrivateFrameworks/ScreenReaderCore.framework/ScreenReaderCore
0x193445000 - 0x193468fff TextToSpeech arm64  <af775fda91ee3edd95cf9e2ded13be24> /System/Library/PrivateFrameworks/TextToSpeech.framework/TextToSpeech
0x193469000 - 0x1934affff CoreMIDI arm64  <aa73021e6d063ffca7e6cc100476442e> /System/Library/Frameworks/CoreMIDI.framework/CoreMIDI
0x1934b0000 - 0x19354cfff MediaPlatform arm64  <b1a2014666ea35abaf09c4e2b9464729> /System/Library/PrivateFrameworks/MediaPlatform.framework/MediaPlatform
0x19354d000 - 0x1935acfff WebBookmarks arm64  <f8ccbfd103623f2dbcec8e19359e3920> /System/Library/PrivateFrameworks/WebBookmarks.framework/WebBookmarks
0x1935ad000 - 0x1935b3fff DAAPKit arm64  <1489e0c7529436419e775108edc2851e> /System/Library/PrivateFrameworks/DAAPKit.framework/DAAPKit
0x1935b4000 - 0x1935b6fff libAXSafeCategoryBundle.dylib arm64  <21766878d5bd36e094b735853c3cd3d5> /usr/lib/libAXSafeCategoryBundle.dylib
0x1935b7000 - 0x1935c1fff libAXSpeechManager.dylib arm64  <6725709d4ee73c9e9baecb53c16db2b1> /usr/lib/libAXSpeechManager.dylib
0x1935c2000 - 0x1936a5fff AccessibilityUtilities arm64  <aa54f44c2ce5380f853ffb425719f9d5> /System/Library/PrivateFrameworks/AccessibilityUtilities.framework/AccessibilityUtilities
0x1936a6000 - 0x19397efff MediaLibraryCore arm64  <02248f50390733a9b45fe8969af53700> /System/Library/PrivateFrameworks/MediaLibraryCore.framework/MediaLibraryCore
0x19397f000 - 0x19397ffff AdSupport arm64  <0ef49250b5443b789f646df92f209391> /System/Library/Frameworks/AdSupport.framework/AdSupport
0x193980000 - 0x193bfefff MusicLibrary arm64  <6ddc4b85c8e63282ab77faa15ab06b14> /System/Library/PrivateFrameworks/MusicLibrary.framework/MusicLibrary
0x193bff000 - 0x194287fff VectorKit arm64  <80e45f0d02973b81a25b9f8933b359ed> /System/Library/PrivateFrameworks/VectorKit.framework/VectorKit
0x194288000 - 0x1944c5fff MapKit arm64  <b159fe592a273823897c1700c7a9a619> /System/Library/Frameworks/MapKit.framework/MapKit
0x1944c6000 - 0x19463efff iTunesCloud arm64  <ba5787ebac97338a9cc3126d539ca42a> /System/Library/PrivateFrameworks/iTunesCloud.framework/iTunesCloud
0x19463f000 - 0x1946dffff HomeSharing arm64  <8d47fbe5e22a3508aea12b531cebe07e> /System/Library/PrivateFrameworks/HomeSharing.framework/HomeSharing
0x1946e0000 - 0x194755fff WebInspector arm64  <7962fa14fbf43e05a60848e3733a08f9> /System/Library/PrivateFrameworks/WebInspector.framework/WebInspector
0x194756000 - 0x19483efff ITMLKit arm64  <60a53f0253903796ac641a148046a7f4> /System/Library/PrivateFrameworks/ITMLKit.framework/ITMLKit
0x19484f000 - 0x194cabfff MediaPlayer arm64  <9cd3159587c4334cb1b0c1d9000647f3> /System/Library/Frameworks/MediaPlayer.framework/MediaPlayer
0x194cd2000 - 0x194cd8fff EmailAddressing arm64  <4f7608603bbb3369aad9abb08f62d8d7> /System/Library/PrivateFrameworks/EmailAddressing.framework/EmailAddressing
0x194cd9000 - 0x194cdbfff MessageSupport arm64  <602ecf8e71b53f969946ea63085fee81> /System/Library/PrivateFrameworks/MessageSupport.framework/MessageSupport
0x194cdc000 - 0x194cdefff InternationalTextSearch arm64  <b2a3ca4912fe32e294e63adb98ecb526> /System/Library/PrivateFrameworks/InternationalTextSearch.framework/InternationalTextSearch
0x194cdf000 - 0x194d3afff MIME arm64  <899cda88811c3fa4952615b77fc80a77> /System/Library/PrivateFrameworks/MIME.framework/MIME
0x194d3b000 - 0x194d6afff ProactiveSupport arm64  <836592f14d5d39ad84c5bce221654f39> /System/Library/PrivateFrameworks/ProactiveSupport.framework/ProactiveSupport
0x194d6b000 - 0x194da3fff Notes arm64  <872aa8ea8d383e66940ef74179811fc0> /System/Library/PrivateFrameworks/Notes.framework/Notes
0x194da4000 - 0x194e58fff TelephonyUtilities arm64  <9e474173abf8315aa1311cb75cb83821> /System/Library/PrivateFrameworks/TelephonyUtilities.framework/TelephonyUtilities
0x194e59000 - 0x194e93fff CalendarUIKit arm64  <afa6455e83d43b319aa481c287d96787> /System/Library/PrivateFrameworks/CalendarUIKit.framework/CalendarUIKit
0x194e94000 - 0x194eabfff AccessibilityUIUtilities arm64  <c981e25f62a533e88ed470020f8c56cc> /System/Library/PrivateFrameworks/Accessibility.framework/Frameworks/AccessibilityUIUtilities.framework/AccessibilityUIUtilities
0x194eac000 - 0x194f07fff DataAccess arm64  <b43109e66f9c3507ad72d0059f5be92c> /System/Library/PrivateFrameworks/DataAccess.framework/DataAccess
0x194f08000 - 0x194f1bfff AssetsLibrary arm64  <0a9e8429c233352c9c9b320506037d25> /System/Library/Frameworks/AssetsLibrary.framework/AssetsLibrary
0x194f1c000 - 0x1950fafff EventKitUI arm64  <8133d7aaf8463776ac659515bb8556ea> /System/Library/Frameworks/EventKitUI.framework/EventKitUI
0x1950fb000 - 0x195156fff AXMediaUtilities arm64  <2d3dcd1a04613d178b3b2b7409a6ff15> /System/Library/PrivateFrameworks/AXMediaUtilities.framework/AXMediaUtilities
0x195157000 - 0x1951cbfff UIAccessibility arm64  <c64c815880d13bef9b86a45d5aed61fd> /System/Library/PrivateFrameworks/UIAccessibility.framework/UIAccessibility
0x1951e7000 - 0x1951edfff SearchToSharePredictions arm64  <668e4f229fc03c6196ac0860ec63cdfe> /System/Library/PrivateFrameworks/SearchToSharePredictions.framework/SearchToSharePredictions
0x1951ee000 - 0x19528ffff Social arm64  <ea4583fa774e36f4a1bb974c65062352> /System/Library/Frameworks/Social.framework/Social
0x195321000 - 0x195337fff CoreFollowUp arm64  <93dc9e73089c3d4fab530a8616e47f74> /System/Library/PrivateFrameworks/CoreFollowUp.framework/CoreFollowUp
0x195338000 - 0x1953a7fff CoreSuggestions arm64  <34d7eee941d53c6d93a2daf16a3bf589> /System/Library/PrivateFrameworks/CoreSuggestions.framework/CoreSuggestions
0x1953a8000 - 0x1953b8fff MailServices arm64  <b0776838b78f3e57b1ba700219f4bf90> /System/Library/PrivateFrameworks/MailServices.framework/MailServices
0x1953b9000 - 0x19544efff CoreRecognition arm64  <b025ec8dcb0633b0aed4dbc5e8bd63e5> /System/Library/PrivateFrameworks/CoreRecognition.framework/CoreRecognition
0x19544f000 - 0x19546afff MailSupport arm64  <2230a40fe77032559bbfd5428fd6bf12> /System/Library/PrivateFrameworks/MailSupport.framework/MailSupport
0x19546b000 - 0x1955bafff Message arm64  <7cab7cc94e783cf1b41d8ce61e16b8d1> /System/Library/PrivateFrameworks/Message.framework/Message
0x1955bb000 - 0x1957ddfff libmecabra.dylib arm64  <74ccf6c38eeb34c98cc6cd018254f154> /usr/lib/libmecabra.dylib
0x1957de000 - 0x195880fff CoreParsec arm64  <9b719b80f87e3cf39762809f06ec3341> /System/Library/PrivateFrameworks/CoreParsec.framework/CoreParsec
0x1958b1000 - 0x1958e1fff SharedUtils arm64  <65cf05decaa430988124bdb58a8b4b3f> /System/Library/Frameworks/LocalAuthentication.framework/Support/SharedUtils.framework/SharedUtils
0x1958e2000 - 0x19591dfff ContactsAutocomplete arm64  <c6d2f37a43453da6a96aabd2e1eed361> /System/Library/PrivateFrameworks/ContactsAutocomplete.framework/ContactsAutocomplete
0x19591e000 - 0x1959e3fff VideoSubscriberAccount arm64  <44e832d1212f39e2b1c783aa72ea3e5f> /System/Library/Frameworks/VideoSubscriberAccount.framework/VideoSubscriberAccount
0x1959e4000 - 0x195a15fff Pegasus arm64  <b998115092ec38ae9617c124e7c0fd50> /System/Library/PrivateFrameworks/Pegasus.framework/Pegasus
0x195a16000 - 0x195a96fff AVKit arm64  <6a14b57a7c523b3d8566e381db1a7e53> /System/Library/Frameworks/AVKit.framework/AVKit
0x195abb000 - 0x195abefff FTClientServices arm64  <872c9460a4f3343faa69d283d08c597a> /System/Library/PrivateFrameworks/FTClientServices.framework/FTClientServices
0x195abf000 - 0x195ad2fff SharedWebCredentials arm64  <eab968b9d57830fb94875644705e02f6> /System/Library/PrivateFrameworks/SharedWebCredentials.framework/SharedWebCredentials
0x195ad4000 - 0x195ad7fff SafariFoundation arm64  <3f43d37367d53332b24fcb2b2c04eb7a> /System/Library/PrivateFrameworks/SafariFoundation.framework/SafariFoundation
0x195c5f000 - 0x195c75fff LocalAuthentication arm64  <350457630f0132729a02a1ad396d68e0> /System/Library/Frameworks/LocalAuthentication.framework/LocalAuthentication
0x195c76000 - 0x195c78fff ParsecSubscriptionServiceSupport arm64  <d996cf371ae635c9969e5b6ead58ef5d> /System/Library/PrivateFrameworks/ParsecSubscriptionServiceSupport.framework/ParsecSubscriptionServiceSupport
0x195d21000 - 0x195d39fff CoreInterest arm64  <44b60438f5d53e24abae7ebd17f77f30> /System/Library/PrivateFrameworks/CoreInterest.framework/CoreInterest
0x195d3a000 - 0x195f9afff SafariShared arm64  <2b66238990a43304b3baa95c8d337210> /System/Library/PrivateFrameworks/SafariShared.framework/SafariShared
0x195f9b000 - 0x195fd5fff WebUI arm64  <ce4028f9f8ed3afcbaed76be9630098f> /System/Library/PrivateFrameworks/WebUI.framework/WebUI
0x195fd6000 - 0x195fe1fff SetupAssistantSupport arm64  <8e5f30aab51e3d4a8d0eb62d834ba0ae> /System/Library/PrivateFrameworks/SetupAssistantSupport.framework/SetupAssistantSupport
0x195fe2000 - 0x196009fff SetupAssistant arm64  <f00552e13f983c3fbc96ddb1eced8a4a> /System/Library/PrivateFrameworks/SetupAssistant.framework/SetupAssistant
0x196059000 - 0x196062fff MobileStorage arm64  <b8ee4c471b3e3315b2f5e98dcd49e8c6> /System/Library/PrivateFrameworks/MobileStorage.framework/MobileStorage
0x196063000 - 0x1960a5fff ContentIndex arm64  <ac4298faaa0d3fa9a95ef5f95a4e5d3c> /System/Library/PrivateFrameworks/ContentIndex.framework/ContentIndex
0x1960a6000 - 0x196399fff ImageCapture arm64  <bc49374b66e137d188e661c1711c6826> /System/Library/PrivateFrameworks/ImageCapture.framework/ImageCapture
0x19656c000 - 0x196582fff iPhotoMigrationSupport arm64  <470f0a2d43433d589c78c896a0eaded9> /System/Library/PrivateFrameworks/iPhotoMigrationSupport.framework/iPhotoMigrationSupport
0x196583000 - 0x196595fff DiagnosticExtensions arm64  <e8775616ebe83a3d8d224a6216dd5ee9> /System/Library/PrivateFrameworks/DiagnosticExtensions.framework/DiagnosticExtensions
0x19689d000 - 0x196934fff PhotoLibrary arm64  <a3bd592248f03852bceee3493f3836dc> /System/Library/PrivateFrameworks/PhotoLibrary.framework/PhotoLibrary
0x196935000 - 0x196c85fff PhotosUICore arm64  <c765e3fc93db32e4b3d1e2f5eb5aa22c> /System/Library/PrivateFrameworks/PhotosUICore.framework/PhotosUICore
0x196cbc000 - 0x196cd5fff CoreSDB arm64  <48f162a90ba236e481178e9849e35aa6> /System/Library/PrivateFrameworks/CoreSDB.framework/CoreSDB
0x196cd6000 - 0x196d33fff IMSharedUtilities arm64  <6115e5af61fb3bb09f26bd60b9456e5e> /System/Library/PrivateFrameworks/IMSharedUtilities.framework/IMSharedUtilities
0x196d34000 - 0x196d3afff LinguisticData arm64  <538d30126cfd3133bb828b6f369a2d9c> /System/Library/PrivateFrameworks/LinguisticData.framework/LinguisticData
0x196d54000 - 0x196ddefff PhotoEditSupport arm64  <bed27a7533b33fd0af7b5e61cbe1c4dd> /System/Library/PrivateFrameworks/PhotoEditSupport.framework/PhotoEditSupport
0x196ddf000 - 0x196df2fff SiriTasks arm64  <9014319fef743f2cb7837d50e1d41246> /System/Library/PrivateFrameworks/SiriTasks.framework/SiriTasks
0x196df3000 - 0x19720ffff PhotosUI arm64  <fc6f0493a7a73784a0593e97683dd7e6> /System/Library/Frameworks/PhotosUI.framework/PhotosUI
0x197319000 - 0x197346fff StoreKit arm64  <b4daf4220dab32eda95c29bd12b8a37f> /System/Library/Frameworks/StoreKit.framework/StoreKit
0x1973a8000 - 0x1973c3fff EmojiFoundation arm64  <3948ceefa85f3c77bab3442a5a8b9ff9> /System/Library/PrivateFrameworks/EmojiFoundation.framework/EmojiFoundation
0x1973c4000 - 0x1974d7fff IMDPersistence arm64  <37779776432a3599a2379d1f28fdc9cc> /System/Library/PrivateFrameworks/IMDPersistence.framework/IMDPersistence
0x1974d8000 - 0x1974f2fff MetalKit arm64  <1e79604e357e36cf81a54c4f420b7b6c> /System/Library/Frameworks/MetalKit.framework/MetalKit
0x1974f3000 - 0x197514fff GenerationalStorage arm64  <010e586020193be287a48e99b625a826> /System/Library/PrivateFrameworks/GenerationalStorage.framework/GenerationalStorage
0x19795f000 - 0x197a2dfff CoreHandwriting arm64  <51ef7f69f6113f3695af8c11242557c8> /System/Library/PrivateFrameworks/CoreHandwriting.framework/CoreHandwriting
0x197b92000 - 0x197b9afff AddressBookUI arm64  <02e93e3a48663afebec669ef46ef2486> /System/Library/Frameworks/AddressBookUI.framework/AddressBookUI
0x197fd1000 - 0x1980fbfff PencilKit arm64  <3ef4d11aec5b33429b1bad20d242fce6> /System/Library/PrivateFrameworks/PencilKit.framework/PencilKit
0x1980fc000 - 0x198119fff QuickLookThumbnailing arm64  <e10fc9be2e7a396caeca3064b80c3d19> /System/Library/PrivateFrameworks/QuickLookThumbnailing.framework/QuickLookThumbnailing
0x19811a000 - 0x1981ccfff PDFKit arm64  <c05fb6202bfe3a1491df3afd383e55bc> /System/Library/Frameworks/PDFKit.framework/PDFKit
0x1981cd000 - 0x1982f9fff AnnotationKit arm64  <635f089d7716342c819fa57f1ee97fd7> /System/Library/PrivateFrameworks/AnnotationKit.framework/AnnotationKit
0x1982fa000 - 0x19849afff IMCore arm64  <e79feb206a603f4cbe10b048b66426da> /System/Library/PrivateFrameworks/IMCore.framework/IMCore
0x19851b000 - 0x19854bfff MarkupUI arm64  <dac9ddd11bc73c6aaee340295b81c9f9> /System/Library/PrivateFrameworks/MarkupUI.framework/MarkupUI
0x19856e000 - 0x198628fff QuickLook arm64  <8a2aa1b03f45351dada703317081e12b> /System/Library/Frameworks/QuickLook.framework/QuickLook
0x198711000 - 0x198757fff SafariSafeBrowsing arm64  <675b6320b011307886a97bad4d294e7a> /System/Library/PrivateFrameworks/SafariSafeBrowsing.framework/SafariSafeBrowsing
0x198776000 - 0x19887dfff SafariServices arm64  <31dec52bc9c0330e963f8cb14ed24930> /System/Library/Frameworks/SafariServices.framework/SafariServices
0x19887e000 - 0x1988b5fff AppStoreDaemon arm64  <2bbd2aefc6f135e78733fcc18797fa2d> /System/Library/PrivateFrameworks/AppStoreDaemon.framework/AppStoreDaemon
0x198bfa000 - 0x198cf4fff MessageUI arm64  <86d11145916a3a81a425402bbfe289e4> /System/Library/Frameworks/MessageUI.framework/MessageUI
0x199f52000 - 0x199f61fff NewsFoundation arm64  <bb43db7444a4308f8deb47e072e15208> /System/Library/PrivateFrameworks/NewsFoundation.framework/NewsFoundation
0x199f62000 - 0x19a1b7fff NewsTransport arm64  <247b8be816813bcb879020dc9784fa69> /System/Library/PrivateFrameworks/NewsTransport.framework/NewsTransport
0x19a201000 - 0x19a256fff CallKit arm64  <9fbaff85ecd43e1ab9c95e5622b14f78> /System/Library/Frameworks/CallKit.framework/CallKit
0x19a2b6000 - 0x19a312fff IMAVCore arm64  <1dc9bf719d1f3019a7bc0de2f1a11fcb> /System/Library/PrivateFrameworks/IMAVCore.framework/IMAVCore
0x19a31f000 - 0x19a677fff NewsCore arm64  <070d4d119ab736a58268b814d375abff> /System/Library/PrivateFrameworks/NewsCore.framework/NewsCore
0x19a6b5000 - 0x19a6fdfff ClockKit arm64  <41ebfbf0ee843dda8904a9297a31296b> /System/Library/PrivateFrameworks/ClockKit.framework/ClockKit
0x19a71d000 - 0x19a721fff NewsDaemon arm64  <25123f25fe783e8a99c2e7a868427f97> /System/Library/PrivateFrameworks/NewsDaemon.framework/NewsDaemon
0x19acf8000 - 0x19ad0dfff NewsServicesInternal arm64  <d6990f1a592430ccae9ec20d17bc4d1d> /System/Library/PrivateFrameworks/NewsServicesInternal.framework/NewsServicesInternal
0x19aec8000 - 0x19aecefff DuetRecommendation arm64  <30818bf2652c31d59a175fb3f874b6d9> /System/Library/PrivateFrameworks/DuetRecommendation.framework/DuetRecommendation
0x19b086000 - 0x19b0effff NewsToday arm64  <c6469fcb07aa3ac086aa76c266796937> /System/Library/PrivateFrameworks/NewsToday.framework/NewsToday
0x19b26c000 - 0x19b270fff NewsServices arm64  <7855ee5938db3dec969be9ffa93f5682> /System/Library/PrivateFrameworks/NewsServices.framework/NewsServices
0x19cb81000 - 0x19cba5fff AppSupportUI arm64  <a834561f64d337958f11376a97856ba4> /System/Library/PrivateFrameworks/AppSupportUI.framework/AppSupportUI
0x19f16b000 - 0x19f1b9fff DataDetectorsUI arm64  <11bff6b414993104945b3a090b65c49e> /System/Library/PrivateFrameworks/DataDetectorsUI.framework/DataDetectorsUI
0x1a317a000 - 0x1a342ffff RawCamera arm64  <f9c361f2865338dcbbacb8cf8f910f66> /System/Library/CoreServices/RawCamera.bundle/RawCamera
0x1a352c000 - 0x1a3540fff libCGInterfaces.dylib arm64  <ad5b2e34ffdd36c4afc9dbbaa93a146f> /System/Library/Frameworks/Accelerate.framework/Frameworks/vImage.framework/Libraries/libCGInterfaces.dylib
0x1a5ad0000 - 0x1a5af7fff CoreServicesInternal arm64  <f1e975f233a335eab52a486ec25520a9> /System/Library/PrivateFrameworks/CoreServicesInternal.framework/CoreServicesInternal
0x1a60c6000 - 0x1a60d7fff libGSFontCache.dylib arm64  <50b74f1d848d3bb693fedc5ec5abcdd4> /System/Library/PrivateFrameworks/FontServices.framework/libGSFontCache.dylib
0x1a60d8000 - 0x1a610afff libTrueTypeScaler.dylib arm64  <61cf1230be373f8c8defd2cfe3e8fd79> /System/Library/PrivateFrameworks/FontServices.framework/libTrueTypeScaler.dylib
0x1a6a39000 - 0x1a6a39fff libmetal_timestamp.dylib arm64  <f18a626680ea3501b7fdf6042433c155> /System/Library/PrivateFrameworks/GPUCompiler.framework/Libraries/libmetal_timestamp.dylib
0x1a78fa000 - 0x1a78fdfff InternationalSupport arm64  <3b40414b65b035ebac8c2f2ecd3be78e> /System/Library/PrivateFrameworks/InternationalSupport.framework/InternationalSupport
0x1a966f000 - 0x1a9674fff TextInputUI arm64  <c60ab0c23a5235fca90ad0601ab45c21> /System/Library/PrivateFrameworks/TextInputUI.framework/TextInputUI
0x1ab4d4000 - 0x1ab594fff AGXMetalA11 arm64  <72735d64c0023a3caa62b6f20919b180> /System/Library/Extensions/AGXMetalA11.bundle/AGXMetalA11
0x1ab7e6000 - 0x1ab817fff libclosured.dylib arm64  <aefc8840686d30a88277d7efcb70abaf> /usr/lib/closure/libclosured.dylib

EOF

Basic Information

  • Version with issue: XF

  • Last known good version:

  • IDE: VS 2017

  • Platform Target Frameworks:

  • iOS: 9, 10, 11

  • XCode 9.2

  • Nuget Packages: Xamarin.Forms 2.3.4.270

  • Affected Devices: iOS Phones

@pauldipietro pauldipietro added this to New in Triage Jan 31, 2018
@PureWeen PureWeen changed the title Race condition between the main thread and a thread used by CADisplayLinkTicker [iOS] Race condition between the main thread and a thread used by CADisplayLinkTicker Feb 2, 2018
@PureWeen
Copy link
Contributor

PureWeen commented Feb 2, 2018

Would it be possible to provide a repro project for this issue so that we can accurately reproduce and fix?

@PureWeen PureWeen moved this from New to Needs Info in Triage Feb 2, 2018
@PureWeen PureWeen added s/needs-repro ❔ This reported issue doesn't include a sample project reproducing the issue. Please provide one. s/needs-info ❓ A question has been asked that requires an answer before work can continue on this issue. labels Feb 4, 2018
@samhouts
Copy link
Member

@nestor-nov Have you had a chance to together a reproduction project? Thanks

@PradoVargasN
Copy link
Author

I'll provide it next week.

@michaelkociansde
Copy link

michaelkociansde commented Mar 7, 2018

Have you solved this problem? I have very similar one. StackTrace points to the SkiaSharp surface.canvas.DrawPath(path, Paint); in method bound to the event PaintSurface. The crash occurs randomly but about 30-90seconds after the startup.

EDIT: downgrade to 1.59.0 solved it

@PureWeen
Copy link
Contributor

Closing for now. If still happening please attach a repro and reopen

Triage automation moved this from Needs Info to Closed Mar 28, 2018
@PradoVargasN
Copy link
Author

PradoVargasN commented Apr 2, 2018

@PureWeen @samhouts please reopen.

CADError.zip

Reproduction project, this is an iOS-only issue, also it only happens on physical devices we used an iPhone 8 (MQ6G2VC/A) version 11.2.6

For us it takes 1 to 5 minutes for the app to crash.

Thanks.

@PureWeen PureWeen reopened this Apr 3, 2018
Triage automation moved this from Closed to Reopened Apr 3, 2018
@PureWeen PureWeen removed s/needs-info ❓ A question has been asked that requires an answer before work can continue on this issue. s/needs-repro ❔ This reported issue doesn't include a sample project reproducing the issue. Please provide one. labels Apr 3, 2018
@jassmith
Copy link

jassmith commented Apr 7, 2018

Annoying thanks, this is almost certainly due to the off thread update to CALayer (which is allowed normally). We'll probably need to provide a mechanism to disable that wholesale for users like yourself.

@jassmith jassmith moved this from Reopened to Ready For Work in Triage Apr 7, 2018
@samhouts samhouts added this to To do in Sprint 138 Jul 2, 2018
@samhouts samhouts added this to To do in Sprint 139 via automation Jul 23, 2018
@samhouts samhouts added i/critical i/high Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often m/low impact ◾ e/1 🕐 1 and removed i/critical labels Jul 23, 2018
@samhouts samhouts removed this from To do in Sprint 139 Jul 24, 2018
@samhouts samhouts added this to To do in Sprint 140 Aug 11, 2018
@samhouts samhouts added this to To do in Sprint 141 Sep 1, 2018
@samhouts samhouts self-assigned this Sep 4, 2018
@samhouts samhouts moved this from To do to In progress in Sprint 141 Sep 6, 2018
@samhouts samhouts added this to In Progress in v3.6.0 Sep 13, 2018
@samhouts samhouts moved this from In progress to Ready for Review (Issues) in Sprint 141 Sep 13, 2018
@samhouts samhouts removed this from Ready For Work in Triage Sep 13, 2018
@samhouts samhouts removed this from In Progress in v3.6.0 Sep 14, 2018
@samhouts samhouts added this to In Progress in v3.4.0 Sep 14, 2018
@samhouts samhouts added this to To do in Sprint 142 Sep 21, 2018
@samhouts samhouts moved this from To do to Ready for Review (Issues) in Sprint 142 Sep 21, 2018
@samhouts samhouts added this to In Progress in v3.6.0 Oct 2, 2018
@samhouts samhouts removed this from In Progress in v3.4.0 Oct 2, 2018
Sprint 142 automation moved this from Ready for Review (Issues) to Done Oct 4, 2018
samhouts added a commit that referenced this issue Oct 4, 2018
… thread (#3774)

* [iOS] Add ability to turn off updates to native controls from another thread

* Flip evaluation order

fixes #1755
andreinitescu pushed a commit to andreinitescu/Xamarin.Forms that referenced this issue Oct 5, 2018
… thread (xamarin#3774)

* [iOS] Add ability to turn off updates to native controls from another thread

* Flip evaluation order

fixes xamarin#1755
@samhouts samhouts moved this from In Progress to Done in v3.6.0 Oct 5, 2018
@samhouts samhouts removed this from Done in v3.6.0 Oct 18, 2018
@samhouts samhouts added this to In Progress in v3.5.0 Oct 18, 2018
@samhouts samhouts moved this from In Progress to Done in v3.5.0 Oct 18, 2018
@samhouts samhouts removed this from Done in v3.5.0 Nov 19, 2018
samhouts pushed a commit that referenced this issue Nov 27, 2018
* Update from origin (#8)

* [C] VisibilityConverter Trims input (#3581)

For CSS purposes, the VisibilityConverter was added, and actually
replaced the `Boolean.Parse(str)` call for parsing Visibility.
`Boolean.Parse()` trims input, and the converter was not, so this was a
regression.
This changes Trim() the input, to be fully backward compatible.

- fixes #3554

* Ensure ConstructorCountId and TimeId elements are available before querying them (#3588)

* For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589)

This would allow previewer/designer/reloader to determine the source of a
stylesheet and refresh its content when appropriate.

* Revert "For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589)"

This reverts commit f66a72de5b475a6a8387a80e418997b38dc40d4c.

* Fix NRE; Ret 0 if Text null (#3594) fixes #3579

* [UWP, WPF] Fixes rendering of the main page (#2896) fixes #2704

* [Core] Ignore Shamehat target when running DesignTimeBuild (#3605)

* [XamlC] Fix binding compilation fo value types (#3551)

properly load valuetype arguments of generated setters, using ldarg,
instead of ldarga.

- fixes #3539

* Update PULL_REQUEST_TEMPLATE.md

* Update PULL_REQUEST_TEMPLATE.md

* [Android] Fix Label LineHeight (#3452)

* fix line height android

* Make UAP respect initial LineHeight

* update .create-nuget.bat (#3638)

* Add Null Check to GetRenderer (#3575)

- fix #3563

* Fix 3562 Null Reference Exception (#3576)

- fixes #3562

* Fix 3564 Null Reference Exception (#3578)

- fixes #3564

* [iOS] AutomationProperty support for cells (#3313) fixes #3296

* [iOS] AutomationProperty support for cells

* Add test case to AutomationProperties gallery

* [UWP] Fix crash app when create navigation/tabbed page without children pages fixes #3188 (#3514)

* [Android] Use height when determining ScaledScreenSize; fixes #3609 (#3641)

* [C] Set binding context on Span Gestures (#3639)

* [Core] Set binding context on Span Gestures
* [Core] Simplify loop setting child binding context

- fixes #3524

* Update PULL_REQUEST_TEMPLATE.md

* [Android] remove deprecated AndroidUseLatestPlatformSdk (#3672)

* [iOS] iPad ActionSheet should always have a Cancel method (#3636)

* Add repro for #3049

* [iOS] iPad ActionSheet should always have a Cancel method

fixes #3049

* [Android] fixes #3675 - set  initial ScrollView Scroll values when RTL (#3676)

* [Android] API check for Shadow properties on Button (#3617) fixes #2702

* [Android] API check for Shadow properties on Button

* Fix swapped shadow values

* [iOS] fixes #3525 - add epsilon for float compare (#3654)

* [iOS] fixes #3525 - add epsilon for float compare and make region immutable

* [ControlGallery] spread out spans to account for click slop

* [ControlGallery] - adjust span slightly for android test

* [Core] remove private

* Fix text wrapping (#3671) fixes #3634

* [GTK] Fix navigation bar visibility updates (#3651)

* Fix partially  #3585 (#3592)

* Make webkit-sharp.dll.config cross-platform

* Update webkit-sharp.dll with missing signals bindings

see: https://github.com/ylatuya/webkit-sharp/tree/fluendo

* [iOS, UWP] fixes #2894 - Gestures collection changes weren't correctly propagating (#3643)

* [iOS, UWP] fixes #2894 - Gestures weren't wiring up to spans in all cases

* [Core] remove ChildGestureRecognizers when spans get removed

* [iOS] removed incorrect return from null

* Fixes #3663 (#3684)

* Fix ScrollView Padding issue (#3685)

* [WPF] Memory leak when you pop a TabbedPage (#3372) fixes #3267

* Fix [WPF] Memory leak when you pop a TabbedPage

* Update ViewRenderer.cs

* Update ViewRenderer.cs

* [Android,iOS,UWP] Allow Entry CursorPosition/SelectionLength to be set in ctor (#3402) fixes #3343 fixes #3633

* Add repro for #3343 + unit tests

* [Core] Disallow negative values for CursorPosition/SelectionLength

* [All] CursorPosition/SelectionLength can bindin ctor & clear value

fixes #3343

* typo

* cleanup

* [iOS] Cursor snaps to end

* try/catch

* [CSS] add more properties (#3466)

map new CSS properties:
- `color` on `IColorElement` (`ActivityIndicator`, `BoxView`),
  `ProgressBar` and `Switch`
- `row-gap` and `column-gap` on `Grid`
- `transform` and `transform-origin` on `VisualElement`
- `vertical-align` on `Label`

add new XF-specific CSS properties
- `-xf-placeholder` and `-xf-placeholder-color` on `Editor`, `Entry`,
  `SearchBar`
- `-xf-max-length` on `InputView` (`Editor` and `Entry`)
- `-xf-bar-background-color` and `-xf-bar-text-color` on
  `NavigationPage` and `TabbedPage`
- `-xf-orientation` on `ScrollView` and `StackLayout`
- `-xf-horizontal-scroll-bar-visibility` and
  `-xf-vertical-scroll-bar-visibility` on `ScrollView`
- `-xf-min-track-color`, `-xf-max-track-color` and `("-xf-thumb-color`
  on `Slider`
- `-xf-spacing` on `StackLayout`

This PR replaces and closes #3276

- fixes #2891

* [iOS] Specify a default size for UISearchBar width if needed (#3635) fixes #3413 fixes #2139

* [Controls] Add reproduction and test case for issue #3413

* [iOS] Don't use max value for iOS UISearchbar breaks on iOS 11.3

* [iOS] Force width value so we can renderer UISearchBar on iOS10 with infinite width

* [Controls] Fix spelling and add Manual Review to the test of #3413

* [iOS] Simplify code for UISearchBar width

* [iOS] Return always some width from measure the UISearchBar on IOS

* [Controls] Add reproduction case for issue #2139

* [UWP] Fixed double set margins in Layouts (#3570) fixes #3398 fixes #3616

* [Android] Support multiple clipping settings in single layout (#3559)

* Repro

* Fix for API 18+

*  [iOS] Unsubscribe CellPropertyChanged when SwitchCellRenderer is disposed (#3518)

* [Controls] Add repo of issue #3408

* [iOS] Unsubscribe CellPropertyChanged when cell is disposed

* [Controls] Add issue to project

* [iOS] Introduce CellPropertyChange to CellTableViewCell to used by all other cell renderers

* [Controls] Simplify Issue

* [iOS] Remove PropertyChanged that was not used

* [Controls] add check for null binding on template, add notes about issues

* [Controls] added reference to Android crash

* [iOS]Use existing PropertyChanged on ViewCelRenderer

* [iOS] Keep the existing override so we don't break users

* Update TextCellRenderer.cs

* update submodule

* 24H Mode (#3701)

The 24h mode for the pickerdialog was not working.

Version 3.1 was working fine. 

Here is an updated file.

* [UWP] uncomment tests that are now passing for 3188 (#3723)

* [UITest] Update Xamarin.UITest nuget package (#3632)

* [UITests] Update Xamarin.UITest 2.2.5

* [UITests] Try fix Toolbaritems

* [UITest] Update to 2.2.5-1606

* [UITests] Small Fixes and workarounds to make uitest happy

* [UITests ] Add delay to 1733 for API28

* [Android] Revert bad merge (#3746)

fixes #3705

* [Android, iOS] Fixes layout compression causes (#3698) fixes #3624

* [Android, iOS] Fixes layout compression causes

* [iOS] improve UpdateNewElement method

* Fix build error hopefully

* [UWP] Fixes CollectionChanged events in ListView (#3323)

* fixes #3273

* [UWP] Fixes CollectionChanged events in ListView

* a wrapped collection is used only if the SourceItem is not ObservableCollection

* improve uitest

* fixed NRE in empty ListView

* added a sortable custom renderer for UItest

* minor refactoring

* fixed reset of not wrapped collections

* addressing comments

* [UWP] remove WinRT hack

* [UWP] add missing using and cleanup additional resources

* [Android] Update Forms to remove API28 deprecated API (#3653) fixes #2128 fixes #3629

* [Build] Update provisioning

* [Controls] Ignore deprecated  Android API usage

* [Android] Remove use of obsolete color usage

* [Android] Remove app fragment usage

* [android] Rollback changes to EntryCellRenderer

* [Android] Better way to get the default color for the label text

* [Android] Obsolete message for ContentPage.CreateFragment()

* [ControlGallery] - create bitmap from Drawable to use for pixel location

* [Android] Use textcolor resource

* Update submodule

* Fix tests (#3771)

* [ControlGallery] Wait for element and add timing to tests

* [iOS] Fix NRE on RenderPool

* Add TabStop/TabIndex (#2795)

* [Core, UWP, Android] support TabStop/TabIndex

* removing linq

* add iOS / MacOS implementation

* add WPF implementation
fixes UWP implementation

* - addressing comments
- improve test
- optimizations
- added previous tab direction in same tab group

* addressing comments

* [Android] support tabstop for pickers

* - moving shared code to a static class
- removed reflection

* ITabStop -> changed to internal, renamed, added in to fastRenderers

* Update ITabStop to be public

* Fix : Binding Icon in ToolbarItem in TabbedPage doesn't refresh (#3761) fixes #3756

* [iOS] Fix NRE on ContextCell (#3714) fixes #3275

* [Controls] Add repo for issue #3275

* [iOS] Fix NRE when no gestures exist on table

* [iOS] Null check outside loop

* [iOS]Make sure to dispose/unhook when we are removed from UITableView.

* Update submodule

* [iOS] Don't double dispose ContextActionCell

* WPF - Fix Width and Height measurement when GetDesiredSize (#3750)

* WPF - Reset Width and Height when GetDesiredSize

* Some formatting changes

* Add APP directive

* [WPF]Fix build

* [Android Maps] Make markers available to subclasses (#3751)

* Make markers available to subclasses

* Fix build

* Use Find instead of FirstOrDefault

* [UITests] wait for element before querying for it (#3791)

* [UITests] wait for element before querying for it

* [Controls] generalize and better represent intended behavior

* WPF - Fix Local store not persistant when restarting App (#3752)

-fixes #3541
* WPF - Fix Local store not persistant when restarting App
* Add UITest
* [Controls] Add automated UI Test

* [UITests] Isolate test 3408

* [UITest] Update Xamarin UITest packages

* [UWP] implement Replace without reloading ListView (#3792)

-fixes #3788
* [UWP] implement Replace without reloading ListView
* [UWP] extract bindingcontext of new item for replace

* [iOS] Use UIApperance default color for UISwitch (#3819)

* [Controls] Set default color of UISwitch to Red

* [iOS] Use default color from Apperance API

* [UITests] replace awaits with more reliable WaitForElement (#3835)

* [Core] Propagate BindingContext changes to TitleView (#3823)

* [Core] Propagate BindingContext changes to TitleView

* [Tests] Move UI test to Core Unit Test

* [A] do not draw gradient for empty CornerRadius (#3786)

Drawing CornerRadius (introduce by #1998) when the CornerRadii are
actually 0 causes scaling artifacts on API < 25.

This fixes the regression when no CornerRadius is set. Expect blurry
border scaling with CornerRadius not empty and API < 25

- fixes #3781

* [Android] Fix WebView.Navigating event, make WebViewClient inheritable (#3780)

* Extracted WebViewRenderer.WebClient to FormsWebViewClient, moved SendNavigating call from ShouldOverrideUrlLoading to OnPageStarted

* Changed _webViewClient and GetWebViewClient() method to return base class

* Changed public things to protected internal

* Fix spaces to tabs indentation to match the coding style (#3745)

* [Build] Fix merge

* Fix #3097 swipe gesture not being handled in VisualElementTracker. (#3098) Fixes #3097

* Update from origin (#9)

* [C] VisibilityConverter Trims input (#3581)

For CSS purposes, the VisibilityConverter was added, and actually
replaced the `Boolean.Parse(str)` call for parsing Visibility.
`Boolean.Parse()` trims input, and the converter was not, so this was a
regression.
This changes Trim() the input, to be fully backward compatible.

- fixes #3554

* Ensure ConstructorCountId and TimeId elements are available before querying them (#3588)

* For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589)

This would allow previewer/designer/reloader to determine the source of a
stylesheet and refresh its content when appropriate.

* Revert "For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589)"

This reverts commit f66a72de5b475a6a8387a80e418997b38dc40d4c.

* Fix NRE; Ret 0 if Text null (#3594) fixes #3579

* [UWP, WPF] Fixes rendering of the main page (#2896) fixes #2704

* [Core] Ignore Shamehat target when running DesignTimeBuild (#3605)

* [XamlC] Fix binding compilation fo value types (#3551)

properly load valuetype arguments of generated setters, using ldarg,
instead of ldarga.

- fixes #3539

* Update PULL_REQUEST_TEMPLATE.md

* Update PULL_REQUEST_TEMPLATE.md

* [Android] Fix Label LineHeight (#3452)

* fix line height android

* Make UAP respect initial LineHeight

* update .create-nuget.bat (#3638)

* Add Null Check to GetRenderer (#3575)

- fix #3563

* Fix 3562 Null Reference Exception (#3576)

- fixes #3562

* Fix 3564 Null Reference Exception (#3578)

- fixes #3564

* [iOS] AutomationProperty support for cells (#3313) fixes #3296

* [iOS] AutomationProperty support for cells

* Add test case to AutomationProperties gallery

* [UWP] Fix crash app when create navigation/tabbed page without children pages fixes #3188 (#3514)

* [Android] Use height when determining ScaledScreenSize; fixes #3609 (#3641)

* [C] Set binding context on Span Gestures (#3639)

* [Core] Set binding context on Span Gestures
* [Core] Simplify loop setting child binding context

- fixes #3524

* Update PULL_REQUEST_TEMPLATE.md

* [Android] remove deprecated AndroidUseLatestPlatformSdk (#3672)

* [iOS] iPad ActionSheet should always have a Cancel method (#3636)

* Add repro for #3049

* [iOS] iPad ActionSheet should always have a Cancel method

fixes #3049

* [Android] fixes #3675 - set  initial ScrollView Scroll values when RTL (#3676)

* [Android] API check for Shadow properties on Button (#3617) fixes #2702

* [Android] API check for Shadow properties on Button

* Fix swapped shadow values

* [iOS] fixes #3525 - add epsilon for float compare (#3654)

* [iOS] fixes #3525 - add epsilon for float compare and make region immutable

* [ControlGallery] spread out spans to account for click slop

* [ControlGallery] - adjust span slightly for android test

* [Core] remove private

* Fix text wrapping (#3671) fixes #3634

* [GTK] Fix navigation bar visibility updates (#3651)

* Fix partially  #3585 (#3592)

* Make webkit-sharp.dll.config cross-platform

* Update webkit-sharp.dll with missing signals bindings

see: https://github.com/ylatuya/webkit-sharp/tree/fluendo

* [iOS, UWP] fixes #2894 - Gestures collection changes weren't correctly propagating (#3643)

* [iOS, UWP] fixes #2894 - Gestures weren't wiring up to spans in all cases

* [Core] remove ChildGestureRecognizers when spans get removed

* [iOS] removed incorrect return from null

* Fixes #3663 (#3684)

* Fix ScrollView Padding issue (#3685)

* [WPF] Memory leak when you pop a TabbedPage (#3372) fixes #3267

* Fix [WPF] Memory leak when you pop a TabbedPage

* Update ViewRenderer.cs

* Update ViewRenderer.cs

* [Android,iOS,UWP] Allow Entry CursorPosition/SelectionLength to be set in ctor (#3402) fixes #3343 fixes #3633

* Add repro for #3343 + unit tests

* [Core] Disallow negative values for CursorPosition/SelectionLength

* [All] CursorPosition/SelectionLength can bindin ctor & clear value

fixes #3343

* typo

* cleanup

* [iOS] Cursor snaps to end

* try/catch

* [CSS] add more properties (#3466)

map new CSS properties:
- `color` on `IColorElement` (`ActivityIndicator`, `BoxView`),
  `ProgressBar` and `Switch`
- `row-gap` and `column-gap` on `Grid`
- `transform` and `transform-origin` on `VisualElement`
- `vertical-align` on `Label`

add new XF-specific CSS properties
- `-xf-placeholder` and `-xf-placeholder-color` on `Editor`, `Entry`,
  `SearchBar`
- `-xf-max-length` on `InputView` (`Editor` and `Entry`)
- `-xf-bar-background-color` and `-xf-bar-text-color` on
  `NavigationPage` and `TabbedPage`
- `-xf-orientation` on `ScrollView` and `StackLayout`
- `-xf-horizontal-scroll-bar-visibility` and
  `-xf-vertical-scroll-bar-visibility` on `ScrollView`
- `-xf-min-track-color`, `-xf-max-track-color` and `("-xf-thumb-color`
  on `Slider`
- `-xf-spacing` on `StackLayout`

This PR replaces and closes #3276

- fixes #2891

* [iOS] Specify a default size for UISearchBar width if needed (#3635) fixes #3413 fixes #2139

* [Controls] Add reproduction and test case for issue #3413

* [iOS] Don't use max value for iOS UISearchbar breaks on iOS 11.3

* [iOS] Force width value so we can renderer UISearchBar on iOS10 with infinite width

* [Controls] Fix spelling and add Manual Review to the test of #3413

* [iOS] Simplify code for UISearchBar width

* [iOS] Return always some width from measure the UISearchBar on IOS

* [Controls] Add reproduction case for issue #2139

* [UWP] Fixed double set margins in Layouts (#3570) fixes #3398 fixes #3616

* [Android] Support multiple clipping settings in single layout (#3559)

* Repro

* Fix for API 18+

*  [iOS] Unsubscribe CellPropertyChanged when SwitchCellRenderer is disposed (#3518)

* [Controls] Add repo of issue #3408

* [iOS] Unsubscribe CellPropertyChanged when cell is disposed

* [Controls] Add issue to project

* [iOS] Introduce CellPropertyChange to CellTableViewCell to used by all other cell renderers

* [Controls] Simplify Issue

* [iOS] Remove PropertyChanged that was not used

* [Controls] add check for null binding on template, add notes about issues

* [Controls] added reference to Android crash

* [iOS]Use existing PropertyChanged on ViewCelRenderer

* [iOS] Keep the existing override so we don't break users

* Update TextCellRenderer.cs

* update submodule

* 24H Mode (#3701)

The 24h mode for the pickerdialog was not working.

Version 3.1 was working fine. 

Here is an updated file.

* [UWP] uncomment tests that are now passing for 3188 (#3723)

* [UITest] Update Xamarin.UITest nuget package (#3632)

* [UITests] Update Xamarin.UITest 2.2.5

* [UITests] Try fix Toolbaritems

* [UITest] Update to 2.2.5-1606

* [UITests] Small Fixes and workarounds to make uitest happy

* [UITests ] Add delay to 1733 for API28

* [Android] Revert bad merge (#3746)

fixes #3705

* [Android, iOS] Fixes layout compression causes (#3698) fixes #3624

* [Android, iOS] Fixes layout compression causes

* [iOS] improve UpdateNewElement method

* Fix build error hopefully

* [UWP] Fixes CollectionChanged events in ListView (#3323)

* fixes #3273

* [UWP] Fixes CollectionChanged events in ListView

* a wrapped collection is used only if the SourceItem is not ObservableCollection

* improve uitest

* fixed NRE in empty ListView

* added a sortable custom renderer for UItest

* minor refactoring

* fixed reset of not wrapped collections

* addressing comments

* [UWP] remove WinRT hack

* [UWP] add missing using and cleanup additional resources

* [Android] Update Forms to remove API28 deprecated API (#3653) fixes #2128 fixes #3629

* [Build] Update provisioning

* [Controls] Ignore deprecated  Android API usage

* [Android] Remove use of obsolete color usage

* [Android] Remove app fragment usage

* [android] Rollback changes to EntryCellRenderer

* [Android] Better way to get the default color for the label text

* [Android] Obsolete message for ContentPage.CreateFragment()

* [ControlGallery] - create bitmap from Drawable to use for pixel location

* [Android] Use textcolor resource

* Update submodule

* Fix tests (#3771)

* [ControlGallery] Wait for element and add timing to tests

* [iOS] Fix NRE on RenderPool

* Add TabStop/TabIndex (#2795)

* [Core, UWP, Android] support TabStop/TabIndex

* removing linq

* add iOS / MacOS implementation

* add WPF implementation
fixes UWP implementation

* - addressing comments
- improve test
- optimizations
- added previous tab direction in same tab group

* addressing comments

* [Android] support tabstop for pickers

* - moving shared code to a static class
- removed reflection

* ITabStop -> changed to internal, renamed, added in to fastRenderers

* Update ITabStop to be public

* Fix : Binding Icon in ToolbarItem in TabbedPage doesn't refresh (#3761) fixes #3756

* [iOS] Fix NRE on ContextCell (#3714) fixes #3275

* [Controls] Add repo for issue #3275

* [iOS] Fix NRE when no gestures exist on table

* [iOS] Null check outside loop

* [iOS]Make sure to dispose/unhook when we are removed from UITableView.

* Update submodule

* [iOS] Don't double dispose ContextActionCell

* WPF - Fix Width and Height measurement when GetDesiredSize (#3750)

* WPF - Reset Width and Height when GetDesiredSize

* Some formatting changes

* Add APP directive

* [WPF]Fix build

* [Android Maps] Make markers available to subclasses (#3751)

* Make markers available to subclasses

* Fix build

* Use Find instead of FirstOrDefault

* [UITests] wait for element before querying for it (#3791)

* [UITests] wait for element before querying for it

* [Controls] generalize and better represent intended behavior

* WPF - Fix Local store not persistant when restarting App (#3752)

-fixes #3541
* WPF - Fix Local store not persistant when restarting App
* Add UITest
* [Controls] Add automated UI Test

* [UITests] Isolate test 3408

* [UITest] Update Xamarin UITest packages

* [UWP] implement Replace without reloading ListView (#3792)

-fixes #3788
* [UWP] implement Replace without reloading ListView
* [UWP] extract bindingcontext of new item for replace

* [iOS] Use UIApperance default color for UISwitch (#3819)

* [Controls] Set default color of UISwitch to Red

* [iOS] Use default color from Apperance API

* [UITests] replace awaits with more reliable WaitForElement (#3835)

* [Core] Propagate BindingContext changes to TitleView (#3823)

* [Core] Propagate BindingContext changes to TitleView

* [Tests] Move UI test to Core Unit Test

* [A] do not draw gradient for empty CornerRadius (#3786)

Drawing CornerRadius (introduce by #1998) when the CornerRadii are
actually 0 causes scaling artifacts on API < 25.

This fixes the regression when no CornerRadius is set. Expect blurry
border scaling with CornerRadius not empty and API < 25

- fixes #3781

* [Android] Fix WebView.Navigating event, make WebViewClient inheritable (#3780)

* Extracted WebViewRenderer.WebClient to FormsWebViewClient, moved SendNavigating call from ShouldOverrideUrlLoading to OnPageStarted

* Changed _webViewClient and GetWebViewClient() method to return base class

* Changed public things to protected internal

* Fix spaces to tabs indentation to match the coding style (#3745)

* [Build] Fix merge

* Fix #3097 swipe gesture not being handled in VisualElementTracker. (#3098) Fixes #3097

* Ensure that the ListViewAdapter is no longer being used by the ListVi… (#3848) fixes #3603

* Ensure that the ListViewAdapter is no longer being used by the ListView before disposing it

* Remove `RemoveAllViews` from `Dispose`

* Update from origin (#11)

* [Android] Enable MaxLines and TextDecorations on fast renderers (#3878)

* enable MaxLines on fast renderers

* added text decoration functionality

* include test in project

* [Enhancement] Create a bindable property for AutomationId (#3879)

* create a bindable property for automationId

* make ClassId and AutomationId properties of Element

* add comments to .create-nuget.bat

* added preserve attribute (#3876) fixes #2306

* [Core] Moving Command's CanExecuteChanged to use the WeakEventManager (#3852) fixes #3656

* [Core]  Use WeakEventManager on CanExecuteChanged

* [Core]Add unit test for remove event handler with WeakEventManager

* [Core] Fix remove the correct handler

* [CSS] accept 'oblique' for 'font-style' (#3815) fixes #3808

- fixes #3808

* Prevent double time/date picker dialogs on Android when setting focus (#3899)

* Prevent double time/date picker dialogs on Android when setting focus (#3899)

* [Controls] Fix merge remove duplciated issue 3788

* WPF - Fix Unable to intercept back button (#3762)

* WPF - Fix Unable to intercept back button

* WPF - Improve OnBackButtonPressed

-fixes #3689

* Fix Bugzilla38723 (#3812)

fixes #2302

* [C] fix css mapping (#3919)

* [Android] Fix UI test 1851 (#3882)

* add preserve attribute

- fixes #2255


* added using System

* fixed spacing

* use TestContentPage

* fixed scope issues

* [Android] Make native Android Platforms accessible via Context (#3364)

* Make native Android Platforms accessible via Context

* Add null checks

* Added a disabled look to Android Toolbar Item images. (#3773)

* Added a disabled look to Android Toolbar Item images.

* Update NavigationPageRenderer.cs

Refactored DisabledToolbarAlpha into a constant as requested.

* [UWP] fixes tabstops of TimePicker, DatePiker. SearchBar, Stepper (#3896)

* [UWP] fixes tabstops of TimePicker, DatePiker. SearchBar, Stepper

* common code moved to VisualElementRenderer

* rename interface

fixes #3872

* [UWP] For the Slider default value of step is set to 1000 to match Android. (#3141)

* WPF - Ctrl+A does not select all in WPF password Entry (#3908)

* [WPF] Fix Height of items not consistent (#3925) fixes #3913

* Fix StartTimer and Ticker for UWP (#3911)

- fixes #1937

* Apply font fix for button and span (#3907)

* added instructions (#3891)

- fixes #2361

* [Android] Convert corner radius with correct pixel density (#3893) fixes #3884

* [Controls] Add Issue #3884 repo

* [Android] Convert  corner radius with correct pixel density fixes #3884

* [Controls] Update test message

* WPF - Fix TimePicker with short time pattern shows verbose time (#3924)

* Fix UI test 39378 (#3928)

fixes #2305

* Update ClipBounds when View bounds changes (#3909)

fixes #3717

* [C] catch AmbiguousMatchException on GetProps (#3915)

- fixes #3870

* Automate UI test B45702 (#3914) fixes #2389

* automate 45702

* fix indentation

* Fix bugzilla60787 (#3933)

* [Android]Fix for frame renderer's bug (bugzilla 60787).

#3902
https://bugzilla.xamarin.com/show_bug.cgi?id=60787
https://github.com/xamarin/Xamarin.Forms/issues/3902

* Add control to repro

* PR fix

* Build fix

* Build fix for Xamarin.Forms.Core.Android.UITests

* added instructions (#3926)

* [UWP] fixes flyout menu on cell item (#3682)

* Fix UI test B41424 needs instructions (#3942)

* Add manual test steps and checks for ui test

* step4Label text fix

* [iOS] fix full width issues for TitleView (#3939)

* [iOS] fix full width issues for TitleView

* [iOS] simplified iOS 10

fixes #3881
fixes #3679

* Changes in TableView GTK Control to allow refresh the content (#3941)

- fixes #3725

* Only set the Page Padding via SafeAreaInset on iOS (#3811)

* only set the Page Padding via SafeAreaInset on iOS
-fixes #3809

* [Controls] add waits for clicks in ui tests

* [Controls] remove wrong category

* [iOS] Move inset logic down into ios renderer

* Added logic to allow set the ListView SelectedIndex (#3948) fixes #3766

* Automate UI test 35127 (#3927)

* automate test
- fixes #2262
* indentation fix
* indentation fix 2

* Make GetIconDrawable virtual (#3967)

By making GetIconDrawable virtual for the Android TabbedPageRenderer it allows for the icon to come from other sources (like glyph fonts). This will work for both top and bottom tabs.

* [GTK] Fix visibility of hidden pages in the stack (#3904)

When navigating to a new page, we should hide the previous
content and show the new one so that the previous page
renderer is not taken in account for redraws and resizes

* [Android] If MaxLines is not explicitly set, let LineBreakMode handle it (#3936)

* [Android] If MaxLines is not explicitly set, all LineBreakMode to set it;
if MaxLines is explicitly set, MaxLines setting wins. Use a more reasonable
default for native MaxLines when handling it via LineBreakMode. Consolidate
MaxLines handling code between legacy and fast renderers. Remove unnecessary
setting of SingleLine (which only applies to input).
- fixes #3772

* Remove unnecessary maxLines setting

* Handle resetting MaxLines to -1/default

* Reinstate workaround for array bounds exception in older Android APIs

* Fix UI test B43941 (#3889)

* Add all platforms and remove non-deterministic behaviour

* Return back correct check of counter

* Endline fix

* remove childPages list

* [XamlC] avoid multiple subscription (#3969)

Avoid multiple subscription to PropertyChanged on TypedBindings

- fixes #3613
- fixes #3650

* Fix typos (mainly 'toogle' becoming 'toggle') (#3975)

* Fix Issue2597 Needs UI Test (#3966)

* Add test for issue 2597

* Fix space

* Add CODEOWNERS

* Fix PanGesture inside scroll issue https://github.com/xamarin/Xamarin… (#3842)

* Fix PanGesture inside scroll issue https://github.com/xamarin/Xamarin.Forms/issues/3840
- fixes #3840
* fixe formatting

* [UITest] added UI Test

* [Controls] adjusted UI Test button positions

* [UITEST]  simplify UI tests

* [C] add CSS mapping for max-lines (#3991)

- fixes #3982

* [iOS] Add ability to turn off updates to native controls from another thread (#3774)

* [iOS] Add ability to turn off updates to native controls from another thread

* Flip evaluation order

fixes #1755

* Fixed NotImplementedException refreshing items in WPF ListView (#3962)

* Fixed NotImplementedException refreshing items in WPF ListView

* Small changes in ListView events subscription

fixes #3309
fixes #3737
fixes #3648

* [GTK] Fix transparent background in visual elements (#3744)

* Fix ActivityIndicator.IsRunning state (#4007)

* add pdb for uap into nuget (#4015)

* update GitInfo

* [XamlC] don't compile bindings with Source (#3978)

Sources are usually x:reference that can't be resolved at compilation
time.

- fixes #3606

* [Xaml[C]] resolve Extensions first (#3977)

XamlLoader should first look for type with the Extension suffix. It used
to be the case, but somehow regressed.

- fixes https://github.com/xamarin/Xamarin.Forms/issues/3606#issuecomment-422377338

* [UWP] Document in the README.md the steps required to run UI Tests (#4014) fixes #3984

* [Tizen] Add TabIndex implement for Tizen renderer (#4046)

* [Tasks] multitarget the build tasks (#3895)

- fixes #2690
- closes #2706

* [UITests] Update TestCloud.Agent (#4055)

* [Tizen] Fix ProjectGuid for Forwarders (#4063)

* [Tizen] Fix ProjectGuid for Forwarders

* [Tizen] Make sure not to generate dependency file

* Correct minor typo (#4068)

* Added WebView Reload (#4013) fixes #3776

* Added WebView Reload

* WebView Reload Added Tizen suport

* [Tizen] Cleanup Code (#4080)

* fixed ios editor placeholder font (#4009)

* Prevented crash https://github.com/xamarin/Xamarin.Forms/issues/2291 (#4072)

- fixes #2291

* [Xaml] Allow OnPlat markup in Styles (#3995)

- fixes #3862

* [Xaml] fix Namescope being different than tree (#4089)

As part of #2556, the namescoping tree was assumed to be equiv to the
object tree, which is obviously wrong. This fixes it, while keeping the
old behavior as a fallback.

We might go further, but I can't come up with a reasonable scenario
failing.

- fixes #3821

* [Sample] [Android] Fixed PagesGallery.Droid build (#3999)

* fixed PagesGallery.Droid build

* Moved Xamarin.Forms.Platform.Android (Forwarders) reference to previous place

* updated project guid to lower case

* Fix typeface reset issue (#4019)

* Use ViewCompat to set and get label for view (#3996)

* Removing LineBreakMode support from WindowsResourcesProvider (#4024)

* Repro test page for 3979

* Removes LineBreakMode support from WindowsResourcesProvider as it is inconsistent with other platforms and caused issues when setting Span style to the default Device Styles

* [macOS] Fix NRE on Mojave when aligning the tile (#4086) fixes #3031

* [GTK] Add support for ClickGestureRecognizer (#3971)

* [GTK] Add support for ClickGestureRecognizer

* Add ClickGestureGalleryPage to test ClickGestureRecognizer

* [iOS] Label TextColor has no effect with FormattedString (#4043)

* https://github.com/xamarin/Xamarin.Forms/issues/4040 fix default font/color for formatted string

* https://github.com/xamarin/Xamarin.Forms/pull/4043 fixed naming, added test case

* Moved field and property to top

- fixes #4040

* fix build, tentatively (#4117)

* [Xaml] don't swallow exceptions from converters (#4100)

Compiled converters are invoked, by reflection, at compile time. Any
exception thrown there will be wrapped in a TargetInvocationException.
When that happens, we still want to expose the inner XamlParseException
to the user.

- fixes #4099

* housekeeping ended with https://github.com/xamarin/Xamarin.Forms/pull/3999 (#4105)

* Bump minimum Microsoft.NETCore.UniversalWindowsPlatform version to 6.0.12 (#4106)

* [Tizen] Fix Window alpha update timing (#4119)

* [UWP] fixed `MinimumDate` and `MaximumDate` properties of DatePicker (#3683) fixes #3331

* [WPF] Fixes `ControlTemplate` sizing issue (#2656)

- fixes #2642

* Remove BOM from nuspec (#4128)

* Navigation Page double Popped event Workaround (#3851) fixes #3509

* Navigation Page double Popped event Workaround

* [UITest] Add UI Test

* [Core] fix formatting

* revert formatting fix

* implemented workaround suggested by PureWeen

* removed whitespace

* moved ignorePopCall to a better location

* [Enhancements] Toolbar a11y  (#3974) fixes #1742 fixes #3795

* [Controls] Add automation id to icon

* [iOS] Add AutomationId support to MDP tooggle button

* [Android] Add support for AutomationId to ActionBarDrawerToggle and MasterDetailPage

* [IOS] Refactor and add Accessibility to ToolbarItems

* [iOS] Fix typos

* [Android] Add accessibility to ToolbarItems

* [UWP]  Refactor A11y to extensions

* [UWP]  Set Accessibility properties on ToolbarItems

* [UWP] Set accessibility to MDP button

* [ControlGallery] Add accessibility toolbaritems to gallery

* Comment test out

* [iOS] Fix NRE when Control is being disposed

* [UITests] Remove not used UITests file

* Implementation of method ForceUpdateSize for Cell on macOS (#4104)

* Implemented Cell ForceUpdateSize on macOS

* Tab Styling

* Prevent crash during setting NULL to element via interface method (#4179)

- fixes #4178
- fixes #4146

* https://github.com/xamarin/Xamarin.Forms/issues/4076 fix (#4161)

* [iOS] Rapidly clicking span (6 times at least) on UITest 3525 throws a null exception (#4109)

* https://github.com/xamarin/Xamarin.Forms/issues/3930 fix

* following convention

* [Android] Fixes AutomationProperties.Name on Button (#4094)

* [Android] Fixes AutomationProperties.Name on Button

* [Android] Fixes for Switch control

* UWP Toolbar dynamic overflow (#4022)

* Adding Windows specific ToolbarDynamicOverflowEnabled configuration

* Enabled ToolbarDynamicOverflowEnabled (pun intended) on page controls and renderers

* Issue 3988 sample

* Removed obsolete comment, cleaned up private and whitespace

* Added toolbar dynamic overflow examples for master detail page and tabbed page


- fixes #2057
- fixes #3988

* Add missing initial call to UpdateLineHeight; fixes #4136 (#4147)

* Added UI test to B45027 (#4079)

* Add UI test to B45027

* Changed execution of current UI test to Android platform

* Added iOS UI test to B45027

* Refactored UI test execution

* Fix https://github.com/xamarin/Xamarin.Forms/issues/3301 (#4164)

- fixes #3301

* [UWP] fixes entering text into SearchBar with UI Tests (#4173)

* [UWP] fixes entering text into SearchBar with UI Tests

* [UWP] ITabStopOnDescendants - fixed selection when setting focus from Selenium

* [UWP] Fix TitleView Width and MDP rendering quirks (#3987)

* [UWP] Fix TitleView Width and MDP rendering quirks

* [UWP] fix load timing for pushed pages and titleview

* [UWP] move renderer check

* [UWP] remove re-measure until 4116 fixed

- fixes #3828
- fixes #3834

* [macOS] NRE in WebViewRenderer (#4188) fixes #4001

* https://github.com/xamarin/Xamarin.Forms/issues/4001

* fixed build

* https://github.com/xamarin/Xamarin.Forms/issues/2831 fixes #2831 (#4111)

* [msbuild] use portable pdb files (#4201)

Currently, on the first build of a "Hello World" Xamarin.Forms app,
you will see this in the build log:

    ConvertDebuggingFiles
        Parameters
            Files
                C:\Users\myuser\.nuget\packages\xamarin.forms\3.1.0.697729\lib\MonoAndroid10\FormsViewGroup.pdb
                C:\Users\myuser\.nuget\packages\xamarin.forms\3.1.0.697729\lib\MonoAndroid10\Xamarin.Forms.Platform.Android.pdb
        OutputItems
            _ConvertedDebuggingFiles
                C:\Users\myuser\.nuget\packages\xamarin.forms\3.1.0.697729\lib\MonoAndroid10\FormsViewGroup.dll
                C:\Users\myuser\.nuget\packages\xamarin.forms\3.1.0.697729\lib\MonoAndroid10\Xamarin.Forms.Platform.Android.dll

The logging is a little weird here, but this `ConvertDebuggingFiles`
MSBuild task takes about 100ms on my machine.

What is it doing?

The Mono debugger can support two types of debugging files:
- `mdb` files
- "portable" `pdb` files

If Xamarin.Android's build finds a "non-portable" `pdb` file, we have
to run it through this task to convert to an `mdb` file... This gives
us proper stacktraces for `FormsViewGroup.dll` and
`Xamarin.Forms.Platform.Android.dll`.

You can change the type of debugging symbols in your project with the
`DebugType` setting, which has these options:
- Blank or `None`: don't generate symbols. (Although Xamarin.Android
  has funny behavior here, see:
  https://github.com/xamarin/xamarin-android/issues/2282)
- `Full` generates an `mdb` file, this is a Windows-proprietary format
  for debug builds
- `PdbOnly` generates a "non-portable" `pdb` file, a
  Windows-proprietary format for release builds
- `Portable` generates a "portable" pdb file, which is the new
  standard that works for debug and release builds. New SDK-style
  MSBuild projects use this option by default.

These values are not case sensitive, I have mostly seen them lower
case in newer projects.

So what does Xamarin.Forms need to do?

Use `<DebugType>portable</DebugType>` in any Android class library or
app project. Other platforms, this is optional, not as much benefit. I
have heard that `DebugType=portable` might cause a problem on UWP.

* Xamarin.Forms will ship "portable" `pdbs` in its NuGet package for
  `FormsViewGroup.dll` and `Xamarin.Forms.*.Android.dll`. Developers
  won't pay the 100ms on initial build.
* Initial build times for `Xamarin.Forms.sln` will be slightly better
  for development, although I didn't measure the difference here.

* [XamlC] fix the argument match check for events (#4134)

Well, it looks like the order of arguments of InheritOrImplements was
reversed... a totally fine and normal Friday so far

- fixes #4130

* Add UI Test. Add instructions. Move to correct namespace (#4170) fixes #2251

* Add uitest for 2794 (#4110) fixes #2293

* Fix PropagateEvent value properly on Cells (#4191)

* bump gitinfo

* [Core, iOS, MacOS, Android, UWP, WPF] ListView hide scroll view scroll bars (#3897) fixes #3843

* Update from origin (#8)

* [C] VisibilityConverter Trims input (#3581)

For CSS purposes, the VisibilityConverter was added, and actually
replaced the `Boolean.Parse(str)` call for parsing Visibility.
`Boolean.Parse()` trims input, and the converter was not, so this was a
regression.
This changes Trim() the input, to be fully backward compatible.

- fixes #3554

* Ensure ConstructorCountId and TimeId elements are available before querying them (#3588)

* For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589)

This would allow previewer/designer/reloader to determine the source of a
stylesheet and refresh its content when appropriate.

* Revert "For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589)"

This reverts commit f66a72de5b475a6a8387a80e418997b38dc40d4c.

* Fix NRE; Ret 0 if Text null (#3594) fixes #3579

* [UWP, WPF] Fixes rendering of the main page (#2896) fixes #2704

* [Core] Ignore Shamehat target when running DesignTimeBuild (#3605)

* [XamlC] Fix binding compilation fo value types (#3551)

properly load valuetype arguments of generated setters, using ldarg,
instead of ldarga.

- fixes #3539

* Update PULL_REQUEST_TEMPLATE.md

* Update PULL_REQUEST_TEMPLATE.md

* [Android] Fix Label LineHeight (#3452)

* fix line height android

* Make UAP respect initial LineHeight

* update .create-nuget.bat (#3638)

* Add Null Check to GetRenderer (#3575)

- fix #3563

* Fix 3562 Null Reference Exception (#3576)

- fixes #3562

* Fix 3564 Null Reference Exception (#3578)

- fixes #3564

* [iOS] AutomationProperty support for cells (#3313) fixes #3296

* [iOS] AutomationProperty support for cells

* Add test case to AutomationProperties gallery

* [UWP] Fix crash app when create navigation/tabbed page without children pages fixes #3188 (#3514)

* [Android] Use height when determining ScaledScreenSize; fixes #3609 (#3641)

* [C] Set binding context on Span Gestures (#3639)

* [Core] Set binding context on Span Gestures
* [Core] Simplify loop setting child binding context

- fixes #3524

* Update PULL_REQUEST_TEMPLATE.md

* [Android] remove deprecated AndroidUseLatestPlatformSdk (#3672)

* [iOS] iPad ActionSheet should always have a Cancel method (#3636)

* Add repro for #3049

* [iOS] iPad ActionSheet should always have a Cancel method

fixes #3049

* [Android] fixes #3675 - set  initial ScrollView Scroll values when RTL (#3676)

* [Android] API check for Shadow properties on Button (#3617) fixes #2702

* [Android] API check for Shadow properties on Button

* Fix swapped shadow values

* [iOS] fixes #3525 - add epsilon for float compare (#3654)

* [iOS] fixes #3525 - add epsilon for float compare and make region immutable

* [ControlGallery] spread out spans to account for click slop

* [ControlGallery] - adjust span slightly for android test

* [Core] remove private

* Fix text wrapping (#3671) fixes #3634

* [GTK] Fix navigation bar visibility updates (#3651)

* Fix partially  #3585 (#3592)

* Make webkit-sharp.dll.config cross-platform

* Update webkit-sharp.dll with missing signals bindings

see: https://github.com/ylatuya/webkit-sharp/tree/fluendo

* [iOS, UWP] fixes #2894 - Gestures collection changes weren't correctly propagating (#3643)

* [iOS, UWP] fixes #2894 - Gestures weren't wiring up to spans in all cases

* [Core] remove ChildGestureRecognizers when spans get removed

* [iOS] removed incorrect return from null

* Fixes #3663 (#3684)

* Fix ScrollView Padding issue (#3685)

* [WPF] Memory leak when you pop a TabbedPage (#3372) fixes #3267

* Fix [WPF] Memory leak when you pop a TabbedPage

* Update ViewRenderer.cs

* Update ViewRenderer.cs

* [Android,iOS,UWP] Allow Entry CursorPosition/SelectionLength to be set in ctor (#3402) fixes #3343 fixes #3633

* Add repro for #3343 + unit tests

* [Core] Disallow negative values for CursorPosition/SelectionLength

* [All] CursorPosition/SelectionLength can bindin ctor & clear value

fixes #3343

* typo

* cleanup

* [iOS] Cursor snaps to end

* try/catch

* [CSS] add more properties (#3466)

map new CSS properties:
- `color` on `IColorElement` (`ActivityIndicator`, `BoxView`),
  `ProgressBar` and `Switch`
- `row-gap` and `column-gap` on `Grid`
- `transform` and `transform-origin` on `VisualElement`
- `vertical-align` on `Label`

add new XF-specific CSS properties
- `-xf-placeholder` and `-xf-placeholder-color` on `Editor`, `Entry`,
  `SearchBar`
- `-xf-max-length` on `InputView` (`Editor` and `Entry`)
- `-xf-bar-background-color` and `-xf-bar-text-color` on
  `NavigationPage` and `TabbedPage`
- `-xf-orientation` on `ScrollView` and `StackLayout`
- `-xf-horizontal-scroll-bar-visibility` and
  `-xf-vertical-scroll-bar-visibility` on `ScrollView`
- `-xf-min-track-color`, `-xf-max-track-color` and `("-xf-thumb-color`
  on `Slider`
- `-xf-spacing` on `StackLayout`

This PR replaces and closes #3276

- fixes #2891

* [iOS] Specify a default size for UISearchBar width if needed (#3635) fixes #3413 fixes #2139

* [Controls] Add reproduction and test case for issue #3413

* [iOS] Don't use max value for iOS UISearchbar breaks on iOS 11.3

* [iOS] Force width value so we can renderer UISearchBar on iOS10 with infinite width

* [Controls] Fix spelling and add Manual Review to the test of #3413

* [iOS] Simplify code for UISearchBar width

* [iOS] Return always some width from measure the UISearchBar on IOS

* [Controls] Add reproduction case for issue #2139

* [UWP] Fixed double set margins in Layouts (#3570) fixes #3398 fixes #3616

* [Android] Support multiple clipping settings in single layout (#3559)

* Repro

* Fix for API 18+

*  [iOS] Unsubscribe CellPropertyChanged when SwitchCellRenderer is disposed (#3518)

* [Controls] Add repo of issue #3408

* [iOS] Unsubscribe CellPropertyChanged when cell is disposed

* [Controls] Add issue to project

* [iOS] Introduce CellPropertyChange to CellTableViewCell to used by all other cell renderers

* [Controls] Simplify Issue

* [iOS] Remove PropertyChanged that was not used

* [Controls] add check for null binding on template, add notes about issues

* [Controls] added reference to Android crash

* [iOS]Use existing PropertyChanged on ViewCelRenderer

* [iOS] Keep the existing override so we don't break users

* Update TextCellRenderer.cs

* update submodule

* 24H Mode (#3701)

The 24h mode for the pickerdialog was not working.

Version 3.1 was working fine. 

Here is an updated file.

* [UWP] uncomment tests that are now passing for 3188 (#3723)

* [UITest] Update Xamarin.UITest nuget package (#3632)

* [UITests] Update Xamarin.UITest 2.2.5

* [UITests] Try fix Toolbaritems

* [UITest] Update to 2.2.5-1606

* [UITests] Small Fixes and workarounds to make uitest happy

* [UITests ] Add delay to 1733 for API28

* [Android] Revert bad merge (#3746)

fixes #3705

* [Android, iOS] Fixes layout compression causes (#3698) fixes #3624

* [Android, iOS] Fixes layout compression causes

* [iOS] improve UpdateNewElement method

* Fix build error hopefully

* [UWP] Fixes CollectionChanged events in ListView (#3323)

* fixes #3273

* [UWP] Fixes CollectionChanged events in ListView

* a wrapped collection is used only if the SourceItem is not ObservableCollection

* improve uitest

* fixed NRE in empty ListView

* added a sortable custom renderer for UItest

* minor refactoring

* fixed reset of not wrapped collections

* addressing comments

* [UWP] remove WinRT hack

* [UWP] add missing using and cleanup additional resources

* [Android] Update Forms to remove API28 deprecated API (#3653) fixes #2128 fixes #3629

* [Build] Update provisioning

* [Controls] Ignore deprecated  Android API usage

* [Android] Remove use of obsolete color usage

* [Android] Remove app fragment usage

* [android] Rollback changes to EntryCellRenderer

* [Android] Better way to get the default color for the label text

* [Android] Obsolete message for ContentPage.CreateFragment()

* [ControlGallery] - create bitmap from Drawable to use for pixel location

* [Android] Use textcolor resource

* Update submodule

* Fix tests (#3771)

* [ControlGallery] Wait for element and add timing to tests

* [iOS] Fix NRE on RenderPool

* Add TabStop/TabIndex (#2795)

* [Core, UWP, Android] support TabStop/TabIndex

* removing linq

* add iOS / MacOS implementation

* add WPF implementation
fixes UWP implementation

* - addressing comments
- improve test
- optimizations
- added previous tab direction in same tab group

* addressing comments

* [Android] support tabstop for pickers

* - moving shared code to a static class
- removed reflection

* ITabStop -> changed to internal, renamed, added in to fastRenderers

* Update ITabStop to be public

* Fix : Binding Icon in ToolbarItem in TabbedPage doesn't refresh (#3761) fixes #3756

* [iOS] Fix NRE on ContextCell (#3714) fixes #3275

* [Controls] Add repo for issue #3275

* [iOS] Fix NRE when no gestures exist on table

* [iOS] Null check outside loop

* [iOS]Make sure to dispose/unhook when we are removed from UITableView.

* Update submodule

* [iOS] Don't double dispose ContextActionCell

* WPF - Fix Width and Height measurement when GetDesiredSize (#3750)

* WPF - Reset Width and Height when GetDesiredSize

* Some formatting changes

* Add APP directive

* [WPF]Fix build

* [Android Maps] Make markers available to subclasses (#3751)

* Make markers available to subclasses

* Fix build

* Use Find instead of FirstOrDefault

* [UITests] wait for element before querying for it (#3791)

* [UITests] wait for element before querying for it

* [Controls] generalize and better represent intended behavior

* WPF - Fix Local store not persistant when restarting App (#3752)

-fixes #3541
* WPF - Fix Local store not persistant when restarting App
* Add UITest
* [Controls] Add automated UI Test

* [UITests] Isolate test 3408

* [UITest] Update Xamarin UITest packages

* [UWP] implement Replace without reloading ListView (#3792)

-fixes #3788
* [UWP] implement Replace without reloading ListView
* [UWP] extract bindingcontext of new item for replace

* [iOS] Use UIApperance default color for UISwitch (#3819)

* [Controls] Set default color of UISwitch to Red

* [iOS] Use default color from Apperance API

* [UITests] replace awaits with more reliable WaitForElement (#3835)

* [Core] Propagate BindingContext changes to TitleView (#3823)

* [Core] Propagate BindingContext changes to TitleView

* [Tests] Move UI test to Core Unit Test

* [A] do not draw gradient for empty CornerRadius (#3786)

Drawing CornerRadius (introduce by #1998) when the CornerRadii are
actually 0 causes scaling artifacts on API < 25.

This fixes the regression when no CornerRadius is set. Expect blurry
border scaling with CornerRadius not empty and API < 25

- fixes #3781

* [Android] Fix WebView.Navigating event, make WebViewClient inheritable (#3780)

* Extracted WebViewRenderer.WebClient to FormsWebViewClient, moved SendNavigating call from ShouldOverrideUrlLoading to OnPageStarted

* Changed _webViewClient and GetWebViewClient() method to return base class

* Changed public things to protected internal

* Fix spaces to tabs indentation to match the coding style (#3745)

* [Build] Fix merge

* Fix #3097 swipe gesture not being handled in VisualElementTracker. (#3098) Fixes #3097

* Implemented for iOS, Android and MacOS

* Implemented UAP and WPF

* Refactored duplicate code and removed typo in method name

* Update from origin (#9)

* [C] VisibilityConverter Trims input (#3581)

For CSS purposes, the VisibilityConverter was added, and actually
replaced the `Boolean.Parse(str)` call for parsing Visibility.
`Boolean.Parse()` trims input, and the converter was not, so this was a
regression.
This changes Trim() the input, to be fully backward compatible.

- fixes #3554

* Ensure ConstructorCountId and TimeId elements are available before querying them (#3588)

* For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589)

This would allow previewer/designer/reloader to determine the source of a
stylesheet and refresh its content when appropriate.

* Revert "For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589)"

This reverts commit f66a72de5b475a6a8387a80e418997b38dc40d4c.

* Fix NRE; Ret 0 if Text null (#3594) fixes #3579

* [UWP, WPF] Fixes rendering of the main page (#2896) fixes #2704

* [Core] Ignore Shamehat target when running DesignTimeBuild (#3605)

* [XamlC] Fix binding compilation fo value types (#3551)

properly load valuetype arguments of generated setters, using ldarg,
instead of ldarga.

- fixes #3539

* Update PULL_REQUEST_TEMPLATE.md

* Update PULL_REQUEST_TEMPLATE.md

* [Android] Fix Label LineHeight (#3452)

* fix line height android

* Make UAP respect initial LineHeight

* update .create-nuget.bat (#3638)

* Add Null Check to GetRenderer (#3575)

- fix #3563

* Fix 3562 Null Reference Exception (#3576)

- fixes #3562

* Fix 3564 Null Reference Exception (#3578)

- fixes #3564

* [iOS] AutomationProperty support for cells (#3313) fixes #3296

* [iOS] AutomationProperty support for cells

* Add test case to AutomationProperties gallery

* [UWP] Fix crash app when create navigation/tabbed page without children pages fixes #3188 (#3514)

* [Android] Use height when determining ScaledScreenSize; fixes #3609 (#3641)

* [C] Set binding context on Span Gestures (#3639)

* [Core] Set binding context on Span Gestures
* [Core] Simplify loop setting child binding context

- fixes #3524

* Update PULL_REQUEST_TEMPLATE.md

* [Android] remove deprecated AndroidUseLatestPlatformSdk (#3672)

* [iOS] iPad ActionSheet should always have a Cancel method (#3636)

* Add repro for #3049

* [iOS] iPad ActionSheet should always have a Cancel method

fixes #3049

* [Android] fixes #3675 - set  initial ScrollView Scroll values when RTL (#3676)

* [Android] API check for Shadow properties on Button (#3617) fixes #2702

* [Android] API check for Shadow properties on Button

* Fix swapped shadow values

* [iOS] fixes #3525 - add epsilon for float compare (#3654)

* [iOS] fixes #3525 - add epsilon for float compare and make region immutable

* [ControlGallery] spread out spans to account for click slop

* [ControlGallery] - adjust span slightly for android test

* [Core] remove private

* Fix text wrapping (#3671) fixes #3634

* [GTK] Fix navigation bar visibility updates (#3651)

* Fix partially  #3585 (#3592)

* Make webkit-sharp.dll.config cross-platform

* Update webkit-sharp.dll with missing signals bindings

see: https://github.com/ylatuya/webkit-sharp/tree/fluendo

* [iOS, UWP] fixes #2894 - Gestures collection changes weren't correctly propagating (#3643)

* [iOS, UWP] fixes #2894 - Gestures weren't wiring up to spans in all cases

* [Core] remove ChildGestureRecognizers when spans get removed

* [iOS] removed incorrect return from null

* Fixes #3663 (#3684)

* Fix ScrollView Padding issue (#3685)

* [WPF] Memory leak when you pop a TabbedPage (#3372) fixes #3267

* Fix [WPF] Memory leak when you pop a TabbedPage

* Update ViewRenderer.cs

* Update ViewRenderer.cs

* [Android,iOS,UWP] Allow Entry CursorPosition/SelectionLength to be set in ctor (#3402) fixes #3343 fixes #3633

* Add repro for #3343 + unit tests

* [Core] Disallow negative values for CursorPosition/SelectionLength

* [All] CursorPosition/SelectionLength can bindin ctor & clear value

fixes #3343

* typo

* cleanup

* [iOS] Cursor snaps to end

* try/catch

* [CSS] add more properties (#3466)

map new CSS properties:
- `color` on `IColorElement` (`ActivityIndicator`, `BoxView`),
  `ProgressBar` and `Switch`
- `row-gap` and `column-gap` on `Grid`
- `transform` and `transform-origin` on `VisualElement`
- `vertical-align` on `Label`

add new XF-specific CSS properties
- `-xf-placeholder` and `-xf-placeholder-color` on `Editor`, `Entry`,
  `SearchBar`
- `-xf-max-length` on `InputView` (`Editor` and `Entry`)
- `-xf-bar-background-color` and `-xf-bar-text-color` on
  `NavigationPage` and `TabbedPage`
- `-xf-orientation` on `ScrollView` and `StackLayout`
- `-xf-horizontal-scroll-bar-visibility` and
  `-xf-vertical-scroll-bar-visibility` on `ScrollView`
- `-xf-min-track-color`, `-xf-max-track-color` and `("-xf-thumb-color`
  on `Slider`
- `-xf-spacing` on `StackLayout`

This PR replaces and closes #3276

- fixes #2891

* [iOS] Specify a default size for UISearchBar width if needed (#3635) fixes #3413 fixes #2139

* [Controls] Add reproduction and test case for issue #3413

* [iOS] Don't use max value for iOS UISearchbar breaks on iOS 11.3

* [iOS] Force width value so we can renderer UISearchBar on iOS10 with infinite width

* [Controls] Fix spelling and add Manual Review to the test of #3413

* [iOS] Simplify code for UISearchBar width

* [iOS] Return always some width from measure the UISearchBar on IOS

* [Controls] Add reproduction case for issue #2139

* [UWP] Fixed double set margins in Layouts (#3570) fixes #3398 fixes #3616

* [Android] Support multiple clipping settings in single layout (#3559)

* Repro

* Fix for API 18+

*  [iOS] Unsubscribe CellPropertyChanged when SwitchCellRenderer is disposed (#3518)

* [Controls] Add repo of issue #3408

* [iOS] Unsubscribe CellPropertyChanged when cell is disposed

* [Controls] Add issue to project

* [iOS] Introduce CellPropertyChange to CellTableViewCell to used by all other cell renderers

* [Controls] Simplify Issue

* [iOS] Remove PropertyChanged that was not used

* [Controls] add check for null binding on template, add notes about issues

* [Controls] added reference to Android crash

* [iOS]Use existing PropertyChanged on ViewCelRenderer

* [iOS] Keep the existing override so we don't break users

* Update TextCellRenderer.cs

* update submodule

* 24H Mode (#3701)

The 24h mode for the pickerdialog was not working.

Version 3.1 was working fine. 

Here is an updated file.

* [UWP] uncomment tests that are now passing for 3188 (#3723)

* [UITest] Update Xamarin.UITest nuget package (#3632)

* [UITests] Update Xamarin.UITest 2.2.5

* [UITests] Try fix Toolbaritems

* [UITest] Update to 2.2.5-1606

* [UITests] Small Fixes and workarounds to make uitest happy

* [UITests ] Add delay to 1733 for API28

* [Android] Revert bad merge (#3746)

fixes #3705

* [Android, iOS] Fixes layout compression causes (#3698) fixes #3624

* [Android, iOS] Fixes layout compression causes

* [iOS] improve UpdateNewElement method

* Fix build error hopefully

* [UWP] Fixes CollectionChanged events in ListView (#3323)

* fixes #3273

* [UWP] Fixes CollectionChanged events in ListView

* a wrapped collection is used only if the SourceItem is not ObservableCollection

* improve uitest

* fixed NRE in empty ListView

* added a sortable custom renderer for UItest

* minor refactoring

* fixed reset of not wrapped collections

* addressing comments

* [UWP] remove WinRT hack

* [UWP] add missing using and cleanup additional resources

* [Android] Update Forms to remove API28 deprecated API (#3653) fixes #2128 fixes #3629

* [Build] Update provisioning

* [Controls] Ignore deprecated  Android API usage

* [Android] Remove use of obsolete color usage

* [Android] Remove app fragment usage

* [android] Rollback changes to EntryCellRenderer

* [Android] Better way to get the default color for the label text

* [Android] Obsolete message for ContentPage.CreateFragment()

* [ControlGallery] - create bitmap from Drawable to use for pixel location

* [Android] Use textcolor resource

* Update submodule

* Fix tests (#3771)

* [ControlGallery] Wait for element and add timing to tests

* [iOS] Fix NRE on RenderPool

* Add TabStop/TabIndex (#2795)

* [Core, UWP, Android] support TabStop/TabIndex

* removing linq

* add iOS / MacOS implementation

* add WPF implementation
fixes UWP implementation

* - addressing comments
- improve test
- optimizations
- added previous tab direction in same tab group

* addressing comments

* [Android] support tabstop for pickers

* - moving shared code to a static class
- removed reflection

* ITabStop -> changed to internal, renamed, added in to fastRenderers

* Update ITabStop to be public

* Fix : Binding Icon in ToolbarItem in TabbedPage doesn't refresh (#3761) fixes #3756

* [iOS] Fix NRE on ContextCell (#3714) fixes #3275

* [Controls] Add repo for issue #3275

* [iOS] Fix NRE when no gestures exist on table

* [iOS] Null check outside loop

* [iOS]Make sure to dispose/unhook when we are removed from UITableView.

* Update submodule

* [iOS] Don't double dispose ContextActionCell

* WPF - Fix Width and Height measurement when GetDesiredSize (#3750)

* WPF - Reset Width and Height when GetDesiredSize

* Some formatting changes

* Add APP directive

* [WPF]Fix build

* [Android Maps] Make markers available to subclasses (#3751)

* Make markers available to subclasses

* Fix build

* Use Find instead of FirstOrDefault

* [UITests] wait for element before querying for it (#3791)

* [UITests] wait for element before querying for it

* [Controls] generalize and better represent intended behavior

* WPF - Fix Local store not persistant when restarting App (#3752)

-fixes #3541
* WPF - Fix Local store not persistant when restarting App
* Add UITest
* [Controls] Add automated UI Test

* [UITests] Isolate test 3408

* [UITest] Update Xamarin UITest packages

* [UWP] implement Replace without reloading ListView (#3792)

-fixes #3788
* [UWP] implement Replace without reloading ListView
* [UWP] extract bindingcontext of new item for replace

* [iOS] Use UIApperance default color for UISwitch (#3819)

* [Controls] Set default color of UISwitch to Red

* [iOS] Use default color from Apperance API

* [UITests] replace awaits with more reliable WaitForElement (#3835)

* [Core] Propagate BindingContext changes to TitleView (#3823)

* [Core] Propagate BindingContext changes to TitleView

* [Tests] Move UI test to Core Unit Test

* [A] do not draw gradient for empty CornerRadius (#3786)

Drawing CornerRadius (introduce by #1998) when the CornerRadii are
actually 0 causes scaling artifacts on API < 25.

This fixes the regression when no CornerRadius is set. Expect blurry
border scaling with CornerRadius not empty and API < 25

- fixes #3781

* [Android] Fix WebView.Navigating event, make WebViewClient inheritable (#3780)

* Extracted WebViewRenderer.WebClient to FormsWebViewClient, moved SendNavigating call from ShouldOverrideUrlLoading to OnPageStarted

* Changed _webViewClient and GetWebViewClient() method to return base class

* Changed public things to protected internal

* Fix spaces to tabs indentation to match the coding style (#3745)

* [Build] Fix merge

* Fix #3097 swipe gesture not being handled in VisualElementTracker. (#3098) Fixes #3097

* Ensure that the ListViewAdapter is no longer being used by the ListVi… (#3848) fixes #3603

* Ensure that the ListViewAdapter is no longer being used by the ListView before disposing it

* Remove `RemoveAllViews` from `Dispose`

* Fixed code review comments

* Removed obsolete convert method

* Making sure default platform functionality is intact iOS and Android

As er code review comments

* Making sure default platform functionality is intact MacOS

* Making sure default platform functionality is intact UWP and WPF

* Code review comments for iOS, Android and MacOS

Default platform value is now preserved and applied when setting is set to default

* Code review comments UWP and WPF

* Fix build

* [UITest] - add ui test to test scroll permutations

* [Uwp] fix bad merge

* [wpf] fix spacing

* Adding instructions and UI tests for Bugzilla44461 (#4144)

* Adding instructions and UI tests for Bugzilla44461

* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla44461.cs

Co-Authored-By: mikescandy <michele.scandura@outlook.com>

* Fix assert

* [C] avoid AmbiguousMatchexception in Bindings (#4216) fixes #4215

if a type defines multiple op_implicit from the same type to different
ones, trying to retrieve it with GetMethod() throws an
AmbiguousMatchException. If this happens, we have to do the resolution
ourself.

- fixes #4215

* https://github.com/xamarin/Xamarin.Forms/issues/4076 fix (#4161)

…
rmarinho pushed a commit that referenced this issue Nov 27, 2018
…leSection (#4379) fixes #2910

* Update from origin (#8)

* [C] VisibilityConverter Trims input (#3581)

For CSS purposes, the VisibilityConverter was added, and actually
replaced the `Boolean.Parse(str)` call for parsing Visibility.
`Boolean.Parse()` trims input, and the converter was not, so this was a
regression.
This changes Trim() the input, to be fully backward compatible.

- fixes #3554

* Ensure ConstructorCountId and TimeId elements are available before querying them (#3588)

* For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589)

This would allow previewer/designer/reloader to determine the source of a
stylesheet and refresh its content when appropriate.

* Revert "For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589)"

This reverts commit f66a72de5b475a6a8387a80e418997b38dc40d4c.

* Fix NRE; Ret 0 if Text null (#3594) fixes #3579

* [UWP, WPF] Fixes rendering of the main page (#2896) fixes #2704

* [Core] Ignore Shamehat target when running DesignTimeBuild (#3605)

* [XamlC] Fix binding compilation fo value types (#3551)

properly load valuetype arguments of generated setters, using ldarg,
instead of ldarga.

- fixes #3539

* Update PULL_REQUEST_TEMPLATE.md

* Update PULL_REQUEST_TEMPLATE.md

* [Android] Fix Label LineHeight (#3452)

* fix line height android

* Make UAP respect initial LineHeight

* update .create-nuget.bat (#3638)

* Add Null Check to GetRenderer (#3575)

- fix #3563

* Fix 3562 Null Reference Exception (#3576)

- fixes #3562

* Fix 3564 Null Reference Exception (#3578)

- fixes #3564

* [iOS] AutomationProperty support for cells (#3313) fixes #3296

* [iOS] AutomationProperty support for cells

* Add test case to AutomationProperties gallery

* [UWP] Fix crash app when create navigation/tabbed page without children pages fixes #3188 (#3514)

* [Android] Use height when determining ScaledScreenSize; fixes #3609 (#3641)

* [C] Set binding context on Span Gestures (#3639)

* [Core] Set binding context on Span Gestures
* [Core] Simplify loop setting child binding context

- fixes #3524

* Update PULL_REQUEST_TEMPLATE.md

* [Android] remove deprecated AndroidUseLatestPlatformSdk (#3672)

* [iOS] iPad ActionSheet should always have a Cancel method (#3636)

* Add repro for #3049

* [iOS] iPad ActionSheet should always have a Cancel method

fixes #3049

* [Android] fixes #3675 - set  initial ScrollView Scroll values when RTL (#3676)

* [Android] API check for Shadow properties on Button (#3617) fixes #2702

* [Android] API check for Shadow properties on Button

* Fix swapped shadow values

* [iOS] fixes #3525 - add epsilon for float compare (#3654)

* [iOS] fixes #3525 - add epsilon for float compare and make region immutable

* [ControlGallery] spread out spans to account for click slop

* [ControlGallery] - adjust span slightly for android test

* [Core] remove private

* Fix text wrapping (#3671) fixes #3634

* [GTK] Fix navigation bar visibility updates (#3651)

* Fix partially  #3585 (#3592)

* Make webkit-sharp.dll.config cross-platform

* Update webkit-sharp.dll with missing signals bindings

see: https://github.com/ylatuya/webkit-sharp/tree/fluendo

* [iOS, UWP] fixes #2894 - Gestures collection changes weren't correctly propagating (#3643)

* [iOS, UWP] fixes #2894 - Gestures weren't wiring up to spans in all cases

* [Core] remove ChildGestureRecognizers when spans get removed

* [iOS] removed incorrect return from null

* Fixes #3663 (#3684)

* Fix ScrollView Padding issue (#3685)

* [WPF] Memory leak when you pop a TabbedPage (#3372) fixes #3267

* Fix [WPF] Memory leak when you pop a TabbedPage

* Update ViewRenderer.cs

* Update ViewRenderer.cs

* [Android,iOS,UWP] Allow Entry CursorPosition/SelectionLength to be set in ctor (#3402) fixes #3343 fixes #3633

* Add repro for #3343 + unit tests

* [Core] Disallow negative values for CursorPosition/SelectionLength

* [All] CursorPosition/SelectionLength can bindin ctor & clear value

fixes #3343

* typo

* cleanup

* [iOS] Cursor snaps to end

* try/catch

* [CSS] add more properties (#3466)

map new CSS properties:
- `color` on `IColorElement` (`ActivityIndicator`, `BoxView`),
  `ProgressBar` and `Switch`
- `row-gap` and `column-gap` on `Grid`
- `transform` and `transform-origin` on `VisualElement`
- `vertical-align` on `Label`

add new XF-specific CSS properties
- `-xf-placeholder` and `-xf-placeholder-color` on `Editor`, `Entry`,
  `SearchBar`
- `-xf-max-length` on `InputView` (`Editor` and `Entry`)
- `-xf-bar-background-color` and `-xf-bar-text-color` on
  `NavigationPage` and `TabbedPage`
- `-xf-orientation` on `ScrollView` and `StackLayout`
- `-xf-horizontal-scroll-bar-visibility` and
  `-xf-vertical-scroll-bar-visibility` on `ScrollView`
- `-xf-min-track-color`, `-xf-max-track-color` and `("-xf-thumb-color`
  on `Slider`
- `-xf-spacing` on `StackLayout`

This PR replaces and closes #3276

- fixes #2891

* [iOS] Specify a default size for UISearchBar width if needed (#3635) fixes #3413 fixes #2139

* [Controls] Add reproduction and test case for issue #3413

* [iOS] Don't use max value for iOS UISearchbar breaks on iOS 11.3

* [iOS] Force width value so we can renderer UISearchBar on iOS10 with infinite width

* [Controls] Fix spelling and add Manual Review to the test of #3413

* [iOS] Simplify code for UISearchBar width

* [iOS] Return always some width from measure the UISearchBar on IOS

* [Controls] Add reproduction case for issue #2139

* [UWP] Fixed double set margins in Layouts (#3570) fixes #3398 fixes #3616

* [Android] Support multiple clipping settings in single layout (#3559)

* Repro

* Fix for API 18+

*  [iOS] Unsubscribe CellPropertyChanged when SwitchCellRenderer is disposed (#3518)

* [Controls] Add repo of issue #3408

* [iOS] Unsubscribe CellPropertyChanged when cell is disposed

* [Controls] Add issue to project

* [iOS] Introduce CellPropertyChange to CellTableViewCell to used by all other cell renderers

* [Controls] Simplify Issue

* [iOS] Remove PropertyChanged that was not used

* [Controls] add check for null binding on template, add notes about issues

* [Controls] added reference to Android crash

* [iOS]Use existing PropertyChanged on ViewCelRenderer

* [iOS] Keep the existing override so we don't break users

* Update TextCellRenderer.cs

* update submodule

* 24H Mode (#3701)

The 24h mode for the pickerdialog was not working.

Version 3.1 was working fine. 

Here is an updated file.

* [UWP] uncomment tests that are now passing for 3188 (#3723)

* [UITest] Update Xamarin.UITest nuget package (#3632)

* [UITests] Update Xamarin.UITest 2.2.5

* [UITests] Try fix Toolbaritems

* [UITest] Update to 2.2.5-1606

* [UITests] Small Fixes and workarounds to make uitest happy

* [UITests ] Add delay to 1733 for API28

* [Android] Revert bad merge (#3746)

fixes #3705

* [Android, iOS] Fixes layout compression causes (#3698) fixes #3624

* [Android, iOS] Fixes layout compression causes

* [iOS] improve UpdateNewElement method

* Fix build error hopefully

* [UWP] Fixes CollectionChanged events in ListView (#3323)

* fixes #3273

* [UWP] Fixes CollectionChanged events in ListView

* a wrapped collection is used only if the SourceItem is not ObservableCollection

* improve uitest

* fixed NRE in empty ListView

* added a sortable custom renderer for UItest

* minor refactoring

* fixed reset of not wrapped collections

* addressing comments

* [UWP] remove WinRT hack

* [UWP] add missing using and cleanup additional resources

* [Android] Update Forms to remove API28 deprecated API (#3653) fixes #2128 fixes #3629

* [Build] Update provisioning

* [Controls] Ignore deprecated  Android API usage

* [Android] Remove use of obsolete color usage

* [Android] Remove app fragment usage

* [android] Rollback changes to EntryCellRenderer

* [Android] Better way to get the default color for the label text

* [Android] Obsolete message for ContentPage.CreateFragment()

* [ControlGallery] - create bitmap from Drawable to use for pixel location

* [Android] Use textcolor resource

* Update submodule

* Fix tests (#3771)

* [ControlGallery] Wait for element and add timing to tests

* [iOS] Fix NRE on RenderPool

* Add TabStop/TabIndex (#2795)

* [Core, UWP, Android] support TabStop/TabIndex

* removing linq

* add iOS / MacOS implementation

* add WPF implementation
fixes UWP implementation

* - addressing comments
- improve test
- optimizations
- added previous tab direction in same tab group

* addressing comments

* [Android] support tabstop for pickers

* - moving shared code to a static class
- removed reflection

* ITabStop -> changed to internal, renamed, added in to fastRenderers

* Update ITabStop to be public

* Fix : Binding Icon in ToolbarItem in TabbedPage doesn't refresh (#3761) fixes #3756

* [iOS] Fix NRE on ContextCell (#3714) fixes #3275

* [Controls] Add repo for issue #3275

* [iOS] Fix NRE when no gestures exist on table

* [iOS] Null check outside loop

* [iOS]Make sure to dispose/unhook when we are removed from UITableView.

* Update submodule

* [iOS] Don't double dispose ContextActionCell

* WPF - Fix Width and Height measurement when GetDesiredSize (#3750)

* WPF - Reset Width and Height when GetDesiredSize

* Some formatting changes

* Add APP directive

* [WPF]Fix build

* [Android Maps] Make markers available to subclasses (#3751)

* Make markers available to subclasses

* Fix build

* Use Find instead of FirstOrDefault

* [UITests] wait for element before querying for it (#3791)

* [UITests] wait for element before querying for it

* [Controls] generalize and better represent intended behavior

* WPF - Fix Local store not persistant when restarting App (#3752)

-fixes #3541
* WPF - Fix Local store not persistant when restarting App
* Add UITest
* [Controls] Add automated UI Test

* [UITests] Isolate test 3408

* [UITest] Update Xamarin UITest packages

* [UWP] implement Replace without reloading ListView (#3792)

-fixes #3788
* [UWP] implement Replace without reloading ListView
* [UWP] extract bindingcontext of new item for replace

* [iOS] Use UIApperance default color for UISwitch (#3819)

* [Controls] Set default color of UISwitch to Red

* [iOS] Use default color from Apperance API

* [UITests] replace awaits with more reliable WaitForElement (#3835)

* [Core] Propagate BindingContext changes to TitleView (#3823)

* [Core] Propagate BindingContext changes to TitleView

* [Tests] Move UI test to Core Unit Test

* [A] do not draw gradient for empty CornerRadius (#3786)

Drawing CornerRadius (introduce by #1998) when the CornerRadii are
actually 0 causes scaling artifacts on API < 25.

This fixes the regression when no CornerRadius is set. Expect blurry
border scaling with CornerRadius not empty and API < 25

- fixes #3781

* [Android] Fix WebView.Navigating event, make WebViewClient inheritable (#3780)

* Extracted WebViewRenderer.WebClient to FormsWebViewClient, moved SendNavigating call from ShouldOverrideUrlLoading to OnPageStarted

* Changed _webViewClient and GetWebViewClient() method to return base class

* Changed public things to protected internal

* Fix spaces to tabs indentation to match the coding style (#3745)

* [Build] Fix merge

* Fix #3097 swipe gesture not being handled in VisualElementTracker. (#3098) Fixes #3097

* Update from origin (#9)

* [C] VisibilityConverter Trims input (#3581)

For CSS purposes, the VisibilityConverter was added, and actually
replaced the `Boolean.Parse(str)` call for parsing Visibility.
`Boolean.Parse()` trims input, and the converter was not, so this was a
regression.
This changes Trim() the input, to be fully backward compatible.

- fixes #3554

* Ensure ConstructorCountId and TimeId elements are available before querying them (#3588)

* For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589)

This would allow previewer/designer/reloader to determine the source of a
stylesheet and refresh its content when appropriate.

* Revert "For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589)"

This reverts commit f66a72de5b475a6a8387a80e418997b38dc40d4c.

* Fix NRE; Ret 0 if Text null (#3594) fixes #3579

* [UWP, WPF] Fixes rendering of the main page (#2896) fixes #2704

* [Core] Ignore Shamehat target when running DesignTimeBuild (#3605)

* [XamlC] Fix binding compilation fo value types (#3551)

properly load valuetype arguments of generated setters, using ldarg,
instead of ldarga.

- fixes #3539

* Update PULL_REQUEST_TEMPLATE.md

* Update PULL_REQUEST_TEMPLATE.md

* [Android] Fix Label LineHeight (#3452)

* fix line height android

* Make UAP respect initial LineHeight

* update .create-nuget.bat (#3638)

* Add Null Check to GetRenderer (#3575)

- fix #3563

* Fix 3562 Null Reference Exception (#3576)

- fixes #3562

* Fix 3564 Null Reference Exception (#3578)

- fixes #3564

* [iOS] AutomationProperty support for cells (#3313) fixes #3296

* [iOS] AutomationProperty support for cells

* Add test case to AutomationProperties gallery

* [UWP] Fix crash app when create navigation/tabbed page without children pages fixes #3188 (#3514)

* [Android] Use height when determining ScaledScreenSize; fixes #3609 (#3641)

* [C] Set binding context on Span Gestures (#3639)

* [Core] Set binding context on Span Gestures
* [Core] Simplify loop setting child binding context

- fixes #3524

* Update PULL_REQUEST_TEMPLATE.md

* [Android] remove deprecated AndroidUseLatestPlatformSdk (#3672)

* [iOS] iPad ActionSheet should always have a Cancel method (#3636)

* Add repro for #3049

* [iOS] iPad ActionSheet should always have a Cancel method

fixes #3049

* [Android] fixes #3675 - set  initial ScrollView Scroll values when RTL (#3676)

* [Android] API check for Shadow properties on Button (#3617) fixes #2702

* [Android] API check for Shadow properties on Button

* Fix swapped shadow values

* [iOS] fixes #3525 - add epsilon for float compare (#3654)

* [iOS] fixes #3525 - add epsilon for float compare and make region immutable

* [ControlGallery] spread out spans to account for click slop

* [ControlGallery] - adjust span slightly for android test

* [Core] remove private

* Fix text wrapping (#3671) fixes #3634

* [GTK] Fix navigation bar visibility updates (#3651)

* Fix partially  #3585 (#3592)

* Make webkit-sharp.dll.config cross-platform

* Update webkit-sharp.dll with missing signals bindings

see: https://github.com/ylatuya/webkit-sharp/tree/fluendo

* [iOS, UWP] fixes #2894 - Gestures collection changes weren't correctly propagating (#3643)

* [iOS, UWP] fixes #2894 - Gestures weren't wiring up to spans in all cases

* [Core] remove ChildGestureRecognizers when spans get removed

* [iOS] removed incorrect return from null

* Fixes #3663 (#3684)

* Fix ScrollView Padding issue (#3685)

* [WPF] Memory leak when you pop a TabbedPage (#3372) fixes #3267

* Fix [WPF] Memory leak when you pop a TabbedPage

* Update ViewRenderer.cs

* Update ViewRenderer.cs

* [Android,iOS,UWP] Allow Entry CursorPosition/SelectionLength to be set in ctor (#3402) fixes #3343 fixes #3633

* Add repro for #3343 + unit tests

* [Core] Disallow negative values for CursorPosition/SelectionLength

* [All] CursorPosition/SelectionLength can bindin ctor & clear value

fixes #3343

* typo

* cleanup

* [iOS] Cursor snaps to end

* try/catch

* [CSS] add more properties (#3466)

map new CSS properties:
- `color` on `IColorElement` (`ActivityIndicator`, `BoxView`),
  `ProgressBar` and `Switch`
- `row-gap` and `column-gap` on `Grid`
- `transform` and `transform-origin` on `VisualElement`
- `vertical-align` on `Label`

add new XF-specific CSS properties
- `-xf-placeholder` and `-xf-placeholder-color` on `Editor`, `Entry`,
  `SearchBar`
- `-xf-max-length` on `InputView` (`Editor` and `Entry`)
- `-xf-bar-background-color` and `-xf-bar-text-color` on
  `NavigationPage` and `TabbedPage`
- `-xf-orientation` on `ScrollView` and `StackLayout`
- `-xf-horizontal-scroll-bar-visibility` and
  `-xf-vertical-scroll-bar-visibility` on `ScrollView`
- `-xf-min-track-color`, `-xf-max-track-color` and `("-xf-thumb-color`
  on `Slider`
- `-xf-spacing` on `StackLayout`

This PR replaces and closes #3276

- fixes #2891

* [iOS] Specify a default size for UISearchBar width if needed (#3635) fixes #3413 fixes #2139

* [Controls] Add reproduction and test case for issue #3413

* [iOS] Don't use max value for iOS UISearchbar breaks on iOS 11.3

* [iOS] Force width value so we can renderer UISearchBar on iOS10 with infinite width

* [Controls] Fix spelling and add Manual Review to the test of #3413

* [iOS] Simplify code for UISearchBar width

* [iOS] Return always some width from measure the UISearchBar on IOS

* [Controls] Add reproduction case for issue #2139

* [UWP] Fixed double set margins in Layouts (#3570) fixes #3398 fixes #3616

* [Android] Support multiple clipping settings in single layout (#3559)

* Repro

* Fix for API 18+

*  [iOS] Unsubscribe CellPropertyChanged when SwitchCellRenderer is disposed (#3518)

* [Controls] Add repo of issue #3408

* [iOS] Unsubscribe CellPropertyChanged when cell is disposed

* [Controls] Add issue to project

* [iOS] Introduce CellPropertyChange to CellTableViewCell to used by all other cell renderers

* [Controls] Simplify Issue

* [iOS] Remove PropertyChanged that was not used

* [Controls] add check for null binding on template, add notes about issues

* [Controls] added reference to Android crash

* [iOS]Use existing PropertyChanged on ViewCelRenderer

* [iOS] Keep the existing override so we don't break users

* Update TextCellRenderer.cs

* update submodule

* 24H Mode (#3701)

The 24h mode for the pickerdialog was not working.

Version 3.1 was working fine. 

Here is an updated file.

* [UWP] uncomment tests that are now passing for 3188 (#3723)

* [UITest] Update Xamarin.UITest nuget package (#3632)

* [UITests] Update Xamarin.UITest 2.2.5

* [UITests] Try fix Toolbaritems

* [UITest] Update to 2.2.5-1606

* [UITests] Small Fixes and workarounds to make uitest happy

* [UITests ] Add delay to 1733 for API28

* [Android] Revert bad merge (#3746)

fixes #3705

* [Android, iOS] Fixes layout compression causes (#3698) fixes #3624

* [Android, iOS] Fixes layout compression causes

* [iOS] improve UpdateNewElement method

* Fix build error hopefully

* [UWP] Fixes CollectionChanged events in ListView (#3323)

* fixes #3273

* [UWP] Fixes CollectionChanged events in ListView

* a wrapped collection is used only if the SourceItem is not ObservableCollection

* improve uitest

* fixed NRE in empty ListView

* added a sortable custom renderer for UItest

* minor refactoring

* fixed reset of not wrapped collections

* addressing comments

* [UWP] remove WinRT hack

* [UWP] add missing using and cleanup additional resources

* [Android] Update Forms to remove API28 deprecated API (#3653) fixes #2128 fixes #3629

* [Build] Update provisioning

* [Controls] Ignore deprecated  Android API usage

* [Android] Remove use of obsolete color usage

* [Android] Remove app fragment usage

* [android] Rollback changes to EntryCellRenderer

* [Android] Better way to get the default color for the label text

* [Android] Obsolete message for ContentPage.CreateFragment()

* [ControlGallery] - create bitmap from Drawable to use for pixel location

* [Android] Use textcolor resource

* Update submodule

* Fix tests (#3771)

* [ControlGallery] Wait for element and add timing to tests

* [iOS] Fix NRE on RenderPool

* Add TabStop/TabIndex (#2795)

* [Core, UWP, Android] support TabStop/TabIndex

* removing linq

* add iOS / MacOS implementation

* add WPF implementation
fixes UWP implementation

* - addressing comments
- improve test
- optimizations
- added previous tab direction in same tab group

* addressing comments

* [Android] support tabstop for pickers

* - moving shared code to a static class
- removed reflection

* ITabStop -> changed to internal, renamed, added in to fastRenderers

* Update ITabStop to be public

* Fix : Binding Icon in ToolbarItem in TabbedPage doesn't refresh (#3761) fixes #3756

* [iOS] Fix NRE on ContextCell (#3714) fixes #3275

* [Controls] Add repo for issue #3275

* [iOS] Fix NRE when no gestures exist on table

* [iOS] Null check outside loop

* [iOS]Make sure to dispose/unhook when we are removed from UITableView.

* Update submodule

* [iOS] Don't double dispose ContextActionCell

* WPF - Fix Width and Height measurement when GetDesiredSize (#3750)

* WPF - Reset Width and Height when GetDesiredSize

* Some formatting changes

* Add APP directive

* [WPF]Fix build

* [Android Maps] Make markers available to subclasses (#3751)

* Make markers available to subclasses

* Fix build

* Use Find instead of FirstOrDefault

* [UITests] wait for element before querying for it (#3791)

* [UITests] wait for element before querying for it

* [Controls] generalize and better represent intended behavior

* WPF - Fix Local store not persistant when restarting App (#3752)

-fixes #3541
* WPF - Fix Local store not persistant when restarting App
* Add UITest
* [Controls] Add automated UI Test

* [UITests] Isolate test 3408

* [UITest] Update Xamarin UITest packages

* [UWP] implement Replace without reloading ListView (#3792)

-fixes #3788
* [UWP] implement Replace without reloading ListView
* [UWP] extract bindingcontext of new item for replace

* [iOS] Use UIApperance default color for UISwitch (#3819)

* [Controls] Set default color of UISwitch to Red

* [iOS] Use default color from Apperance API

* [UITests] replace awaits with more reliable WaitForElement (#3835)

* [Core] Propagate BindingContext changes to TitleView (#3823)

* [Core] Propagate BindingContext changes to TitleView

* [Tests] Move UI test to Core Unit Test

* [A] do not draw gradient for empty CornerRadius (#3786)

Drawing CornerRadius (introduce by #1998) when the CornerRadii are
actually 0 causes scaling artifacts on API < 25.

This fixes the regression when no CornerRadius is set. Expect blurry
border scaling with CornerRadius not empty and API < 25

- fixes #3781

* [Android] Fix WebView.Navigating event, make WebViewClient inheritable (#3780)

* Extracted WebViewRenderer.WebClient to FormsWebViewClient, moved SendNavigating call from ShouldOverrideUrlLoading to OnPageStarted

* Changed _webViewClient and GetWebViewClient() method to return base class

* Changed public things to protected internal

* Fix spaces to tabs indentation to match the coding style (#3745)

* [Build] Fix merge

* Fix #3097 swipe gesture not being handled in VisualElementTracker. (#3098) Fixes #3097

* Ensure that the ListViewAdapter is no longer being used by the ListVi… (#3848) fixes #3603

* Ensure that the ListViewAdapter is no longer being used by the ListView before disposing it

* Remove `RemoveAllViews` from `Dispose`

* Update from origin (#11)

* [Android] Enable MaxLines and TextDecorations on fast renderers (#3878)

* enable MaxLines on fast renderers

* added text decoration functionality

* include test in project

* [Enhancement] Create a bindable property for AutomationId (#3879)

* create a bindable property for automationId

* make ClassId and AutomationId properties of Element

* add comments to .create-nuget.bat

* added preserve attribute (#3876) fixes #2306

* [Core] Moving Command's CanExecuteChanged to use the WeakEventManager (#3852) fixes #3656

* [Core]  Use WeakEventManager on CanExecuteChanged

* [Core]Add unit test for remove event handler with WeakEventManager

* [Core] Fix remove the correct handler

* [CSS] accept 'oblique' for 'font-style' (#3815) fixes #3808

- fixes #3808

* Prevent double time/date picker dialogs on Android when setting focus (#3899)

* Prevent double time/date picker dialogs on Android when setting focus (#3899)

* [Controls] Fix merge remove duplciated issue 3788

* WPF - Fix Unable to intercept back button (#3762)

* WPF - Fix Unable to intercept back button

* WPF - Improve OnBackButtonPressed

-fixes #3689

* Fix Bugzilla38723 (#3812)

fixes #2302

* [C] fix css mapping (#3919)

* [Android] Fix UI test 1851 (#3882)

* add preserve attribute

- fixes #2255


* added using System

* fixed spacing

* use TestContentPage

* fixed scope issues

* [Android] Make native Android Platforms accessible via Context (#3364)

* Make native Android Platforms accessible via Context

* Add null checks

* Added a disabled look to Android Toolbar Item images. (#3773)

* Added a disabled look to Android Toolbar Item images.

* Update NavigationPageRenderer.cs

Refactored DisabledToolbarAlpha into a constant as requested.

* [UWP] fixes tabstops of TimePicker, DatePiker. SearchBar, Stepper (#3896)

* [UWP] fixes tabstops of TimePicker, DatePiker. SearchBar, Stepper

* common code moved to VisualElementRenderer

* rename interface

fixes #3872

* [UWP] For the Slider default value of step is set to 1000 to match Android. (#3141)

* WPF - Ctrl+A does not select all in WPF password Entry (#3908)

* [WPF] Fix Height of items not consistent (#3925) fixes #3913

* Fix StartTimer and Ticker for UWP (#3911)

- fixes #1937

* Apply font fix for button and span (#3907)

* added instructions (#3891)

- fixes #2361

* [Android] Convert corner radius with correct pixel density (#3893) fixes #3884

* [Controls] Add Issue #3884 repo

* [Android] Convert  corner radius with correct pixel density fixes #3884

* [Controls] Update test message

* WPF - Fix TimePicker with short time pattern shows verbose time (#3924)

* Fix UI test 39378 (#3928)

fixes #2305

* Update ClipBounds when View bounds changes (#3909)

fixes #3717

* [C] catch AmbiguousMatchException on GetProps (#3915)

- fixes #3870

* Automate UI test B45702 (#3914) fixes #2389

* automate 45702

* fix indentation

* Fix bugzilla60787 (#3933)

* [Android]Fix for frame renderer's bug (bugzilla 60787).

#3902
https://bugzilla.xamarin.com/show_bug.cgi?id=60787
https://github.com/xamarin/Xamarin.Forms/issues/3902

* Add control to repro

* PR fix

* Build fix

* Build fix for Xamarin.Forms.Core.Android.UITests

* added instructions (#3926)

* [UWP] fixes flyout menu on cell item (#3682)

* Fix UI test B41424 needs instructions (#3942)

* Add manual test steps and checks for ui test

* step4Label text fix

* [iOS] fix full width issues for TitleView (#3939)

* [iOS] fix full width issues for TitleView

* [iOS] simplified iOS 10

fixes #3881
fixes #3679

* Changes in TableView GTK Control to allow refresh the content (#3941)

- fixes #3725

* Only set the Page Padding via SafeAreaInset on iOS (#3811)

* only set the Page Padding via SafeAreaInset on iOS
-fixes #3809

* [Controls] add waits for clicks in ui tests

* [Controls] remove wrong category

* [iOS] Move inset logic down into ios renderer

* Added logic to allow set the ListView SelectedIndex (#3948) fixes #3766

* Automate UI test 35127 (#3927)

* automate test
- fixes #2262
* indentation fix
* indentation fix 2

* Make GetIconDrawable virtual (#3967)

By making GetIconDrawable virtual for the Android TabbedPageRenderer it allows for the icon to come from other sources (like glyph fonts). This will work for both top and bottom tabs.

* [GTK] Fix visibility of hidden pages in the stack (#3904)

When navigating to a new page, we should hide the previous
content and show the new one so that the previous page
renderer is not taken in account for redraws and resizes

* [Android] If MaxLines is not explicitly set, let LineBreakMode handle it (#3936)

* [Android] If MaxLines is not explicitly set, all LineBreakMode to set it;
if MaxLines is explicitly set, MaxLines setting wins. Use a more reasonable
default for native MaxLines when handling it via LineBreakMode. Consolidate
MaxLines handling code between legacy and fast renderers. Remove unnecessary
setting of SingleLine (which only applies to input).
- fixes #3772

* Remove unnecessary maxLines setting

* Handle resetting MaxLines to -1/default

* Reinstate workaround for array bounds exception in older Android APIs

* Fix UI test B43941 (#3889)

* Add all platforms and remove non-deterministic behaviour

* Return back correct check of counter

* Endline fix

* remove childPages list

* [XamlC] avoid multiple subscription (#3969)

Avoid multiple subscription to PropertyChanged on TypedBindings

- fixes #3613
- fixes #3650

* Fix typos (mainly 'toogle' becoming 'toggle') (#3975)

* Fix Issue2597 Needs UI Test (#3966)

* Add test for issue 2597

* Fix space

* Add CODEOWNERS

* Fix PanGesture inside scroll issue https://github.com/xamarin/Xamarin… (#3842)

* Fix PanGesture inside scroll issue https://github.com/xamarin/Xamarin.Forms/issues/3840
- fixes #3840
* fixe formatting

* [UITest] added UI Test

* [Controls] adjusted UI Test button positions

* [UITEST]  simplify UI tests

* [C] add CSS mapping for max-lines (#3991)

- fixes #3982

* [iOS] Add ability to turn off updates to native controls from another thread (#3774)

* [iOS] Add ability to turn off updates to native controls from another thread

* Flip evaluation order

fixes #1755

* Fixed NotImplementedException refreshing items in WPF ListView (#3962)

* Fixed NotImplementedException refreshing items in WPF ListView

* Small changes in ListView events subscription

fixes #3309
fixes #3737
fixes #3648

* [GTK] Fix transparent background in visual elements (#3744)

* Fix ActivityIndicator.IsRunning state (#4007)

* add pdb for uap into nuget (#4015)

* update GitInfo

* [XamlC] don't compile bindings with Source (#3978)

Sources are usually x:reference that can't be resolved at compilation
time.

- fixes #3606

* [Xaml[C]] resolve Extensions first (#3977)

XamlLoader should first look for type with the Extension suffix. It used
to be the case, but somehow regressed.

- fixes https://github.com/xamarin/Xamarin.Forms/issues/3606#issuecomment-422377338

* [UWP] Document in the README.md the steps required to run UI Tests (#4014) fixes #3984

* [Tizen] Add TabIndex implement for Tizen renderer (#4046)

* [Tasks] multitarget the build tasks (#3895)

- fixes #2690
- closes #2706

* [UITests] Update TestCloud.Agent (#4055)

* [Tizen] Fix ProjectGuid for Forwarders (#4063)

* [Tizen] Fix ProjectGuid for Forwarders

* [Tizen] Make sure not to generate dependency file

* Correct minor typo (#4068)

* Added WebView Reload (#4013) fixes #3776

* Added WebView Reload

* WebView Reload Added Tizen suport

* [Tizen] Cleanup Code (#4080)

* fixed ios editor placeholder font (#4009)

* Prevented crash https://github.com/xamarin/Xamarin.Forms/issues/2291 (#4072)

- fixes #2291

* [Xaml] Allow OnPlat markup in Styles (#3995)

- fixes #3862

* [Xaml] fix Namescope being different than tree (#4089)

As part of #2556, the namescoping tree was assumed to be equiv to the
object tree, which is obviously wrong. This fixes it, while keeping the
old behavior as a fallback.

We might go further, but I can't come up with a reasonable scenario
failing.

- fixes #3821

* [Sample] [Android] Fixed PagesGallery.Droid build (#3999)

* fixed PagesGallery.Droid build

* Moved Xamarin.Forms.Platform.Android (Forwarders) reference to previous place

* updated project guid to lower case

* Fix typeface reset issue (#4019)

* Use ViewCompat to set and get label for view (#3996)

* Removing LineBreakMode support from WindowsResourcesProvider (#4024)

* Repro test page for 3979

* Removes LineBreakMode support from WindowsResourcesProvider as it is inconsistent with other platforms and caused issues when setting Span style to the default Device Styles

* [macOS] Fix NRE on Mojave when aligning the tile (#4086) fixes #3031

* [GTK] Add support for ClickGestureRecognizer (#3971)

* [GTK] Add support for ClickGestureRecognizer

* Add ClickGestureGalleryPage to test ClickGestureRecognizer

* [iOS] Label TextColor has no effect with FormattedString (#4043)

* https://github.com/xamarin/Xamarin.Forms/issues/4040 fix default font/color for formatted string

* https://github.com/xamarin/Xamarin.Forms/pull/4043 fixed naming, added test case

* Moved field and property to top

- fixes #4040

* fix build, tentatively (#4117)

* [Xaml] don't swallow exceptions from converters (#4100)

Compiled converters are invoked, by reflection, at compile time. Any
exception thrown there will be wrapped in a TargetInvocationException.
When that happens, we still want to expose the inner XamlParseException
to the user.

- fixes #4099

* housekeeping ended with https://github.com/xamarin/Xamarin.Forms/pull/3999 (#4105)

* Bump minimum Microsoft.NETCore.UniversalWindowsPlatform version to 6.0.12 (#4106)

* [Tizen] Fix Window alpha update timing (#4119)

* [UWP] fixed `MinimumDate` and `MaximumDate` properties of DatePicker (#3683) fixes #3331

* [WPF] Fixes `ControlTemplate` sizing issue (#2656)

- fixes #2642

* Remove BOM from nuspec (#4128)

* Navigation Page double Popped event Workaround (#3851) fixes #3509

* Navigation Page double Popped event Workaround

* [UITest] Add UI Test

* [Core] fix formatting

* revert formatting fix

* implemented workaround suggested by PureWeen

* removed whitespace

* moved ignorePopCall to a better location

* [Enhancements] Toolbar a11y  (#3974) fixes #1742 fixes #3795

* [Controls] Add automation id to icon

* [iOS] Add AutomationId support to MDP tooggle button

* [Android] Add support for AutomationId to ActionBarDrawerToggle and MasterDetailPage

* [IOS] Refactor and add Accessibility to ToolbarItems

* [iOS] Fix typos

* [Android] Add accessibility to ToolbarItems

* [UWP]  Refactor A11y to extensions

* [UWP]  Set Accessibility properties on ToolbarItems

* [UWP] Set accessibility to MDP button

* [ControlGallery] Add accessibility toolbaritems to gallery

* Comment test out

* [iOS] Fix NRE when Control is being disposed

* [UITests] Remove not used UITests file

* Implementation of method ForceUpdateSize for Cell on macOS (#4104)

* Implemented Cell ForceUpdateSize on macOS

* Tab Styling

* Prevent crash during setting NULL to element via interface method (#4179)

- fixes #4178
- fixes #4146

* https://github.com/xamarin/Xamarin.Forms/issues/4076 fix (#4161)

* [iOS] Rapidly clicking span (6 times at least) on UITest 3525 throws a null exception (#4109)

* https://github.com/xamarin/Xamarin.Forms/issues/3930 fix

* following convention

* [Android] Fixes AutomationProperties.Name on Button (#4094)

* [Android] Fixes AutomationProperties.Name on Button

* [Android] Fixes for Switch control

* UWP Toolbar dynamic overflow (#4022)

* Adding Windows specific ToolbarDynamicOverflowEnabled configuration

* Enabled ToolbarDynamicOverflowEnabled (pun intended) on page controls and renderers

* Issue 3988 sample

* Removed obsolete comment, cleaned up private and whitespace

* Added toolbar dynamic overflow examples for master detail page and tabbed page


- fixes #2057
- fixes #3988

* Add missing initial call to UpdateLineHeight; fixes #4136 (#4147)

* Added UI test to B45027 (#4079)

* Add UI test to B45027

* Changed execution of current UI test to Android platform

* Added iOS UI test to B45027

* Refactored UI test execution

* Fix https://github.com/xamarin/Xamarin.Forms/issues/3301 (#4164)

- fixes #3301

* [UWP] fixes entering text into SearchBar with UI Tests (#4173)

* [UWP] fixes entering text into SearchBar with UI Tests

* [UWP] ITabStopOnDescendants - fixed selection when setting focus from Selenium

* [UWP] Fix TitleView Width and MDP rendering quirks (#3987)

* [UWP] Fix TitleView Width and MDP rendering quirks

* [UWP] fix load timing for pushed pages and titleview

* [UWP] move renderer check

* [UWP] remove re-measure until 4116 fixed

- fixes #3828
- fixes #3834

* [macOS] NRE in WebViewRenderer (#4188) fixes #4001

* https://github.com/xamarin/Xamarin.Forms/issues/4001

* fixed build

* https://github.com/xamarin/Xamarin.Forms/issues/2831 fixes #2831 (#4111)

* [msbuild] use portable pdb files (#4201)

Currently, on the first build of a "Hello World" Xamarin.Forms app,
you will see this in the build log:

    ConvertDebuggingFiles
        Parameters
            Files
                C:\Users\myuser\.nuget\packages\xamarin.forms\3.1.0.697729\lib\MonoAndroid10\FormsViewGroup.pdb
                C:\Users\myuser\.nuget\packages\xamarin.forms\3.1.0.697729\lib\MonoAndroid10\Xamarin.Forms.Platform.Android.pdb
        OutputItems
            _ConvertedDebuggingFiles
                C:\Users\myuser\.nuget\packages\xamarin.forms\3.1.0.697729\lib\MonoAndroid10\FormsViewGroup.dll
                C:\Users\myuser\.nuget\packages\xamarin.forms\3.1.0.697729\lib\MonoAndroid10\Xamarin.Forms.Platform.Android.dll

The logging is a little weird here, but this `ConvertDebuggingFiles`
MSBuild task takes about 100ms on my machine.

What is it doing?

The Mono debugger can support two types of debugging files:
- `mdb` files
- "portable" `pdb` files

If Xamarin.Android's build finds a "non-portable" `pdb` file, we have
to run it through this task to convert to an `mdb` file... This gives
us proper stacktraces for `FormsViewGroup.dll` and
`Xamarin.Forms.Platform.Android.dll`.

You can change the type of debugging symbols in your project with the
`DebugType` setting, which has these options:
- Blank or `None`: don't generate symbols. (Although Xamarin.Android
  has funny behavior here, see:
  https://github.com/xamarin/xamarin-android/issues/2282)
- `Full` generates an `mdb` file, this is a Windows-proprietary format
  for debug builds
- `PdbOnly` generates a "non-portable" `pdb` file, a
  Windows-proprietary format for release builds
- `Portable` generates a "portable" pdb file, which is the new
  standard that works for debug and release builds. New SDK-style
  MSBuild projects use this option by default.

These values are not case sensitive, I have mostly seen them lower
case in newer projects.

So what does Xamarin.Forms need to do?

Use `<DebugType>portable</DebugType>` in any Android class library or
app project. Other platforms, this is optional, not as much benefit. I
have heard that `DebugType=portable` might cause a problem on UWP.

* Xamarin.Forms will ship "portable" `pdbs` in its NuGet package for
  `FormsViewGroup.dll` and `Xamarin.Forms.*.Android.dll`. Developers
  won't pay the 100ms on initial build.
* Initial build times for `Xamarin.Forms.sln` will be slightly better
  for development, although I didn't measure the difference here.

* [XamlC] fix the argument match check for events (#4134)

Well, it looks like the order of arguments of InheritOrImplements was
reversed... a totally fine and normal Friday so far

- fixes #4130

* Add UI Test. Add instructions. Move to correct namespace (#4170) fixes #2251

* Add uitest for 2794 (#4110) fixes #2293

* Fix PropagateEvent value properly on Cells (#4191)

* bump gitinfo

* [Core, iOS, MacOS, Android, UWP, WPF] ListView hide scroll view scroll bars (#3897) fixes #3843

* Update from origin (#8)

* [C] VisibilityConverter Trims input (#3581)

For CSS purposes, the VisibilityConverter was added, and actually
replaced the `Boolean.Parse(str)` call for parsing Visibility.
`Boolean.Parse()` trims input, and the converter was not, so this was a
regression.
This changes Trim() the input, to be fully backward compatible.

- fixes #3554

* Ensure ConstructorCountId and TimeId elements are available before querying them (#3588)

* For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589)

This would allow previewer/designer/reloader to determine the source of a
stylesheet and refresh its content when appropriate.

* Revert "For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589)"

This reverts commit f66a72de5b475a6a8387a80e418997b38dc40d4c.

* Fix NRE; Ret 0 if Text null (#3594) fixes #3579

* [UWP, WPF] Fixes rendering of the main page (#2896) fixes #2704

* [Core] Ignore Shamehat target when running DesignTimeBuild (#3605)

* [XamlC] Fix binding compilation fo value types (#3551)

properly load valuetype arguments of generated setters, using ldarg,
instead of ldarga.

- fixes #3539

* Update PULL_REQUEST_TEMPLATE.md

* Update PULL_REQUEST_TEMPLATE.md

* [Android] Fix Label LineHeight (#3452)

* fix line height android

* Make UAP respect initial LineHeight

* update .create-nuget.bat (#3638)

* Add Null Check to GetRenderer (#3575)

- fix #3563

* Fix 3562 Null Reference Exception (#3576)

- fixes #3562

* Fix 3564 Null Reference Exception (#3578)

- fixes #3564

* [iOS] AutomationProperty support for cells (#3313) fixes #3296

* [iOS] AutomationProperty support for cells

* Add test case to AutomationProperties gallery

* [UWP] Fix crash app when create navigation/tabbed page without children pages fixes #3188 (#3514)

* [Android] Use height when determining ScaledScreenSize; fixes #3609 (#3641)

* [C] Set binding context on Span Gestures (#3639)

* [Core] Set binding context on Span Gestures
* [Core] Simplify loop setting child binding context

- fixes #3524

* Update PULL_REQUEST_TEMPLATE.md

* [Android] remove deprecated AndroidUseLatestPlatformSdk (#3672)

* [iOS] iPad ActionSheet should always have a Cancel method (#3636)

* Add repro for #3049

* [iOS] iPad ActionSheet should always have a Cancel method

fixes #3049

* [Android] fixes #3675 - set  initial ScrollView Scroll values when RTL (#3676)

* [Android] API check for Shadow properties on Button (#3617) fixes #2702

* [Android] API check for Shadow properties on Button

* Fix swapped shadow values

* [iOS] fixes #3525 - add epsilon for float compare (#3654)

* [iOS] fixes #3525 - add epsilon for float compare and make region immutable

* [ControlGallery] spread out spans to account for click slop

* [ControlGallery] - adjust span slightly for android test

* [Core] remove private

* Fix text wrapping (#3671) fixes #3634

* [GTK] Fix navigation bar visibility updates (#3651)

* Fix partially  #3585 (#3592)

* Make webkit-sharp.dll.config cross-platform

* Update webkit-sharp.dll with missing signals bindings

see: https://github.com/ylatuya/webkit-sharp/tree/fluendo

* [iOS, UWP] fixes #2894 - Gestures collection changes weren't correctly propagating (#3643)

* [iOS, UWP] fixes #2894 - Gestures weren't wiring up to spans in all cases

* [Core] remove ChildGestureRecognizers when spans get removed

* [iOS] removed incorrect return from null

* Fixes #3663 (#3684)

* Fix ScrollView Padding issue (#3685)

* [WPF] Memory leak when you pop a TabbedPage (#3372) fixes #3267

* Fix [WPF] Memory leak when you pop a TabbedPage

* Update ViewRenderer.cs

* Update ViewRenderer.cs

* [Android,iOS,UWP] Allow Entry CursorPosition/SelectionLength to be set in ctor (#3402) fixes #3343 fixes #3633

* Add repro for #3343 + unit tests

* [Core] Disallow negative values for CursorPosition/SelectionLength

* [All] CursorPosition/SelectionLength can bindin ctor & clear value

fixes #3343

* typo

* cleanup

* [iOS] Cursor snaps to end

* try/catch

* [CSS] add more properties (#3466)

map new CSS properties:
- `color` on `IColorElement` (`ActivityIndicator`, `BoxView`),
  `ProgressBar` and `Switch`
- `row-gap` and `column-gap` on `Grid`
- `transform` and `transform-origin` on `VisualElement`
- `vertical-align` on `Label`

add new XF-specific CSS properties
- `-xf-placeholder` and `-xf-placeholder-color` on `Editor`, `Entry`,
  `SearchBar`
- `-xf-max-length` on `InputView` (`Editor` and `Entry`)
- `-xf-bar-background-color` and `-xf-bar-text-color` on
  `NavigationPage` and `TabbedPage`
- `-xf-orientation` on `ScrollView` and `StackLayout`
- `-xf-horizontal-scroll-bar-visibility` and
  `-xf-vertical-scroll-bar-visibility` on `ScrollView`
- `-xf-min-track-color`, `-xf-max-track-color` and `("-xf-thumb-color`
  on `Slider`
- `-xf-spacing` on `StackLayout`

This PR replaces and closes #3276

- fixes #2891

* [iOS] Specify a default size for UISearchBar width if needed (#3635) fixes #3413 fixes #2139

* [Controls] Add reproduction and test case for issue #3413

* [iOS] Don't use max value for iOS UISearchbar breaks on iOS 11.3

* [iOS] Force width value so we can renderer UISearchBar on iOS10 with infinite width

* [Controls] Fix spelling and add Manual Review to the test of #3413

* [iOS] Simplify code for UISearchBar width

* [iOS] Return always some width from measure the UISearchBar on IOS

* [Controls] Add reproduction case for issue #2139

* [UWP] Fixed double set margins in Layouts (#3570) fixes #3398 fixes #3616

* [Android] Support multiple clipping settings in single layout (#3559)

* Repro

* Fix for API 18+

*  [iOS] Unsubscribe CellPropertyChanged when SwitchCellRenderer is disposed (#3518)

* [Controls] Add repo of issue #3408

* [iOS] Unsubscribe CellPropertyChanged when cell is disposed

* [Controls] Add issue to project

* [iOS] Introduce CellPropertyChange to CellTableViewCell to used by all other cell renderers

* [Controls] Simplify Issue

* [iOS] Remove PropertyChanged that was not used

* [Controls] add check for null binding on template, add notes about issues

* [Controls] added reference to Android crash

* [iOS]Use existing PropertyChanged on ViewCelRenderer

* [iOS] Keep the existing override so we don't break users

* Update TextCellRenderer.cs

* update submodule

* 24H Mode (#3701)

The 24h mode for the pickerdialog was not working.

Version 3.1 was working fine. 

Here is an updated file.

* [UWP] uncomment tests that are now passing for 3188 (#3723)

* [UITest] Update Xamarin.UITest nuget package (#3632)

* [UITests] Update Xamarin.UITest 2.2.5

* [UITests] Try fix Toolbaritems

* [UITest] Update to 2.2.5-1606

* [UITests] Small Fixes and workarounds to make uitest happy

* [UITests ] Add delay to 1733 for API28

* [Android] Revert bad merge (#3746)

fixes #3705

* [Android, iOS] Fixes layout compression causes (#3698) fixes #3624

* [Android, iOS] Fixes layout compression causes

* [iOS] improve UpdateNewElement method

* Fix build error hopefully

* [UWP] Fixes CollectionChanged events in ListView (#3323)

* fixes #3273

* [UWP] Fixes CollectionChanged events in ListView

* a wrapped collection is used only if the SourceItem is not ObservableCollection

* improve uitest

* fixed NRE in empty ListView

* added a sortable custom renderer for UItest

* minor refactoring

* fixed reset of not wrapped collections

* addressing comments

* [UWP] remove WinRT hack

* [UWP] add missing using and cleanup additional resources

* [Android] Update Forms to remove API28 deprecated API (#3653) fixes #2128 fixes #3629

* [Build] Update provisioning

* [Controls] Ignore deprecated  Android API usage

* [Android] Remove use of obsolete color usage

* [Android] Remove app fragment usage

* [android] Rollback changes to EntryCellRenderer

* [Android] Better way to get the default color for the label text

* [Android] Obsolete message for ContentPage.CreateFragment()

* [ControlGallery] - create bitmap from Drawable to use for pixel location

* [Android] Use textcolor resource

* Update submodule

* Fix tests (#3771)

* [ControlGallery] Wait for element and add timing to tests

* [iOS] Fix NRE on RenderPool

* Add TabStop/TabIndex (#2795)

* [Core, UWP, Android] support TabStop/TabIndex

* removing linq

* add iOS / MacOS implementation

* add WPF implementation
fixes UWP implementation

* - addressing comments
- improve test
- optimizations
- added previous tab direction in same tab group

* addressing comments

* [Android] support tabstop for pickers

* - moving shared code to a static class
- removed reflection

* ITabStop -> changed to internal, renamed, added in to fastRenderers

* Update ITabStop to be public

* Fix : Binding Icon in ToolbarItem in TabbedPage doesn't refresh (#3761) fixes #3756

* [iOS] Fix NRE on ContextCell (#3714) fixes #3275

* [Controls] Add repo for issue #3275

* [iOS] Fix NRE when no gestures exist on table

* [iOS] Null check outside loop

* [iOS]Make sure to dispose/unhook when we are removed from UITableView.

* Update submodule

* [iOS] Don't double dispose ContextActionCell

* WPF - Fix Width and Height measurement when GetDesiredSize (#3750)

* WPF - Reset Width and Height when GetDesiredSize

* Some formatting changes

* Add APP directive

* [WPF]Fix build

* [Android Maps] Make markers available to subclasses (#3751)

* Make markers available to subclasses

* Fix build

* Use Find instead of FirstOrDefault

* [UITests] wait for element before querying for it (#3791)

* [UITests] wait for element before querying for it

* [Controls] generalize and better represent intended behavior

* WPF - Fix Local store not persistant when restarting App (#3752)

-fixes #3541
* WPF - Fix Local store not persistant when restarting App
* Add UITest
* [Controls] Add automated UI Test

* [UITests] Isolate test 3408

* [UITest] Update Xamarin UITest packages

* [UWP] implement Replace without reloading ListView (#3792)

-fixes #3788
* [UWP] implement Replace without reloading ListView
* [UWP] extract bindingcontext of new item for replace

* [iOS] Use UIApperance default color for UISwitch (#3819)

* [Controls] Set default color of UISwitch to Red

* [iOS] Use default color from Apperance API

* [UITests] replace awaits with more reliable WaitForElement (#3835)

* [Core] Propagate BindingContext changes to TitleView (#3823)

* [Core] Propagate BindingContext changes to TitleView

* [Tests] Move UI test to Core Unit Test

* [A] do not draw gradient for empty CornerRadius (#3786)

Drawing CornerRadius (introduce by #1998) when the CornerRadii are
actually 0 causes scaling artifacts on API < 25.

This fixes the regression when no CornerRadius is set. Expect blurry
border scaling with CornerRadius not empty and API < 25

- fixes #3781

* [Android] Fix WebView.Navigating event, make WebViewClient inheritable (#3780)

* Extracted WebViewRenderer.WebClient to FormsWebViewClient, moved SendNavigating call from ShouldOverrideUrlLoading to OnPageStarted

* Changed _webViewClient and GetWebViewClient() method to return base class

* Changed public things to protected internal

* Fix spaces to tabs indentation to match the coding style (#3745)

* [Build] Fix merge

* Fix #3097 swipe gesture not being handled in VisualElementTracker. (#3098) Fixes #3097

* Implemented for iOS, Android and MacOS

* Implemented UAP and WPF

* Refactored duplicate code and removed typo in method name

* Update from origin (#9)

* [C] VisibilityConverter Trims input (#3581)

For CSS purposes, the VisibilityConverter was added, and actually
replaced the `Boolean.Parse(str)` call for parsing Visibility.
`Boolean.Parse()` trims input, and the converter was not, so this was a
regression.
This changes Trim() the input, to be fully backward compatible.

- fixes #3554

* Ensure ConstructorCountId and TimeId elements are available before querying them (#3588)

* For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589)

This would allow previewer/designer/reloader to determine the source of a
stylesheet and refresh its content when appropriate.

* Revert "For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589)"

This reverts commit f66a72de5b475a6a8387a80e418997b38dc40d4c.

* Fix NRE; Ret 0 if Text null (#3594) fixes #3579

* [UWP, WPF] Fixes rendering of the main page (#2896) fixes #2704

* [Core] Ignore Shamehat target when running DesignTimeBuild (#3605)

* [XamlC] Fix binding compilation fo value types (#3551)

properly load valuetype arguments of generated setters, using ldarg,
instead of ldarga.

- fixes #3539

* Update PULL_REQUEST_TEMPLATE.md

* Update PULL_REQUEST_TEMPLATE.md

* [Android] Fix Label LineHeight (#3452)

* fix line height android

* Make UAP respect initial LineHeight

* update .create-nuget.bat (#3638)

* Add Null Check to GetRenderer (#3575)

- fix #3563

* Fix 3562 Null Reference Exception (#3576)

- fixes #3562

* Fix 3564 Null Reference Exception (#3578)

- fixes #3564

* [iOS] AutomationProperty support for cells (#3313) fixes #3296

* [iOS] AutomationProperty support for cells

* Add test case to AutomationProperties gallery

* [UWP] Fix crash app when create navigation/tabbed page without children pages fixes #3188 (#3514)

* [Android] Use height when determining ScaledScreenSize; fixes #3609 (#3641)

* [C] Set binding context on Span Gestures (#3639)

* [Core] Set binding context on Span Gestures
* [Core] Simplify loop setting child binding context

- fixes #3524

* Update PULL_REQUEST_TEMPLATE.md

* [Android] remove deprecated AndroidUseLatestPlatformSdk (#3672)

* [iOS] iPad ActionSheet should always have a Cancel method (#3636)

* Add repro for #3049

* [iOS] iPad ActionSheet should always have a Cancel method

fixes #3049

* [Android] fixes #3675 - set  initial ScrollView Scroll values when RTL (#3676)

* [Android] API check for Shadow properties on Button (#3617) fixes #2702

* [Android] API check for Shadow properties on Button

* Fix swapped shadow values

* [iOS] fixes #3525 - add epsilon for float compare (#3654)

* [iOS] fixes #3525 - add epsilon for float compare and make region immutable

* [ControlGallery] spread out spans to account for click slop

* [ControlGallery] - adjust span slightly for android test

* [Core] remove private

* Fix text wrapping (#3671) fixes #3634

* [GTK] Fix navigation bar visibility updates (#3651)

* Fix partially  #3585 (#3592)

* Make webkit-sharp.dll.config cross-platform

* Update webkit-sharp.dll with missing signals bindings

see: https://github.com/ylatuya/webkit-sharp/tree/fluendo

* [iOS, UWP] fixes #2894 - Gestures collection changes weren't correctly propagating (#3643)

* [iOS, UWP] fixes #2894 - Gestures weren't wiring up to spans in all cases

* [Core] remove ChildGestureRecognizers when spans get removed

* [iOS] removed incorrect return from null

* Fixes #3663 (#3684)

* Fix ScrollView Padding issue (#3685)

* [WPF] Memory leak when you pop a TabbedPage (#3372) fixes #3267

* Fix [WPF] Memory leak when you pop a TabbedPage

* Update ViewRenderer.cs

* Update ViewRenderer.cs

* [Android,iOS,UWP] Allow Entry CursorPosition/SelectionLength to be set in ctor (#3402) fixes #3343 fixes #3633

* Add repro for #3343 + unit tests

* [Core] Disallow negative values for CursorPosition/SelectionLength

* [All] CursorPosition/SelectionLength can bindin ctor & clear value

fixes #3343

* typo

* cleanup

* [iOS] Cursor snaps to end

* try/catch

* [CSS] add more properties (#3466)

map new CSS properties:
- `color` on `IColorElement` (`ActivityIndicator`, `BoxView`),
  `ProgressBar` and `Switch`
- `row-gap` and `column-gap` on `Grid`
- `transform` and `transform-origin` on `VisualElement`
- `vertical-align` on `Label`

add new XF-specific CSS properties
- `-xf-placeholder` and `-xf-placeholder-color` on `Editor`, `Entry`,
  `SearchBar`
- `-xf-max-length` on `InputView` (`Editor` and `Entry`)
- `-xf-bar-background-color` and `-xf-bar-text-color` on
  `NavigationPage` and `TabbedPage`
- `-xf-orientation` on `ScrollView` and `StackLayout`
- `-xf-horizontal-scroll-bar-visibility` and
  `-xf-vertical-scroll-bar-visibility` on `ScrollView`
- `-xf-min-track-color`, `-xf-max-track-color` and `("-xf-thumb-color`
  on `Slider`
- `-xf-spacing` on `StackLayout`

This PR replaces and closes #3276

- fixes #2891

* [iOS] Specify a default size for UISearchBar width if needed (#3635) fixes #3413 fixes #2139

* [Controls] Add reproduction and test case for issue #3413

* [iOS] Don't use max value for iOS UISearchbar breaks on iOS 11.3

* [iOS] Force width value so we can renderer UISearchBar on iOS10 with infinite width

* [Controls] Fix spelling and add Manual Review to the test of #3413

* [iOS] Simplify code for UISearchBar width

* [iOS] Return always some width from measure the UISearchBar on IOS

* [Controls] Add reproduction case for issue #2139

* [UWP] Fixed double set margins in Layouts (#3570) fixes #3398 fixes #3616

* [Android] Support multiple clipping settings in single layout (#3559)

* Repro

* Fix for API 18+

*  [iOS] Unsubscribe CellPropertyChanged when SwitchCellRenderer is disposed (#3518)

* [Controls] Add repo of issue #3408

* [iOS] Unsubscribe CellPropertyChanged when cell is disposed

* [Controls] Add issue to project

* [iOS] Introduce CellPropertyChange to CellTableViewCell to used by all other cell renderers

* [Controls] Simplify Issue

* [iOS] Remove PropertyChanged that was not used

* [Controls] add check for null binding on template, add notes about issues

* [Controls] added reference to Android crash

* [iOS]Use existing PropertyChanged on ViewCelRenderer

* [iOS] Keep the existing override so we don't break users

* Update TextCellRenderer.cs

* update submodule

* 24H Mode (#3701)

The 24h mode for the pickerdialog was not working.

Version 3.1 was working fine. 

Here is an updated file.

* [UWP] uncomment tests that are now passing for 3188 (#3723)

* [UITest] Update Xamarin.UITest nuget package (#3632)

* [UITests] Update Xamarin.UITest 2.2.5

* [UITests] Try fix Toolbaritems

* [UITest] Update to 2.2.5-1606

* [UITests] Small Fixes and workarounds to make uitest happy

* [UITests ] Add delay to 1733 for API28

* [Android] Revert bad merge (#3746)

fixes #3705

* [Android, iOS] Fixes layout compression causes (#3698) fixes #3624

* [Android, iOS] Fixes layout compression causes

* [iOS] improve UpdateNewElement method

* Fix build error hopefully

* [UWP] Fixes CollectionChanged events in ListView (#3323)

* fixes #3273

* [UWP] Fixes CollectionChanged events in ListView

* a wrapped collection is used only if the SourceItem is not ObservableCollection

* improve uitest

* fixed NRE in empty ListView

* added a sortable custom renderer for UItest

* minor refactoring

* fixed reset of not wrapped collections

* addressing comments

* [UWP] remove WinRT hack

* [UWP] add missing using and cleanup additional resources

* [Android] Update Forms to remove API28 deprecated API (#3653) fixes #2128 fixes #3629

* [Build] Update provisioning

* [Controls] Ignore deprecated  Android API usage

* [Android] Remove use of obsolete color usage

* [Android] Remove app fragment usage

* [android] Rollback changes to EntryCellRenderer

* [Android] Better way to get the default color for the label text

* [Android] Obsolete message for ContentPage.CreateFragment()

* [ControlGallery] - create bitmap from Drawable to use for pixel location

* [Android] Use textcolor resource

* Update submodule

* Fix tests (#3771)

* [ControlGallery] Wait for element and add timing to tests

* [iOS] Fix NRE on RenderPool

* Add TabStop/TabIndex (#2795)

* [Core, UWP, Android] support TabStop/TabIndex

* removing linq

* add iOS / MacOS implementation

* add WPF implementation
fixes UWP implementation

* - addressing comments
- improve test
- optimizations
- added previous tab direction in same tab group

* addressing comments

* [Android] support tabstop for pickers

* - moving shared code to a static class
- removed reflection

* ITabStop -> changed to internal, renamed, added in to fastRenderers

* Update ITabStop to be public

* Fix : Binding Icon in ToolbarItem in TabbedPage doesn't refresh (#3761) fixes #3756

* [iOS] Fix NRE on ContextCell (#3714) fixes #3275

* [Controls] Add repo for issue #3275

* [iOS] Fix NRE when no gestures exist on table

* [iOS] Null check outside loop

* [iOS]Make sure to dispose/unhook when we are removed from UITableView.

* Update submodule

* [iOS] Don't double dispose ContextActionCell

* WPF - Fix Width and Height measurement when GetDesiredSize (#3750)

* WPF - Reset Width and Height when GetDesiredSize

* Some formatting changes

* Add APP directive

* [WPF]Fix build

* [Android Maps] Make markers available to subclasses (#3751)

* Make markers available to subclasses

* Fix build

* Use Find instead of FirstOrDefault

* [UITests] wait for element before querying for it (#3791)

* [UITests] wait for element before querying for it

* [Controls] generalize and better represent intended behavior

* WPF - Fix Local store not persistant when restarting App (#3752)

-fixes #3541
* WPF - Fix Local store not persistant when restarting App
* Add UITest
* [Controls] Add automated UI Test

* [UITests] Isolate test 3408

* [UITest] Update Xamarin UITest packages

* [UWP] implement Replace without reloading ListView (#3792)

-fixes #3788
* [UWP] implement Replace without reloading ListView
* [UWP] extract bindingcontext of new item for replace

* [iOS] Use UIApperance default color for UISwitch (#3819)

* [Controls] Set default color of UISwitch to Red

* [iOS] Use default color from Apperance API

* [UITests] replace awaits with more reliable WaitForElement (#3835)

* [Core] Propagate BindingContext changes to TitleView (#3823)

* [Core] Propagate BindingContext changes to TitleView

* [Tests] Move UI test to Core Unit Test

* [A] do not draw gradient for empty CornerRadius (#3786)

Drawing CornerRadius (introduce by #1998) when the CornerRadii are
actually 0 causes scaling artifacts on API < 25.

This fixes the regression when no CornerRadius is set. Expect blurry
border scaling with CornerRadius not empty and API < 25

- fixes #3781

* [Android] Fix WebView.Navigating event, make WebViewClient inheritable (#3780)

* Extracted WebViewRenderer.WebClient to FormsWebViewClient, moved SendNavigating call from ShouldOverrideUrlLoading to OnPageStarted

* Changed _webViewClient and GetWebViewClient() method to return base class

* Changed public things to protected internal

* Fix spaces to tabs indentation to match the coding style (#3745)

* [Build] Fix merge

* Fix #3097 swipe gesture not being handled in VisualElementTracker. (#3098) Fixes #3097

* Ensure that the ListViewAdapter is no longer being used by the ListVi… (#3848) fixes #3603

* Ensure that the ListViewAdapter is no longer being used by the ListView before disposing it

* Remove `RemoveAllViews` from `Dispose`

* Fixed code review comments

* Removed obsolete convert method

* Making sure default platform functionality is intact iOS and Android

As er code review comments

* Making sure default platform functionality is intact MacOS

* Making sure default platform functionality is intact UWP and WPF

* Code review comments for iOS, Android and MacOS

Default platform value is now preserved and applied when setting is set to default

* Code review comments UWP and WPF

* Fix build

* [UITest] - add ui test to test scroll permutations

* [Uwp] fix bad merge

* [wpf] fix spacing

* Adding instructions and UI tests for Bugzilla44461 (#4144)

* Adding instructions and UI tests for Bugzilla44461

* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla44461.cs

Co-Authored-By: mikescandy <michele.scandura@outlook.com>

* Fix assert

* [C] avoid AmbiguousMatchexception in Bindings (#4216) fixes #4215

if a type defines multiple op_implicit from the same type to different
ones, trying to retrieve it with GetMethod() throws an
AmbiguousMatchException. If this happens, we have to do the resolution
ourself.

- fixes #4215

* https://gi…
@samhouts samhouts added this to In Progress in v3.4.0 Dec 14, 2018
@samhouts samhouts moved this from In Progress to Done in v3.4.0 Dec 14, 2018
hartez pushed a commit that referenced this issue Jan 29, 2019
#4431)

* Update from origin (#8)

* [C] VisibilityConverter Trims input (#3581)

For CSS purposes, the VisibilityConverter was added, and actually
replaced the `Boolean.Parse(str)` call for parsing Visibility.
`Boolean.Parse()` trims input, and the converter was not, so this was a
regression.
This changes Trim() the input, to be fully backward compatible.

- fixes #3554

* Ensure ConstructorCountId and TimeId elements are available before querying them (#3588)

* For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589)

This would allow previewer/designer/reloader to determine the source of a
stylesheet and refresh its content when appropriate.

* Revert "For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589)"

This reverts commit f66a72de5b475a6a8387a80e418997b38dc40d4c.

* Fix NRE; Ret 0 if Text null (#3594) fixes #3579

* [UWP, WPF] Fixes rendering of the main page (#2896) fixes #2704

* [Core] Ignore Shamehat target when running DesignTimeBuild (#3605)

* [XamlC] Fix binding compilation fo value types (#3551)

properly load valuetype arguments of generated setters, using ldarg,
instead of ldarga.

- fixes #3539

* Update PULL_REQUEST_TEMPLATE.md

* Update PULL_REQUEST_TEMPLATE.md

* [Android] Fix Label LineHeight (#3452)

* fix line height android

* Make UAP respect initial LineHeight

* update .create-nuget.bat (#3638)

* Add Null Check to GetRenderer (#3575)

- fix #3563

* Fix 3562 Null Reference Exception (#3576)

- fixes #3562

* Fix 3564 Null Reference Exception (#3578)

- fixes #3564

* [iOS] AutomationProperty support for cells (#3313) fixes #3296

* [iOS] AutomationProperty support for cells

* Add test case to AutomationProperties gallery

* [UWP] Fix crash app when create navigation/tabbed page without children pages fixes #3188 (#3514)

* [Android] Use height when determining ScaledScreenSize; fixes #3609 (#3641)

* [C] Set binding context on Span Gestures (#3639)

* [Core] Set binding context on Span Gestures
* [Core] Simplify loop setting child binding context

- fixes #3524

* Update PULL_REQUEST_TEMPLATE.md

* [Android] remove deprecated AndroidUseLatestPlatformSdk (#3672)

* [iOS] iPad ActionSheet should always have a Cancel method (#3636)

* Add repro for #3049

* [iOS] iPad ActionSheet should always have a Cancel method

fixes #3049

* [Android] fixes #3675 - set  initial ScrollView Scroll values when RTL (#3676)

* [Android] API check for Shadow properties on Button (#3617) fixes #2702

* [Android] API check for Shadow properties on Button

* Fix swapped shadow values

* [iOS] fixes #3525 - add epsilon for float compare (#3654)

* [iOS] fixes #3525 - add epsilon for float compare and make region immutable

* [ControlGallery] spread out spans to account for click slop

* [ControlGallery] - adjust span slightly for android test

* [Core] remove private

* Fix text wrapping (#3671) fixes #3634

* [GTK] Fix navigation bar visibility updates (#3651)

* Fix partially  #3585 (#3592)

* Make webkit-sharp.dll.config cross-platform

* Update webkit-sharp.dll with missing signals bindings

see: https://github.com/ylatuya/webkit-sharp/tree/fluendo

* [iOS, UWP] fixes #2894 - Gestures collection changes weren't correctly propagating (#3643)

* [iOS, UWP] fixes #2894 - Gestures weren't wiring up to spans in all cases

* [Core] remove ChildGestureRecognizers when spans get removed

* [iOS] removed incorrect return from null

* Fixes #3663 (#3684)

* Fix ScrollView Padding issue (#3685)

* [WPF] Memory leak when you pop a TabbedPage (#3372) fixes #3267

* Fix [WPF] Memory leak when you pop a TabbedPage

* Update ViewRenderer.cs

* Update ViewRenderer.cs

* [Android,iOS,UWP] Allow Entry CursorPosition/SelectionLength to be set in ctor (#3402) fixes #3343 fixes #3633

* Add repro for #3343 + unit tests

* [Core] Disallow negative values for CursorPosition/SelectionLength

* [All] CursorPosition/SelectionLength can bindin ctor & clear value

fixes #3343

* typo

* cleanup

* [iOS] Cursor snaps to end

* try/catch

* [CSS] add more properties (#3466)

map new CSS properties:
- `color` on `IColorElement` (`ActivityIndicator`, `BoxView`),
  `ProgressBar` and `Switch`
- `row-gap` and `column-gap` on `Grid`
- `transform` and `transform-origin` on `VisualElement`
- `vertical-align` on `Label`

add new XF-specific CSS properties
- `-xf-placeholder` and `-xf-placeholder-color` on `Editor`, `Entry`,
  `SearchBar`
- `-xf-max-length` on `InputView` (`Editor` and `Entry`)
- `-xf-bar-background-color` and `-xf-bar-text-color` on
  `NavigationPage` and `TabbedPage`
- `-xf-orientation` on `ScrollView` and `StackLayout`
- `-xf-horizontal-scroll-bar-visibility` and
  `-xf-vertical-scroll-bar-visibility` on `ScrollView`
- `-xf-min-track-color`, `-xf-max-track-color` and `("-xf-thumb-color`
  on `Slider`
- `-xf-spacing` on `StackLayout`

This PR replaces and closes #3276

- fixes #2891

* [iOS] Specify a default size for UISearchBar width if needed (#3635) fixes #3413 fixes #2139

* [Controls] Add reproduction and test case for issue #3413

* [iOS] Don't use max value for iOS UISearchbar breaks on iOS 11.3

* [iOS] Force width value so we can renderer UISearchBar on iOS10 with infinite width

* [Controls] Fix spelling and add Manual Review to the test of #3413

* [iOS] Simplify code for UISearchBar width

* [iOS] Return always some width from measure the UISearchBar on IOS

* [Controls] Add reproduction case for issue #2139

* [UWP] Fixed double set margins in Layouts (#3570) fixes #3398 fixes #3616

* [Android] Support multiple clipping settings in single layout (#3559)

* Repro

* Fix for API 18+

*  [iOS] Unsubscribe CellPropertyChanged when SwitchCellRenderer is disposed (#3518)

* [Controls] Add repo of issue #3408

* [iOS] Unsubscribe CellPropertyChanged when cell is disposed

* [Controls] Add issue to project

* [iOS] Introduce CellPropertyChange to CellTableViewCell to used by all other cell renderers

* [Controls] Simplify Issue

* [iOS] Remove PropertyChanged that was not used

* [Controls] add check for null binding on template, add notes about issues

* [Controls] added reference to Android crash

* [iOS]Use existing PropertyChanged on ViewCelRenderer

* [iOS] Keep the existing override so we don't break users

* Update TextCellRenderer.cs

* update submodule

* 24H Mode (#3701)

The 24h mode for the pickerdialog was not working.

Version 3.1 was working fine. 

Here is an updated file.

* [UWP] uncomment tests that are now passing for 3188 (#3723)

* [UITest] Update Xamarin.UITest nuget package (#3632)

* [UITests] Update Xamarin.UITest 2.2.5

* [UITests] Try fix Toolbaritems

* [UITest] Update to 2.2.5-1606

* [UITests] Small Fixes and workarounds to make uitest happy

* [UITests ] Add delay to 1733 for API28

* [Android] Revert bad merge (#3746)

fixes #3705

* [Android, iOS] Fixes layout compression causes (#3698) fixes #3624

* [Android, iOS] Fixes layout compression causes

* [iOS] improve UpdateNewElement method

* Fix build error hopefully

* [UWP] Fixes CollectionChanged events in ListView (#3323)

* fixes #3273

* [UWP] Fixes CollectionChanged events in ListView

* a wrapped collection is used only if the SourceItem is not ObservableCollection

* improve uitest

* fixed NRE in empty ListView

* added a sortable custom renderer for UItest

* minor refactoring

* fixed reset of not wrapped collections

* addressing comments

* [UWP] remove WinRT hack

* [UWP] add missing using and cleanup additional resources

* [Android] Update Forms to remove API28 deprecated API (#3653) fixes #2128 fixes #3629

* [Build] Update provisioning

* [Controls] Ignore deprecated  Android API usage

* [Android] Remove use of obsolete color usage

* [Android] Remove app fragment usage

* [android] Rollback changes to EntryCellRenderer

* [Android] Better way to get the default color for the label text

* [Android] Obsolete message for ContentPage.CreateFragment()

* [ControlGallery] - create bitmap from Drawable to use for pixel location

* [Android] Use textcolor resource

* Update submodule

* Fix tests (#3771)

* [ControlGallery] Wait for element and add timing to tests

* [iOS] Fix NRE on RenderPool

* Add TabStop/TabIndex (#2795)

* [Core, UWP, Android] support TabStop/TabIndex

* removing linq

* add iOS / MacOS implementation

* add WPF implementation
fixes UWP implementation

* - addressing comments
- improve test
- optimizations
- added previous tab direction in same tab group

* addressing comments

* [Android] support tabstop for pickers

* - moving shared code to a static class
- removed reflection

* ITabStop -> changed to internal, renamed, added in to fastRenderers

* Update ITabStop to be public

* Fix : Binding Icon in ToolbarItem in TabbedPage doesn't refresh (#3761) fixes #3756

* [iOS] Fix NRE on ContextCell (#3714) fixes #3275

* [Controls] Add repo for issue #3275

* [iOS] Fix NRE when no gestures exist on table

* [iOS] Null check outside loop

* [iOS]Make sure to dispose/unhook when we are removed from UITableView.

* Update submodule

* [iOS] Don't double dispose ContextActionCell

* WPF - Fix Width and Height measurement when GetDesiredSize (#3750)

* WPF - Reset Width and Height when GetDesiredSize

* Some formatting changes

* Add APP directive

* [WPF]Fix build

* [Android Maps] Make markers available to subclasses (#3751)

* Make markers available to subclasses

* Fix build

* Use Find instead of FirstOrDefault

* [UITests] wait for element before querying for it (#3791)

* [UITests] wait for element before querying for it

* [Controls] generalize and better represent intended behavior

* WPF - Fix Local store not persistant when restarting App (#3752)

-fixes #3541
* WPF - Fix Local store not persistant when restarting App
* Add UITest
* [Controls] Add automated UI Test

* [UITests] Isolate test 3408

* [UITest] Update Xamarin UITest packages

* [UWP] implement Replace without reloading ListView (#3792)

-fixes #3788
* [UWP] implement Replace without reloading ListView
* [UWP] extract bindingcontext of new item for replace

* [iOS] Use UIApperance default color for UISwitch (#3819)

* [Controls] Set default color of UISwitch to Red

* [iOS] Use default color from Apperance API

* [UITests] replace awaits with more reliable WaitForElement (#3835)

* [Core] Propagate BindingContext changes to TitleView (#3823)

* [Core] Propagate BindingContext changes to TitleView

* [Tests] Move UI test to Core Unit Test

* [A] do not draw gradient for empty CornerRadius (#3786)

Drawing CornerRadius (introduce by #1998) when the CornerRadii are
actually 0 causes scaling artifacts on API < 25.

This fixes the regression when no CornerRadius is set. Expect blurry
border scaling with CornerRadius not empty and API < 25

- fixes #3781

* [Android] Fix WebView.Navigating event, make WebViewClient inheritable (#3780)

* Extracted WebViewRenderer.WebClient to FormsWebViewClient, moved SendNavigating call from ShouldOverrideUrlLoading to OnPageStarted

* Changed _webViewClient and GetWebViewClient() method to return base class

* Changed public things to protected internal

* Fix spaces to tabs indentation to match the coding style (#3745)

* [Build] Fix merge

* Fix #3097 swipe gesture not being handled in VisualElementTracker. (#3098) Fixes #3097

* Update from origin (#9)

* [C] VisibilityConverter Trims input (#3581)

For CSS purposes, the VisibilityConverter was added, and actually
replaced the `Boolean.Parse(str)` call for parsing Visibility.
`Boolean.Parse()` trims input, and the converter was not, so this was a
regression.
This changes Trim() the input, to be fully backward compatible.

- fixes #3554

* Ensure ConstructorCountId and TimeId elements are available before querying them (#3588)

* For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589)

This would allow previewer/designer/reloader to determine the source of a
stylesheet and refresh its content when appropriate.

* Revert "For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589)"

This reverts commit f66a72de5b475a6a8387a80e418997b38dc40d4c.

* Fix NRE; Ret 0 if Text null (#3594) fixes #3579

* [UWP, WPF] Fixes rendering of the main page (#2896) fixes #2704

* [Core] Ignore Shamehat target when running DesignTimeBuild (#3605)

* [XamlC] Fix binding compilation fo value types (#3551)

properly load valuetype arguments of generated setters, using ldarg,
instead of ldarga.

- fixes #3539

* Update PULL_REQUEST_TEMPLATE.md

* Update PULL_REQUEST_TEMPLATE.md

* [Android] Fix Label LineHeight (#3452)

* fix line height android

* Make UAP respect initial LineHeight

* update .create-nuget.bat (#3638)

* Add Null Check to GetRenderer (#3575)

- fix #3563

* Fix 3562 Null Reference Exception (#3576)

- fixes #3562

* Fix 3564 Null Reference Exception (#3578)

- fixes #3564

* [iOS] AutomationProperty support for cells (#3313) fixes #3296

* [iOS] AutomationProperty support for cells

* Add test case to AutomationProperties gallery

* [UWP] Fix crash app when create navigation/tabbed page without children pages fixes #3188 (#3514)

* [Android] Use height when determining ScaledScreenSize; fixes #3609 (#3641)

* [C] Set binding context on Span Gestures (#3639)

* [Core] Set binding context on Span Gestures
* [Core] Simplify loop setting child binding context

- fixes #3524

* Update PULL_REQUEST_TEMPLATE.md

* [Android] remove deprecated AndroidUseLatestPlatformSdk (#3672)

* [iOS] iPad ActionSheet should always have a Cancel method (#3636)

* Add repro for #3049

* [iOS] iPad ActionSheet should always have a Cancel method

fixes #3049

* [Android] fixes #3675 - set  initial ScrollView Scroll values when RTL (#3676)

* [Android] API check for Shadow properties on Button (#3617) fixes #2702

* [Android] API check for Shadow properties on Button

* Fix swapped shadow values

* [iOS] fixes #3525 - add epsilon for float compare (#3654)

* [iOS] fixes #3525 - add epsilon for float compare and make region immutable

* [ControlGallery] spread out spans to account for click slop

* [ControlGallery] - adjust span slightly for android test

* [Core] remove private

* Fix text wrapping (#3671) fixes #3634

* [GTK] Fix navigation bar visibility updates (#3651)

* Fix partially  #3585 (#3592)

* Make webkit-sharp.dll.config cross-platform

* Update webkit-sharp.dll with missing signals bindings

see: https://github.com/ylatuya/webkit-sharp/tree/fluendo

* [iOS, UWP] fixes #2894 - Gestures collection changes weren't correctly propagating (#3643)

* [iOS, UWP] fixes #2894 - Gestures weren't wiring up to spans in all cases

* [Core] remove ChildGestureRecognizers when spans get removed

* [iOS] removed incorrect return from null

* Fixes #3663 (#3684)

* Fix ScrollView Padding issue (#3685)

* [WPF] Memory leak when you pop a TabbedPage (#3372) fixes #3267

* Fix [WPF] Memory leak when you pop a TabbedPage

* Update ViewRenderer.cs

* Update ViewRenderer.cs

* [Android,iOS,UWP] Allow Entry CursorPosition/SelectionLength to be set in ctor (#3402) fixes #3343 fixes #3633

* Add repro for #3343 + unit tests

* [Core] Disallow negative values for CursorPosition/SelectionLength

* [All] CursorPosition/SelectionLength can bindin ctor & clear value

fixes #3343

* typo

* cleanup

* [iOS] Cursor snaps to end

* try/catch

* [CSS] add more properties (#3466)

map new CSS properties:
- `color` on `IColorElement` (`ActivityIndicator`, `BoxView`),
  `ProgressBar` and `Switch`
- `row-gap` and `column-gap` on `Grid`
- `transform` and `transform-origin` on `VisualElement`
- `vertical-align` on `Label`

add new XF-specific CSS properties
- `-xf-placeholder` and `-xf-placeholder-color` on `Editor`, `Entry`,
  `SearchBar`
- `-xf-max-length` on `InputView` (`Editor` and `Entry`)
- `-xf-bar-background-color` and `-xf-bar-text-color` on
  `NavigationPage` and `TabbedPage`
- `-xf-orientation` on `ScrollView` and `StackLayout`
- `-xf-horizontal-scroll-bar-visibility` and
  `-xf-vertical-scroll-bar-visibility` on `ScrollView`
- `-xf-min-track-color`, `-xf-max-track-color` and `("-xf-thumb-color`
  on `Slider`
- `-xf-spacing` on `StackLayout`

This PR replaces and closes #3276

- fixes #2891

* [iOS] Specify a default size for UISearchBar width if needed (#3635) fixes #3413 fixes #2139

* [Controls] Add reproduction and test case for issue #3413

* [iOS] Don't use max value for iOS UISearchbar breaks on iOS 11.3

* [iOS] Force width value so we can renderer UISearchBar on iOS10 with infinite width

* [Controls] Fix spelling and add Manual Review to the test of #3413

* [iOS] Simplify code for UISearchBar width

* [iOS] Return always some width from measure the UISearchBar on IOS

* [Controls] Add reproduction case for issue #2139

* [UWP] Fixed double set margins in Layouts (#3570) fixes #3398 fixes #3616

* [Android] Support multiple clipping settings in single layout (#3559)

* Repro

* Fix for API 18+

*  [iOS] Unsubscribe CellPropertyChanged when SwitchCellRenderer is disposed (#3518)

* [Controls] Add repo of issue #3408

* [iOS] Unsubscribe CellPropertyChanged when cell is disposed

* [Controls] Add issue to project

* [iOS] Introduce CellPropertyChange to CellTableViewCell to used by all other cell renderers

* [Controls] Simplify Issue

* [iOS] Remove PropertyChanged that was not used

* [Controls] add check for null binding on template, add notes about issues

* [Controls] added reference to Android crash

* [iOS]Use existing PropertyChanged on ViewCelRenderer

* [iOS] Keep the existing override so we don't break users

* Update TextCellRenderer.cs

* update submodule

* 24H Mode (#3701)

The 24h mode for the pickerdialog was not working.

Version 3.1 was working fine. 

Here is an updated file.

* [UWP] uncomment tests that are now passing for 3188 (#3723)

* [UITest] Update Xamarin.UITest nuget package (#3632)

* [UITests] Update Xamarin.UITest 2.2.5

* [UITests] Try fix Toolbaritems

* [UITest] Update to 2.2.5-1606

* [UITests] Small Fixes and workarounds to make uitest happy

* [UITests ] Add delay to 1733 for API28

* [Android] Revert bad merge (#3746)

fixes #3705

* [Android, iOS] Fixes layout compression causes (#3698) fixes #3624

* [Android, iOS] Fixes layout compression causes

* [iOS] improve UpdateNewElement method

* Fix build error hopefully

* [UWP] Fixes CollectionChanged events in ListView (#3323)

* fixes #3273

* [UWP] Fixes CollectionChanged events in ListView

* a wrapped collection is used only if the SourceItem is not ObservableCollection

* improve uitest

* fixed NRE in empty ListView

* added a sortable custom renderer for UItest

* minor refactoring

* fixed reset of not wrapped collections

* addressing comments

* [UWP] remove WinRT hack

* [UWP] add missing using and cleanup additional resources

* [Android] Update Forms to remove API28 deprecated API (#3653) fixes #2128 fixes #3629

* [Build] Update provisioning

* [Controls] Ignore deprecated  Android API usage

* [Android] Remove use of obsolete color usage

* [Android] Remove app fragment usage

* [android] Rollback changes to EntryCellRenderer

* [Android] Better way to get the default color for the label text

* [Android] Obsolete message for ContentPage.CreateFragment()

* [ControlGallery] - create bitmap from Drawable to use for pixel location

* [Android] Use textcolor resource

* Update submodule

* Fix tests (#3771)

* [ControlGallery] Wait for element and add timing to tests

* [iOS] Fix NRE on RenderPool

* Add TabStop/TabIndex (#2795)

* [Core, UWP, Android] support TabStop/TabIndex

* removing linq

* add iOS / MacOS implementation

* add WPF implementation
fixes UWP implementation

* - addressing comments
- improve test
- optimizations
- added previous tab direction in same tab group

* addressing comments

* [Android] support tabstop for pickers

* - moving shared code to a static class
- removed reflection

* ITabStop -> changed to internal, renamed, added in to fastRenderers

* Update ITabStop to be public

* Fix : Binding Icon in ToolbarItem in TabbedPage doesn't refresh (#3761) fixes #3756

* [iOS] Fix NRE on ContextCell (#3714) fixes #3275

* [Controls] Add repo for issue #3275

* [iOS] Fix NRE when no gestures exist on table

* [iOS] Null check outside loop

* [iOS]Make sure to dispose/unhook when we are removed from UITableView.

* Update submodule

* [iOS] Don't double dispose ContextActionCell

* WPF - Fix Width and Height measurement when GetDesiredSize (#3750)

* WPF - Reset Width and Height when GetDesiredSize

* Some formatting changes

* Add APP directive

* [WPF]Fix build

* [Android Maps] Make markers available to subclasses (#3751)

* Make markers available to subclasses

* Fix build

* Use Find instead of FirstOrDefault

* [UITests] wait for element before querying for it (#3791)

* [UITests] wait for element before querying for it

* [Controls] generalize and better represent intended behavior

* WPF - Fix Local store not persistant when restarting App (#3752)

-fixes #3541
* WPF - Fix Local store not persistant when restarting App
* Add UITest
* [Controls] Add automated UI Test

* [UITests] Isolate test 3408

* [UITest] Update Xamarin UITest packages

* [UWP] implement Replace without reloading ListView (#3792)

-fixes #3788
* [UWP] implement Replace without reloading ListView
* [UWP] extract bindingcontext of new item for replace

* [iOS] Use UIApperance default color for UISwitch (#3819)

* [Controls] Set default color of UISwitch to Red

* [iOS] Use default color from Apperance API

* [UITests] replace awaits with more reliable WaitForElement (#3835)

* [Core] Propagate BindingContext changes to TitleView (#3823)

* [Core] Propagate BindingContext changes to TitleView

* [Tests] Move UI test to Core Unit Test

* [A] do not draw gradient for empty CornerRadius (#3786)

Drawing CornerRadius (introduce by #1998) when the CornerRadii are
actually 0 causes scaling artifacts on API < 25.

This fixes the regression when no CornerRadius is set. Expect blurry
border scaling with CornerRadius not empty and API < 25

- fixes #3781

* [Android] Fix WebView.Navigating event, make WebViewClient inheritable (#3780)

* Extracted WebViewRenderer.WebClient to FormsWebViewClient, moved SendNavigating call from ShouldOverrideUrlLoading to OnPageStarted

* Changed _webViewClient and GetWebViewClient() method to return base class

* Changed public things to protected internal

* Fix spaces to tabs indentation to match the coding style (#3745)

* [Build] Fix merge

* Fix #3097 swipe gesture not being handled in VisualElementTracker. (#3098) Fixes #3097

* Ensure that the ListViewAdapter is no longer being used by the ListVi… (#3848) fixes #3603

* Ensure that the ListViewAdapter is no longer being used by the ListView before disposing it

* Remove `RemoveAllViews` from `Dispose`

* Update from origin (#11)

* [Android] Enable MaxLines and TextDecorations on fast renderers (#3878)

* enable MaxLines on fast renderers

* added text decoration functionality

* include test in project

* [Enhancement] Create a bindable property for AutomationId (#3879)

* create a bindable property for automationId

* make ClassId and AutomationId properties of Element

* add comments to .create-nuget.bat

* added preserve attribute (#3876) fixes #2306

* [Core] Moving Command's CanExecuteChanged to use the WeakEventManager (#3852) fixes #3656

* [Core]  Use WeakEventManager on CanExecuteChanged

* [Core]Add unit test for remove event handler with WeakEventManager

* [Core] Fix remove the correct handler

* [CSS] accept 'oblique' for 'font-style' (#3815) fixes #3808

- fixes #3808

* Prevent double time/date picker dialogs on Android when setting focus (#3899)

* Prevent double time/date picker dialogs on Android when setting focus (#3899)

* [Controls] Fix merge remove duplciated issue 3788

* WPF - Fix Unable to intercept back button (#3762)

* WPF - Fix Unable to intercept back button

* WPF - Improve OnBackButtonPressed

-fixes #3689

* Fix Bugzilla38723 (#3812)

fixes #2302

* [C] fix css mapping (#3919)

* [Android] Fix UI test 1851 (#3882)

* add preserve attribute

- fixes #2255


* added using System

* fixed spacing

* use TestContentPage

* fixed scope issues

* [Android] Make native Android Platforms accessible via Context (#3364)

* Make native Android Platforms accessible via Context

* Add null checks

* Added a disabled look to Android Toolbar Item images. (#3773)

* Added a disabled look to Android Toolbar Item images.

* Update NavigationPageRenderer.cs

Refactored DisabledToolbarAlpha into a constant as requested.

* [UWP] fixes tabstops of TimePicker, DatePiker. SearchBar, Stepper (#3896)

* [UWP] fixes tabstops of TimePicker, DatePiker. SearchBar, Stepper

* common code moved to VisualElementRenderer

* rename interface

fixes #3872

* [UWP] For the Slider default value of step is set to 1000 to match Android. (#3141)

* WPF - Ctrl+A does not select all in WPF password Entry (#3908)

* [WPF] Fix Height of items not consistent (#3925) fixes #3913

* Fix StartTimer and Ticker for UWP (#3911)

- fixes #1937

* Apply font fix for button and span (#3907)

* added instructions (#3891)

- fixes #2361

* [Android] Convert corner radius with correct pixel density (#3893) fixes #3884

* [Controls] Add Issue #3884 repo

* [Android] Convert  corner radius with correct pixel density fixes #3884

* [Controls] Update test message

* WPF - Fix TimePicker with short time pattern shows verbose time (#3924)

* Fix UI test 39378 (#3928)

fixes #2305

* Update ClipBounds when View bounds changes (#3909)

fixes #3717

* [C] catch AmbiguousMatchException on GetProps (#3915)

- fixes #3870

* Automate UI test B45702 (#3914) fixes #2389

* automate 45702

* fix indentation

* Fix bugzilla60787 (#3933)

* [Android]Fix for frame renderer's bug (bugzilla 60787).

#3902
https://bugzilla.xamarin.com/show_bug.cgi?id=60787
https://github.com/xamarin/Xamarin.Forms/issues/3902

* Add control to repro

* PR fix

* Build fix

* Build fix for Xamarin.Forms.Core.Android.UITests

* added instructions (#3926)

* [UWP] fixes flyout menu on cell item (#3682)

* Fix UI test B41424 needs instructions (#3942)

* Add manual test steps and checks for ui test

* step4Label text fix

* [iOS] fix full width issues for TitleView (#3939)

* [iOS] fix full width issues for TitleView

* [iOS] simplified iOS 10

fixes #3881
fixes #3679

* Changes in TableView GTK Control to allow refresh the content (#3941)

- fixes #3725

* Only set the Page Padding via SafeAreaInset on iOS (#3811)

* only set the Page Padding via SafeAreaInset on iOS
-fixes #3809

* [Controls] add waits for clicks in ui tests

* [Controls] remove wrong category

* [iOS] Move inset logic down into ios renderer

* Added logic to allow set the ListView SelectedIndex (#3948) fixes #3766

* Automate UI test 35127 (#3927)

* automate test
- fixes #2262
* indentation fix
* indentation fix 2

* Make GetIconDrawable virtual (#3967)

By making GetIconDrawable virtual for the Android TabbedPageRenderer it allows for the icon to come from other sources (like glyph fonts). This will work for both top and bottom tabs.

* [GTK] Fix visibility of hidden pages in the stack (#3904)

When navigating to a new page, we should hide the previous
content and show the new one so that the previous page
renderer is not taken in account for redraws and resizes

* [Android] If MaxLines is not explicitly set, let LineBreakMode handle it (#3936)

* [Android] If MaxLines is not explicitly set, all LineBreakMode to set it;
if MaxLines is explicitly set, MaxLines setting wins. Use a more reasonable
default for native MaxLines when handling it via LineBreakMode. Consolidate
MaxLines handling code between legacy and fast renderers. Remove unnecessary
setting of SingleLine (which only applies to input).
- fixes #3772

* Remove unnecessary maxLines setting

* Handle resetting MaxLines to -1/default

* Reinstate workaround for array bounds exception in older Android APIs

* Fix UI test B43941 (#3889)

* Add all platforms and remove non-deterministic behaviour

* Return back correct check of counter

* Endline fix

* remove childPages list

* [XamlC] avoid multiple subscription (#3969)

Avoid multiple subscription to PropertyChanged on TypedBindings

- fixes #3613
- fixes #3650

* Fix typos (mainly 'toogle' becoming 'toggle') (#3975)

* Fix Issue2597 Needs UI Test (#3966)

* Add test for issue 2597

* Fix space

* Add CODEOWNERS

* Fix PanGesture inside scroll issue https://github.com/xamarin/Xamarin… (#3842)

* Fix PanGesture inside scroll issue https://github.com/xamarin/Xamarin.Forms/issues/3840
- fixes #3840
* fixe formatting

* [UITest] added UI Test

* [Controls] adjusted UI Test button positions

* [UITEST]  simplify UI tests

* [C] add CSS mapping for max-lines (#3991)

- fixes #3982

* [iOS] Add ability to turn off updates to native controls from another thread (#3774)

* [iOS] Add ability to turn off updates to native controls from another thread

* Flip evaluation order

fixes #1755

* Fixed NotImplementedException refreshing items in WPF ListView (#3962)

* Fixed NotImplementedException refreshing items in WPF ListView

* Small changes in ListView events subscription

fixes #3309
fixes #3737
fixes #3648

* [GTK] Fix transparent background in visual elements (#3744)

* Fix ActivityIndicator.IsRunning state (#4007)

* add pdb for uap into nuget (#4015)

* update GitInfo

* [XamlC] don't compile bindings with Source (#3978)

Sources are usually x:reference that can't be resolved at compilation
time.

- fixes #3606

* [Xaml[C]] resolve Extensions first (#3977)

XamlLoader should first look for type with the Extension suffix. It used
to be the case, but somehow regressed.

- fixes https://github.com/xamarin/Xamarin.Forms/issues/3606#issuecomment-422377338

* [UWP] Document in the README.md the steps required to run UI Tests (#4014) fixes #3984

* [Tizen] Add TabIndex implement for Tizen renderer (#4046)

* [Tasks] multitarget the build tasks (#3895)

- fixes #2690
- closes #2706

* [UITests] Update TestCloud.Agent (#4055)

* [Tizen] Fix ProjectGuid for Forwarders (#4063)

* [Tizen] Fix ProjectGuid for Forwarders

* [Tizen] Make sure not to generate dependency file

* Correct minor typo (#4068)

* Added WebView Reload (#4013) fixes #3776

* Added WebView Reload

* WebView Reload Added Tizen suport

* [Tizen] Cleanup Code (#4080)

* fixed ios editor placeholder font (#4009)

* Prevented crash https://github.com/xamarin/Xamarin.Forms/issues/2291 (#4072)

- fixes #2291

* [Xaml] Allow OnPlat markup in Styles (#3995)

- fixes #3862

* [Xaml] fix Namescope being different than tree (#4089)

As part of #2556, the namescoping tree was assumed to be equiv to the
object tree, which is obviously wrong. This fixes it, while keeping the
old behavior as a fallback.

We might go further, but I can't come up with a reasonable scenario
failing.

- fixes #3821

* [Sample] [Android] Fixed PagesGallery.Droid build (#3999)

* fixed PagesGallery.Droid build

* Moved Xamarin.Forms.Platform.Android (Forwarders) reference to previous place

* updated project guid to lower case

* Fix typeface reset issue (#4019)

* Use ViewCompat to set and get label for view (#3996)

* Removing LineBreakMode support from WindowsResourcesProvider (#4024)

* Repro test page for 3979

* Removes LineBreakMode support from WindowsResourcesProvider as it is inconsistent with other platforms and caused issues when setting Span style to the default Device Styles

* [macOS] Fix NRE on Mojave when aligning the tile (#4086) fixes #3031

* [GTK] Add support for ClickGestureRecognizer (#3971)

* [GTK] Add support for ClickGestureRecognizer

* Add ClickGestureGalleryPage to test ClickGestureRecognizer

* [iOS] Label TextColor has no effect with FormattedString (#4043)

* https://github.com/xamarin/Xamarin.Forms/issues/4040 fix default font/color for formatted string

* https://github.com/xamarin/Xamarin.Forms/pull/4043 fixed naming, added test case

* Moved field and property to top

- fixes #4040

* fix build, tentatively (#4117)

* [Xaml] don't swallow exceptions from converters (#4100)

Compiled converters are invoked, by reflection, at compile time. Any
exception thrown there will be wrapped in a TargetInvocationException.
When that happens, we still want to expose the inner XamlParseException
to the user.

- fixes #4099

* housekeeping ended with https://github.com/xamarin/Xamarin.Forms/pull/3999 (#4105)

* Bump minimum Microsoft.NETCore.UniversalWindowsPlatform version to 6.0.12 (#4106)

* [Tizen] Fix Window alpha update timing (#4119)

* [UWP] fixed `MinimumDate` and `MaximumDate` properties of DatePicker (#3683) fixes #3331

* [WPF] Fixes `ControlTemplate` sizing issue (#2656)

- fixes #2642

* Remove BOM from nuspec (#4128)

* Navigation Page double Popped event Workaround (#3851) fixes #3509

* Navigation Page double Popped event Workaround

* [UITest] Add UI Test

* [Core] fix formatting

* revert formatting fix

* implemented workaround suggested by PureWeen

* removed whitespace

* moved ignorePopCall to a better location

* [Enhancements] Toolbar a11y  (#3974) fixes #1742 fixes #3795

* [Controls] Add automation id to icon

* [iOS] Add AutomationId support to MDP tooggle button

* [Android] Add support for AutomationId to ActionBarDrawerToggle and MasterDetailPage

* [IOS] Refactor and add Accessibility to ToolbarItems

* [iOS] Fix typos

* [Android] Add accessibility to ToolbarItems

* [UWP]  Refactor A11y to extensions

* [UWP]  Set Accessibility properties on ToolbarItems

* [UWP] Set accessibility to MDP button

* [ControlGallery] Add accessibility toolbaritems to gallery

* Comment test out

* [iOS] Fix NRE when Control is being disposed

* [UITests] Remove not used UITests file

* Implementation of method ForceUpdateSize for Cell on macOS (#4104)

* Implemented Cell ForceUpdateSize on macOS

* Tab Styling

* Prevent crash during setting NULL to element via interface method (#4179)

- fixes #4178
- fixes #4146

* https://github.com/xamarin/Xamarin.Forms/issues/4076 fix (#4161)

* [iOS] Rapidly clicking span (6 times at least) on UITest 3525 throws a null exception (#4109)

* https://github.com/xamarin/Xamarin.Forms/issues/3930 fix

* following convention

* [Android] Fixes AutomationProperties.Name on Button (#4094)

* [Android] Fixes AutomationProperties.Name on Button

* [Android] Fixes for Switch control

* UWP Toolbar dynamic overflow (#4022)

* Adding Windows specific ToolbarDynamicOverflowEnabled configuration

* Enabled ToolbarDynamicOverflowEnabled (pun intended) on page controls and renderers

* Issue 3988 sample

* Removed obsolete comment, cleaned up private and whitespace

* Added toolbar dynamic overflow examples for master detail page and tabbed page


- fixes #2057
- fixes #3988

* Add missing initial call to UpdateLineHeight; fixes #4136 (#4147)

* Added UI test to B45027 (#4079)

* Add UI test to B45027

* Changed execution of current UI test to Android platform

* Added iOS UI test to B45027

* Refactored UI test execution

* Fix https://github.com/xamarin/Xamarin.Forms/issues/3301 (#4164)

- fixes #3301

* [UWP] fixes entering text into SearchBar with UI Tests (#4173)

* [UWP] fixes entering text into SearchBar with UI Tests

* [UWP] ITabStopOnDescendants - fixed selection when setting focus from Selenium

* [UWP] Fix TitleView Width and MDP rendering quirks (#3987)

* [UWP] Fix TitleView Width and MDP rendering quirks

* [UWP] fix load timing for pushed pages and titleview

* [UWP] move renderer check

* [UWP] remove re-measure until 4116 fixed

- fixes #3828
- fixes #3834

* [macOS] NRE in WebViewRenderer (#4188) fixes #4001

* https://github.com/xamarin/Xamarin.Forms/issues/4001

* fixed build

* https://github.com/xamarin/Xamarin.Forms/issues/2831 fixes #2831 (#4111)

* [msbuild] use portable pdb files (#4201)

Currently, on the first build of a "Hello World" Xamarin.Forms app,
you will see this in the build log:

    ConvertDebuggingFiles
        Parameters
            Files
                C:\Users\myuser\.nuget\packages\xamarin.forms\3.1.0.697729\lib\MonoAndroid10\FormsViewGroup.pdb
                C:\Users\myuser\.nuget\packages\xamarin.forms\3.1.0.697729\lib\MonoAndroid10\Xamarin.Forms.Platform.Android.pdb
        OutputItems
            _ConvertedDebuggingFiles
                C:\Users\myuser\.nuget\packages\xamarin.forms\3.1.0.697729\lib\MonoAndroid10\FormsViewGroup.dll
                C:\Users\myuser\.nuget\packages\xamarin.forms\3.1.0.697729\lib\MonoAndroid10\Xamarin.Forms.Platform.Android.dll

The logging is a little weird here, but this `ConvertDebuggingFiles`
MSBuild task takes about 100ms on my machine.

What is it doing?

The Mono debugger can support two types of debugging files:
- `mdb` files
- "portable" `pdb` files

If Xamarin.Android's build finds a "non-portable" `pdb` file, we have
to run it through this task to convert to an `mdb` file... This gives
us proper stacktraces for `FormsViewGroup.dll` and
`Xamarin.Forms.Platform.Android.dll`.

You can change the type of debugging symbols in your project with the
`DebugType` setting, which has these options:
- Blank or `None`: don't generate symbols. (Although Xamarin.Android
  has funny behavior here, see:
  https://github.com/xamarin/xamarin-android/issues/2282)
- `Full` generates an `mdb` file, this is a Windows-proprietary format
  for debug builds
- `PdbOnly` generates a "non-portable" `pdb` file, a
  Windows-proprietary format for release builds
- `Portable` generates a "portable" pdb file, which is the new
  standard that works for debug and release builds. New SDK-style
  MSBuild projects use this option by default.

These values are not case sensitive, I have mostly seen them lower
case in newer projects.

So what does Xamarin.Forms need to do?

Use `<DebugType>portable</DebugType>` in any Android class library or
app project. Other platforms, this is optional, not as much benefit. I
have heard that `DebugType=portable` might cause a problem on UWP.

* Xamarin.Forms will ship "portable" `pdbs` in its NuGet package for
  `FormsViewGroup.dll` and `Xamarin.Forms.*.Android.dll`. Developers
  won't pay the 100ms on initial build.
* Initial build times for `Xamarin.Forms.sln` will be slightly better
  for development, although I didn't measure the difference here.

* [XamlC] fix the argument match check for events (#4134)

Well, it looks like the order of arguments of InheritOrImplements was
reversed... a totally fine and normal Friday so far

- fixes #4130

* Add UI Test. Add instructions. Move to correct namespace (#4170) fixes #2251

* Add uitest for 2794 (#4110) fixes #2293

* Fix PropagateEvent value properly on Cells (#4191)

* bump gitinfo

* [Core, iOS, MacOS, Android, UWP, WPF] ListView hide scroll view scroll bars (#3897) fixes #3843

* Update from origin (#8)

* [C] VisibilityConverter Trims input (#3581)

For CSS purposes, the VisibilityConverter was added, and actually
replaced the `Boolean.Parse(str)` call for parsing Visibility.
`Boolean.Parse()` trims input, and the converter was not, so this was a
regression.
This changes Trim() the input, to be fully backward compatible.

- fixes #3554

* Ensure ConstructorCountId and TimeId elements are available before querying them (#3588)

* For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589)

This would allow previewer/designer/reloader to determine the source of a
stylesheet and refresh its content when appropriate.

* Revert "For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589)"

This reverts commit f66a72de5b475a6a8387a80e418997b38dc40d4c.

* Fix NRE; Ret 0 if Text null (#3594) fixes #3579

* [UWP, WPF] Fixes rendering of the main page (#2896) fixes #2704

* [Core] Ignore Shamehat target when running DesignTimeBuild (#3605)

* [XamlC] Fix binding compilation fo value types (#3551)

properly load valuetype arguments of generated setters, using ldarg,
instead of ldarga.

- fixes #3539

* Update PULL_REQUEST_TEMPLATE.md

* Update PULL_REQUEST_TEMPLATE.md

* [Android] Fix Label LineHeight (#3452)

* fix line height android

* Make UAP respect initial LineHeight

* update .create-nuget.bat (#3638)

* Add Null Check to GetRenderer (#3575)

- fix #3563

* Fix 3562 Null Reference Exception (#3576)

- fixes #3562

* Fix 3564 Null Reference Exception (#3578)

- fixes #3564

* [iOS] AutomationProperty support for cells (#3313) fixes #3296

* [iOS] AutomationProperty support for cells

* Add test case to AutomationProperties gallery

* [UWP] Fix crash app when create navigation/tabbed page without children pages fixes #3188 (#3514)

* [Android] Use height when determining ScaledScreenSize; fixes #3609 (#3641)

* [C] Set binding context on Span Gestures (#3639)

* [Core] Set binding context on Span Gestures
* [Core] Simplify loop setting child binding context

- fixes #3524

* Update PULL_REQUEST_TEMPLATE.md

* [Android] remove deprecated AndroidUseLatestPlatformSdk (#3672)

* [iOS] iPad ActionSheet should always have a Cancel method (#3636)

* Add repro for #3049

* [iOS] iPad ActionSheet should always have a Cancel method

fixes #3049

* [Android] fixes #3675 - set  initial ScrollView Scroll values when RTL (#3676)

* [Android] API check for Shadow properties on Button (#3617) fixes #2702

* [Android] API check for Shadow properties on Button

* Fix swapped shadow values

* [iOS] fixes #3525 - add epsilon for float compare (#3654)

* [iOS] fixes #3525 - add epsilon for float compare and make region immutable

* [ControlGallery] spread out spans to account for click slop

* [ControlGallery] - adjust span slightly for android test

* [Core] remove private

* Fix text wrapping (#3671) fixes #3634

* [GTK] Fix navigation bar visibility updates (#3651)

* Fix partially  #3585 (#3592)

* Make webkit-sharp.dll.config cross-platform

* Update webkit-sharp.dll with missing signals bindings

see: https://github.com/ylatuya/webkit-sharp/tree/fluendo

* [iOS, UWP] fixes #2894 - Gestures collection changes weren't correctly propagating (#3643)

* [iOS, UWP] fixes #2894 - Gestures weren't wiring up to spans in all cases

* [Core] remove ChildGestureRecognizers when spans get removed

* [iOS] removed incorrect return from null

* Fixes #3663 (#3684)

* Fix ScrollView Padding issue (#3685)

* [WPF] Memory leak when you pop a TabbedPage (#3372) fixes #3267

* Fix [WPF] Memory leak when you pop a TabbedPage

* Update ViewRenderer.cs

* Update ViewRenderer.cs

* [Android,iOS,UWP] Allow Entry CursorPosition/SelectionLength to be set in ctor (#3402) fixes #3343 fixes #3633

* Add repro for #3343 + unit tests

* [Core] Disallow negative values for CursorPosition/SelectionLength

* [All] CursorPosition/SelectionLength can bindin ctor & clear value

fixes #3343

* typo

* cleanup

* [iOS] Cursor snaps to end

* try/catch

* [CSS] add more properties (#3466)

map new CSS properties:
- `color` on `IColorElement` (`ActivityIndicator`, `BoxView`),
  `ProgressBar` and `Switch`
- `row-gap` and `column-gap` on `Grid`
- `transform` and `transform-origin` on `VisualElement`
- `vertical-align` on `Label`

add new XF-specific CSS properties
- `-xf-placeholder` and `-xf-placeholder-color` on `Editor`, `Entry`,
  `SearchBar`
- `-xf-max-length` on `InputView` (`Editor` and `Entry`)
- `-xf-bar-background-color` and `-xf-bar-text-color` on
  `NavigationPage` and `TabbedPage`
- `-xf-orientation` on `ScrollView` and `StackLayout`
- `-xf-horizontal-scroll-bar-visibility` and
  `-xf-vertical-scroll-bar-visibility` on `ScrollView`
- `-xf-min-track-color`, `-xf-max-track-color` and `("-xf-thumb-color`
  on `Slider`
- `-xf-spacing` on `StackLayout`

This PR replaces and closes #3276

- fixes #2891

* [iOS] Specify a default size for UISearchBar width if needed (#3635) fixes #3413 fixes #2139

* [Controls] Add reproduction and test case for issue #3413

* [iOS] Don't use max value for iOS UISearchbar breaks on iOS 11.3

* [iOS] Force width value so we can renderer UISearchBar on iOS10 with infinite width

* [Controls] Fix spelling and add Manual Review to the test of #3413

* [iOS] Simplify code for UISearchBar width

* [iOS] Return always some width from measure the UISearchBar on IOS

* [Controls] Add reproduction case for issue #2139

* [UWP] Fixed double set margins in Layouts (#3570) fixes #3398 fixes #3616

* [Android] Support multiple clipping settings in single layout (#3559)

* Repro

* Fix for API 18+

*  [iOS] Unsubscribe CellPropertyChanged when SwitchCellRenderer is disposed (#3518)

* [Controls] Add repo of issue #3408

* [iOS] Unsubscribe CellPropertyChanged when cell is disposed

* [Controls] Add issue to project

* [iOS] Introduce CellPropertyChange to CellTableViewCell to used by all other cell renderers

* [Controls] Simplify Issue

* [iOS] Remove PropertyChanged that was not used

* [Controls] add check for null binding on template, add notes about issues

* [Controls] added reference to Android crash

* [iOS]Use existing PropertyChanged on ViewCelRenderer

* [iOS] Keep the existing override so we don't break users

* Update TextCellRenderer.cs

* update submodule

* 24H Mode (#3701)

The 24h mode for the pickerdialog was not working.

Version 3.1 was working fine. 

Here is an updated file.

* [UWP] uncomment tests that are now passing for 3188 (#3723)

* [UITest] Update Xamarin.UITest nuget package (#3632)

* [UITests] Update Xamarin.UITest 2.2.5

* [UITests] Try fix Toolbaritems

* [UITest] Update to 2.2.5-1606

* [UITests] Small Fixes and workarounds to make uitest happy

* [UITests ] Add delay to 1733 for API28

* [Android] Revert bad merge (#3746)

fixes #3705

* [Android, iOS] Fixes layout compression causes (#3698) fixes #3624

* [Android, iOS] Fixes layout compression causes

* [iOS] improve UpdateNewElement method

* Fix build error hopefully

* [UWP] Fixes CollectionChanged events in ListView (#3323)

* fixes #3273

* [UWP] Fixes CollectionChanged events in ListView

* a wrapped collection is used only if the SourceItem is not ObservableCollection

* improve uitest

* fixed NRE in empty ListView

* added a sortable custom renderer for UItest

* minor refactoring

* fixed reset of not wrapped collections

* addressing comments

* [UWP] remove WinRT hack

* [UWP] add missing using and cleanup additional resources

* [Android] Update Forms to remove API28 deprecated API (#3653) fixes #2128 fixes #3629

* [Build] Update provisioning

* [Controls] Ignore deprecated  Android API usage

* [Android] Remove use of obsolete color usage

* [Android] Remove app fragment usage

* [android] Rollback changes to EntryCellRenderer

* [Android] Better way to get the default color for the label text

* [Android] Obsolete message for ContentPage.CreateFragment()

* [ControlGallery] - create bitmap from Drawable to use for pixel location

* [Android] Use textcolor resource

* Update submodule

* Fix tests (#3771)

* [ControlGallery] Wait for element and add timing to tests

* [iOS] Fix NRE on RenderPool

* Add TabStop/TabIndex (#2795)

* [Core, UWP, Android] support TabStop/TabIndex

* removing linq

* add iOS / MacOS implementation

* add WPF implementation
fixes UWP implementation

* - addressing comments
- improve test
- optimizations
- added previous tab direction in same tab group

* addressing comments

* [Android] support tabstop for pickers

* - moving shared code to a static class
- removed reflection

* ITabStop -> changed to internal, renamed, added in to fastRenderers

* Update ITabStop to be public

* Fix : Binding Icon in ToolbarItem in TabbedPage doesn't refresh (#3761) fixes #3756

* [iOS] Fix NRE on ContextCell (#3714) fixes #3275

* [Controls] Add repo for issue #3275

* [iOS] Fix NRE when no gestures exist on table

* [iOS] Null check outside loop

* [iOS]Make sure to dispose/unhook when we are removed from UITableView.

* Update submodule

* [iOS] Don't double dispose ContextActionCell

* WPF - Fix Width and Height measurement when GetDesiredSize (#3750)

* WPF - Reset Width and Height when GetDesiredSize

* Some formatting changes

* Add APP directive

* [WPF]Fix build

* [Android Maps] Make markers available to subclasses (#3751)

* Make markers available to subclasses

* Fix build

* Use Find instead of FirstOrDefault

* [UITests] wait for element before querying for it (#3791)

* [UITests] wait for element before querying for it

* [Controls] generalize and better represent intended behavior

* WPF - Fix Local store not persistant when restarting App (#3752)

-fixes #3541
* WPF - Fix Local store not persistant when restarting App
* Add UITest
* [Controls] Add automated UI Test

* [UITests] Isolate test 3408

* [UITest] Update Xamarin UITest packages

* [UWP] implement Replace without reloading ListView (#3792)

-fixes #3788
* [UWP] implement Replace without reloading ListView
* [UWP] extract bindingcontext of new item for replace

* [iOS] Use UIApperance default color for UISwitch (#3819)

* [Controls] Set default color of UISwitch to Red

* [iOS] Use default color from Apperance API

* [UITests] replace awaits with more reliable WaitForElement (#3835)

* [Core] Propagate BindingContext changes to TitleView (#3823)

* [Core] Propagate BindingContext changes to TitleView

* [Tests] Move UI test to Core Unit Test

* [A] do not draw gradient for empty CornerRadius (#3786)

Drawing CornerRadius (introduce by #1998) when the CornerRadii are
actually 0 causes scaling artifacts on API < 25.

This fixes the regression when no CornerRadius is set. Expect blurry
border scaling with CornerRadius not empty and API < 25

- fixes #3781

* [Android] Fix WebView.Navigating event, make WebViewClient inheritable (#3780)

* Extracted WebViewRenderer.WebClient to FormsWebViewClient, moved SendNavigating call from ShouldOverrideUrlLoading to OnPageStarted

* Changed _webViewClient and GetWebViewClient() method to return base class

* Changed public things to protected internal

* Fix spaces to tabs indentation to match the coding style (#3745)

* [Build] Fix merge

* Fix #3097 swipe gesture not being handled in VisualElementTracker. (#3098) Fixes #3097

* Implemented for iOS, Android and MacOS

* Implemented UAP and WPF

* Refactored duplicate code and removed typo in method name

* Update from origin (#9)

* [C] VisibilityConverter Trims input (#3581)

For CSS purposes, the VisibilityConverter was added, and actually
replaced the `Boolean.Parse(str)` call for parsing Visibility.
`Boolean.Parse()` trims input, and the converter was not, so this was a
regression.
This changes Trim() the input, to be fully backward compatible.

- fixes #3554

* Ensure ConstructorCountId and TimeId elements are available before querying them (#3588)

* For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589)

This would allow previewer/designer/reloader to determine the source of a
stylesheet and refresh its content when appropriate.

* Revert "For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589)"

This reverts commit f66a72de5b475a6a8387a80e418997b38dc40d4c.

* Fix NRE; Ret 0 if Text null (#3594) fixes #3579

* [UWP, WPF] Fixes rendering of the main page (#2896) fixes #2704

* [Core] Ignore Shamehat target when running DesignTimeBuild (#3605)

* [XamlC] Fix binding compilation fo value types (#3551)

properly load valuetype arguments of generated setters, using ldarg,
instead of ldarga.

- fixes #3539

* Update PULL_REQUEST_TEMPLATE.md

* Update PULL_REQUEST_TEMPLATE.md

* [Android] Fix Label LineHeight (#3452)

* fix line height android

* Make UAP respect initial LineHeight

* update .create-nuget.bat (#3638)

* Add Null Check to GetRenderer (#3575)

- fix #3563

* Fix 3562 Null Reference Exception (#3576)

- fixes #3562

* Fix 3564 Null Reference Exception (#3578)

- fixes #3564

* [iOS] AutomationProperty support for cells (#3313) fixes #3296

* [iOS] AutomationProperty support for cells

* Add test case to AutomationProperties gallery

* [UWP] Fix crash app when create navigation/tabbed page without children pages fixes #3188 (#3514)

* [Android] Use height when determining ScaledScreenSize; fixes #3609 (#3641)

* [C] Set binding context on Span Gestures (#3639)

* [Core] Set binding context on Span Gestures
* [Core] Simplify loop setting child binding context

- fixes #3524

* Update PULL_REQUEST_TEMPLATE.md

* [Android] remove deprecated AndroidUseLatestPlatformSdk (#3672)

* [iOS] iPad ActionSheet should always have a Cancel method (#3636)

* Add repro for #3049

* [iOS] iPad ActionSheet should always have a Cancel method

fixes #3049

* [Android] fixes #3675 - set  initial ScrollView Scroll values when RTL (#3676)

* [Android] API check for Shadow properties on Button (#3617) fixes #2702

* [Android] API check for Shadow properties on Button

* Fix swapped shadow values

* [iOS] fixes #3525 - add epsilon for float compare (#3654)

* [iOS] fixes #3525 - add epsilon for float compare and make region immutable

* [ControlGallery] spread out spans to account for click slop

* [ControlGallery] - adjust span slightly for android test

* [Core] remove private

* Fix text wrapping (#3671) fixes #3634

* [GTK] Fix navigation bar visibility updates (#3651)

* Fix partially  #3585 (#3592)

* Make webkit-sharp.dll.config cross-platform

* Update webkit-sharp.dll with missing signals bindings

see: https://github.com/ylatuya/webkit-sharp/tree/fluendo

* [iOS, UWP] fixes #2894 - Gestures collection changes weren't correctly propagating (#3643)

* [iOS, UWP] fixes #2894 - Gestures weren't wiring up to spans in all cases

* [Core] remove ChildGestureRecognizers when spans get removed

* [iOS] removed incorrect return from null

* Fixes #3663 (#3684)

* Fix ScrollView Padding issue (#3685)

* [WPF] Memory leak when you pop a TabbedPage (#3372) fixes #3267

* Fix [WPF] Memory leak when you pop a TabbedPage

* Update ViewRenderer.cs

* Update ViewRenderer.cs

* [Android,iOS,UWP] Allow Entry CursorPosition/SelectionLength to be set in ctor (#3402) fixes #3343 fixes #3633

* Add repro for #3343 + unit tests

* [Core] Disallow negative values for CursorPosition/SelectionLength

* [All] CursorPosition/SelectionLength can bindin ctor & clear value

fixes #3343

* typo

* cleanup

* [iOS] Cursor snaps to end

* try/catch

* [CSS] add more properties (#3466)

map new CSS properties:
- `color` on `IColorElement` (`ActivityIndicator`, `BoxView`),
  `ProgressBar` and `Switch`
- `row-gap` and `column-gap` on `Grid`
- `transform` and `transform-origin` on `VisualElement`
- `vertical-align` on `Label`

add new XF-specific CSS properties
- `-xf-placeholder` and `-xf-placeholder-color` on `Editor`, `Entry`,
  `SearchBar`
- `-xf-max-length` on `InputView` (`Editor` and `Entry`)
- `-xf-bar-background-color` and `-xf-bar-text-color` on
  `NavigationPage` and `TabbedPage`
- `-xf-orientation` on `ScrollView` and `StackLayout`
- `-xf-horizontal-scroll-bar-visibility` and
  `-xf-vertical-scroll-bar-visibility` on `ScrollView`
- `-xf-min-track-color`, `-xf-max-track-color` and `("-xf-thumb-color`
  on `Slider`
- `-xf-spacing` on `StackLayout`

This PR replaces and closes #3276

- fixes #2891

* [iOS] Specify a default size for UISearchBar width if needed (#3635) fixes #3413 fixes #2139

* [Controls] Add reproduction and test case for issue #3413

* [iOS] Don't use max value for iOS UISearchbar breaks on iOS 11.3

* [iOS] Force width value so we can renderer UISearchBar on iOS10 with infinite width

* [Controls] Fix spelling and add Manual Review to the test of #3413

* [iOS] Simplify code for UISearchBar width

* [iOS] Return always some width from measure the UISearchBar on IOS

* [Controls] Add reproduction case for issue #2139

* [UWP] Fixed double set margins in Layouts (#3570) fixes #3398 fixes #3616

* [Android] Support multiple clipping settings in single layout (#3559)

* Repro

* Fix for API 18+

*  [iOS] Unsubscribe CellPropertyChanged when SwitchCellRenderer is disposed (#3518)

* [Controls] Add repo of issue #3408

* [iOS] Unsubscribe CellPropertyChanged when cell is disposed

* [Controls] Add issue to project

* [iOS] Introduce CellPropertyChange to CellTableViewCell to used by all other cell renderers

* [Controls] Simplify Issue

* [iOS] Remove PropertyChanged that was not used

* [Controls] add check for null binding on template, add notes about issues

* [Controls] added reference to Android crash

* [iOS]Use existing PropertyChanged on ViewCelRenderer

* [iOS] Keep the existing override so we don't break users

* Update TextCellRenderer.cs

* update submodule

* 24H Mode (#3701)

The 24h mode for the pickerdialog was not working.

Version 3.1 was working fine. 

Here is an updated file.

* [UWP] uncomment tests that are now passing for 3188 (#3723)

* [UITest] Update Xamarin.UITest nuget package (#3632)

* [UITests] Update Xamarin.UITest 2.2.5

* [UITests] Try fix Toolbaritems

* [UITest] Update to 2.2.5-1606

* [UITests] Small Fixes and workarounds to make uitest happy

* [UITests ] Add delay to 1733 for API28

* [Android] Revert bad merge (#3746)

fixes #3705

* [Android, iOS] Fixes layout compression causes (#3698) fixes #3624

* [Android, iOS] Fixes layout compression causes

* [iOS] improve UpdateNewElement method

* Fix build error hopefully

* [UWP] Fixes CollectionChanged events in ListView (#3323)

* fixes #3273

* [UWP] Fixes CollectionChanged events in ListView

* a wrapped collection is used only if the SourceItem is not ObservableCollection

* improve uitest

* fixed NRE in empty ListView

* added a sortable custom renderer for UItest

* minor refactoring

* fixed reset of not wrapped collections

* addressing comments

* [UWP] remove WinRT hack

* [UWP] add missing using and cleanup additional resources

* [Android] Update Forms to remove API28 deprecated API (#3653) fixes #2128 fixes #3629

* [Build] Update provisioning

* [Controls] Ignore deprecated  Android API usage

* [Android] Remove use of obsolete color usage

* [Android] Remove app fragment usage

* [android] Rollback changes to EntryCellRenderer

* [Android] Better way to get the default color for the label text

* [Android] Obsolete message for ContentPage.CreateFragment()

* [ControlGallery] - create bitmap from Drawable to use for pixel location

* [Android] Use textcolor resource

* Update submodule

* Fix tests (#3771)

* [ControlGallery] Wait for element and add timing to tests

* [iOS] Fix NRE on RenderPool

* Add TabStop/TabIndex (#2795)

* [Core, UWP, Android] support TabStop/TabIndex

* removing linq

* add iOS / MacOS implementation

* add WPF implementation
fixes UWP implementation

* - addressing comments
- improve test
- optimizations
- added previous tab direction in same tab group

* addressing comments

* [Android] support tabstop for pickers

* - moving shared code to a static class
- removed reflection

* ITabStop -> changed to internal, renamed, added in to fastRenderers

* Update ITabStop to be public

* Fix : Binding Icon in ToolbarItem in TabbedPage doesn't refresh (#3761) fixes #3756

* [iOS] Fix NRE on ContextCell (#3714) fixes #3275

* [Controls] Add repo for issue #3275

* [iOS] Fix NRE when no gestures exist on table

* [iOS] Null check outside loop

* [iOS]Make sure to dispose/unhook when we are removed from UITableView.

* Update submodule

* [iOS] Don't double dispose ContextActionCell

* WPF - Fix Width and Height measurement when GetDesiredSize (#3750)

* WPF - Reset Width and Height when GetDesiredSize

* Some formatting changes

* Add APP directive

* [WPF]Fix build

* [Android Maps] Make markers available to subclasses (#3751)

* Make markers available to subclasses

* Fix build

* Use Find instead of FirstOrDefault

* [UITests] wait for element before querying for it (#3791)

* [UITests] wait for element before querying for it

* [Controls] generalize and better represent intended behavior

* WPF - Fix Local store not persistant when restarting App (#3752)

-fixes #3541
* WPF - Fix Local store not persistant when restarting App
* Add UITest
* [Controls] Add automated UI Test

* [UITests] Isolate test 3408

* [UITest] Update Xamarin UITest packages

* [UWP] implement Replace without reloading ListView (#3792)

-fixes #3788
* [UWP] implement Replace without reloading ListView
* [UWP] extract bindingcontext of new item for replace

* [iOS] Use UIApperance default color for UISwitch (#3819)

* [Controls] Set default color of UISwitch to Red

* [iOS] Use default color from Apperance API

* [UITests] replace awaits with more reliable WaitForElement (#3835)

* [Core] Propagate BindingContext changes to TitleView (#3823)

* [Core] Propagate BindingContext changes to TitleView

* [Tests] Move UI test to Core Unit Test

* [A] do not draw gradient for empty CornerRadius (#3786)

Drawing CornerRadius (introduce by #1998) when the CornerRadii are
actually 0 causes scaling artifacts on API < 25.

This fixes the regression when no CornerRadius is set. Expect blurry
border scaling with CornerRadius not empty and API < 25

- fixes #3781

* [Android] Fix WebView.Navigating event, make WebViewClient inheritable (#3780)

* Extracted WebViewRenderer.WebClient to FormsWebViewClient, moved SendNavigating call from ShouldOverrideUrlLoading to OnPageStarted

* Changed _webViewClient and GetWebViewClient() method to return base class

* Changed public things to protected internal

* Fix spaces to tabs indentation to match the coding style (#3745)

* [Build] Fix merge

* Fix #3097 swipe gesture not being handled in VisualElementTracker. (#3098) Fixes #3097

* Ensure that the ListViewAdapter is no longer being used by the ListVi… (#3848) fixes #3603

* Ensure that the ListViewAdapter is no longer being used by the ListView before disposing it

* Remove `RemoveAllViews` from `Dispose`

* Fixed code review comments

* Removed obsolete convert method

* Making sure default platform functionality is intact iOS and Android

As er code review comments

* Making sure default platform functionality is intact MacOS

* Making sure default platform functionality is intact UWP and WPF

* Code review comments for iOS, Android and MacOS

Default platform value is now preserved and applied when setting is set to default

* Code review comments UWP and WPF

* Fix build

* [UITest] - add ui test to test scroll permutations

* [Uwp] fix bad merge

* [wpf] fix spacing

* Adding instructions and UI tests for Bugzilla44461 (#4144)

* Adding instructions and UI tests for Bugzilla44461

* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla44461.cs

Co-Authored-By: mikescandy <michele.scandura@outlook.com>

* Fix assert

* [C] avoid AmbiguousMatchexception in Bindings (#4216) fixes #4215

if a type defines multiple op_implicit from the same type to different
ones, trying to retrieve it with GetMethod() throws an
AmbiguousMatchException. If this happens, we have to do the resolution
ourself.

- fixes #4215

* https://github.com/xamarin/Xam…
andreinitescu pushed a commit to andreinitescu/Xamarin.Forms that referenced this issue Jan 29, 2019
xamarin#4431)

* Update from origin (#8)

* [C] VisibilityConverter Trims input (#3581)

For CSS purposes, the VisibilityConverter was added, and actually
replaced the `Boolean.Parse(str)` call for parsing Visibility.
`Boolean.Parse()` trims input, and the converter was not, so this was a
regression.
This changes Trim() the input, to be fully backward compatible.

- fixes #3554

* Ensure ConstructorCountId and TimeId elements are available before querying them (#3588)

* For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589)

This would allow previewer/designer/reloader to determine the source of a
stylesheet and refresh its content when appropriate.

* Revert "For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589)"

This reverts commit f66a72de5b475a6a8387a80e418997b38dc40d4c.

* Fix NRE; Ret 0 if Text null (#3594) fixes #3579

* [UWP, WPF] Fixes rendering of the main page (#2896) fixes #2704

* [Core] Ignore Shamehat target when running DesignTimeBuild (#3605)

* [XamlC] Fix binding compilation fo value types (#3551)

properly load valuetype arguments of generated setters, using ldarg,
instead of ldarga.

- fixes #3539

* Update PULL_REQUEST_TEMPLATE.md

* Update PULL_REQUEST_TEMPLATE.md

* [Android] Fix Label LineHeight (#3452)

* fix line height android

* Make UAP respect initial LineHeight

* update .create-nuget.bat (#3638)

* Add Null Check to GetRenderer (#3575)

- fix #3563

* Fix 3562 Null Reference Exception (#3576)

- fixes #3562

* Fix 3564 Null Reference Exception (#3578)

- fixes #3564

* [iOS] AutomationProperty support for cells (#3313) fixes #3296

* [iOS] AutomationProperty support for cells

* Add test case to AutomationProperties gallery

* [UWP] Fix crash app when create navigation/tabbed page without children pages fixes #3188 (#3514)

* [Android] Use height when determining ScaledScreenSize; fixes #3609 (#3641)

* [C] Set binding context on Span Gestures (#3639)

* [Core] Set binding context on Span Gestures
* [Core] Simplify loop setting child binding context

- fixes #3524

* Update PULL_REQUEST_TEMPLATE.md

* [Android] remove deprecated AndroidUseLatestPlatformSdk (#3672)

* [iOS] iPad ActionSheet should always have a Cancel method (#3636)

* Add repro for #3049

* [iOS] iPad ActionSheet should always have a Cancel method

fixes #3049

* [Android] fixes #3675 - set  initial ScrollView Scroll values when RTL (#3676)

* [Android] API check for Shadow properties on Button (#3617) fixes #2702

* [Android] API check for Shadow properties on Button

* Fix swapped shadow values

* [iOS] fixes #3525 - add epsilon for float compare (#3654)

* [iOS] fixes #3525 - add epsilon for float compare and make region immutable

* [ControlGallery] spread out spans to account for click slop

* [ControlGallery] - adjust span slightly for android test

* [Core] remove private

* Fix text wrapping (#3671) fixes #3634

* [GTK] Fix navigation bar visibility updates (#3651)

* Fix partially  #3585 (#3592)

* Make webkit-sharp.dll.config cross-platform

* Update webkit-sharp.dll with missing signals bindings

see: https://github.com/ylatuya/webkit-sharp/tree/fluendo

* [iOS, UWP] fixes #2894 - Gestures collection changes weren't correctly propagating (#3643)

* [iOS, UWP] fixes #2894 - Gestures weren't wiring up to spans in all cases

* [Core] remove ChildGestureRecognizers when spans get removed

* [iOS] removed incorrect return from null

* Fixes #3663 (#3684)

* Fix ScrollView Padding issue (#3685)

* [WPF] Memory leak when you pop a TabbedPage (#3372) fixes #3267

* Fix [WPF] Memory leak when you pop a TabbedPage

* Update ViewRenderer.cs

* Update ViewRenderer.cs

* [Android,iOS,UWP] Allow Entry CursorPosition/SelectionLength to be set in ctor (#3402) fixes #3343 fixes #3633

* Add repro for #3343 + unit tests

* [Core] Disallow negative values for CursorPosition/SelectionLength

* [All] CursorPosition/SelectionLength can bindin ctor & clear value

fixes #3343

* typo

* cleanup

* [iOS] Cursor snaps to end

* try/catch

* [CSS] add more properties (#3466)

map new CSS properties:
- `color` on `IColorElement` (`ActivityIndicator`, `BoxView`),
  `ProgressBar` and `Switch`
- `row-gap` and `column-gap` on `Grid`
- `transform` and `transform-origin` on `VisualElement`
- `vertical-align` on `Label`

add new XF-specific CSS properties
- `-xf-placeholder` and `-xf-placeholder-color` on `Editor`, `Entry`,
  `SearchBar`
- `-xf-max-length` on `InputView` (`Editor` and `Entry`)
- `-xf-bar-background-color` and `-xf-bar-text-color` on
  `NavigationPage` and `TabbedPage`
- `-xf-orientation` on `ScrollView` and `StackLayout`
- `-xf-horizontal-scroll-bar-visibility` and
  `-xf-vertical-scroll-bar-visibility` on `ScrollView`
- `-xf-min-track-color`, `-xf-max-track-color` and `("-xf-thumb-color`
  on `Slider`
- `-xf-spacing` on `StackLayout`

This PR replaces and closes #3276

- fixes #2891

* [iOS] Specify a default size for UISearchBar width if needed (#3635) fixes #3413 fixes #2139

* [Controls] Add reproduction and test case for issue #3413

* [iOS] Don't use max value for iOS UISearchbar breaks on iOS 11.3

* [iOS] Force width value so we can renderer UISearchBar on iOS10 with infinite width

* [Controls] Fix spelling and add Manual Review to the test of #3413

* [iOS] Simplify code for UISearchBar width

* [iOS] Return always some width from measure the UISearchBar on IOS

* [Controls] Add reproduction case for issue #2139

* [UWP] Fixed double set margins in Layouts (#3570) fixes #3398 fixes #3616

* [Android] Support multiple clipping settings in single layout (#3559)

* Repro

* Fix for API 18+

*  [iOS] Unsubscribe CellPropertyChanged when SwitchCellRenderer is disposed (#3518)

* [Controls] Add repo of issue #3408

* [iOS] Unsubscribe CellPropertyChanged when cell is disposed

* [Controls] Add issue to project

* [iOS] Introduce CellPropertyChange to CellTableViewCell to used by all other cell renderers

* [Controls] Simplify Issue

* [iOS] Remove PropertyChanged that was not used

* [Controls] add check for null binding on template, add notes about issues

* [Controls] added reference to Android crash

* [iOS]Use existing PropertyChanged on ViewCelRenderer

* [iOS] Keep the existing override so we don't break users

* Update TextCellRenderer.cs

* update submodule

* 24H Mode (#3701)

The 24h mode for the pickerdialog was not working.

Version 3.1 was working fine. 

Here is an updated file.

* [UWP] uncomment tests that are now passing for 3188 (#3723)

* [UITest] Update Xamarin.UITest nuget package (#3632)

* [UITests] Update Xamarin.UITest 2.2.5

* [UITests] Try fix Toolbaritems

* [UITest] Update to 2.2.5-1606

* [UITests] Small Fixes and workarounds to make uitest happy

* [UITests ] Add delay to 1733 for API28

* [Android] Revert bad merge (#3746)

fixes #3705

* [Android, iOS] Fixes layout compression causes (#3698) fixes #3624

* [Android, iOS] Fixes layout compression causes

* [iOS] improve UpdateNewElement method

* Fix build error hopefully

* [UWP] Fixes CollectionChanged events in ListView (#3323)

* fixes #3273

* [UWP] Fixes CollectionChanged events in ListView

* a wrapped collection is used only if the SourceItem is not ObservableCollection

* improve uitest

* fixed NRE in empty ListView

* added a sortable custom renderer for UItest

* minor refactoring

* fixed reset of not wrapped collections

* addressing comments

* [UWP] remove WinRT hack

* [UWP] add missing using and cleanup additional resources

* [Android] Update Forms to remove API28 deprecated API (#3653) fixes #2128 fixes #3629

* [Build] Update provisioning

* [Controls] Ignore deprecated  Android API usage

* [Android] Remove use of obsolete color usage

* [Android] Remove app fragment usage

* [android] Rollback changes to EntryCellRenderer

* [Android] Better way to get the default color for the label text

* [Android] Obsolete message for ContentPage.CreateFragment()

* [ControlGallery] - create bitmap from Drawable to use for pixel location

* [Android] Use textcolor resource

* Update submodule

* Fix tests (#3771)

* [ControlGallery] Wait for element and add timing to tests

* [iOS] Fix NRE on RenderPool

* Add TabStop/TabIndex (#2795)

* [Core, UWP, Android] support TabStop/TabIndex

* removing linq

* add iOS / MacOS implementation

* add WPF implementation
fixes UWP implementation

* - addressing comments
- improve test
- optimizations
- added previous tab direction in same tab group

* addressing comments

* [Android] support tabstop for pickers

* - moving shared code to a static class
- removed reflection

* ITabStop -> changed to internal, renamed, added in to fastRenderers

* Update ITabStop to be public

* Fix : Binding Icon in ToolbarItem in TabbedPage doesn't refresh (#3761) fixes #3756

* [iOS] Fix NRE on ContextCell (#3714) fixes #3275

* [Controls] Add repo for issue #3275

* [iOS] Fix NRE when no gestures exist on table

* [iOS] Null check outside loop

* [iOS]Make sure to dispose/unhook when we are removed from UITableView.

* Update submodule

* [iOS] Don't double dispose ContextActionCell

* WPF - Fix Width and Height measurement when GetDesiredSize (#3750)

* WPF - Reset Width and Height when GetDesiredSize

* Some formatting changes

* Add APP directive

* [WPF]Fix build

* [Android Maps] Make markers available to subclasses (#3751)

* Make markers available to subclasses

* Fix build

* Use Find instead of FirstOrDefault

* [UITests] wait for element before querying for it (#3791)

* [UITests] wait for element before querying for it

* [Controls] generalize and better represent intended behavior

* WPF - Fix Local store not persistant when restarting App (#3752)

-fixes #3541
* WPF - Fix Local store not persistant when restarting App
* Add UITest
* [Controls] Add automated UI Test

* [UITests] Isolate test 3408

* [UITest] Update Xamarin UITest packages

* [UWP] implement Replace without reloading ListView (#3792)

-fixes #3788
* [UWP] implement Replace without reloading ListView
* [UWP] extract bindingcontext of new item for replace

* [iOS] Use UIApperance default color for UISwitch (#3819)

* [Controls] Set default color of UISwitch to Red

* [iOS] Use default color from Apperance API

* [UITests] replace awaits with more reliable WaitForElement (#3835)

* [Core] Propagate BindingContext changes to TitleView (#3823)

* [Core] Propagate BindingContext changes to TitleView

* [Tests] Move UI test to Core Unit Test

* [A] do not draw gradient for empty CornerRadius (#3786)

Drawing CornerRadius (introduce by #1998) when the CornerRadii are
actually 0 causes scaling artifacts on API < 25.

This fixes the regression when no CornerRadius is set. Expect blurry
border scaling with CornerRadius not empty and API < 25

- fixes #3781

* [Android] Fix WebView.Navigating event, make WebViewClient inheritable (#3780)

* Extracted WebViewRenderer.WebClient to FormsWebViewClient, moved SendNavigating call from ShouldOverrideUrlLoading to OnPageStarted

* Changed _webViewClient and GetWebViewClient() method to return base class

* Changed public things to protected internal

* Fix spaces to tabs indentation to match the coding style (#3745)

* [Build] Fix merge

* Fix #3097 swipe gesture not being handled in VisualElementTracker. (#3098) Fixes #3097

* Update from origin (#9)

* [C] VisibilityConverter Trims input (#3581)

For CSS purposes, the VisibilityConverter was added, and actually
replaced the `Boolean.Parse(str)` call for parsing Visibility.
`Boolean.Parse()` trims input, and the converter was not, so this was a
regression.
This changes Trim() the input, to be fully backward compatible.

- fixes #3554

* Ensure ConstructorCountId and TimeId elements are available before querying them (#3588)

* For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589)

This would allow previewer/designer/reloader to determine the source of a
stylesheet and refresh its content when appropriate.

* Revert "For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589)"

This reverts commit f66a72de5b475a6a8387a80e418997b38dc40d4c.

* Fix NRE; Ret 0 if Text null (#3594) fixes #3579

* [UWP, WPF] Fixes rendering of the main page (#2896) fixes #2704

* [Core] Ignore Shamehat target when running DesignTimeBuild (#3605)

* [XamlC] Fix binding compilation fo value types (#3551)

properly load valuetype arguments of generated setters, using ldarg,
instead of ldarga.

- fixes #3539

* Update PULL_REQUEST_TEMPLATE.md

* Update PULL_REQUEST_TEMPLATE.md

* [Android] Fix Label LineHeight (#3452)

* fix line height android

* Make UAP respect initial LineHeight

* update .create-nuget.bat (#3638)

* Add Null Check to GetRenderer (#3575)

- fix #3563

* Fix 3562 Null Reference Exception (#3576)

- fixes #3562

* Fix 3564 Null Reference Exception (#3578)

- fixes #3564

* [iOS] AutomationProperty support for cells (#3313) fixes #3296

* [iOS] AutomationProperty support for cells

* Add test case to AutomationProperties gallery

* [UWP] Fix crash app when create navigation/tabbed page without children pages fixes #3188 (#3514)

* [Android] Use height when determining ScaledScreenSize; fixes #3609 (#3641)

* [C] Set binding context on Span Gestures (#3639)

* [Core] Set binding context on Span Gestures
* [Core] Simplify loop setting child binding context

- fixes #3524

* Update PULL_REQUEST_TEMPLATE.md

* [Android] remove deprecated AndroidUseLatestPlatformSdk (#3672)

* [iOS] iPad ActionSheet should always have a Cancel method (#3636)

* Add repro for #3049

* [iOS] iPad ActionSheet should always have a Cancel method

fixes #3049

* [Android] fixes #3675 - set  initial ScrollView Scroll values when RTL (#3676)

* [Android] API check for Shadow properties on Button (#3617) fixes #2702

* [Android] API check for Shadow properties on Button

* Fix swapped shadow values

* [iOS] fixes #3525 - add epsilon for float compare (#3654)

* [iOS] fixes #3525 - add epsilon for float compare and make region immutable

* [ControlGallery] spread out spans to account for click slop

* [ControlGallery] - adjust span slightly for android test

* [Core] remove private

* Fix text wrapping (#3671) fixes #3634

* [GTK] Fix navigation bar visibility updates (#3651)

* Fix partially  #3585 (#3592)

* Make webkit-sharp.dll.config cross-platform

* Update webkit-sharp.dll with missing signals bindings

see: https://github.com/ylatuya/webkit-sharp/tree/fluendo

* [iOS, UWP] fixes #2894 - Gestures collection changes weren't correctly propagating (#3643)

* [iOS, UWP] fixes #2894 - Gestures weren't wiring up to spans in all cases

* [Core] remove ChildGestureRecognizers when spans get removed

* [iOS] removed incorrect return from null

* Fixes #3663 (#3684)

* Fix ScrollView Padding issue (#3685)

* [WPF] Memory leak when you pop a TabbedPage (#3372) fixes #3267

* Fix [WPF] Memory leak when you pop a TabbedPage

* Update ViewRenderer.cs

* Update ViewRenderer.cs

* [Android,iOS,UWP] Allow Entry CursorPosition/SelectionLength to be set in ctor (#3402) fixes #3343 fixes #3633

* Add repro for #3343 + unit tests

* [Core] Disallow negative values for CursorPosition/SelectionLength

* [All] CursorPosition/SelectionLength can bindin ctor & clear value

fixes #3343

* typo

* cleanup

* [iOS] Cursor snaps to end

* try/catch

* [CSS] add more properties (#3466)

map new CSS properties:
- `color` on `IColorElement` (`ActivityIndicator`, `BoxView`),
  `ProgressBar` and `Switch`
- `row-gap` and `column-gap` on `Grid`
- `transform` and `transform-origin` on `VisualElement`
- `vertical-align` on `Label`

add new XF-specific CSS properties
- `-xf-placeholder` and `-xf-placeholder-color` on `Editor`, `Entry`,
  `SearchBar`
- `-xf-max-length` on `InputView` (`Editor` and `Entry`)
- `-xf-bar-background-color` and `-xf-bar-text-color` on
  `NavigationPage` and `TabbedPage`
- `-xf-orientation` on `ScrollView` and `StackLayout`
- `-xf-horizontal-scroll-bar-visibility` and
  `-xf-vertical-scroll-bar-visibility` on `ScrollView`
- `-xf-min-track-color`, `-xf-max-track-color` and `("-xf-thumb-color`
  on `Slider`
- `-xf-spacing` on `StackLayout`

This PR replaces and closes #3276

- fixes #2891

* [iOS] Specify a default size for UISearchBar width if needed (#3635) fixes #3413 fixes #2139

* [Controls] Add reproduction and test case for issue #3413

* [iOS] Don't use max value for iOS UISearchbar breaks on iOS 11.3

* [iOS] Force width value so we can renderer UISearchBar on iOS10 with infinite width

* [Controls] Fix spelling and add Manual Review to the test of #3413

* [iOS] Simplify code for UISearchBar width

* [iOS] Return always some width from measure the UISearchBar on IOS

* [Controls] Add reproduction case for issue #2139

* [UWP] Fixed double set margins in Layouts (#3570) fixes #3398 fixes #3616

* [Android] Support multiple clipping settings in single layout (#3559)

* Repro

* Fix for API 18+

*  [iOS] Unsubscribe CellPropertyChanged when SwitchCellRenderer is disposed (#3518)

* [Controls] Add repo of issue #3408

* [iOS] Unsubscribe CellPropertyChanged when cell is disposed

* [Controls] Add issue to project

* [iOS] Introduce CellPropertyChange to CellTableViewCell to used by all other cell renderers

* [Controls] Simplify Issue

* [iOS] Remove PropertyChanged that was not used

* [Controls] add check for null binding on template, add notes about issues

* [Controls] added reference to Android crash

* [iOS]Use existing PropertyChanged on ViewCelRenderer

* [iOS] Keep the existing override so we don't break users

* Update TextCellRenderer.cs

* update submodule

* 24H Mode (#3701)

The 24h mode for the pickerdialog was not working.

Version 3.1 was working fine. 

Here is an updated file.

* [UWP] uncomment tests that are now passing for 3188 (#3723)

* [UITest] Update Xamarin.UITest nuget package (#3632)

* [UITests] Update Xamarin.UITest 2.2.5

* [UITests] Try fix Toolbaritems

* [UITest] Update to 2.2.5-1606

* [UITests] Small Fixes and workarounds to make uitest happy

* [UITests ] Add delay to 1733 for API28

* [Android] Revert bad merge (#3746)

fixes #3705

* [Android, iOS] Fixes layout compression causes (#3698) fixes #3624

* [Android, iOS] Fixes layout compression causes

* [iOS] improve UpdateNewElement method

* Fix build error hopefully

* [UWP] Fixes CollectionChanged events in ListView (#3323)

* fixes #3273

* [UWP] Fixes CollectionChanged events in ListView

* a wrapped collection is used only if the SourceItem is not ObservableCollection

* improve uitest

* fixed NRE in empty ListView

* added a sortable custom renderer for UItest

* minor refactoring

* fixed reset of not wrapped collections

* addressing comments

* [UWP] remove WinRT hack

* [UWP] add missing using and cleanup additional resources

* [Android] Update Forms to remove API28 deprecated API (#3653) fixes #2128 fixes #3629

* [Build] Update provisioning

* [Controls] Ignore deprecated  Android API usage

* [Android] Remove use of obsolete color usage

* [Android] Remove app fragment usage

* [android] Rollback changes to EntryCellRenderer

* [Android] Better way to get the default color for the label text

* [Android] Obsolete message for ContentPage.CreateFragment()

* [ControlGallery] - create bitmap from Drawable to use for pixel location

* [Android] Use textcolor resource

* Update submodule

* Fix tests (#3771)

* [ControlGallery] Wait for element and add timing to tests

* [iOS] Fix NRE on RenderPool

* Add TabStop/TabIndex (#2795)

* [Core, UWP, Android] support TabStop/TabIndex

* removing linq

* add iOS / MacOS implementation

* add WPF implementation
fixes UWP implementation

* - addressing comments
- improve test
- optimizations
- added previous tab direction in same tab group

* addressing comments

* [Android] support tabstop for pickers

* - moving shared code to a static class
- removed reflection

* ITabStop -> changed to internal, renamed, added in to fastRenderers

* Update ITabStop to be public

* Fix : Binding Icon in ToolbarItem in TabbedPage doesn't refresh (#3761) fixes #3756

* [iOS] Fix NRE on ContextCell (#3714) fixes #3275

* [Controls] Add repo for issue #3275

* [iOS] Fix NRE when no gestures exist on table

* [iOS] Null check outside loop

* [iOS]Make sure to dispose/unhook when we are removed from UITableView.

* Update submodule

* [iOS] Don't double dispose ContextActionCell

* WPF - Fix Width and Height measurement when GetDesiredSize (#3750)

* WPF - Reset Width and Height when GetDesiredSize

* Some formatting changes

* Add APP directive

* [WPF]Fix build

* [Android Maps] Make markers available to subclasses (#3751)

* Make markers available to subclasses

* Fix build

* Use Find instead of FirstOrDefault

* [UITests] wait for element before querying for it (#3791)

* [UITests] wait for element before querying for it

* [Controls] generalize and better represent intended behavior

* WPF - Fix Local store not persistant when restarting App (#3752)

-fixes #3541
* WPF - Fix Local store not persistant when restarting App
* Add UITest
* [Controls] Add automated UI Test

* [UITests] Isolate test 3408

* [UITest] Update Xamarin UITest packages

* [UWP] implement Replace without reloading ListView (#3792)

-fixes #3788
* [UWP] implement Replace without reloading ListView
* [UWP] extract bindingcontext of new item for replace

* [iOS] Use UIApperance default color for UISwitch (#3819)

* [Controls] Set default color of UISwitch to Red

* [iOS] Use default color from Apperance API

* [UITests] replace awaits with more reliable WaitForElement (#3835)

* [Core] Propagate BindingContext changes to TitleView (#3823)

* [Core] Propagate BindingContext changes to TitleView

* [Tests] Move UI test to Core Unit Test

* [A] do not draw gradient for empty CornerRadius (#3786)

Drawing CornerRadius (introduce by #1998) when the CornerRadii are
actually 0 causes scaling artifacts on API < 25.

This fixes the regression when no CornerRadius is set. Expect blurry
border scaling with CornerRadius not empty and API < 25

- fixes #3781

* [Android] Fix WebView.Navigating event, make WebViewClient inheritable (#3780)

* Extracted WebViewRenderer.WebClient to FormsWebViewClient, moved SendNavigating call from ShouldOverrideUrlLoading to OnPageStarted

* Changed _webViewClient and GetWebViewClient() method to return base class

* Changed public things to protected internal

* Fix spaces to tabs indentation to match the coding style (#3745)

* [Build] Fix merge

* Fix #3097 swipe gesture not being handled in VisualElementTracker. (#3098) Fixes #3097

* Ensure that the ListViewAdapter is no longer being used by the ListVi… (#3848) fixes #3603

* Ensure that the ListViewAdapter is no longer being used by the ListView before disposing it

* Remove `RemoveAllViews` from `Dispose`

* Update from origin (#11)

* [Android] Enable MaxLines and TextDecorations on fast renderers (#3878)

* enable MaxLines on fast renderers

* added text decoration functionality

* include test in project

* [Enhancement] Create a bindable property for AutomationId (#3879)

* create a bindable property for automationId

* make ClassId and AutomationId properties of Element

* add comments to .create-nuget.bat

* added preserve attribute (#3876) fixes #2306

* [Core] Moving Command's CanExecuteChanged to use the WeakEventManager (#3852) fixes #3656

* [Core]  Use WeakEventManager on CanExecuteChanged

* [Core]Add unit test for remove event handler with WeakEventManager

* [Core] Fix remove the correct handler

* [CSS] accept 'oblique' for 'font-style' (#3815) fixes #3808

- fixes #3808

* Prevent double time/date picker dialogs on Android when setting focus (#3899)

* Prevent double time/date picker dialogs on Android when setting focus (#3899)

* [Controls] Fix merge remove duplciated issue 3788

* WPF - Fix Unable to intercept back button (#3762)

* WPF - Fix Unable to intercept back button

* WPF - Improve OnBackButtonPressed

-fixes #3689

* Fix Bugzilla38723 (#3812)

fixes #2302

* [C] fix css mapping (#3919)

* [Android] Fix UI test 1851 (#3882)

* add preserve attribute

- fixes #2255


* added using System

* fixed spacing

* use TestContentPage

* fixed scope issues

* [Android] Make native Android Platforms accessible via Context (#3364)

* Make native Android Platforms accessible via Context

* Add null checks

* Added a disabled look to Android Toolbar Item images. (#3773)

* Added a disabled look to Android Toolbar Item images.

* Update NavigationPageRenderer.cs

Refactored DisabledToolbarAlpha into a constant as requested.

* [UWP] fixes tabstops of TimePicker, DatePiker. SearchBar, Stepper (#3896)

* [UWP] fixes tabstops of TimePicker, DatePiker. SearchBar, Stepper

* common code moved to VisualElementRenderer

* rename interface

fixes #3872

* [UWP] For the Slider default value of step is set to 1000 to match Android. (#3141)

* WPF - Ctrl+A does not select all in WPF password Entry (#3908)

* [WPF] Fix Height of items not consistent (#3925) fixes #3913

* Fix StartTimer and Ticker for UWP (#3911)

- fixes #1937

* Apply font fix for button and span (#3907)

* added instructions (#3891)

- fixes #2361

* [Android] Convert corner radius with correct pixel density (#3893) fixes #3884

* [Controls] Add Issue #3884 repo

* [Android] Convert  corner radius with correct pixel density fixes #3884

* [Controls] Update test message

* WPF - Fix TimePicker with short time pattern shows verbose time (#3924)

* Fix UI test 39378 (#3928)

fixes #2305

* Update ClipBounds when View bounds changes (#3909)

fixes #3717

* [C] catch AmbiguousMatchException on GetProps (#3915)

- fixes #3870

* Automate UI test B45702 (#3914) fixes #2389

* automate 45702

* fix indentation

* Fix bugzilla60787 (#3933)

* [Android]Fix for frame renderer's bug (bugzilla 60787).

#3902
https://bugzilla.xamarin.com/show_bug.cgi?id=60787
https://github.com/xamarin/Xamarin.Forms/issues/3902

* Add control to repro

* PR fix

* Build fix

* Build fix for Xamarin.Forms.Core.Android.UITests

* added instructions (#3926)

* [UWP] fixes flyout menu on cell item (#3682)

* Fix UI test B41424 needs instructions (#3942)

* Add manual test steps and checks for ui test

* step4Label text fix

* [iOS] fix full width issues for TitleView (#3939)

* [iOS] fix full width issues for TitleView

* [iOS] simplified iOS 10

fixes #3881
fixes #3679

* Changes in TableView GTK Control to allow refresh the content (#3941)

- fixes #3725

* Only set the Page Padding via SafeAreaInset on iOS (#3811)

* only set the Page Padding via SafeAreaInset on iOS
-fixes #3809

* [Controls] add waits for clicks in ui tests

* [Controls] remove wrong category

* [iOS] Move inset logic down into ios renderer

* Added logic to allow set the ListView SelectedIndex (#3948) fixes #3766

* Automate UI test 35127 (#3927)

* automate test
- fixes #2262
* indentation fix
* indentation fix 2

* Make GetIconDrawable virtual (#3967)

By making GetIconDrawable virtual for the Android TabbedPageRenderer it allows for the icon to come from other sources (like glyph fonts). This will work for both top and bottom tabs.

* [GTK] Fix visibility of hidden pages in the stack (#3904)

When navigating to a new page, we should hide the previous
content and show the new one so that the previous page
renderer is not taken in account for redraws and resizes

* [Android] If MaxLines is not explicitly set, let LineBreakMode handle it (#3936)

* [Android] If MaxLines is not explicitly set, all LineBreakMode to set it;
if MaxLines is explicitly set, MaxLines setting wins. Use a more reasonable
default for native MaxLines when handling it via LineBreakMode. Consolidate
MaxLines handling code between legacy and fast renderers. Remove unnecessary
setting of SingleLine (which only applies to input).
- fixes #3772

* Remove unnecessary maxLines setting

* Handle resetting MaxLines to -1/default

* Reinstate workaround for array bounds exception in older Android APIs

* Fix UI test B43941 (#3889)

* Add all platforms and remove non-deterministic behaviour

* Return back correct check of counter

* Endline fix

* remove childPages list

* [XamlC] avoid multiple subscription (#3969)

Avoid multiple subscription to PropertyChanged on TypedBindings

- fixes #3613
- fixes #3650

* Fix typos (mainly 'toogle' becoming 'toggle') (#3975)

* Fix Issue2597 Needs UI Test (#3966)

* Add test for issue 2597

* Fix space

* Add CODEOWNERS

* Fix PanGesture inside scroll issue https://github.com/xamarin/Xamarin… (#3842)

* Fix PanGesture inside scroll issue https://github.com/xamarin/Xamarin.Forms/issues/3840
- fixes #3840
* fixe formatting

* [UITest] added UI Test

* [Controls] adjusted UI Test button positions

* [UITEST]  simplify UI tests

* [C] add CSS mapping for max-lines (#3991)

- fixes #3982

* [iOS] Add ability to turn off updates to native controls from another thread (#3774)

* [iOS] Add ability to turn off updates to native controls from another thread

* Flip evaluation order

fixes #1755

* Fixed NotImplementedException refreshing items in WPF ListView (#3962)

* Fixed NotImplementedException refreshing items in WPF ListView

* Small changes in ListView events subscription

fixes #3309
fixes #3737
fixes #3648

* [GTK] Fix transparent background in visual elements (#3744)

* Fix ActivityIndicator.IsRunning state (#4007)

* add pdb for uap into nuget (#4015)

* update GitInfo

* [XamlC] don't compile bindings with Source (#3978)

Sources are usually x:reference that can't be resolved at compilation
time.

- fixes #3606

* [Xaml[C]] resolve Extensions first (#3977)

XamlLoader should first look for type with the Extension suffix. It used
to be the case, but somehow regressed.

- fixes https://github.com/xamarin/Xamarin.Forms/issues/3606#issuecomment-422377338

* [UWP] Document in the README.md the steps required to run UI Tests (#4014) fixes #3984

* [Tizen] Add TabIndex implement for Tizen renderer (#4046)

* [Tasks] multitarget the build tasks (#3895)

- fixes #2690
- closes #2706

* [UITests] Update TestCloud.Agent (#4055)

* [Tizen] Fix ProjectGuid for Forwarders (#4063)

* [Tizen] Fix ProjectGuid for Forwarders

* [Tizen] Make sure not to generate dependency file

* Correct minor typo (#4068)

* Added WebView Reload (#4013) fixes #3776

* Added WebView Reload

* WebView Reload Added Tizen suport

* [Tizen] Cleanup Code (#4080)

* fixed ios editor placeholder font (#4009)

* Prevented crash https://github.com/xamarin/Xamarin.Forms/issues/2291 (#4072)

- fixes #2291

* [Xaml] Allow OnPlat markup in Styles (#3995)

- fixes #3862

* [Xaml] fix Namescope being different than tree (#4089)

As part of #2556, the namescoping tree was assumed to be equiv to the
object tree, which is obviously wrong. This fixes it, while keeping the
old behavior as a fallback.

We might go further, but I can't come up with a reasonable scenario
failing.

- fixes #3821

* [Sample] [Android] Fixed PagesGallery.Droid build (#3999)

* fixed PagesGallery.Droid build

* Moved Xamarin.Forms.Platform.Android (Forwarders) reference to previous place

* updated project guid to lower case

* Fix typeface reset issue (#4019)

* Use ViewCompat to set and get label for view (#3996)

* Removing LineBreakMode support from WindowsResourcesProvider (#4024)

* Repro test page for 3979

* Removes LineBreakMode support from WindowsResourcesProvider as it is inconsistent with other platforms and caused issues when setting Span style to the default Device Styles

* [macOS] Fix NRE on Mojave when aligning the tile (#4086) fixes #3031

* [GTK] Add support for ClickGestureRecognizer (#3971)

* [GTK] Add support for ClickGestureRecognizer

* Add ClickGestureGalleryPage to test ClickGestureRecognizer

* [iOS] Label TextColor has no effect with FormattedString (#4043)

* https://github.com/xamarin/Xamarin.Forms/issues/4040 fix default font/color for formatted string

* https://github.com/xamarin/Xamarin.Forms/pull/4043 fixed naming, added test case

* Moved field and property to top

- fixes #4040

* fix build, tentatively (#4117)

* [Xaml] don't swallow exceptions from converters (#4100)

Compiled converters are invoked, by reflection, at compile time. Any
exception thrown there will be wrapped in a TargetInvocationException.
When that happens, we still want to expose the inner XamlParseException
to the user.

- fixes #4099

* housekeeping ended with https://github.com/xamarin/Xamarin.Forms/pull/3999 (#4105)

* Bump minimum Microsoft.NETCore.UniversalWindowsPlatform version to 6.0.12 (#4106)

* [Tizen] Fix Window alpha update timing (#4119)

* [UWP] fixed `MinimumDate` and `MaximumDate` properties of DatePicker (#3683) fixes #3331

* [WPF] Fixes `ControlTemplate` sizing issue (#2656)

- fixes #2642

* Remove BOM from nuspec (#4128)

* Navigation Page double Popped event Workaround (#3851) fixes #3509

* Navigation Page double Popped event Workaround

* [UITest] Add UI Test

* [Core] fix formatting

* revert formatting fix

* implemented workaround suggested by PureWeen

* removed whitespace

* moved ignorePopCall to a better location

* [Enhancements] Toolbar a11y  (#3974) fixes #1742 fixes #3795

* [Controls] Add automation id to icon

* [iOS] Add AutomationId support to MDP tooggle button

* [Android] Add support for AutomationId to ActionBarDrawerToggle and MasterDetailPage

* [IOS] Refactor and add Accessibility to ToolbarItems

* [iOS] Fix typos

* [Android] Add accessibility to ToolbarItems

* [UWP]  Refactor A11y to extensions

* [UWP]  Set Accessibility properties on ToolbarItems

* [UWP] Set accessibility to MDP button

* [ControlGallery] Add accessibility toolbaritems to gallery

* Comment test out

* [iOS] Fix NRE when Control is being disposed

* [UITests] Remove not used UITests file

* Implementation of method ForceUpdateSize for Cell on macOS (#4104)

* Implemented Cell ForceUpdateSize on macOS

* Tab Styling

* Prevent crash during setting NULL to element via interface method (#4179)

- fixes #4178
- fixes #4146

* https://github.com/xamarin/Xamarin.Forms/issues/4076 fix (#4161)

* [iOS] Rapidly clicking span (6 times at least) on UITest 3525 throws a null exception (#4109)

* https://github.com/xamarin/Xamarin.Forms/issues/3930 fix

* following convention

* [Android] Fixes AutomationProperties.Name on Button (#4094)

* [Android] Fixes AutomationProperties.Name on Button

* [Android] Fixes for Switch control

* UWP Toolbar dynamic overflow (#4022)

* Adding Windows specific ToolbarDynamicOverflowEnabled configuration

* Enabled ToolbarDynamicOverflowEnabled (pun intended) on page controls and renderers

* Issue 3988 sample

* Removed obsolete comment, cleaned up private and whitespace

* Added toolbar dynamic overflow examples for master detail page and tabbed page


- fixes #2057
- fixes #3988

* Add missing initial call to UpdateLineHeight; fixes #4136 (#4147)

* Added UI test to B45027 (#4079)

* Add UI test to B45027

* Changed execution of current UI test to Android platform

* Added iOS UI test to B45027

* Refactored UI test execution

* Fix https://github.com/xamarin/Xamarin.Forms/issues/3301 (#4164)

- fixes #3301

* [UWP] fixes entering text into SearchBar with UI Tests (#4173)

* [UWP] fixes entering text into SearchBar with UI Tests

* [UWP] ITabStopOnDescendants - fixed selection when setting focus from Selenium

* [UWP] Fix TitleView Width and MDP rendering quirks (#3987)

* [UWP] Fix TitleView Width and MDP rendering quirks

* [UWP] fix load timing for pushed pages and titleview

* [UWP] move renderer check

* [UWP] remove re-measure until 4116 fixed

- fixes #3828
- fixes #3834

* [macOS] NRE in WebViewRenderer (#4188) fixes #4001

* https://github.com/xamarin/Xamarin.Forms/issues/4001

* fixed build

* https://github.com/xamarin/Xamarin.Forms/issues/2831 fixes #2831 (#4111)

* [msbuild] use portable pdb files (#4201)

Currently, on the first build of a "Hello World" Xamarin.Forms app,
you will see this in the build log:

    ConvertDebuggingFiles
        Parameters
            Files
                C:\Users\myuser\.nuget\packages\xamarin.forms\3.1.0.697729\lib\MonoAndroid10\FormsViewGroup.pdb
                C:\Users\myuser\.nuget\packages\xamarin.forms\3.1.0.697729\lib\MonoAndroid10\Xamarin.Forms.Platform.Android.pdb
        OutputItems
            _ConvertedDebuggingFiles
                C:\Users\myuser\.nuget\packages\xamarin.forms\3.1.0.697729\lib\MonoAndroid10\FormsViewGroup.dll
                C:\Users\myuser\.nuget\packages\xamarin.forms\3.1.0.697729\lib\MonoAndroid10\Xamarin.Forms.Platform.Android.dll

The logging is a little weird here, but this `ConvertDebuggingFiles`
MSBuild task takes about 100ms on my machine.

What is it doing?

The Mono debugger can support two types of debugging files:
- `mdb` files
- "portable" `pdb` files

If Xamarin.Android's build finds a "non-portable" `pdb` file, we have
to run it through this task to convert to an `mdb` file... This gives
us proper stacktraces for `FormsViewGroup.dll` and
`Xamarin.Forms.Platform.Android.dll`.

You can change the type of debugging symbols in your project with the
`DebugType` setting, which has these options:
- Blank or `None`: don't generate symbols. (Although Xamarin.Android
  has funny behavior here, see:
  https://github.com/xamarin/xamarin-android/issues/2282)
- `Full` generates an `mdb` file, this is a Windows-proprietary format
  for debug builds
- `PdbOnly` generates a "non-portable" `pdb` file, a
  Windows-proprietary format for release builds
- `Portable` generates a "portable" pdb file, which is the new
  standard that works for debug and release builds. New SDK-style
  MSBuild projects use this option by default.

These values are not case sensitive, I have mostly seen them lower
case in newer projects.

So what does Xamarin.Forms need to do?

Use `<DebugType>portable</DebugType>` in any Android class library or
app project. Other platforms, this is optional, not as much benefit. I
have heard that `DebugType=portable` might cause a problem on UWP.

* Xamarin.Forms will ship "portable" `pdbs` in its NuGet package for
  `FormsViewGroup.dll` and `Xamarin.Forms.*.Android.dll`. Developers
  won't pay the 100ms on initial build.
* Initial build times for `Xamarin.Forms.sln` will be slightly better
  for development, although I didn't measure the difference here.

* [XamlC] fix the argument match check for events (#4134)

Well, it looks like the order of arguments of InheritOrImplements was
reversed... a totally fine and normal Friday so far

- fixes #4130

* Add UI Test. Add instructions. Move to correct namespace (#4170) fixes #2251

* Add uitest for 2794 (#4110) fixes #2293

* Fix PropagateEvent value properly on Cells (#4191)

* bump gitinfo

* [Core, iOS, MacOS, Android, UWP, WPF] ListView hide scroll view scroll bars (#3897) fixes #3843

* Update from origin (#8)

* [C] VisibilityConverter Trims input (#3581)

For CSS purposes, the VisibilityConverter was added, and actually
replaced the `Boolean.Parse(str)` call for parsing Visibility.
`Boolean.Parse()` trims input, and the converter was not, so this was a
regression.
This changes Trim() the input, to be fully backward compatible.

- fixes #3554

* Ensure ConstructorCountId and TimeId elements are available before querying them (#3588)

* For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589)

This would allow previewer/designer/reloader to determine the source of a
stylesheet and refresh its content when appropriate.

* Revert "For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589)"

This reverts commit f66a72de5b475a6a8387a80e418997b38dc40d4c.

* Fix NRE; Ret 0 if Text null (#3594) fixes #3579

* [UWP, WPF] Fixes rendering of the main page (#2896) fixes #2704

* [Core] Ignore Shamehat target when running DesignTimeBuild (#3605)

* [XamlC] Fix binding compilation fo value types (#3551)

properly load valuetype arguments of generated setters, using ldarg,
instead of ldarga.

- fixes #3539

* Update PULL_REQUEST_TEMPLATE.md

* Update PULL_REQUEST_TEMPLATE.md

* [Android] Fix Label LineHeight (#3452)

* fix line height android

* Make UAP respect initial LineHeight

* update .create-nuget.bat (#3638)

* Add Null Check to GetRenderer (#3575)

- fix #3563

* Fix 3562 Null Reference Exception (#3576)

- fixes #3562

* Fix 3564 Null Reference Exception (#3578)

- fixes #3564

* [iOS] AutomationProperty support for cells (#3313) fixes #3296

* [iOS] AutomationProperty support for cells

* Add test case to AutomationProperties gallery

* [UWP] Fix crash app when create navigation/tabbed page without children pages fixes #3188 (#3514)

* [Android] Use height when determining ScaledScreenSize; fixes #3609 (#3641)

* [C] Set binding context on Span Gestures (#3639)

* [Core] Set binding context on Span Gestures
* [Core] Simplify loop setting child binding context

- fixes #3524

* Update PULL_REQUEST_TEMPLATE.md

* [Android] remove deprecated AndroidUseLatestPlatformSdk (#3672)

* [iOS] iPad ActionSheet should always have a Cancel method (#3636)

* Add repro for #3049

* [iOS] iPad ActionSheet should always have a Cancel method

fixes #3049

* [Android] fixes #3675 - set  initial ScrollView Scroll values when RTL (#3676)

* [Android] API check for Shadow properties on Button (#3617) fixes #2702

* [Android] API check for Shadow properties on Button

* Fix swapped shadow values

* [iOS] fixes #3525 - add epsilon for float compare (#3654)

* [iOS] fixes #3525 - add epsilon for float compare and make region immutable

* [ControlGallery] spread out spans to account for click slop

* [ControlGallery] - adjust span slightly for android test

* [Core] remove private

* Fix text wrapping (#3671) fixes #3634

* [GTK] Fix navigation bar visibility updates (#3651)

* Fix partially  #3585 (#3592)

* Make webkit-sharp.dll.config cross-platform

* Update webkit-sharp.dll with missing signals bindings

see: https://github.com/ylatuya/webkit-sharp/tree/fluendo

* [iOS, UWP] fixes #2894 - Gestures collection changes weren't correctly propagating (#3643)

* [iOS, UWP] fixes #2894 - Gestures weren't wiring up to spans in all cases

* [Core] remove ChildGestureRecognizers when spans get removed

* [iOS] removed incorrect return from null

* Fixes #3663 (#3684)

* Fix ScrollView Padding issue (#3685)

* [WPF] Memory leak when you pop a TabbedPage (#3372) fixes #3267

* Fix [WPF] Memory leak when you pop a TabbedPage

* Update ViewRenderer.cs

* Update ViewRenderer.cs

* [Android,iOS,UWP] Allow Entry CursorPosition/SelectionLength to be set in ctor (#3402) fixes #3343 fixes #3633

* Add repro for #3343 + unit tests

* [Core] Disallow negative values for CursorPosition/SelectionLength

* [All] CursorPosition/SelectionLength can bindin ctor & clear value

fixes #3343

* typo

* cleanup

* [iOS] Cursor snaps to end

* try/catch

* [CSS] add more properties (#3466)

map new CSS properties:
- `color` on `IColorElement` (`ActivityIndicator`, `BoxView`),
  `ProgressBar` and `Switch`
- `row-gap` and `column-gap` on `Grid`
- `transform` and `transform-origin` on `VisualElement`
- `vertical-align` on `Label`

add new XF-specific CSS properties
- `-xf-placeholder` and `-xf-placeholder-color` on `Editor`, `Entry`,
  `SearchBar`
- `-xf-max-length` on `InputView` (`Editor` and `Entry`)
- `-xf-bar-background-color` and `-xf-bar-text-color` on
  `NavigationPage` and `TabbedPage`
- `-xf-orientation` on `ScrollView` and `StackLayout`
- `-xf-horizontal-scroll-bar-visibility` and
  `-xf-vertical-scroll-bar-visibility` on `ScrollView`
- `-xf-min-track-color`, `-xf-max-track-color` and `("-xf-thumb-color`
  on `Slider`
- `-xf-spacing` on `StackLayout`

This PR replaces and closes #3276

- fixes #2891

* [iOS] Specify a default size for UISearchBar width if needed (#3635) fixes #3413 fixes #2139

* [Controls] Add reproduction and test case for issue #3413

* [iOS] Don't use max value for iOS UISearchbar breaks on iOS 11.3

* [iOS] Force width value so we can renderer UISearchBar on iOS10 with infinite width

* [Controls] Fix spelling and add Manual Review to the test of #3413

* [iOS] Simplify code for UISearchBar width

* [iOS] Return always some width from measure the UISearchBar on IOS

* [Controls] Add reproduction case for issue #2139

* [UWP] Fixed double set margins in Layouts (#3570) fixes #3398 fixes #3616

* [Android] Support multiple clipping settings in single layout (#3559)

* Repro

* Fix for API 18+

*  [iOS] Unsubscribe CellPropertyChanged when SwitchCellRenderer is disposed (#3518)

* [Controls] Add repo of issue #3408

* [iOS] Unsubscribe CellPropertyChanged when cell is disposed

* [Controls] Add issue to project

* [iOS] Introduce CellPropertyChange to CellTableViewCell to used by all other cell renderers

* [Controls] Simplify Issue

* [iOS] Remove PropertyChanged that was not used

* [Controls] add check for null binding on template, add notes about issues

* [Controls] added reference to Android crash

* [iOS]Use existing PropertyChanged on ViewCelRenderer

* [iOS] Keep the existing override so we don't break users

* Update TextCellRenderer.cs

* update submodule

* 24H Mode (#3701)

The 24h mode for the pickerdialog was not working.

Version 3.1 was working fine. 

Here is an updated file.

* [UWP] uncomment tests that are now passing for 3188 (#3723)

* [UITest] Update Xamarin.UITest nuget package (#3632)

* [UITests] Update Xamarin.UITest 2.2.5

* [UITests] Try fix Toolbaritems

* [UITest] Update to 2.2.5-1606

* [UITests] Small Fixes and workarounds to make uitest happy

* [UITests ] Add delay to 1733 for API28

* [Android] Revert bad merge (#3746)

fixes #3705

* [Android, iOS] Fixes layout compression causes (#3698) fixes #3624

* [Android, iOS] Fixes layout compression causes

* [iOS] improve UpdateNewElement method

* Fix build error hopefully

* [UWP] Fixes CollectionChanged events in ListView (#3323)

* fixes #3273

* [UWP] Fixes CollectionChanged events in ListView

* a wrapped collection is used only if the SourceItem is not ObservableCollection

* improve uitest

* fixed NRE in empty ListView

* added a sortable custom renderer for UItest

* minor refactoring

* fixed reset of not wrapped collections

* addressing comments

* [UWP] remove WinRT hack

* [UWP] add missing using and cleanup additional resources

* [Android] Update Forms to remove API28 deprecated API (#3653) fixes #2128 fixes #3629

* [Build] Update provisioning

* [Controls] Ignore deprecated  Android API usage

* [Android] Remove use of obsolete color usage

* [Android] Remove app fragment usage

* [android] Rollback changes to EntryCellRenderer

* [Android] Better way to get the default color for the label text

* [Android] Obsolete message for ContentPage.CreateFragment()

* [ControlGallery] - create bitmap from Drawable to use for pixel location

* [Android] Use textcolor resource

* Update submodule

* Fix tests (#3771)

* [ControlGallery] Wait for element and add timing to tests

* [iOS] Fix NRE on RenderPool

* Add TabStop/TabIndex (#2795)

* [Core, UWP, Android] support TabStop/TabIndex

* removing linq

* add iOS / MacOS implementation

* add WPF implementation
fixes UWP implementation

* - addressing comments
- improve test
- optimizations
- added previous tab direction in same tab group

* addressing comments

* [Android] support tabstop for pickers

* - moving shared code to a static class
- removed reflection

* ITabStop -> changed to internal, renamed, added in to fastRenderers

* Update ITabStop to be public

* Fix : Binding Icon in ToolbarItem in TabbedPage doesn't refresh (#3761) fixes #3756

* [iOS] Fix NRE on ContextCell (#3714) fixes #3275

* [Controls] Add repo for issue #3275

* [iOS] Fix NRE when no gestures exist on table

* [iOS] Null check outside loop

* [iOS]Make sure to dispose/unhook when we are removed from UITableView.

* Update submodule

* [iOS] Don't double dispose ContextActionCell

* WPF - Fix Width and Height measurement when GetDesiredSize (#3750)

* WPF - Reset Width and Height when GetDesiredSize

* Some formatting changes

* Add APP directive

* [WPF]Fix build

* [Android Maps] Make markers available to subclasses (#3751)

* Make markers available to subclasses

* Fix build

* Use Find instead of FirstOrDefault

* [UITests] wait for element before querying for it (#3791)

* [UITests] wait for element before querying for it

* [Controls] generalize and better represent intended behavior

* WPF - Fix Local store not persistant when restarting App (#3752)

-fixes #3541
* WPF - Fix Local store not persistant when restarting App
* Add UITest
* [Controls] Add automated UI Test

* [UITests] Isolate test 3408

* [UITest] Update Xamarin UITest packages

* [UWP] implement Replace without reloading ListView (#3792)

-fixes #3788
* [UWP] implement Replace without reloading ListView
* [UWP] extract bindingcontext of new item for replace

* [iOS] Use UIApperance default color for UISwitch (#3819)

* [Controls] Set default color of UISwitch to Red

* [iOS] Use default color from Apperance API

* [UITests] replace awaits with more reliable WaitForElement (#3835)

* [Core] Propagate BindingContext changes to TitleView (#3823)

* [Core] Propagate BindingContext changes to TitleView

* [Tests] Move UI test to Core Unit Test

* [A] do not draw gradient for empty CornerRadius (#3786)

Drawing CornerRadius (introduce by #1998) when the CornerRadii are
actually 0 causes scaling artifacts on API < 25.

This fixes the regression when no CornerRadius is set. Expect blurry
border scaling with CornerRadius not empty and API < 25

- fixes #3781

* [Android] Fix WebView.Navigating event, make WebViewClient inheritable (#3780)

* Extracted WebViewRenderer.WebClient to FormsWebViewClient, moved SendNavigating call from ShouldOverrideUrlLoading to OnPageStarted

* Changed _webViewClient and GetWebViewClient() method to return base class

* Changed public things to protected internal

* Fix spaces to tabs indentation to match the coding style (#3745)

* [Build] Fix merge

* Fix #3097 swipe gesture not being handled in VisualElementTracker. (#3098) Fixes #3097

* Implemented for iOS, Android and MacOS

* Implemented UAP and WPF

* Refactored duplicate code and removed typo in method name

* Update from origin (#9)

* [C] VisibilityConverter Trims input (#3581)

For CSS purposes, the VisibilityConverter was added, and actually
replaced the `Boolean.Parse(str)` call for parsing Visibility.
`Boolean.Parse()` trims input, and the converter was not, so this was a
regression.
This changes Trim() the input, to be fully backward compatible.

- fixes #3554

* Ensure ConstructorCountId and TimeId elements are available before querying them (#3588)

* For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589)

This would allow previewer/designer/reloader to determine the source of a
stylesheet and refresh its content when appropriate.

* Revert "For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589)"

This reverts commit f66a72de5b475a6a8387a80e418997b38dc40d4c.

* Fix NRE; Ret 0 if Text null (#3594) fixes #3579

* [UWP, WPF] Fixes rendering of the main page (#2896) fixes #2704

* [Core] Ignore Shamehat target when running DesignTimeBuild (#3605)

* [XamlC] Fix binding compilation fo value types (#3551)

properly load valuetype arguments of generated setters, using ldarg,
instead of ldarga.

- fixes #3539

* Update PULL_REQUEST_TEMPLATE.md

* Update PULL_REQUEST_TEMPLATE.md

* [Android] Fix Label LineHeight (#3452)

* fix line height android

* Make UAP respect initial LineHeight

* update .create-nuget.bat (#3638)

* Add Null Check to GetRenderer (#3575)

- fix #3563

* Fix 3562 Null Reference Exception (#3576)

- fixes #3562

* Fix 3564 Null Reference Exception (#3578)

- fixes #3564

* [iOS] AutomationProperty support for cells (#3313) fixes #3296

* [iOS] AutomationProperty support for cells

* Add test case to AutomationProperties gallery

* [UWP] Fix crash app when create navigation/tabbed page without children pages fixes #3188 (#3514)

* [Android] Use height when determining ScaledScreenSize; fixes #3609 (#3641)

* [C] Set binding context on Span Gestures (#3639)

* [Core] Set binding context on Span Gestures
* [Core] Simplify loop setting child binding context

- fixes #3524

* Update PULL_REQUEST_TEMPLATE.md

* [Android] remove deprecated AndroidUseLatestPlatformSdk (#3672)

* [iOS] iPad ActionSheet should always have a Cancel method (#3636)

* Add repro for #3049

* [iOS] iPad ActionSheet should always have a Cancel method

fixes #3049

* [Android] fixes #3675 - set  initial ScrollView Scroll values when RTL (#3676)

* [Android] API check for Shadow properties on Button (#3617) fixes #2702

* [Android] API check for Shadow properties on Button

* Fix swapped shadow values

* [iOS] fixes #3525 - add epsilon for float compare (#3654)

* [iOS] fixes #3525 - add epsilon for float compare and make region immutable

* [ControlGallery] spread out spans to account for click slop

* [ControlGallery] - adjust span slightly for android test

* [Core] remove private

* Fix text wrapping (#3671) fixes #3634

* [GTK] Fix navigation bar visibility updates (#3651)

* Fix partially  #3585 (#3592)

* Make webkit-sharp.dll.config cross-platform

* Update webkit-sharp.dll with missing signals bindings

see: https://github.com/ylatuya/webkit-sharp/tree/fluendo

* [iOS, UWP] fixes #2894 - Gestures collection changes weren't correctly propagating (#3643)

* [iOS, UWP] fixes #2894 - Gestures weren't wiring up to spans in all cases

* [Core] remove ChildGestureRecognizers when spans get removed

* [iOS] removed incorrect return from null

* Fixes #3663 (#3684)

* Fix ScrollView Padding issue (#3685)

* [WPF] Memory leak when you pop a TabbedPage (#3372) fixes #3267

* Fix [WPF] Memory leak when you pop a TabbedPage

* Update ViewRenderer.cs

* Update ViewRenderer.cs

* [Android,iOS,UWP] Allow Entry CursorPosition/SelectionLength to be set in ctor (#3402) fixes #3343 fixes #3633

* Add repro for #3343 + unit tests

* [Core] Disallow negative values for CursorPosition/SelectionLength

* [All] CursorPosition/SelectionLength can bindin ctor & clear value

fixes #3343

* typo

* cleanup

* [iOS] Cursor snaps to end

* try/catch

* [CSS] add more properties (#3466)

map new CSS properties:
- `color` on `IColorElement` (`ActivityIndicator`, `BoxView`),
  `ProgressBar` and `Switch`
- `row-gap` and `column-gap` on `Grid`
- `transform` and `transform-origin` on `VisualElement`
- `vertical-align` on `Label`

add new XF-specific CSS properties
- `-xf-placeholder` and `-xf-placeholder-color` on `Editor`, `Entry`,
  `SearchBar`
- `-xf-max-length` on `InputView` (`Editor` and `Entry`)
- `-xf-bar-background-color` and `-xf-bar-text-color` on
  `NavigationPage` and `TabbedPage`
- `-xf-orientation` on `ScrollView` and `StackLayout`
- `-xf-horizontal-scroll-bar-visibility` and
  `-xf-vertical-scroll-bar-visibility` on `ScrollView`
- `-xf-min-track-color`, `-xf-max-track-color` and `("-xf-thumb-color`
  on `Slider`
- `-xf-spacing` on `StackLayout`

This PR replaces and closes #3276

- fixes #2891

* [iOS] Specify a default size for UISearchBar width if needed (#3635) fixes #3413 fixes #2139

* [Controls] Add reproduction and test case for issue #3413

* [iOS] Don't use max value for iOS UISearchbar breaks on iOS 11.3

* [iOS] Force width value so we can renderer UISearchBar on iOS10 with infinite width

* [Controls] Fix spelling and add Manual Review to the test of #3413

* [iOS] Simplify code for UISearchBar width

* [iOS] Return always some width from measure the UISearchBar on IOS

* [Controls] Add reproduction case for issue #2139

* [UWP] Fixed double set margins in Layouts (#3570) fixes #3398 fixes #3616

* [Android] Support multiple clipping settings in single layout (#3559)

* Repro

* Fix for API 18+

*  [iOS] Unsubscribe CellPropertyChanged when SwitchCellRenderer is disposed (#3518)

* [Controls] Add repo of issue #3408

* [iOS] Unsubscribe CellPropertyChanged when cell is disposed

* [Controls] Add issue to project

* [iOS] Introduce CellPropertyChange to CellTableViewCell to used by all other cell renderers

* [Controls] Simplify Issue

* [iOS] Remove PropertyChanged that was not used

* [Controls] add check for null binding on template, add notes about issues

* [Controls] added reference to Android crash

* [iOS]Use existing PropertyChanged on ViewCelRenderer

* [iOS] Keep the existing override so we don't break users

* Update TextCellRenderer.cs

* update submodule

* 24H Mode (#3701)

The 24h mode for the pickerdialog was not working.

Version 3.1 was working fine. 

Here is an updated file.

* [UWP] uncomment tests that are now passing for 3188 (#3723)

* [UITest] Update Xamarin.UITest nuget package (#3632)

* [UITests] Update Xamarin.UITest 2.2.5

* [UITests] Try fix Toolbaritems

* [UITest] Update to 2.2.5-1606

* [UITests] Small Fixes and workarounds to make uitest happy

* [UITests ] Add delay to 1733 for API28

* [Android] Revert bad merge (#3746)

fixes #3705

* [Android, iOS] Fixes layout compression causes (#3698) fixes #3624

* [Android, iOS] Fixes layout compression causes

* [iOS] improve UpdateNewElement method

* Fix build error hopefully

* [UWP] Fixes CollectionChanged events in ListView (#3323)

* fixes #3273

* [UWP] Fixes CollectionChanged events in ListView

* a wrapped collection is used only if the SourceItem is not ObservableCollection

* improve uitest

* fixed NRE in empty ListView

* added a sortable custom renderer for UItest

* minor refactoring

* fixed reset of not wrapped collections

* addressing comments

* [UWP] remove WinRT hack

* [UWP] add missing using and cleanup additional resources

* [Android] Update Forms to remove API28 deprecated API (#3653) fixes #2128 fixes #3629

* [Build] Update provisioning

* [Controls] Ignore deprecated  Android API usage

* [Android] Remove use of obsolete color usage

* [Android] Remove app fragment usage

* [android] Rollback changes to EntryCellRenderer

* [Android] Better way to get the default color for the label text

* [Android] Obsolete message for ContentPage.CreateFragment()

* [ControlGallery] - create bitmap from Drawable to use for pixel location

* [Android] Use textcolor resource

* Update submodule

* Fix tests (#3771)

* [ControlGallery] Wait for element and add timing to tests

* [iOS] Fix NRE on RenderPool

* Add TabStop/TabIndex (#2795)

* [Core, UWP, Android] support TabStop/TabIndex

* removing linq

* add iOS / MacOS implementation

* add WPF implementation
fixes UWP implementation

* - addressing comments
- improve test
- optimizations
- added previous tab direction in same tab group

* addressing comments

* [Android] support tabstop for pickers

* - moving shared code to a static class
- removed reflection

* ITabStop -> changed to internal, renamed, added in to fastRenderers

* Update ITabStop to be public

* Fix : Binding Icon in ToolbarItem in TabbedPage doesn't refresh (#3761) fixes #3756

* [iOS] Fix NRE on ContextCell (#3714) fixes #3275

* [Controls] Add repo for issue #3275

* [iOS] Fix NRE when no gestures exist on table

* [iOS] Null check outside loop

* [iOS]Make sure to dispose/unhook when we are removed from UITableView.

* Update submodule

* [iOS] Don't double dispose ContextActionCell

* WPF - Fix Width and Height measurement when GetDesiredSize (#3750)

* WPF - Reset Width and Height when GetDesiredSize

* Some formatting changes

* Add APP directive

* [WPF]Fix build

* [Android Maps] Make markers available to subclasses (#3751)

* Make markers available to subclasses

* Fix build

* Use Find instead of FirstOrDefault

* [UITests] wait for element before querying for it (#3791)

* [UITests] wait for element before querying for it

* [Controls] generalize and better represent intended behavior

* WPF - Fix Local store not persistant when restarting App (#3752)

-fixes #3541
* WPF - Fix Local store not persistant when restarting App
* Add UITest
* [Controls] Add automated UI Test

* [UITests] Isolate test 3408

* [UITest] Update Xamarin UITest packages

* [UWP] implement Replace without reloading ListView (#3792)

-fixes #3788
* [UWP] implement Replace without reloading ListView
* [UWP] extract bindingcontext of new item for replace

* [iOS] Use UIApperance default color for UISwitch (#3819)

* [Controls] Set default color of UISwitch to Red

* [iOS] Use default color from Apperance API

* [UITests] replace awaits with more reliable WaitForElement (#3835)

* [Core] Propagate BindingContext changes to TitleView (#3823)

* [Core] Propagate BindingContext changes to TitleView

* [Tests] Move UI test to Core Unit Test

* [A] do not draw gradient for empty CornerRadius (#3786)

Drawing CornerRadius (introduce by #1998) when the CornerRadii are
actually 0 causes scaling artifacts on API < 25.

This fixes the regression when no CornerRadius is set. Expect blurry
border scaling with CornerRadius not empty and API < 25

- fixes #3781

* [Android] Fix WebView.Navigating event, make WebViewClient inheritable (#3780)

* Extracted WebViewRenderer.WebClient to FormsWebViewClient, moved SendNavigating call from ShouldOverrideUrlLoading to OnPageStarted

* Changed _webViewClient and GetWebViewClient() method to return base class

* Changed public things to protected internal

* Fix spaces to tabs indentation to match the coding style (#3745)

* [Build] Fix merge

* Fix #3097 swipe gesture not being handled in VisualElementTracker. (#3098) Fixes #3097

* Ensure that the ListViewAdapter is no longer being used by the ListVi… (#3848) fixes #3603

* Ensure that the ListViewAdapter is no longer being used by the ListView before disposing it

* Remove `RemoveAllViews` from `Dispose`

* Fixed code review comments

* Removed obsolete convert method

* Making sure default platform functionality is intact iOS and Android

As er code review comments

* Making sure default platform functionality is intact MacOS

* Making sure default platform functionality is intact UWP and WPF

* Code review comments for iOS, Android and MacOS

Default platform value is now preserved and applied when setting is set to default

* Code review comments UWP and WPF

* Fix build

* [UITest] - add ui test to test scroll permutations

* [Uwp] fix bad merge

* [wpf] fix spacing

* Adding instructions and UI tests for Bugzilla44461 (#4144)

* Adding instructions and UI tests for Bugzilla44461

* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla44461.cs

Co-Authored-By: mikescandy <michele.scandura@outlook.com>

* Fix assert

* [C] avoid AmbiguousMatchexception in Bindings (#4216) fixes #4215

if a type defines multiple op_implicit from the same type to different
ones, trying to retrieve it with GetMethod() throws an
AmbiguousMatchException. If this happens, we have to do the resolution
ourself.

- fixes #4215

* https://github.com/xamarin/Xam…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e/1 🕐 1 i/high Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often m/low impact ◾ p/iOS 🍎 t/bug 🐛
Projects
No open projects
Sprint 138
  
To do
Sprint 140
  
To do
Sprint 141
  
Ready for Review (Issues)
Sprint 142
  
Done
v3.4.0
  
Done
Development

Successfully merging a pull request may close this issue.

6 participants