New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VisualStateManager] "Focused" does not behave correctly. #2157

Closed
P3PPP opened this Issue Mar 21, 2018 · 1 comment

Comments

Projects
3 participants
@P3PPP
Contributor

P3PPP commented Mar 21, 2018

Description

The common visual state "Focused" does not behave correctly.

Steps to Reproduce

use Xamarin.Forms 3.0.0-pre2

<Entry Placeholder="IsFocused: true = Orange, false = Green" >
    <VisualStateManager.VisualStateGroups>
        <VisualStateGroupList>
            <VisualStateGroup x:Name="CommonStates">
                <VisualState x:Name="Normal">
                    <VisualState.Setters>
                        <Setter Property="BackgroundColor" Value="Green" />
                    </VisualState.Setters>
                </VisualState>
                <VisualState x:Name="Focused">
                    <VisualState.Setters>
                        <Setter Property="BackgroundColor" Value="Orange" />
                    </VisualState.Setters>
                </VisualState>
            </VisualStateGroup>
        </VisualStateGroupList>
    </VisualStateManager.VisualStateGroups>
</Entry>

Expected Behavior

When Entry is focused it's BackgroundColor set to Green, and When Entry is not focused it's BackgroundColor set to Orange.

Actual Behavior

When Entry is focused it's BackgroundColor set to Orange, and When Entry is not focused it's BackgroundColor set to Green.

Basic Information

  • Version with issue: 3.0.0.296286-pre2
  • Last known good version: nothing
  • IDE: Visual Studio for Mac
  • Platform Target Frameworks:
    • all

Reproduction Link

https://github.com/P3PPP/CommonStatesFocusedReproduction

@pauldipietro pauldipietro added this to New in Triage Mar 21, 2018

@P3PPP P3PPP referenced this issue Mar 21, 2018

Merged

[Core] Fix CommonStates.Focused issue #2158

0 of 4 tasks complete

@pauldipietro pauldipietro moved this from New to PR Available in Triage Mar 21, 2018

@hartez

This comment has been minimized.

Member

hartez commented Mar 23, 2018

Fixed by PR #2158. Thanks, @P3PPP !

@hartez hartez closed this Mar 23, 2018

Triage automation moved this from PR Available to Closed Mar 23, 2018

@samhouts samhouts added this to Done in v3.0.0 Apr 24, 2018

@samhouts samhouts removed this from Closed in Triage Jun 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment