This repository has been archived by the owner on May 1, 2024. It is now read-only.
[Enhancement] Editor: Control over text-prediction #3555
Labels
help wanted
We welcome community contributions to any issue, but these might be a good place to start!
t/enhancement ➕
up-for-grabs
We welcome community contributions to any issue, but these might be a good place to start!
Projects
Comments
samhouts
added
t/enhancement ➕
help wanted
We welcome community contributions to any issue, but these might be a good place to start!
labels
Aug 13, 2018
samhouts
added
the
up-for-grabs
We welcome community contributions to any issue, but these might be a good place to start!
label
Oct 5, 2018
@noamyogev84 Great! I know that we had conflicts with the SpellCheckEnabled property for Entry, but otherwise, this should be pretty straightforward. Good luck, and let us know if we can help! Thank you! |
3 tasks
Hi @samhouts. I'll be happy to do any modifications if needed. |
Hi, can I please fix this issue as my Hackocterfest PR? |
Wouldn't it be better to add this property to |
I'll wait for you guys are sure what specific changes I have to do :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
help wanted
We welcome community contributions to any issue, but these might be a good place to start!
t/enhancement ➕
up-for-grabs
We welcome community contributions to any issue, but these might be a good place to start!
Rationale
#1677 for Editor
Editor
s do not currently allow users to disable text prediction/autocomplete/autosuggest without a custom renderer or effect.Implementation
Add bindable property to
Editor
:Renderers will need to be updated accordingly.
Expected Result
Android
IsTextPredictionEnabled == true
: Default. Text prediction is enabled.IsTextPredictionEnabled == false
: Text prediction is disabled.iOS
IsTextPredictionEnabled == true
: Default. Text prediction is enabled. Note: may also disable autocorrect.IsTextPredictionEnabled == false
: Text prediction is disabled.UWP
IsTextPredictionEnabled == true
: Default. Text prediction is enabled.IsTextPredictionEnabled == false
: Text prediction is disabled.Implications for CSS
None
Backward Compatibility
Since we are adding new properties, there should be no compatibility problems as long as:
Editor
's text prediction defaults to enabled, as is the expected behavior now,Third party renderers will need to be updated to ensure that this functionality is officially supported.
Difficulty : Easy-Medium
This is an easy-medium change and great for a first-time contributor. Biggest challenge will be ensuring that disabling text prediction does not also disable other features of the
Editor
view on all platforms.The text was updated successfully, but these errors were encountered: