Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ApplinkEntry Thumbnail required after upgrading to 3.5/3.6 #5470

Closed
veryhumble opened this issue Mar 6, 2019 · 2 comments
Closed

ApplinkEntry Thumbnail required after upgrading to 3.5/3.6 #5470

veryhumble opened this issue Mar 6, 2019 · 2 comments

Comments

@veryhumble
Copy link

veryhumble commented Mar 6, 2019

Description

After upgrading from Xamarin.Forms 3.4 to Version 3.5 or 3.6 I get the following Exception after trying to Register an AppLinkEntry using Application.Current.AppLinks.RegisterLink on iOS.

InvalidOperationException: Thumbnail must be set to a valid source

Steps to Reproduce

  1. Register AppLinks with a valid AppLinkEntry
  2. Start App
  3. Exception is thrown saying Thumbnail is required

Expected Behavior

Actual Behavior

I see that Code was changed between Version 3.4 and 3.6
Before it was valid to have the Thumbnail Property not set, now it's mandatory. While I can certainly provide an ImageSource for example using ImageSource.FromFile("icon_app.png"); . The requirement is still a change.

Basic Information

  • Version with issue: 3.6.0
  • Last known good version: 3.4.0 SR2
  • IDE: VisualStudio 8.0 Preview
  • Platform Target Frameworks:
    • iOS: 12.1

Update:
I missed the fact that I used "FromResource" instead of "FromFile" to load the ImageSource, I leave this open, because the Title still and description qualifies.

@pauldipietro pauldipietro added this to New in Triage Mar 6, 2019
@kingces95
Copy link
Contributor

Change is breaking.

@kingces95 kingces95 moved this from New to Ready For Work in Triage Mar 8, 2019
@samhouts samhouts moved this from Ready For Work to Needs Estimate in Triage Mar 11, 2019
@samhouts
Copy link
Member

Caused by #4733

@samhouts samhouts added this to the 3.6.0 milestone Mar 11, 2019
@samhouts samhouts moved this from Needs Estimate to Ready For Work in Triage Mar 11, 2019
@samhouts samhouts added this to To do in v3.6.0 Mar 12, 2019
@samhouts samhouts added this to To do in Sprint 150 Mar 12, 2019
@samhouts samhouts added this to To do in iOS Ready For Work Mar 13, 2019
@samhouts samhouts removed this from Ready For Work in Triage Mar 13, 2019
samhouts added a commit that referenced this issue Mar 25, 2019
@samhouts samhouts moved this from To do to In Progress in v3.6.0 Mar 26, 2019
@samhouts samhouts moved this from To do to Ready for Review (Issues) in Sprint 150 Mar 26, 2019
@samhouts samhouts self-assigned this Mar 26, 2019
@samhouts samhouts moved this from Ready for Review (Issues) to In progress in Sprint 150 Mar 27, 2019
iOS Ready For Work automation moved this from To do to Done Mar 28, 2019
Sprint 150 automation moved this from In progress to Done Mar 28, 2019
@samhouts samhouts moved this from In Progress to Done in v3.6.0 Mar 28, 2019
@samhouts samhouts removed this from Done in iOS Ready For Work May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Sprint 150
  
Done
v3.6.0
  
Done
Development

No branches or pull requests

3 participants