Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Bug] ScrollView at CollectionView at RefreshView always leads to Pull-To-Refresh #8198

Closed
aubiyko opened this issue Oct 24, 2019 · 1 comment · Fixed by #8224
Closed

[Bug] ScrollView at CollectionView at RefreshView always leads to Pull-To-Refresh #8198

aubiyko opened this issue Oct 24, 2019 · 1 comment · Fixed by #8224
Assignees
@jsuarezruiz
Labels
a/collectionview e/2 🕑 2 p/Android t/bug 🐛
Projects
v4.5.0

Comments

@aubiyko
Copy link

aubiyko commented Oct 24, 2019

Description

On Android, imagine having CollectionView with ScrollView as ItemTempate and have that inside RefreshView.
If you scroll down, release, then scroll up, Pull-To-Refresh gesture always fires despite list position.

Steps to Reproduce

  1. Use reproduction.
  2. Scroll down a bit.
  3. Scroll up.

Expected Behavior

CollectionView scrolls up.

Actual Behavior

RefreshView's Pull-To-Refresh is firing.

Basic Information

  • Version with issue: 4.3.0.908675
  • Last known good version: -
  • IDE: MS VS Community 16.3.6
  • Platform Target Frameworks:
    • Android: 9.0 (Pie)
  • Nuget Packages:
    • NETStandard.Library v2.0.3
    • Xamarin.Forms v4.3.0.908675
  • Affected Devices:
    • Android Emulator

Reproduction Link

Repro
@aubiyko aubiyko added s/unverified New report that has yet to be verified t/bug 🐛 labels Oct 24, 2019
@pauldipietro pauldipietro added this to New in Triage Oct 24, 2019
@samhouts samhouts added this to Backlog in CollectionView Oct 24, 2019
@jsuarezruiz jsuarezruiz added e/2 🕑 2 and removed s/unverified New report that has yet to be verified labels Oct 25, 2019
@jsuarezruiz jsuarezruiz self-assigned this Oct 25, 2019
@jsuarezruiz jsuarezruiz mentioned this issue Oct 25, 2019
Merged
2 tasks
@hartez
Copy link
Contributor

hartez commented Oct 25, 2019

Yeah, even if you make the ScrollViews in the ItemTemplate Orientation="Horizontal", this happens.

@hartez hartez removed this from New in Triage Oct 25, 2019
@hartez hartez added this to To do in Android Ready For Work via automation Oct 25, 2019
@hartez hartez removed this from Backlog in CollectionView Oct 25, 2019
Android Ready For Work automation moved this from To do to Done Oct 29, 2019
rmarinho pushed a commit that referenced this issue Oct 29, 2019
@jsuarezruiz @rmarinho
[Android] Fixed issue refreshing CollectionView using ScrollView insi…
0918df1 
…de DataTemplate (#8224) fixes #8198

* Fixed issue 8198 - ScrollView at CollectionView at RefreshView always leads to Pull-To-Refresh

* Added instructions to the Issue8198

* Added support for WebView on Android to align functionality with iOS

* Added more RefreshView Core Gallery samples

* Updated new samples

* Updated instructions text
@samhouts samhouts added this to In Progress in v4.5.0 Nov 2, 2019
@samhouts samhouts moved this from In Progress to Done in v4.5.0 Nov 2, 2019
felipebaltazar pushed a commit to felipebaltazar/Xamarin.Forms that referenced this issue Dec 1, 2019
@jsuarezruiz @felipebaltazar
[Android] Fixed issue refreshing CollectionView using ScrollView insi…
9539db6 
…de DataTemplate (xamarin#8224) fixes xamarin#8198

* Fixed issue 8198 - ScrollView at CollectionView at RefreshView always leads to Pull-To-Refresh

* Added instructions to the Issue8198

* Added support for WebView on Android to align functionality with iOS

* Added more RefreshView Core Gallery samples

* Updated new samples

* Updated instructions text
felipebaltazar pushed a commit to felipebaltazar/Xamarin.Forms that referenced this issue Dec 1, 2019
@jsuarezruiz @felipebaltazar
[Android] Fixed issue refreshing CollectionView using ScrollView insi…
530857d 
…de DataTemplate (xamarin#8224) fixes xamarin#8198

* Fixed issue 8198 - ScrollView at CollectionView at RefreshView always leads to Pull-To-Refresh

* Added instructions to the Issue8198

* Added support for WebView on Android to align functionality with iOS

* Added more RefreshView Core Gallery samples

* Updated new samples

* Updated instructions text
@felipebaltazar felipebaltazar mentioned this issue Dec 1, 2019
Merged
2 tasks
@samhouts samhouts removed this from Done in Android Ready For Work May 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jsuarezruiz jsuarezruiz

Labels
a/collectionview e/2 🕑 2 p/Android t/bug 🐛
Projects
No open projects
v4.5.0
  
Done
Milestone
No milestone
4 participants
@hartez @jsuarezruiz @samhouts @aubiyko