Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Enhancement] Allow extend GroupableItemsViewAdapter #9012

Closed
bill2004158 opened this issue Dec 24, 2019 · 1 comment
Closed

[Enhancement] Allow extend GroupableItemsViewAdapter #9012

bill2004158 opened this issue Dec 24, 2019 · 1 comment
Labels
a/collectionview p/Android proposal-open t/enhancement ➕
Projects
v4.6.0

Comments

@bill2004158
Copy link
Contributor

Summary

We want to extend GroupableItemsViewAdapter for some extra feature.
however, it is internal class, is it possible make it public?

API Changes

https://github.com/xamarin/Xamarin.Forms/blob/master/Xamarin.Forms.Platform.Android/CollectionView/GroupableItemsViewAdapter.cs#L12

make the class public.

Intended Use Case

allow developer to extend it for customize feature.
@pauldipietro pauldipietro added this to New in Triage Dec 24, 2019
@samhouts samhouts removed this from New in Triage Dec 30, 2019
@samhouts samhouts added this to Under consideration in Enhancements Jan 28, 2020
@samhouts samhouts added this to Backlog in CollectionView Feb 13, 2020
bill2004158 added a commit to bill2004158/Xamarin.Forms that referenced this issue Apr 30, 2020
@bill2004158
xamarin#9012: [Enhancement] Allow extend GroupableItemsViewAdapter
f5ec3ad
rmarinho pushed a commit that referenced this issue Jun 5, 2020
@bill2004158
#9012: [Enhancement] Allow extend GroupableItemsViewAdapter (#10521)
b804d00 
* #9012: [Enhancement] Allow extend GroupableItemsViewAdapter

* fix compile error
@bill2004158 bill2004158 mentioned this issue Jun 25, 2020
Merged
2 tasks
@samhouts samhouts added this to In Progress in v4.6.0 Jun 25, 2020
@samhouts samhouts moved this from In Progress to Done in v4.6.0 Jun 25, 2020
@samhouts
Copy link
Member

closed by #10521

Enhancements automation moved this from Under consideration to Closed Jul 13, 2020
CollectionView automation moved this from Backlog to Done Jul 13, 2020
@samhouts samhouts removed this from Closed in Enhancements Aug 12, 2020
@samhouts samhouts removed this from Done in CollectionView Aug 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
a/collectionview p/Android proposal-open t/enhancement ➕
Projects
No open projects
v4.6.0
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bill2004158 @samhouts